< belcher> when will 0.20.1 be released? (sorry if it was answered earlier i wasnt able to follow)
< harding> belcher: do you mean 0.21.1? (0.20.1 was released months ago).
< belcher> derp, yes
< belcher> the node which has ST
< fanquake> I haven't heard any issues in regards to the rc1. Likely be discussed in the meeting tomorrow. If we bump to final after that, then a day or two for gitian builds, and 0.21.1 could be released just after that.
< BlueMatt> big week
< aj> fanquake: only issues i've seen are code signing ones
< bitcoin-git> [bitcoin] catgirladdict opened pull request #21790: #freetheblockchain (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21790
< bitcoin-git> [bitcoin] fanquake closed pull request #21790: #freetheblockchain (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21790
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/c6d6bc8abb72...bce09da1228a
< bitcoin-git> bitcoin/master fa1fdeb MarcoFalke: fuzz: Ensure prevout is consensus-valid
< bitcoin-git> bitcoin/master bce09da MarcoFalke: Merge bitcoin/bitcoin#21773: fuzz: Ensure prevout is consensus-valid
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21773: fuzz: Ensure prevout is consensus-valid (master...2104-fuzzScript) https://github.com/bitcoin/bitcoin/pull/21773
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bce09da1228a...edf679503c55
< bitcoin-git> bitcoin/master 363df75 glozow: doc/style followups in MempoolAcceptResult
< bitcoin-git> bitcoin/master edf6795 MarcoFalke: Merge bitcoin/bitcoin#21783: refactor: Make MempoolAcceptResult members co...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21783: refactor: Make MempoolAcceptResult members const (master...2021-04-mempoolacceptresult) https://github.com/bitcoin/bitcoin/pull/21783
< bitcoin-git> [bitcoin] raulsiles opened pull request #21791: QT build errors with 'qt' v6.x (master...patch-1) https://github.com/bitcoin/bitcoin/pull/21791
< jonasschnelli> Looks like #21009 broke bitcoinbuilds.org
< gribble> https://github.com/bitcoin/bitcoin/issues/21009 | Remove RewindBlockIndex logic by dhruv · Pull Request #21009 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21792: test: Fix intermittent issue in p2p_segwit.py (master...2104-testInt2) https://github.com/bitcoin/bitcoin/pull/21792
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/edf679503c55...e45863166f5e
< bitcoin-git> bitcoin/master 545404e practicalswift: fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%.
< bitcoin-git> bitcoin/master e458631 MarcoFalke: Merge bitcoin/bitcoin#21169: fuzz: Add RPC interface fuzzing. Increase fuz...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #21169: fuzz: Add RPC interface fuzzing. Increase fuzzing coverage from 65% to 70%. (master...fuzzing-rpc) https://github.com/bitcoin/bitcoin/pull/21169
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45863166f5e...549d20a31bea
< bitcoin-git> bitcoin/master a29f522 Michael Dietz: fuzz: bolster ExtractDestination(s) checks
< bitcoin-git> bitcoin/master 549d20a MarcoFalke: Merge bitcoin/bitcoin#20772: fuzz: bolster ExtractDestination(s) checks
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #20772: fuzz: bolster ExtractDestination(s) checks (master...test-fuzz-extract-destinations) https://github.com/bitcoin/bitcoin/pull/20772
< bitcoin-git> [bitcoin] fanquake opened pull request #21793: build: use `-isysroot` over `--sysroot` on macOS (master...macos_use_isysroot) https://github.com/bitcoin/bitcoin/pull/21793
< fanquake> Change a couple "-"s to "i"s and magically you've fixed "dark mode" on macOS
< fanquake> Hopefully this is the end of that debacle
< promag> when running make on depends I get this:
< promag> libtool: warning: remember to run 'libtool --finish /Users/joao/Projects/bitcoin/depends/arm-apple-darwin20.3.0/lib'
< promag> it doesnt matter right?
< promag> is the signal emitted while resizing?
< promag> or only when mouse button is released?
< bitcoin-git> [bitcoin] practicalswift opened pull request #21795: fuzz: Terminate immediately if a fuzzing input ever causes a DNS lookup (belts and suspenders) (master...fuzz-terminate-on-dns-lookup) https://github.com/bitcoin/bitcoin/pull/21795
< bitcoin-git> [gui] NioGreek opened pull request #302: Update README.md (master...master) https://github.com/bitcoin-core/gui/pull/302
< bitcoin-git> [gui] fanquake closed pull request #302: Update README.md (master...master) https://github.com/bitcoin-core/gui/pull/302
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21796: index: Avoid async shutdown on init error (master...2104-indexInit) https://github.com/bitcoin/bitcoin/pull/21796
< hebasto> fanquake: re "Change a couple "-"s to "i"s and magically you've fixed "dark mode" on macOS" -- exciting!
< fanquake> I think at the same time it points to why build systems can sometimes be frightening
< hebasto> heh
< hebasto> promag: tested, while resizing
< bitcoin-git> [bitcoin] hebasto closed pull request #21782: build: Fix static Darwin builds (master...210426-darwin) https://github.com/bitcoin/bitcoin/pull/21782
< queip> can taproot allow new signature types, like ntru sign, lamport and such?
< sipa> depends on whether you mean taproot in reference to the technology to tweak keys as a commitment scheme, or the BIP341/BIP342 proposal
< sipa> taproot itself does not, but it's still just an improvement to the script execution system, and script does (and always has) had ways to extend it, including with new signature types
< sipa> BIP342 specifically contains a (somewhat unrelated) improvement of introducing "key versions", specifically intended for things like that
< sipa> it is restricted to just script path spending though; key path spending is necessarily fixed (needs a new output type/witness version to change that)
< dongcarl> roconnor: For the memcmp bug, was GCC miscompiling memcmp in glibc, or was it some weird GCC builtin optimized memcmp that was problematic?
< sipa> dongcarl: gcc miscompiling a builtin
< sipa> (which is done automatically for memcmp and a few related functions like std::lexicographic_compare
< dongcarl> sipa: I see, so this would have happened even if we swapped glibc for some other libc implementation?
< sipa> yes, it's entirely independent of libc
< dongcarl> Got it
< sipa> of course, the bug could be present in a particular compilation of glibc itself
< bitcoin-git> [bitcoin] mjdietzx closed pull request #20889: test: ensure any failing method in MiniWallet leaves no side-effects (master...test-miniwallet-no-side-effects) https://github.com/bitcoin/bitcoin/pull/20889
< roconnor> I've been meaning to test whether this bug I encountered is fixed in GCC 10.3, but in any cases, libsecp256k1 now has its own definition of memcmp that it uses.
< roconnor> sipa: there is some evidence that it isn't present in glibc since glibc isn't amoung the libraries profiled that emitted an warning with real_or_random's bug profiling enabled: http://r6.ca/blog/20200929T023701Z.html
< sipa> roconnor: right
< dongcarl> roconnor: I think it is fixed in 10.3! https://github.com/bitcoin/bitcoin/issues/21145#issuecomment-826145244
< sipa> dongcarl: we know the patch is in 10.3; roconnor means he wants to test if that actually means the bug is gone
< dongcarl> Ah right :-)
< roconnor> I also believe it is fixed, but it isn't marked as fixed in the https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189 and thus doesn't appear in their list of known fixed issues for 10.3
< roconnor> also there are some horrifying bugs fixed in 10.3: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96549
< roconnor> or at least I find them horrifying. Maybe I'm not jaded enough yet.
< bitcoin-git> [gui] hebasto merged pull request #18: Add peertablesortproxy module (master...200701-peer) https://github.com/bitcoin-core/gui/pull/18
< dongcarl> Oh wow... Perhaps sticking to gcc 8 is the safe bet after all...
< bitcoin-git> [bitcoin] hebasto pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/549d20a31bea...328da3355787
< bitcoin-git> bitcoin/master df2d165 Hennadii Stepanov: qt: Add peertablesortproxy module
< bitcoin-git> bitcoin/master 778a64a Hennadii Stepanov: qt: Use PeerTableSortProxy for sorting peer table
< bitcoin-git> bitcoin/master 9a9f180 Hennadii Stepanov: qt, refactor: Drop no longer used PeerTableModel::sort function
< dongcarl> For mingw builds, Gitian right now uses g++-mingw-w64, which, on focal, is gcc 9.3... Hmmm
< luke-jr> dongcarl: iirc someone concluded no harm was done to the gitian binaries
< dongcarl> luke-jr: Right! But we might trigger it with future code-changes...
< luke-jr> yeah, I think we were assuming at the time, that it would be fixed quickly :/
< luke-jr> kinda disappointing GCC upstream doesn't seem to take it seriously
< sipa> well, it's fixed in trunk, allegedly
< dongcarl> Is gcc 9 still receiving backports?
< luke-jr> sipa: I imagine it will be some time before trunk gets into Ubuntu (but maybe guix solves this?)
< sipa> luke-jr: i have some version of GCC 11 in Ubuntu 21.04
< luke-jr> :o
< dongcarl> GCC 11's already packaged in Guix I believe: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/gcc.scm#n597
< roconnor> BTW, I've been left with the impression that it shouldn't be hard to write a Nix expression to produce the same binaries that Guix produces. Someday I'd like to give it a try. It would be cool to have two different build systems producing the same binaries.
< roconnor> though it would only take a single wrinke to cause a problem.
< dongcarl> roconnor: Yes that'd be wonderful! It might be nice to ask the folks how they did this: https://reproducible-builds.org/news/2019/12/21/reproducible-bootstrap-of-mes-c-compiler/
< yanmaani> How do unit tests work?
< yanmaani> Less vaguely: say you introduce a new function. Where do the unit tests go?
< yanmaani> roconnor: You can do a 'reflections on trusting trust'. If guix produces a gcc with compile flags X set, all you need is to create a *functioning* gcc, compile another gcc with compile flags X set, and then use that gcc to compile itself. So any eventual errors are self-correcting.
< dongcarl> yanmaani: src/test/<relevant_module>_tests.cpp
< yanmaani> dongcarl: thanks
< dongcarl> yanmaani: yw :-)
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #21798: fuzz: Create a block template in tx_pool targets (master...2104-fuzzMempool) https://github.com/bitcoin/bitcoin/pull/21798
< yanmaani> dongcarl: Is there a document documenting this stuff somewhere?
< yanmaani> or is it just oral tradition
< dongcarl> yanmaani: I believe the README in the root folder points to the README in src/test
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/328da3355787...4cfe6c37d956
< bitcoin-git> bitcoin/master 83a425d William Casarin: compressor: use a prevector in compressed script serialization
< bitcoin-git> bitcoin/master 4cfe6c3 MarcoFalke: Merge bitcoin/bitcoin#18847: compressor: use a prevector in CompressScript...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18847: compressor: use a prevector in CompressScript serialization [ZAP1] (master...2020-05-compresscript-prevector) https://github.com/bitcoin/bitcoin/pull/18847
< bitcoin-git> [bitcoin] dongcarl opened pull request #21799: guix: Use `gcc-8` across the board (master...2021-04-guix-gcc-memcmp) https://github.com/bitcoin/bitcoin/pull/21799
< bitcoin-git> [bitcoin] glozow opened pull request #21800: [WIP] mempool/validation: mempool ancestor/descendant limits for packages (master...package-mempool-ancestors) https://github.com/bitcoin/bitcoin/pull/21800
< queip> in case if TR ST would fail to activate, what is the time limit by which TR overall should activate using some other mechanism that would be attempted after the (hopefully avoidable) ST failure?
< sipa> queip: not here, please
< bitcoin-git> [gui] hebasto closed pull request #264: Add "Copy address" item to the context menu in the Peers table (master...210330-copy) https://github.com/bitcoin-core/gui/pull/264