<Guest7564>
I think the was destop wallet at bit4coin
<Guest7564>
Yes, I know the provider is no longer there. Is the wallet gone then?
<michaelfolkson>
Guest7564: #bitcoin please. This is for Core development discussion
<stickies-v>
fanquake thanks, I'll keep an eye out then. Feel free to tag me when there's an issue/PR for this, couldn't find any yet
<MarcoFalke>
32 % of all issues are timeouts, likely the TSan issue
<MarcoFalke>
46% are due to TSan
grettke has joined #bitcoin-core-dev
hashfunc569 has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
<MarcoFalke>
Trying to reproduce in a pod ...
belcher has quit [Quit: Leaving]
sipsorcery has quit [Read error: Connection reset by peer]
belcher has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
<MarcoFalke>
can reproduce
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] josibake opened pull request #24570: test, refactor: fund tx deterministically in `test/functional/feature_coinstatindex.py` (master...josibake-make-coinstatindex-test-deterministic) https://github.com/bitcoin/bitcoin/pull/24570
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<keymeta>
@Guest7564 like i said search how to restore electrum wallet this place for bitcoin core
<keymeta>
what is the best tool for wallet.dat file inspecting? i wrote a few of my own but i seem to not be able to locate private key for a key in my key pool that has version 60400
<achow101>
keymeta: you can use `bitcoin-wallet -wallet=<wallet> -dumpfile=<file> dump` to get all of the records of a wallet file dumped to a file as hex strings
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] dergoegge opened pull request #24571: p2p: Prevent block index fingerprinting by sending additional getheaders messages (master...2022-03-header-fingerprinting) https://github.com/bitcoin/bitcoin/pull/24571
arythmet_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
arythmetic has quit [Ping timeout: 250 seconds]
<keymeta>
@achow101, it isnt acurate it skips alot of keys i find with a hex search for 0101041f 01010420.32
<achow101>
keymeta: it's literally what bdb outputs as all records
<achow101>
like the library itself says "here's everything"
<achow101>
you're probably seing deleted records
<keymeta>
db_dump works ok but i have a really old wallet i think with a bug that has LARGE transactions so output is annoying
<achow101>
when records are deleted or moved, the data is not always removed from the file, just the pointers to their locations changed/deleted
<achow101>
depending on the options you use, db_dump might output stuff that isn't actually there
<keymeta>
what can be caused with unknown key in keypool
<keymeta>
alot of stuff right
<keymeta>
like an encrypted key or a latest key being newer than the order pos next?
<keymeta>
if i make sense
<achow101>
your wallet could also just be corrupted
<keymeta>
i generate a new key gets the key in the keypool in order, for example the keyid 27172 27173 27174 but when it tries fetching 27175 it says unknown key in key pool and then i try again and again and then it fetches 27240 or something
<keymeta>
order as in the keys in the key pool
<achow101>
how are you fetching? custom tooling?
<keymeta>
i see the timestamps the ones encoded with uint32 time? i searched for the time in uint32 for other occurances maybe the key originated from another file, i just need to figuure out where that key originatedso i can recover the original wallet file
<keymeta>
custom
szkl has joined #bitcoin-core-dev
<keymeta>
fetching, i just use getnewaddress("")
<keymeta>
also i noticed, the addressbook is replaced with base58checksum of "" sometimes when i tried to load the wallet in a regtest or somewhere will that also mess up located key data
<keymeta>
like listreceivedbyaddress/account returns "" for the address
<keymeta>
i found a ton of bugs really ill try to get familiar with github and contribute
<achow101>
it sounds like your wallet is corrupted
<achow101>
"unknown key in key pool" is the kind of error that shouldn't ever happen
<keymeta>
yeah i realised that, i just need to figure out where it originated from because i have backups with 100;'s of berkeley database files
<keymeta>
2013 wallet
<keymeta>
and also i have alot of from account timesmart values but i suppose they arnt suppored in new wallets
<keymeta>
and i mined alot of blocks in the past with 2011 wallet maybe thats why
<achow101>
it could be that the backups don't contain the database log files?
<achow101>
I'm not sure when we implemented database compacting to ensure that the data file contained everything
<keymeta>
yeah i have database log files i tried to read berkeley database documentation and figure out the db recover utility or replication
calvinalvin has quit [Ping timeout: 250 seconds]
<achow101>
there should be some database id that will match it with the log file
<keymeta>
i think the wallet got corrupted with a bug where someone attacked the clint it had loads of orphans
<achow101>
but that requires digging into some of the utils to figure it out
<keymeta>
when i read debug log
<keymeta>
one of the debug logs also had a wallet file attached to it but that might be a file recovery program i used lol
<keymeta>
okay i did db printlog it did have times too
<keymeta>
theres too much that i did i cant pull it all up ill write something up
brunoerg has joined #bitcoin-core-dev
<keymeta>
does the database do checkpointing?
kcalvinalvin has joined #bitcoin-core-dev
<keymeta>
i think im asking too many quesitons ill save the good ones bbl
<achow101>
I think the only time we do checkpointing is when we prepare to compact it
<keymeta>
its the only book that documented internals of wallet.dat i found
<keymeta>
and its horrible because the english is bad
<keymeta>
but its really useful, is there any documentatons i can look at or parts of the code that might help me understand the wallet data better
<keymeta>
thanks for your help btw
<keymeta>
btw the old salvagewallet errors are haunting lol
<keymeta>
the bugs*
<keymeta>
running salvage with -R is crazy
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 252 seconds]
Guyver2_ is now known as Guyver2
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24572: ci: Temporarily use clang-13 to work around clang-14 TSan bug (master...2203-tsan-clang-bug-🎵) https://github.com/bitcoin/bitcoin/pull/24572
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
belcher has quit [Quit: Leaving]
AaronvanW has quit [Quit: Leaving...]
Guest7564 has quit [Ping timeout: 256 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #24573: Update signapple for platform identifier fix (master...signapple-correct-platform) https://github.com/bitcoin/bitcoin/pull/24573
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<achow101>
keymeta: ReadKeyValue in src/wallet/walletdb.cpp pretty much lays out how data is stored
<achow101>
you'll probably have to look up the Unserialize functions of the various classes used in there, but it's fairly straightforward
sipsorcery has quit [Ping timeout: 268 seconds]
<keymeta>
thanks
sipsorcery has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
dougefish has quit [Remote host closed the connection]
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
dougefish has joined #bitcoin-core-dev
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
arythmet_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
<laanwj>
rc2 binaries up https://bitcoincore.org/bin/bitcoin-core-23.0/test.rc2/ , apple dmgs have been renamed to bitcoin-23.0rc2-arm64-apple-darwin.dmg bitcoin-23.0rc2-x86_64-apple-darwin.dmg because of a naming conflict due to adding the ARM binary, will be fixed in next rc
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 252 seconds]
sipsorcery has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
jarthur has quit [Ping timeout: 240 seconds]
Talkless has quit [Quit: Konversation terminated!]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest75 has quit [Quit: Client closed]
Willtech has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
emcy has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 256 seconds]
bomb-on has quit [Quit: aллилѹіа!]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 256 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
gossie has quit [Quit: = "bye bye"]
CoinForensics has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
<jeremyrubin>
only mildly core-dev related, but i've sorta 'take over' a fork of the bitcoin-core npm lib, if anyone is interested in contributing on this https://www.npmjs.com/package/bitcoin-core-ts i think there are some other improvements we could make (already it's a lot better than the unmaintained version since it now supports typescript and gives you
<jeremyrubin>
.d.ts's, and supports connecting to signet)
<jeremyrubin>
would be cool to improve the tests, get CI running and stuff, and then actually refactor the modules :)