bitdex has quit [Remote host closed the connection]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Beck has joined #bitcoin-core-dev
Beck has quit [Client Quit]
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
vysn has joined #bitcoin-core-dev
afmencken has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
afmencken has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<luke-jr>
jamesob: the purpose of linters is to be pedantic :P
<luke-jr>
I think things like that linter require an environment variable to tell them the base to compare with
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Guest3014 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Guest3014 has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
vysn has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
greypw254600 has quit [Remote host closed the connection]
greypw254600 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 248 seconds]
cmirror has joined #bitcoin-core-dev
Guest14 has joined #bitcoin-core-dev
Guest14 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
cornfeedhobo has quit [Remote host closed the connection]
cornfeedhobo has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
dongcarl has quit [Quit: Ping timeout (120 seconds)]
dongcarl has joined #bitcoin-core-dev
dongcarl has quit [Quit: Ping timeout (120 seconds)]
dongcarl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
baldur_ has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
baldur_ has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
dongcarl has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
dongcarl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
gnaf_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
yanmaani has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
flooded has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
Guest34 has joined #bitcoin-core-dev
Guest34 has quit [Write error: Broken pipe]
nathanael has quit [Quit: connection reset by purr]
brunoerg has quit [Ping timeout: 264 seconds]
gnaf_ has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
<laanwj>
i'm also a bit divided about the whitespace linter, it was introduced at some point because some people's editors automatically removed trailing whitespace in save so it'd introduce diff noise, prohibiting trailing space in general avoids this, it's not exactly new
AaronvanW has joined #bitcoin-core-dev
<laanwj>
jamesob: you can also use -p to specify the number of previous commits to check
dongcarl has quit [Quit: Ping timeout (120 seconds)]
dongcarl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
dongcarl has quit [Read error: Connection reset by peer]
dongcarl has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
gnaf_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 264 seconds]
esats has quit [Ping timeout: 248 seconds]
evbo has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
TallTim has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
gnaf_ has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
dongcarl has quit [Quit: Ping timeout (120 seconds)]
dongcarl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
dongcarl has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
baldur_ has quit [Ping timeout: 272 seconds]
aielima has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
javi404 has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
javi404 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
TallTim_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 246 seconds]
gnaf_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
gnaf_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 255 seconds]
kexkey has quit [Ping timeout: 248 seconds]
kexkey has joined #bitcoin-core-dev
gnaf_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
baldur has joined #bitcoin-core-dev
<bitcoin-git>
[gui] laanwj merged pull request #623: Getting ready to Qt 6 (9/n). Apply Qt 6 specific changes (master...220622-qt6) https://github.com/bitcoin-core/gui/pull/623
<bitcoin-git>
bitcoin/master 3f51d0b Hennadii Stepanov: qt6: Fix type registration
<bitcoin-git>
bitcoin/master ad73447 Hennadii Stepanov: qt6: Do not use deprecated `QLibraryInfo::path` in Qt 6
<bitcoin-git>
bitcoin/master 8927bb8 Hennadii Stepanov: refactor: Fix style in `initTranslations()` function
dongcarl has joined #bitcoin-core-dev
<kallewoof>
jamesob: I think it's reasonable to ask that people don't add random spacing throughout the codebase. Also the linter is run first, IIRC, so it fails pretty quickly in the CI process.
<bitcoin-git>
bitcoin/master ceec680 brunoerg: test: `-whitebind` and `-bind` with `-listen=0` should throw an error
<bitcoin-git>
bitcoin/master 01e9e2d MacroFake: Merge bitcoin/bitcoin#25451: test: `-whitebind` and `-bind` with `-listen...
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25451: test: `-whitebind` and `-bind` with `-listen=0` should throw an error (master...2022-06-test-whitebind-bind-listen0) https://github.com/bitcoin/bitcoin/pull/25451
brunoerg has quit [Ping timeout: 268 seconds]
<in3rsha>
Is the Compact Size field (e.g. the one used for indicating the number of inputs in a tx) something that Satoshi came up with for bitcoin or is it found in other network protocols?
brunoerg has joined #bitcoin-core-dev
<vasild>
jamesob: IMO the linters are there to avoid wasting time on discussing the same minor stuff over and over again, and of course, to enforce some kind of consistency over the code base
brunoerg has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
vysn has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25456: rpc: Use steady_clock for getrpcinfo durations (master...2206-rpc-steady-duration-🎴) https://github.com/bitcoin/bitcoin/pull/25456
TallTim_ is now known as TallTim
jonatack has quit [Quit: Ping timeout (120 seconds)]
aielima has joined #bitcoin-core-dev
jespada has quit [Ping timeout: 256 seconds]
<bitcoin-git>
[bitcoin] hebasto opened pull request #25457: Use more specific path when including `memenv.h` header (master...220623-memenv) https://github.com/bitcoin/bitcoin/pull/25457
<bitcoin-git>
bitcoin/master f3b5c1e Hennadii Stepanov: Use more specific path when including `memenv.h` header
<bitcoin-git>
bitcoin/master 2598720 laanwj: Merge bitcoin/bitcoin#25457: Use more specific path when including `memenv...
<bitcoin-git>
[bitcoin] laanwj merged pull request #25457: Use more specific path when including `memenv.h` header (master...220623-memenv) https://github.com/bitcoin/bitcoin/pull/25457
<laanwj>
fanquake: oh neat!
sipsorcery has joined #bitcoin-core-dev
evanlinjin has quit [Quit: Konversation terminated!]
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #25420: rpc: small description/help improvements in blockchain.cpp (master...rpc-description-improvements-blockchain) https://github.com/bitcoin/bitcoin/pull/25420
af_mencken has quit [Quit: Leaving]
afmencken has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
lightningbot has quit [Ping timeout: 246 seconds]
lightningbot has joined #bitcoin-core-dev
cornfeedhobo has quit [Ping timeout: 246 seconds]
cornfeedhobo has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 264 seconds]
sipsorcery has joined #bitcoin-core-dev
seejee has joined #bitcoin-core-dev
Nekorand has quit [Quit: Leaving]
seejee has quit [Quit: Client closed]
jarthur has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #25460: ci: Update Windows task image up to visualstudio2022 (master...220623-vs2022) https://github.com/bitcoin/bitcoin/pull/25460
<jamesob>
[shill] if anyone is looking to dispose of their glut of spare review time :), I might recommend checking out these nice taproot unittests that first-time contributor david-bakin wrote: https://github.com/bitcoin/bitcoin/pull/25097
evanlinjin_ has joined #bitcoin-core-dev
<laanwj>
jamesob: thanks for the suggestion
evanlinjin has joined #bitcoin-core-dev
<dongcarl>
ariard: Thanks for mentioning, very happy that I have lots of reviews to address! :-)
<laanwj>
jamesob: was that meant for high prio for review btw?
belcher has quit [Quit: Leaving]
devguest82 has quit [Quit: Client closed]
furszy has joined #bitcoin-core-dev
furszy has quit [Quit: Ping timeout (120 seconds)]
furszy has joined #bitcoin-core-dev
furszy has quit [Client Quit]
bitdex has quit [Ping timeout: 268 seconds]
bitdex has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
jonatack has quit [Quit: Ping timeout (120 seconds)]
mudsip has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
Talkless has joined #bitcoin-core-dev
mudsip has quit []
bitdex has quit [Ping timeout: 268 seconds]
bitdex has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto closed pull request #25460: ci: Update Windows task image up to visualstudio2022 (master...220623-vs2022) https://github.com/bitcoin/bitcoin/pull/25460
bitdex has quit [Ping timeout: 268 seconds]
bitdex has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
evanlinjin_ has quit [Ping timeout: 268 seconds]
sipsorcery has quit [Ping timeout: 272 seconds]
brunoerg has quit [Remote host closed the connection]