<bitcoin-git>
bitcoin/master d683221 fanquake: Merge bitcoin/bitcoin#25382: doc requirement that replacement must have hi...
<bitcoin-git>
[bitcoin] fanquake merged pull request #25382: doc requirement that replacement must have higher feerate than direct conflicts (master...2022-06-rbf-feerate-rule) https://github.com/bitcoin/bitcoin/pull/25382
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
hashfunc1f17 has quit [Remote host closed the connection]
noonien has quit [Ping timeout: 248 seconds]
Guyver2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
Guyver2 has quit [Ping timeout: 256 seconds]
noonien has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
gleb7454386853 has joined #bitcoin-core-dev
gleb745438685 has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
hebasto_ has quit []
hebasto has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] glozow closed pull request #21413: [rfc] add option to bypass contextual timelocks in testmempoolaccept? (master...2021-03-bypass-timelocks) https://github.com/bitcoin/bitcoin/pull/21413
brunoerg has quit [Ping timeout: 258 seconds]
Guest77 has joined #bitcoin-core-dev
Guest77 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #25388: refactor: move policy constants to policy (master...25295_cleanup_all_constants) https://github.com/bitcoin/bitcoin/pull/25388
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
NorrinRadd has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
TheRec has quit [Ping timeout: 256 seconds]
emcy has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
NorrinRadd has quit [Ping timeout: 252 seconds]
emcy has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
argmin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
warren_ is now known as warren
brunoerg has quit [Remote host closed the connection]
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 244 seconds]
kexkey has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bcdarc_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 258 seconds]
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
kexkey has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
bcdarc has quit [Ping timeout: 248 seconds]
Bullitje_enable has quit [Read error: Connection reset by peer]
sudoforge has joined #bitcoin-core-dev
Guest47 has quit [Quit: Client closed]
brunoerg has quit [Ping timeout: 248 seconds]
kexkey_ has quit [Quit: kexkey_]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
Guest47 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Guest47 has quit [Client Quit]
bitdex has quit [Quit: = ""]
<bitcoin-git>
[bitcoin] vasild opened pull request #25390: sync: introduce a thread-safe smart pointer and use it to remove g_maplocalhost_mutex (master...ThreadSafePtr) https://github.com/bitcoin/bitcoin/pull/25390
<ariard>
there is also a more deeper question of recactoring a bit the mempool settings code
<luke-jr>
it doesn't make sense to special-case each configuration as a dedicated option
<ariard>
s/recactoring/refactoring/g
<sipa>
i expect that over time we'll only want the most incentive-compatible option, though i don't know when that'll be
<luke-jr>
sipa: that's one opinion, and shouldn't have a monopoly
<luke-jr>
sipa: also, incentives vary; miners vs non-miners in this case
<sipa>
sure, every node operator is free to implement whatever policy they want, but that doesn't need to mean we need to support anything anyone can come up with
<ariard>
luke-jr: could you precise, do you mean each _imaginable_ replacement policy shouldn't have a dedicated option?
evbo has quit [Ping timeout: 244 seconds]
<sipa>
why not? node operators will want to have policy that matches miners' policies
<luke-jr>
ariard: I mean for mutually exclusive policies, a single option makes sense with multiple values
<luke-jr>
sipa: no, miners will want to have policy that matches nodes' policies
<ariard>
luke-jr: here i agree, i don't think to implement `mempoolrbf=disable,full` for 25353
<sipa>
luke-jr: I don't think that makes sense. If there is a tangible economic benefit for both miners and wallets to use a certain policy, it will be adopted. If full nodes choose to ignore it for their own mempools, they'll be bypassed.
<sipa>
And then everyone is worse off.
<ariard>
luke-jr: in anycase, core is a software for both node and miners operators, what's the dynamics of the bitcoin system w.r.t policy adoption are beyond the scope of the discussion?
<luke-jr>
sipa: compact blocks was only acceptable because miners are incentivised to match nodes' policies, and not vice-versa.
<sipa>
The incentives for transaction relay are very different than for block acceptance.
<sipa>
I don't think this discussion is going anywhere.
<achow101>
imo mempoolreplacement is not a good name
<achow101>
unless the idea is to have replacement policies other than rbf
<laanwj>
well, we have optin
<ariard>
do we have people who really want disablerbf ? not even optin
<luke-jr>
achow101: mempoolreplacement is the name it's always used.. and makes sense, since non-fee-based policies exist
<laanwj>
no
<sipa>
adding an option for full-rbf makes sense to me, and discussions around experimenting with wallets using it. I don't care about the name, but I don't think we should spend much time about accomodating even more policies right now
<luke-jr>
ariard: I don't have any way to tell if anyone uses it with Knots
<laanwj>
sipa: +1
<laanwj>
i do think the option name should be prefixed with mempool though
<ariard>
okay, good if anyone has more ideas on the name setting, please express so on 25353
<achow101>
luke-jr: considering that the option currently does not exist in the codebase, I would not say "always"
<ariard>
yeah, prefix good
<luke-jr>
achow101: it's in older Core versions, and has been in Knots the entire time
<ariard>
i won't consider `disablerbf` for 25353, if we think `disablerbf` isn't worthy
<laanwj>
apart from that, yes, it seems what could have been a simple quick to mereg PR has been hijacked by bikeshedding and competing PR
<luke-jr>
ariard's being the competing one. I don't know why there was a desire to rewrite what has existed for years..
<ariard>
okay, i'll take the refactoring suggestion in 25353
<luke-jr>
and then even make it incompatible needlessly
<ariard>
luke-jr: should we OTS our PR opening next time :p ?
<laanwj>
incompatible with an option that hasn't existed for years
<luke-jr>
laanwj: yes, it has
<laanwj>
luke-jr: in your implementation, not core
<achow101>
the args manager makes the option that has beenremoved for years to already be incompatible
<luke-jr>
gratuitous incompatibility seems like a recurring problem in Core.
<achow101>
it literally errors on unknown options
<laanwj>
achow101: right
<luke-jr>
achow101: not in the config file
<laanwj>
ok, any other topics?
Talkless has quit [Quit: Konversation terminated!]
<laanwj>
or, would anyone like to talk about what they're working on?
<sipa>
Not much has changed on what I'm working on compared to the last time we did this.
<fanquake>
I’ve made some LTO related progress, and am circling back to musl builds
<sipa>
What are the prospects around musl?
<ariard>
luke-jr: sure, i think what matters between our 2 PRs, which are really equivalent, is making things well encapsulated
<fanquake>
sipa: My current PR will build you a fully static musl based bitcoind
<sipa>
Nice. Does the binary also work? ;)
<fanquake>
Still need to expand it for all hosts, building on non x86-64 etc
<fanquake>
I have done a sync with the binary 😅
<laanwj>
haha :)
<laanwj>
but great to hear that
<laanwj>
fully static LTO'ed binaries are getting closer
<sipa>
Great.
<ariard>
oh, i've a message from gleb who can't log in the chan apparently..
<ariard>
gleb "I just wanna mention that we had a good momentum with #23443 getting acks or near-acks from antoine and gloria, but then kinda lost it a month ago :( "
<fanquake>
and we can build those with a from src bootstrapped Guix
<ariard>
"I will rebase tomorrow, and the review is very very welcome to make progress on the first batch, perhaps one or two pair of extra eyes could make a big difference"
brunoerg has joined #bitcoin-core-dev
furszy has quit []
<ariard>
(sorry for the interruption)
<fanquake>
ariard: thanks for the update
<laanwj>
yes, thanks for the update, the IRC problem is strange, maybe not logged into nickserv?
<ariard>
yeah dunno what he's done with his IRC setup, i'll relay
<laanwj>
we had to enable posting for only logged in users, because of anonymoous off topic drive-by posting, a while ago
<laanwj>
i think that concludes the meeting, thanks for the updates! see you next week
<luke-jr>
ariard: being compatible with the existing option, is important
brunoerg has quit [Ping timeout: 260 seconds]
<ariard>
luke-jr: ah you mean compatiblity of the config file between node implementations?
<luke-jr>
ariard: yes
<luke-jr>
ariard: also note, the code in my PR has been in production use and well-tested (incl functional tests) for years
<ariard>
luke-jr: sure one comment feedback in 25353 was making things more encapsulate, now we take codebase modularity more seriously
belcher has quit [Quit: Leaving]
<ariard>
luke-jr: w.r.t to the compatibility of the config file between impl, i don't know what's core project philosophy on that, it open the door to have a weird haskell implem with no-users to require supporting their config file
<luke-jr>
ariard: if there's no reason *not* to use the same config option as weird Haskell impl, why not?
<luke-jr>
I'm not suggesting compatibility at all costs, only preferring it over incompatibility, between multiple equal possibilities
<ariard>
luke-jr: yeah i think it would take more thinkings to envision well all the cases of cross-implementation backward/forward compatibility, maybe open an issue to have a separate project discussion on that specific point ?
Guest38 has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<luke-jr>
don't have to envision things in advance either :P
<bitcoin-git>
bitcoin/master 7e7b3e4 fanquake: build: add and use C_STANDARD in depends
<bitcoin-git>
bitcoin/master f7595f1 fanquake: build: add and use CXX_STANDARD in depends
<bitcoin-git>
bitcoin/master 8745296 laanwj: Merge bitcoin/bitcoin#22380: build: add and use C_STANDARD and CXX_STANDAR...
<bitcoin-git>
[bitcoin] laanwj merged pull request #22380: build: add and use C_STANDARD and CXX_STANDARD in depends (master...set_std_c_version_depends) https://github.com/bitcoin/bitcoin/pull/22380
stick_ has quit []
stick has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
rex4539 has quit [Quit: No Ping reply in 180 seconds.]