brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
Guest50 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
jonatack has quit [Ping timeout: 256 seconds]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Client Quit]
luke-jr has joined #bitcoin-core-dev
luke-jr has quit [Client Quit]
luke-jr has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
jarthur has quit [Quit: jarthur]
bomb-on has quit [Quit: aллилѹіа!]
zxrqmz88 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 276 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
zxrqmz88 has quit [Quit: Quit]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
hebasto has quit [*.net *.split]
arturomf94[m] has quit [*.net *.split]
hendi has quit [*.net *.split]
windsok has quit [*.net *.split]
mjdietzx has quit [*.net *.split]
harding has quit [*.net *.split]
x88x88x has quit [*.net *.split]
jrayhawk has quit [*.net *.split]
otoburb has quit [*.net *.split]
roasbeef has quit [*.net *.split]
mjdietzx has joined #bitcoin-core-dev
harding has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
jrayhawk has joined #bitcoin-core-dev
windsok has joined #bitcoin-core-dev
otoburb has joined #bitcoin-core-dev
hendi has joined #bitcoin-core-dev
arturomf94[m] has joined #bitcoin-core-dev
sugarpuff_ has quit [*.net *.split]
gwillen has quit [*.net *.split]
MatrixBot1 has quit [*.net *.split]
notmandatory_ has quit [*.net *.split]
roasbeef has joined #bitcoin-core-dev
MatrixBot1 has joined #bitcoin-core-dev
notmandatory has joined #bitcoin-core-dev
sugarpuff_ has joined #bitcoin-core-dev
Guest25 has joined #bitcoin-core-dev
gwillen has joined #bitcoin-core-dev
gwillen has quit [Signing in (gwillen)]
gwillen has joined #bitcoin-core-dev
Guest25 has quit [Client Quit]
x88x88x has joined #bitcoin-core-dev
cameron[m] has quit [*.net *.split]
nickler has quit [*.net *.split]
livestradamus has quit [*.net *.split]
hugohn_ has quit [*.net *.split]
RubenSomsen has quit [*.net *.split]
hirish has quit [*.net *.split]
nickler has joined #bitcoin-core-dev
livestradamus has joined #bitcoin-core-dev
livestradamus has quit [Changing host]
livestradamus has joined #bitcoin-core-dev
hugohn_ has joined #bitcoin-core-dev
RubenSomsen has joined #bitcoin-core-dev
hirish has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
cameron[m] has joined #bitcoin-core-dev
Landryl6 has joined #bitcoin-core-dev
johnzwen- has joined #bitcoin-core-dev
erwanor_ has joined #bitcoin-core-dev
cfields_ has joined #bitcoin-core-dev
Keele_ has joined #bitcoin-core-dev
cjd_ has joined #bitcoin-core-dev
freedomcode has joined #bitcoin-core-dev
erwanor has quit [Ping timeout: 272 seconds]
johnzweng has quit [Ping timeout: 272 seconds]
cameron[m] has quit [Ping timeout: 272 seconds]
sipa has quit [Ping timeout: 272 seconds]
reardencode has quit [Ping timeout: 272 seconds]
Keele has quit [Ping timeout: 272 seconds]
cjd has quit [Ping timeout: 272 seconds]
Landryl has quit [Ping timeout: 272 seconds]
cfields has quit [Ping timeout: 272 seconds]
Landryl6 is now known as Landryl
brunoerg has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 248 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
cameron[m] has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
sipa has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 276 seconds]
JavaScript2169 has joined #bitcoin-core-dev
JavaScript2169 has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guest82 has joined #bitcoin-core-dev
Guest82 has quit [Client Quit]
rex4539_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
sipsorcery has joined #bitcoin-core-dev
bitdex has quit [*.net *.split]
SpellChecker has quit [*.net *.split]
ghost43 has quit [*.net *.split]
yanmaani has quit [*.net *.split]
vasild has quit [*.net *.split]
ghost43 has joined #bitcoin-core-dev
yanmaani has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
SpellChecker has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guest96 has joined #bitcoin-core-dev
Guest96 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
vasild has quit [Quit: leaving]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
realies has quit [Ping timeout: 276 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
realies has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
vasild has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
vasild has quit [Ping timeout: 268 seconds]
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<darosior> I couldn't make it to the wallet meeting but wanted to ask: achow101: could you have a look to #24148?
<gribble> https://github.com/bitcoin/bitcoin/issues/24148 | Miniscript support in Output Descriptors by darosior · Pull Request #24148 · bitcoin/bitcoin · GitHub
brunoerg has quit [Ping timeout: 268 seconds]
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
realies has quit [Ping timeout: 264 seconds]
realies has joined #bitcoin-core-dev
ebraminio has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<ebraminio> Hi people around, I have a minor code style tweak patch and contributing.md says 'Pull requests that refactor the code should not be made by new contributors.' which is totally understandable, so maybe I can send the link of change to someone here privately so I can get a quick Y/N review (I wouldn't argue on why not if the answer is simply No)
<ebraminio> before submitting the PR, it is essentially a minor code style fix taking advantage of a syntax change already available since C++11 but well contributing.md felt the repo is against any of such changes. Thanks!
realies has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
realies has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8e7eeb597144...a09033e22c4f
<bitcoin-git> bitcoin/master 20c58a3 Marnix: doc: typo fix
<bitcoin-git> bitcoin/master a09033e MacroFake: Merge bitcoin/bitcoin#25409: doc: fix typos
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #25409: doc: fix typos (master...MarnixCroes2022-06-fix-typo) https://github.com/bitcoin/bitcoin/pull/25409
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
ebraminio has quit [Quit: Ping timeout (120 seconds)]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] ebraminio opened pull request #25419: refactor: Remove space between two greater-than signs (master...master) https://github.com/bitcoin/bitcoin/pull/25419
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
<bitcoin-git> [bitcoin] MarnixCroes opened pull request #25420: rpc: small description/help improvements in blockchain.cpp (master...rpc-description-improvements-blockchain) https://github.com/bitcoin/bitcoin/pull/25420
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke closed pull request #25419: refactor: Remove space between two greater-than signs (master...master) https://github.com/bitcoin/bitcoin/pull/25419
brunoerg has quit [Ping timeout: 240 seconds]
vasild has quit [Ping timeout: 268 seconds]
vasild has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] vasild opened pull request #25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods (master...convert_IsSelectableSocket_and_SetSocketNonBlocking) https://github.com/bitcoin/bitcoin/pull/25421
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] jnewbery closed pull request #24970: net processing: Move cleanSubVer, fPreferredDownload and nLocalHostNonce to Peer (master...202204_net_net_processing) https://github.com/bitcoin/bitcoin/pull/24970
<bitcoin-git> [bitcoin] fanquake opened pull request #25422: build: globally define NOMINMAX when building with mingw-w64 (master...no_min_max_preprocessor) https://github.com/bitcoin/bitcoin/pull/25422
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
szkl has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #25424: build, qt: Fix `QMAKE_CXXFLAGS` expression for `mingw32` host (master...220620-cxxflags) https://github.com/bitcoin/bitcoin/pull/25424
gleb7454386852 has joined #bitcoin-core-dev
gleb745438685 has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 248 seconds]
sipsorcery has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guyver2_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #25425: build: Fix `::_wsystem` check (master...220620-wsystem) https://github.com/bitcoin/bitcoin/pull/25425
brunoerg has quit [Ping timeout: 255 seconds]
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
metallicc99 has quit [Remote host closed the connection]
zxrqmz88 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
emcy has quit [Read error: Connection reset by peer]
emcy_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] vasild opened pull request #25426: net: add new method Sock::GetSockName() that wraps getsockname() and use it in GetBindAddress() (master...getsockname) https://github.com/bitcoin/bitcoin/pull/25426
sipsorcery has quit [Ping timeout: 248 seconds]
Guest76 has joined #bitcoin-core-dev
<bitcoin-git> [gui] w0xlt opened pull request #620: qt: replace `QRegExp` with `QRegularExpression` (master...regexp-obsolete) https://github.com/bitcoin-core/gui/pull/620
furszy has joined #bitcoin-core-dev
Guest76 has quit [Quit: Client closed]
Guest76 has joined #bitcoin-core-dev
Guest50 has quit [Quit: Client closed]
evanlinjin has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
Guest76 has quit [Quit: Client closed]
Guest73 has joined #bitcoin-core-dev
Guest73 has quit [Ping timeout: 252 seconds]
ziggie has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] furszy opened pull request #25427: wallet: remove extra wtx lookup in AddToSpends (master...2022_wallet_AddToSpends_extra_wtx_lookup) https://github.com/bitcoin/bitcoin/pull/25427
<bitcoin-git> [bitcoin] vasild opened pull request #25428: Remove Sock::Release() and CloseSocket() (master...remove_Sock_Release_and_CloseSocket) https://github.com/bitcoin/bitcoin/pull/25428
<bitcoin-git> [gui] hebasto closed pull request #606: Replace QRegExp with QRegularExpression (master...regexp-obsolete) https://github.com/bitcoin-core/gui/pull/606
furszy has quit [Remote host closed the connection]
mikehu44_ has quit [Ping timeout: 248 seconds]
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #25429: refactor: Avoid UniValue copies (master...2206-uni-copy-👾) https://github.com/bitcoin/bitcoin/pull/25429
furszy has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theStack opened pull request #25430: test: refactor: save MiniWallet mode explicitly (master...202205-test-refactor-save_mode_for_MiniWallet) https://github.com/bitcoin/bitcoin/pull/25430
bomb-on has joined #bitcoin-core-dev
furszy has quit []
furszy has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
furszy has quit [Client Quit]
bomb-on has quit [Ping timeout: 264 seconds]
nanotube_ has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
nanotube has quit [Ping timeout: 246 seconds]
jeremyrubin has quit [Quit: The Lounge - https://thelounge.chat]
jeremyrubin has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]
<bitcoin-git> [bitcoin] laanwj pushed 9 commits to master: https://github.com/bitcoin/bitcoin/compare/a09033e22c4f...57a491bee17a
<bitcoin-git> bitcoin/master da8d304 CAnon: refactor: Move DEFAULT_ANCESTOR_LIMIT to policy/policy.h
<bitcoin-git> bitcoin/master 05fc5fd fanquake: refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.h
<bitcoin-git> bitcoin/master a34aa4c fanquake: refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.h
<bitcoin-git> [bitcoin] laanwj merged pull request #25388: refactor: move policy constants to policy (master...25295_cleanup_all_constants) https://github.com/bitcoin/bitcoin/pull/25388
jarthur has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 268 seconds]
Guest50 has joined #bitcoin-core-dev
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/57a491bee17a...bc28ca3afb7f
<bitcoin-git> bitcoin/master 25749f1 furszy: wallet: unify “allow/block other inputs“ concept
<bitcoin-git> bitcoin/master b4e2d4d furszy: wallet: move "use-only coinControl inputs" below the selected inputs lookup
<bitcoin-git> bitcoin/master 8dea74a furszy: refactor: use GetWalletTx in SelectCoins instead of access mapWallet
<bitcoin-git> [bitcoin] laanwj merged pull request #25118: wallet: unify “allow/block other inputs“ concept (master...2022_coinControl_unify_allowOtherInputs) https://github.com/bitcoin/bitcoin/pull/25118
gleb74543868529 has joined #bitcoin-core-dev
realies1 has joined #bitcoin-core-dev
realies has quit [Ping timeout: 240 seconds]
realies1 is now known as realies
jeremyrubin1 has joined #bitcoin-core-dev
jeremyrubin has quit [Ping timeout: 240 seconds]
gleb7454386852 has quit [Ping timeout: 240 seconds]
kexkey has quit [Ping timeout: 240 seconds]
jeremyrubin1 is now known as jeremyrubin
nanotube_ has quit [Ping timeout: 240 seconds]
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bc28ca3afb7f...6c6cc7989cac
<bitcoin-git> bitcoin/master 6c6cc79 laanwj: Merge bitcoin/bitcoin#25424: build, qt: Fix `QMAKE_CXXFLAGS` expression fo...
<bitcoin-git> bitcoin/master 71d33bf Hennadii Stepanov: build, qt: Fix `QMAKE_CXXFLAGS` expression for `mingw32` host
<bitcoin-git> [bitcoin] laanwj merged pull request #25424: build, qt: Fix `QMAKE_CXXFLAGS` expression for `mingw32` host (master...220620-cxxflags) https://github.com/bitcoin/bitcoin/pull/25424
AaronvanW has quit [Ping timeout: 264 seconds]
AaronvanW has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
nanotube_ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
sipsorcery has joined #bitcoin-core-dev
Guest50 has quit [Quit: Client closed]
sipsorcery has quit [Read error: Connection reset by peer]
sipsorcery has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6c6cc7989cac...e16f6441044f
<bitcoin-git> bitcoin/master 9d6a7b2 fanquake: build: sqlite 3380500 in depends
<bitcoin-git> bitcoin/master e16f644 laanwj: Merge bitcoin/bitcoin#25378: build: use sqlite 3380500 in depends
<bitcoin-git> [bitcoin] laanwj merged pull request #25378: build: use sqlite 3380500 in depends (master...sqlite_3380500) https://github.com/bitcoin/bitcoin/pull/25378
Guest33 has joined #bitcoin-core-dev
Guest33 has quit [Client Quit]
jonatack has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
vasild has quit [Ping timeout: 268 seconds]
vasild has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bomb-on has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 255 seconds]
aleggg has quit [Ping timeout: 276 seconds]
aleggg has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
sipsorcery has quit [Ping timeout: 244 seconds]
Guest25 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e16f6441044f...09a76e43fd60
<bitcoin-git> bitcoin/master 40566e2 Jadi: If -prune=0 is set, Uncheck Prune on Intro page
<bitcoin-git> bitcoin/master 09a76e4 Hennadii Stepanov: Merge bitcoin-core/gui#615: If -prune=0 is set, Uncheck Prune on Intro page
<bitcoin-git> [gui] hebasto merged pull request #615: If -prune=0 is set, Uncheck Prune on Intro page (master...jadi-prune-uncheck) https://github.com/bitcoin-core/gui/pull/615
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guest25 has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
<bitcoin-git> [bitcoin] Crypt-iQ opened pull request #25433: validation: remove unused using directives (master...remove_using) https://github.com/bitcoin/bitcoin/pull/25433