ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
rbatty has quit [Quit: rbatty]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
Guest68 has joined #bitcoin-core-dev
Guest68 has left #bitcoin-core-dev [#bitcoin-core-dev]
zato has quit [Quit: Om mani padme hum]
bitdex has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test__ has quit [Ping timeout: 260 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 268 seconds]
puchka has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
bob_x2 has quit [Excess Flood]
bob_x2 has joined #bitcoin-core-dev
Guest6228 has left #bitcoin-core-dev [#bitcoin-core-dev]
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
grndslm has quit [Read error: Connection reset by peer]
jarthur has quit [Quit: jarthur]
puchka has quit [Ping timeout: 260 seconds]
puchka has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
<bitcoin-git> [gui] MarnixCroes opened pull request #788: gui: debugwindow: update session ID tooltip (master...session-id-tooltip) https://github.com/bitcoin-core/gui/pull/788
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
pythcoiner has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
utzig has joined #bitcoin-core-dev
angusp has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/8106b268cde8...c818607ed59e
<bitcoin-git> bitcoin/master 42b2283 fanquake: depends: deduplicate use of mmacosx-version-min in macOS build
<bitcoin-git> bitcoin/master cbc9bf1 fanquake: build: move -mlinker-version to *FLAGS
<bitcoin-git> bitcoin/master c818607 fanquake: Merge bitcoin/bitcoin#29233: build: depends move macOS C(XX) FLAGS out of ...
<bitcoin-git> [bitcoin] fanquake merged pull request #29233: build: depends move macOS C(XX) FLAGS out of C & CXX (master...dedup_macos_flags) https://github.com/bitcoin/bitcoin/pull/29233
<bitcoin-git> [bitcoin] Sjors opened pull request #29259: Support self hosted Github workers on forks (master...2024/01/github-self-hosted-ci) https://github.com/bitcoin/bitcoin/pull/29259
PaperSword1 has joined #bitcoin-core-dev
PaperSword has quit [Ping timeout: 268 seconds]
PaperSword1 is now known as PaperSword
AaronvanW has joined #bitcoin-core-dev
test__ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 268 seconds]
AaronvanW has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] stickies-v opened pull request #29260: refactor: remove CTxMemPool::queryHashes() (master...2024-01/remove-queryhashes) https://github.com/bitcoin/bitcoin/pull/29260
AaronvanW has joined #bitcoin-core-dev
pythcoiner has quit [Quit: Client closed]
puchka has quit [Ping timeout: 252 seconds]
<sipa> instagibbs: would you be upset if i rewrite the diagram comparison logic?
<instagibbs> specifically "CompareFeerateDiagram"?
<sipa> i think there is a simpler approach that doesn't need Mul128/Add128, just FeeFrac operations
<instagibbs> Ah, please go ahead then
bitdex has quit [Quit: = ""]
szkl has quit [Quit: Connection closed for inactivity]
test__ is now known as _flood
otoburb has quit [Quit: leaving]
otoburb has joined #bitcoin-core-dev
<jamesob> Hm, found a possible performance regression in master. Anyone up to try to repro? https://github.com/bitcoin/bitcoin/pull/29169#issuecomment-1895934159
<sipa> jamesob: any unusual compilation flags?
<sipa> wait, this stops before the assumevalid point, so secp256k1 stuff should be irrelevant here
<jamesob> sipa: not the case; I manually set -assumevalid=000000000000000000176c192f42ad13ab159fdb20198b87e7ba3c001e47b876 (height=522_000) for these runs
<jamesob> sipa: no exotic flags; I have the config.log for each run if you'd like anything out of them
<sipa> jamesob: oh, i see
<sipa> yeah, the config.logs would be useful
jon_atack has quit [Ping timeout: 252 seconds]
preimage has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
PaperSword has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #29262: rpc: Fix race in loadtxoutset (master...2401-rpc-race-) https://github.com/bitcoin/bitcoin/pull/29262
<fanquake> <=>
<instagibbs> muh spaceship
<instagibbs> dank
<sipa> oops, missing file
Guest40 has joined #bitcoin-core-dev
<sipa> fixed
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/c818607ed59e...514268170b53
<bitcoin-git> bitcoin/master 999962d MarcoFalke: Add missing XOnlyPubKey::data() to get mutable data
<bitcoin-git> bitcoin/master fa96d93 MarcoFalke: refactor: Allow std::span construction from CKey
<bitcoin-git> bitcoin/master 5142681 fanquake: Merge bitcoin/bitcoin#29133: refactor: Allow std::span construction from C...
<bitcoin-git> [bitcoin] fanquake merged pull request #29133: refactor: Allow std::span construction from CKey (master...2312-key-span-) https://github.com/bitcoin/bitcoin/pull/29133
Guest38 has joined #bitcoin-core-dev
Guest38 has quit [Client Quit]
Guest40 has quit [Quit: Client closed]
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/514268170b53...3d52cedb497e
<bitcoin-git> bitcoin/master 008e81e TheCharlatan: contrib: Latest clang-format-diff.py script
<bitcoin-git> bitcoin/master 52149b7 TheCharlatan: contrib: Fix clang-format-diff.py lint errors
<bitcoin-git> bitcoin/master 3d52ced fanquake: Merge bitcoin/bitcoin#29251: contrib: Update clang-format-diff
<bitcoin-git> [bitcoin] fanquake merged pull request #29251: contrib: Update clang-format-diff (master...ClangFormatDiffBinaryOption) https://github.com/bitcoin/bitcoin/pull/29251
<sipa> instagibbs: it also simplifies the 128-bit multiply fallback code (because 96 bit actually suffices), and avoids the conditions to switch between 64-bit and 128-bit versions (the conditional makes performance worse in my benchmarks)
<instagibbs> awesome, will go over it asap
puchka has joined #bitcoin-core-dev
zato has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 252 seconds]
puchka has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 245 seconds]
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 276 seconds]
puchka has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 276 seconds]
puchka has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.1.2]
puchka has quit [Ping timeout: 264 seconds]
puchka has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
TheRec_ has quit [Ping timeout: 268 seconds]
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
pablomartin has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
_flood has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] theuni closed pull request #29057: Replace non-standard CLZ builtins with c++20's bit_width (master...bit_width) https://github.com/bitcoin/bitcoin/pull/29057
pablomartin4btc has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] theuni opened pull request #29263: serialization: c++20 endian/byteswap/clz modernization (master...cxx_20_endian2) https://github.com/bitcoin/bitcoin/pull/29263
pablomartin has quit [Ping timeout: 246 seconds]
<bitcoin-git> [bitcoin] fanquake closed pull request #28674: [POC] C++20 `std::endian` (master...cxx_20_endian) https://github.com/bitcoin/bitcoin/pull/28674
<bitcoin-git> [bitcoin] fanquake closed pull request #29036: Add missing byteswap functions for MSVC (master...msvc_fast_byteswap) https://github.com/bitcoin/bitcoin/pull/29036
Talkless has quit [Quit: Konversation terminated!]
<bitcoin-git> [bitcoin] instagibbs opened pull request #29264: Add max_tx_weight to transaction funding options (master...2024-01-max-tx-weight) https://github.com/bitcoin/bitcoin/pull/29264
<bitcoin-git> [bitcoin] Christewart opened pull request #29265: Add leaf_version parameter to `IsOpSuccess()` (master...2024-01-17-isopsuccess-leafver) https://github.com/bitcoin/bitcoin/pull/29265
aureleoules has quit [Ping timeout: 260 seconds]
___nick___ has quit [Ping timeout: 245 seconds]
aureleoules has joined #bitcoin-core-dev
vysn has quit [Remote host closed the connection]
realies has quit [Read error: Connection reset by peer]
Zenton has quit [Ping timeout: 256 seconds]
realies has joined #bitcoin-core-dev
test__ has joined #bitcoin-core-dev
flooded has quit [Ping timeout: 255 seconds]
jonatack has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.1.2]
jonatack has quit [Ping timeout: 276 seconds]
AaronvanW has quit [Remote host closed the connection]
bugs_ has quit [Quit: Leaving]
bitdex has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
bitdex_ has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
bitdex_ has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 256 seconds]
bitdex_ has quit [Remote host closed the connection]
bitdex_ has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
thodg has quit [Read error: Connection reset by peer]
thodg has joined #bitcoin-core-dev