brunoerg has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] maflcko opened pull request #29329: fuzz: Print coverage summary after run_once (master...2401-fuzz-print-cov-) https://github.com/bitcoin/bitcoin/pull/29329
jarthur has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<stevenroose>
Purely for debugging purposes, how hard would it be for Core to somehow propagate the sighash used in sig validation to the user in error messages when sig validation failed?
<stevenroose>
The sighash is there somewhere and getting a "invalid signature" error is really annoying if you're not sure consensus is looking at the same sighash as yourself. You basically can't know if the sighash is wrong or the signature is wrong.
<instagibbs>
to expose it to users seems really off, but maybe some TRACE level debug log?
<instagibbs>
otherwise do it like everyone: add your own printfs :P
<stevenroose>
instagibbs: yeah that'd be great already
<stevenroose>
instagibbs: considered that ofc, but I mean there is an error message that is being pushed up right? I just don't know if that msg is generated deep enough in a level that knows about the sighash, I'd think not.
<instagibbs>
stick BCLog::Level::Trace in the appropriate spots, open a PR? Anyone who's written wallets has been there
Jackielove4u has quit []
puchka has joined #bitcoin-core-dev
<darosior>
Also, btcdeb is helpful for this
Sip_E_Cup has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Guest35 has joined #bitcoin-core-dev
Guest35 has quit [Client Quit]
cotsuka has quit [Remote host closed the connection]
cotsuka has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
Sip_E_Cup has quit [Remote host closed the connection]
qxs has quit [Ping timeout: 255 seconds]
qxs has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
vasild has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
Guest65 has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 264 seconds]
Guest52 has joined #bitcoin-core-dev
Guest52 has quit [Client Quit]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
SpellChecker has quit [Remote host closed the connection]
<bitcoin-git>
[bitcoin] brunoerg opened pull request #29330: addrman: delete addresses that don't belong to the supported networks (master...2024-01-addrman-delete) https://github.com/bitcoin/bitcoin/pull/29330
___nick___ has quit [Ping timeout: 246 seconds]
Talkless has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 3bfc5bd stickies-v: test: ensure output is large enough to pay for its fees
<bitcoin-git>
bitcoin/master ff0eac0 Ava Chow: Merge bitcoin/bitcoin#29283: test: ensure output is large enough to pay fo...
<bitcoin-git>
[bitcoin] achow101 merged pull request #29283: test: ensure output is large enough to pay for its fees (master...2024-01/wallet-import-rescan-fix-intermittency) https://github.com/bitcoin/bitcoin/pull/29283