ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
AaronvanW has quit [Remote host closed the connection]
thodg has quit [Ping timeout: 268 seconds]
vasild_ has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 240 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
PaperSword has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
AaronvanW has joined #bitcoin-core-dev
qxs has quit [Remote host closed the connection]
AaronvanW has quit [Ping timeout: 276 seconds]
qxs has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
qxs has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
DEWEZ has quit [Quit: Leaving]
jarthur has quit [Quit: jarthur]
qxs has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 256 seconds]
vysn has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 276 seconds]
puchka has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
javi404 has quit [Ping timeout: 256 seconds]
javi404 has joined #bitcoin-core-dev
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 268 seconds]
AaronvanW has quit [Ping timeout: 240 seconds]
qxs has quit [Quit: Lost terminal]
qxs has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 256 seconds]
luke-jr has joined #bitcoin-core-dev
Flow has quit [Ping timeout: 245 seconds]
Guyver2 has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
qxs has quit [Ping timeout: 240 seconds]
luke-jr_ has quit [Ping timeout: 260 seconds]
qxs has joined #bitcoin-core-dev
Flow has joined #bitcoin-core-dev
brunoerg has quit []
brunoerg has joined #bitcoin-core-dev
<vasild> Sjors[m]: FUZZ=banman ./src/test/fuzz/fuzz --printtoconsole=1
<vasild> cool :)
noonien has quit [Quit: The Lounge - https://thelounge.chat]
noonien has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
zato has joined #bitcoin-core-dev
qxs has quit [Ping timeout: 240 seconds]
qxs has joined #bitcoin-core-dev
noonien has quit [Quit: The Lounge - https://thelounge.chat]
noonien has joined #bitcoin-core-dev
noonien7 has joined #bitcoin-core-dev
noonien has quit [Ping timeout: 264 seconds]
noonien7 is now known as noonien
puchka has quit [Ping timeout: 260 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 256 seconds]
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
Chris_Stewart_5 has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] Sjors opened pull request #29295: CKey: add Unserialize (master...2024/01/ckey_unserialize) https://github.com/bitcoin/bitcoin/pull/29295
jonatack has quit [Quit: WeeChat 4.1.2]
Chris_Stewart_5 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
zato has quit [Quit: Om mani padme hum]
<maflcko> PSA (if you see a CI failure on your pull request): https://github.com/bitcoin/bitcoin/pull/29218#issuecomment-1906227242
jonatack has quit [Ping timeout: 256 seconds]
puchka has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
furszy_ has joined #bitcoin-core-dev
BlueMatt has joined #bitcoin-core-dev
_cold has joined #bitcoin-core-dev
Guest4 has joined #bitcoin-core-dev
Guest4 has quit [Client Quit]
lbia1 has joined #bitcoin-core-dev
freedomcode has joined #bitcoin-core-dev
lbia has quit [Ping timeout: 264 seconds]
BlueMatt_ has quit [Ping timeout: 264 seconds]
furszy has quit [Ping timeout: 264 seconds]
reardencode has quit [Ping timeout: 264 seconds]
flooded has quit [Ping timeout: 264 seconds]
cold has quit [Ping timeout: 264 seconds]
adil has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
preimage has quit [Client Quit]
stmbln has joined #bitcoin-core-dev
stmbln has left #bitcoin-core-dev [#bitcoin-core-dev]
SpellChecker has quit [Remote host closed the connection]
qxs has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
qxs has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/651fb034d85e...8c9dceb962b2
<bitcoin-git> bitcoin/master 97181de Chris Stewart: Add test for negative transaction version w/ CSV to tx_valid.json
<bitcoin-git> bitcoin/master 8c9dceb fanquake: Merge bitcoin/bitcoin#29291: Add test for negative transaction version w/ ...
<bitcoin-git> [bitcoin] fanquake merged pull request #29291: Add test for negative transaction version w/ CSV to tx_valid.json (master...2024-01-11-locktime-neg-txversion-test) https://github.com/bitcoin/bitcoin/pull/29291
preimage has joined #bitcoin-core-dev
adil has quit [Quit: adil]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8c9dceb962b2...f1ab078ed774
<bitcoin-git> bitcoin/master b8105b3 Ryan Ofsky: depends: Update libmultiprocess library to fix C++20 macos build error
<bitcoin-git> bitcoin/master f1ab078 fanquake: Merge bitcoin/bitcoin#29276: depends: Update libmultiprocess library to fi...
<bitcoin-git> [bitcoin] fanquake merged pull request #29276: depends: Update libmultiprocess library to fix C++20 macos build error (master...pr/c14) https://github.com/bitcoin/bitcoin/pull/29276
zato has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] dergoegge opened pull request #165: Add fuzz inputs (main...2024-01-inputs) https://github.com/bitcoin-core/qa-assets/pull/165
___nick___ has joined #bitcoin-core-dev
Guest66 has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
jonatack has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
<sdaftuar> glozow: I was wondering why testmempoolaccept will process (as a package/AcceptMultipleTransactions) sets of transactions that are not connected?
<sdaftuar> it seems like AcceptMultipleTransactions could be much simpler, eg for the v3 case, if we didn't have to deal with that as a possibility -- my thought was that disconnected components could be processed separately
<sdaftuar> but i wasn't sure if there was a reason that we do things this way?
Guest66 has quit [Quit: Client closed]
Talkless has quit [Ping timeout: 260 seconds]
test_ is now known as _flood
<glozow> sdaftuar: the answer to that question is that I wrote #20833 not knowing anything about package relay and was actually just trying to enable a "multi testmempoolaccept" feature 😅. At the time people were suggesting #21413 as a use case, and I hadn't thought about child-with-parents topology yet
<gribble> https://github.com/bitcoin/bitcoin/issues/20833 | rpc/validation: enable packages through testmempoolaccept by glozow · Pull Request #20833 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/21413 | [rfc] add option to bypass contextual timelocks in testmempoolaccept? by glozow · Pull Request #21413 · bitcoin/bitcoin · GitHub
<glozow> Today, I can't think of a good reason... agree that it would make the most sense to packageify the transactions before sending them to validation
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
preimage has quit [Ping timeout: 264 seconds]
tecnecio has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/f1ab078ed774...7cb7759b25f3
<bitcoin-git> bitcoin/master 2d58629 Richard Myers: wallet: fix coin selection tracing to return -1 when no change pos
<bitcoin-git> bitcoin/master d55fdb1 Richard Myers: Move TRACEx parameters to seperate lines
<bitcoin-git> bitcoin/master 7cb7759 Ava Chow: Merge bitcoin/bitcoin#29272: wallet: fix coin selection tracing to return ...
<bitcoin-git> [bitcoin] achow101 merged pull request #29272: wallet: fix coin selection tracing to return -1 when no change pos (master...cs-usdt-fixup) https://github.com/bitcoin/bitcoin/pull/29272
zato has quit [Quit: Om mani padme hum]
szkl has quit [Quit: Connection closed for inactivity]
AaronvanW has joined #bitcoin-core-dev
qxs has quit [Ping timeout: 240 seconds]
qxs has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7cb7759b25f3...6f732ffc3c91
<bitcoin-git> bitcoin/master 32a9f13 Vasil Dimov: wallet: avoid returning a reference to vMasterKey after releasing the mute...
<bitcoin-git> bitcoin/master 6f732ff Ava Chow: Merge bitcoin/bitcoin#28774: wallet: avoid returning a reference to vMaste...
<bitcoin-git> [bitcoin] achow101 merged pull request #28774: wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it (master...avoid_returning_reference_to_mutex_guarded_member) https://github.com/bitcoin/bitcoin/pull/28774
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/6f732ffc3c91...874c8bdb9e3c
<bitcoin-git> bitcoin/master 966f5de furszy: init: improve corrupted/empty settings file error msg
<bitcoin-git> bitcoin/master e901404 furszy: settings: add auto-generated warning msg for editing the file manually
<bitcoin-git> bitcoin/master 874c8bd Ava Chow: Merge bitcoin/bitcoin#29144: init: handle empty settings file gracefully
<bitcoin-git> [bitcoin] achow101 merged pull request #29144: init: handle empty settings file gracefully (master...2023_empty_settings_file) https://github.com/bitcoin/bitcoin/pull/29144
preimage has joined #bitcoin-core-dev
tecnecio has quit [Quit: Leaving]
jonatack has quit [Ping timeout: 264 seconds]
bugs_ has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
bomb-on has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] petertodd opened pull request #29297: RBF: Require unconfirmed inputs to come from a single conflicting transaction (master...2024-01-rbf-merging-unconfirmed-inputs) https://github.com/bitcoin/bitcoin/pull/29297
___nick___ has quit [Ping timeout: 260 seconds]
qxs has quit [Ping timeout: 240 seconds]
qxs has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/874c8bdb9e3c...2f218c664b32
<bitcoin-git> bitcoin/master 4aaee23 Ryan Ofsky: test: add ipc test to test multiprocess type conversion code
<bitcoin-git> bitcoin/master 0cc74fc Ryan Ofsky: multiprocess: Add type conversion code for serializable types
<bitcoin-git> bitcoin/master 6acec6b Ryan Ofsky: multiprocess: Add type conversion code for UniValue types
<bitcoin-git> [bitcoin] achow101 merged pull request #28921: multiprocess: Add basic type conversion hooks (master...pr/ipcc) https://github.com/bitcoin/bitcoin/pull/28921
<bitcoin-git> [bitcoin] theuni opened pull request #29298: depends: patch libool out of libnatpmp/miniupnpc (master...depends-no-libtool2) https://github.com/bitcoin/bitcoin/pull/29298
<bitcoin-git> [bitcoin] theuni closed pull request #29232: depends: remove dependency on Darwin libtool (master...depends-no-libtool) https://github.com/bitcoin/bitcoin/pull/29232
<bitcoin-git> [bitcoin] achow101 pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/2f218c664b32...e69796c79c0a
<bitcoin-git> bitcoin/master 435fe5c josibake: test: add tests for fundrawtx and sendmany rpcs
<bitcoin-git> bitcoin/master 6f569ac josibake: refactor: move normalization to new function
<bitcoin-git> bitcoin/master f7384b9 josibake: refactor: move parsing to new function
<bitcoin-git> [bitcoin] achow101 merged pull request #28560: wallet, rpc: `FundTransaction` refactor (master...fundtransaction-sffo-crecipient-refactor) https://github.com/bitcoin/bitcoin/pull/28560
jonolito has joined #bitcoin-core-dev
jonolito has quit [Client Quit]
AaronvanW has quit [Remote host closed the connection]
_cold is now known as cold
vysn has quit [Remote host closed the connection]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
virtu has quit [Ping timeout: 264 seconds]
preimage has quit [Quit: WeeChat 4.2.1]
<bitcoin-git> [bitcoin] mzumsande opened pull request #29299: validation: improve checkblockindex comments (master...202401_cbi_assert) https://github.com/bitcoin/bitcoin/pull/29299
bugs_ has quit [Quit: Leaving]
AaronvanW has quit [Ping timeout: 256 seconds]
Calabrese has joined #bitcoin-core-dev