thodg has quit [Read error: Connection reset by peer]
thodg has joined #bitcoin-core-dev
Guest73 has left #bitcoin-core-dev [#bitcoin-core-dev]
abubakarsadiq has joined #bitcoin-core-dev
<Chris_Stewart_5>
sipa: I don't think that is correct. While we don't agree on the means of implementing these, the point holds true of any OP_SUCCESSx op code being used in the future I believe. Prior semantics cause the Script to trivially pass when seeing OP_SUCCESSx. Now we have new restrictions (such as inputs being 8 bytes in len) on the OP_SUCCESSx that will cause the 'success' test vectors to fail
<Chris_Stewart_5>
in script_assets.json.
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
puchka has joined #bitcoin-core-dev
puchka has quit [Client Quit]
<sipa>
Chris_Stewart_5: but script_assets.json specifies which verification flags are passed; if the flags don't change, the test outcomes should not change
<sipa>
if they do, you're at least affecting script validation _prior_ to your proposed softfork activating
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
<sipa>
Chris_Stewart_5: you're right that this does not imply it's not a softfork, but you shouldn't be changing consensus when your softfork isn't active
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
<sipa>
Chris_Stewart_5: in your closed PR i don't see any activation logic to gate the new behavior on, so that would explain why the tests fail
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 264 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
reardencode has quit [Ping timeout: 245 seconds]
reardencode has joined #bitcoin-core-dev
<Chris_Stewart_5>
sipa: Ah ok, so gate the logic (whether with a new leaf version of policy flag) and things should work. That makes sense.
<sipa>
Chris_Stewart_5: yes, a script execution flag; if the flag is not active, the behavior of the interpreter should not change (which e.g. means that a new leaf version cannot even be triggered)
<Chris_Stewart_5>
I'm having a hard time understanding the difference between script execution flags and leaf versions. Leaf versions are _user specified_ , although I guess you can argue that script execution flags are user specified as well (they are _choosing_ what version of bitcoind to run). Is there any write up on the differences between the two or how modern soft forks in a taproot world should be
<Chris_Stewart_5>
both seem to also affect global consensus - I believe both can cause chain splits if a majority is not enforcing leaf version or script execution flag rules
zato has joined #bitcoin-core-dev
<sipa>
Chris_Stewart_5: that's the definition of a softfork: a consensus change that is safe if enforced by a majority of the hashrate
<sipa>
Chris_Stewart_5: script flags indicate which consensus rules are active; logic for assigning meaning to a leaf version would be subject to the corresponding script flag being active
<sipa>
but sorry, i'm going to stop commenting here; i don't want to get dragged into consensus change discussions anymore
brunoerg has quit [Ping timeout: 268 seconds]
JongJan has joined #bitcoin-core-dev
not_reserved has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 255 seconds]
puchka has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 255 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 252 seconds]
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
dviola has quit [Quit: WeeChat 4.1.2]
jonatack has quit [Ping timeout: 246 seconds]
dviola has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 264 seconds]
szkl has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 245 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
not_reserved has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]