ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
kevkevin has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
Earnestly has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
upekkha has quit []
upekkha has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
Guest25 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
Guest25 has quit [Quit: Ping timeout (120 seconds)]
Guest25 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 268 seconds]
Guest25 has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
test_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
flooded has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
jarthur has quit [Ping timeout: 240 seconds]
jarthur_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
not_reserved has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
flooded has joined #bitcoin-core-dev
test_ has quit [Ping timeout: 252 seconds]
jarthur_ has quit [Quit: jarthur_]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
jarthur has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
Adamperry has joined #bitcoin-core-dev
Adamperry has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest30 has joined #bitcoin-core-dev
Guest30 has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
kevkevin has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
test_ has joined #bitcoin-core-dev
josie has quit [Remote host closed the connection]
flooded has quit [Ping timeout: 245 seconds]
oneeyedalien has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
<bitcoin-git> [bitcoin] Retropex opened pull request #29173: doc: revert clarify -datacarriersize (master...doc-datacarrier) https://github.com/bitcoin/bitcoin/pull/29173
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
jarthur has quit [Quit: jarthur]
Guyver2 has joined #bitcoin-core-dev
oneeyedalien has quit [Quit: Leaving]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 255 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Guest80 has joined #bitcoin-core-dev
Guest80 has quit [Client Quit]
Guest80 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
abubakarsadiq has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
Guest80 has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
Guest80 has joined #bitcoin-core-dev
<bitcoin-git> [qa-assets] dergoegge merged pull request #164: Add Murch’s fuzz seed in January 2024 (main...2024-01-murch) https://github.com/bitcoin-core/qa-assets/pull/164
<bitcoin-git> [qa-assets] dergoegge pushed 2 commits to main: https://github.com/bitcoin-core/qa-assets/compare/1da8e1797aa4...0745c8615dff
<bitcoin-git> qa-assets/main 7072888 Murch: Add fuzz seeds
<bitcoin-git> qa-assets/main 0745c86 Niklas Gögge: Merge pull request #164 from murchandamus/2024-01-murch
brunoerg has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
jQrgen_ has joined #bitcoin-core-dev
jQrgen__ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow closed pull request #29173: doc: revert clarify -datacarriersize (master...doc-datacarrier) https://github.com/bitcoin/bitcoin/pull/29173
jQrgen_ has quit [Ping timeout: 256 seconds]
not_reserved has quit [Ping timeout: 250 seconds]
jQrgen__ has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] torkelrogstad opened pull request #29175: rpc: validate fee estimation mode case insensitive (master...2024-01-04-estimatemode) https://github.com/bitcoin/bitcoin/pull/29175
Earnestly has joined #bitcoin-core-dev
Guest80 has quit [Quit: Client closed]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Remote host closed the connection]
jQrgen_ has joined #bitcoin-core-dev
jQrgen__ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 260 seconds]
ajonas has quit [Quit: Connection closed for inactivity]
Guyver2_ has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko opened pull request #29176: wallet: Fix use-after-free in WalletBatch::EraseRecords (master...2401-wallet-fix-a-bug-) https://github.com/bitcoin/bitcoin/pull/29176
brunoerg has quit [Ping timeout: 276 seconds]
josie has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
<bitcoin-git> [bitcoin] hebasto opened pull request #29177: build: Fix check whether `-latomic` needed (master...240104-atomic) https://github.com/bitcoin/bitcoin/pull/29177
jQrgen__ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
utzig has quit [Read error: Connection reset by peer]
angusp has quit [Write error: Connection reset by peer]
angusp has joined #bitcoin-core-dev
utzig has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
puchka has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
bitdex has quit [Quit: = ""]
not_reserved has joined #bitcoin-core-dev
realies has quit [Read error: Connection reset by peer]
realies has joined #bitcoin-core-dev
guest-127 has joined #bitcoin-core-dev
<glozow> hi
kevkevin has joined #bitcoin-core-dev
<glozow> #startmeeting
<dergoegge> hi
<Sjors[m]> hi
<TheCharlatan> hi
<stickies-v> hi
<hebasto> hi
<fjahr> hi
<glozow> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa theStack TheCharlatan vasild
<brunoerg> hi
<darosior> hi
<furszy> hi
<vasild> hi
<glozow> Any last minute topics to add?
<cfields> hi
<josie> hi
<LarryRuane> Hi
<glozow> I'm having trouble seeing whether there are proposed topics. Please lmk if you proposed a topic, I'm going to start with project updates
<glozow> #topic silent payments updates (josie)
<josie> no updates, still looking for review on #28560
<gribble> https://github.com/bitcoin/bitcoin/issues/28560 | wallet, rpc: `FundTransaction` refactor by josibake · Pull Request #28560 · bitcoin/bitcoin · GitHub
<josie> been making some bip updates, mostly style, but planning to finalize all of that this week
<sdaftuar> hi
<josie> thats all for me
<glozow> #topic package relay updates (glozow)
<abubakarsadiq> hi
<glozow> #28948 has had some activity in the past few days
<gribble> https://github.com/bitcoin/bitcoin/issues/28948 | v3 transaction policy for anti-pinning by glozow · Pull Request #28948 · bitcoin/bitcoin · GitHub
<kevkevin> hi
<glozow> re: criticisms about real world usage, we're working on getting some more recent comments from LN people as well as feedback on instagibbs' designs on using single-anchor v3/EA commitment txns
<glozow> instagibbs also has an update, "for package rbf I'm looking at using Suhas code to have diagram check instead of heuristic "
PaperSword has joined #bitcoin-core-dev
<glozow> (that's for #28984)
<gribble> https://github.com/bitcoin/bitcoin/issues/28984 | Cluster size 2 package rbf by instagibbs · Pull Request #28984 · bitcoin/bitcoin · GitHub
<glozow> #topic multiprocess updates (ryanofsky)
<fjahr> (if ryanofsky isn’t here) #28978 was merged, per the tracking issue it appears that #28921 and #28929 are ready for review but unsure which one is higher priority
<gribble> https://github.com/bitcoin/bitcoin/issues/28978 | doc: Add multiprocess design doc by ryanofsky · Pull Request #28978 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28921 | multiprocess: Add basic type conversion hooks by ryanofsky · Pull Request #28921 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28929 | serialization: Support for multiple parameters by ryanofsky · Pull Request #28929 · bitcoin/bitcoin · GitHub
<Murch[m]> Hi
<glozow> I'll add #28921 to the board since the other one needs rebase?
<gribble> https://github.com/bitcoin/bitcoin/issues/28921 | multiprocess: Add basic type conversion hooks by ryanofsky · Pull Request #28921 · bitcoin/bitcoin · GitHub
<fjahr> sounds good
<glozow> ok cool
<glozow> #topic Ad-hoc high priority for review
<glozow> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4?
<pinheadmz> #27375 has an ACK by vasild. I'd love another review on that before I have to rebase again. Will bake cookies and ship them anywhere in the world for your time. 🍪🙏
<gribble> https://github.com/bitcoin/bitcoin/issues/27375 | net: support unix domain sockets for -proxy and -onion by pinheadmz · Pull Request #27375 · bitcoin/bitcoin · GitHub
<glozow> pinheadmz: 👀 🍪
<glozow> Anything else to discuss?
<vasild> aha! then I want cookies for me too! :-D
<glozow> #endmeeting
guest-127 has quit [Quit: Client closed]
<pinheadmz> Yes I owe you big cookies
brunoerg has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/65c05db660b2...d84f736ba185
<bitcoin-git> bitcoin/master faebf1d MarcoFalke: wallet: Fix use-after-free in WalletBatch::EraseRecords
<bitcoin-git> bitcoin/master d84f736 Ava Chow: Merge bitcoin/bitcoin#29176: wallet: Fix use-after-free in WalletBatch::Er...
<bitcoin-git> [bitcoin] achow101 merged pull request #29176: wallet: Fix use-after-free in WalletBatch::EraseRecords (master...2401-wallet-fix-a-bug-) https://github.com/bitcoin/bitcoin/pull/29176
zato has joined #bitcoin-core-dev
ChanServ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
TomBriar has joined #bitcoin-core-dev
puchka has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
test_ is now known as _flood
kevkevin has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 260 seconds]
puchka has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] glozow opened pull request #29179: test: wallet rescan with reorged parent + IsFromMe child in mempool (master...2024-01-test-reorg-rescan) https://github.com/bitcoin/bitcoin/pull/29179
kevkevin has joined #bitcoin-core-dev
PaperSword has quit [Quit: PaperSword]
not_reserved has quit [Quit: Client closed]
preimage has joined #bitcoin-core-dev
pablomartin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/d84f736ba185...737e5884cc82
<bitcoin-git> bitcoin/master 29fde02 fanquake: Squashed 'src/secp256k1/' changes from 199d27cea3..efe85c70a2
<bitcoin-git> bitcoin/master e2cdeb5 fanquake: Update secp256k1 subtree to latest master
<bitcoin-git> bitcoin/master 737e588 glozow: Merge bitcoin/bitcoin#29169: Update libsecp256k1 subtree to current master
<bitcoin-git> [bitcoin] glozow merged pull request #29169: Update libsecp256k1 subtree to current master (master...libsecp256k1_0_4_1) https://github.com/bitcoin/bitcoin/pull/29169
guest-127 has joined #bitcoin-core-dev
<dergoegge> i was trying to write a test for the adjusted time warning but apparently it is not possible to send custom version messages from outbound connections in the func tests?
henmeh has joined #bitcoin-core-dev
Guest3466 has joined #bitcoin-core-dev
alanD has joined #bitcoin-core-dev
alanD has quit [Client Quit]
bugs_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<furszy> dergoegge: make a of P2PInterface and override the 'peer_connect_send_version' method with your custom msg_version
<furszy> *make a child of P2PInterface
<dergoegge> right that should work, thanks
<bitcoin-git> [bitcoin] theuni opened pull request #29180: crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256 (master...kernel-sha2-optims) https://github.com/bitcoin/bitcoin/pull/29180
<sipa> dergoegge: there is a hidden RPC to cause an arbitrary message to be sent
<dergoegge> sipa: I want to send a message to a node from a P2PInterface, so after calling `add_outbound_p2p_connection` i want to control the timestamp in the version message send from that connection to the node
<dergoegge> I'm pretty sure what furszy suggested will work
Guest3466 has quit [Quit: Client closed]
<sipa> ah
Guest9720 has joined #bitcoin-core-dev
Guest9720 has quit [Client Quit]
jQrgen_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #29181: build: remove systemtap variadic patch (master...drop_systemtap_variadic_patch) https://github.com/bitcoin/bitcoin/pull/29181
jQrgen_ has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] L0laL33tz opened pull request #29182: test: randomize perturbed files excluding ldb (master...fix_feature_init) https://github.com/bitcoin/bitcoin/pull/29182
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
willcl-ark has quit [Ping timeout: 276 seconds]
guest-127 has quit [Quit: Client closed]
henmeh has quit [Quit: Leaving]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
willcl-ark has quit [Changing host]
brunoerg has joined #bitcoin-core-dev
flooded has joined #bitcoin-core-dev
jQrgen_ has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 246 seconds]
jQrgen_ has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
willcl-ark has quit [Ping timeout: 276 seconds]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has quit [Changing host]
willcl-ark has joined #bitcoin-core-dev
jonatack has quit [Quit: WeeChat 4.1.2]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 276 seconds]
Talkless has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
kevkevin has quit [Remote host closed the connection]
jQrgen_ has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 268 seconds]
willcl-ark has quit [Ping timeout: 246 seconds]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has quit [Changing host]
willcl-ark has joined #bitcoin-core-dev
cryptografikturk has joined #bitcoin-core-dev
cryptografikturk has quit [Client Quit]
Talkless has quit [Quit: Konversation terminated!]
cryptografikturk has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] luke-jr opened pull request #29184: RPC/Blockchain: scanblocks: Accept named param for filter_false_positives (master...rpc_scanblocks_ffp_named) https://github.com/bitcoin/bitcoin/pull/29184
jarthur has joined #bitcoin-core-dev
DarrylTheFish has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 276 seconds]
kevkevin has quit [Ping timeout: 246 seconds]
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
brunoerg has quit [Ping timeout: 252 seconds]
brunoerg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
bomb-on has quit [Quit: aллилѹіа!]
kevkevin has quit [Ping timeout: 256 seconds]
preimage has quit [Quit: WeeChat 4.1.1]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
jonatack has joined #bitcoin-core-dev
darosior has quit [Ping timeout: 264 seconds]
PaperSword has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/737e5884cc82...d44554567f27
<bitcoin-git> bitcoin/master a44808f Antoine Poinsot: fuzz: rule-out too deep derivation paths in descriptor parsing targets
<bitcoin-git> bitcoin/master d445545 Ava Chow: Merge bitcoin/bitcoin#28832: fuzz: rule-out too deep derivation paths in d...
<bitcoin-git> [bitcoin] achow101 merged pull request #28832: fuzz: rule-out too deep derivation paths in descriptor parsing targets (master...2311_fuzz_timeout_desc_parse) https://github.com/bitcoin/bitcoin/pull/28832
test_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
darosior has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
flooded has quit [Ping timeout: 246 seconds]
jQrgen_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jQrgen_ has quit [Ping timeout: 245 seconds]
brunoerg has quit [Ping timeout: 245 seconds]
benwestgate has quit [Quit: Leaving.]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]