<vasild>
What is the correct way to serialize a transaction? if (tx->HasWitness()) { MakeAndPushMessage(node, NetMsgType::TX, TX_WITH_WITNESS(*tx)); } else { MakeAndPushMessage(node, NetMsgType::TX, TX_NO_WITNESS(*tx)); }
<vasild>
I find the (::SerializeMany(*~!@, ...), ...) code a bit hard to follow, so I step inside a debugger to see what is going on
<vasild>
Looks like SerializeTransaction() will add the witness if TX_WITH_WITNESS() is used _and_ there is a witness => a tx without a witness will be serialized just fine even when TX_WITH_WITNESS() is used, right?
<vasild>
whereas the witness will be omitted if TX_NO_WITNESS() is used _or_ there is no witness
<_aj_>
use TX_WITH_WITNESS(*tx). only use TX_NO_WITNESS(*tx) for backwards compat with things that can't process witness data
<vasild>
_aj_: thanks, for confirming, just TX_WITH_WITNESS() and don't check tx->HasWitness() explicitly, right?
<_aj_>
yeah, the serialization code checks HasWitness already
jespada has quit [Read error: Connection reset by peer]
jespada has joined #bitcoin-core-dev
the_mariner has joined #bitcoin-core-dev
willcl-ark has quit [Quit: left]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has quit [Changing host]
willcl-ark has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
willcl-ark has quit [Quit: left]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
TracaChang has quit [Remote host closed the connection]
TracaChang has joined #bitcoin-core-dev
Guest66 has joined #bitcoin-core-dev
TracaChang has quit [Remote host closed the connection]
TracaChang has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #29354: test: Assumeutxo with more than just coinbase transactions (master...2401-test-au-tx-) https://github.com/bitcoin/bitcoin/pull/29354
<bitcoin-git>
[bitcoin] maflcko opened pull request #29355: doc: Assert that assumed-valid blocks are not fully valid in CheckBlockIndex() (master...2401-doc-au-fully-valid-) https://github.com/bitcoin/bitcoin/pull/29355
Guyver2 has left #bitcoin-core-dev [Closing Window]
test_ has joined #bitcoin-core-dev
_flood has quit [Ping timeout: 260 seconds]
pablomartin has joined #bitcoin-core-dev
<real_or_random>
hm yeah. at least for secp256k1, we don't really care. ^^ we have 3 single-thread test binaries, so 3 CPUs is perfect :D
<bitcoin-git>
[bitcoin] stratospher opened pull request #29356: [test] make v2transport arg in addconnection mandatory and few cleanups (master...24748-followups) https://github.com/bitcoin/bitcoin/pull/29356
Chris_Stewart_5 has joined #bitcoin-core-dev
Guest66 has joined #bitcoin-core-dev
puchka has quit [Ping timeout: 264 seconds]
jarthur has joined #bitcoin-core-dev
jarthur_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 268 seconds]
<bitcoin-git>
[bitcoin] hebasto opened pull request #29357: test: Drop `x` modifier in `fsbridge::fopen` call (master...240131-fopen-x) https://github.com/bitcoin/bitcoin/pull/29357
Guest66 has quit [Quit: Client closed]
rbatty has quit [Remote host closed the connection]
Talkless has quit [Quit: Konversation terminated!]
Talkless has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Guest94 has joined #bitcoin-core-dev
Guest94 has quit [Client Quit]
Talkless has quit [Ping timeout: 260 seconds]
szkl has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #29358: test: use v2 everywhere for P2PConnection if --v2transport is enabled (master...202401_bip324_alltests) https://github.com/bitcoin/bitcoin/pull/29358
abubakarsadiq has quit [Quit: Connection closed for inactivity]