AaronvanW has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 252 seconds]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
zato has quit [Quit: Om mani padme hum]
lbia has quit [Quit: lbia]
PaperSword has quit [Remote host closed the connection]
puchka has quit [Ping timeout: 268 seconds]
AaronvanW has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 256 seconds]
cmirror has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.2.1]
adil has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 260 seconds]
puchka has joined #bitcoin-core-dev
adil has quit [Quit: adil]
AaronvanW has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
adil has quit [Quit: adil]
salvatoshi has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
adil has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #29369: refactor: Allow CScript construction from any std::input_iterator (master...2402-script-input-iterator-) https://github.com/bitcoin/bitcoin/pull/29369
adil has quit [Quit: adil]
achow101 has quit [Ping timeout: 268 seconds]
the_mariner has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 255 seconds]
vasild has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 260 seconds]
GregTonoski has joined #bitcoin-core-dev
GregTonoski has quit [Quit: GregTonoski]
the_mariner has joined #bitcoin-core-dev
dviola has joined #bitcoin-core-dev
the_mariner1 has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 252 seconds]
the_mariner1 is now known as the_mariner
adil has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 256 seconds]
the_mariner has joined #bitcoin-core-dev
the_mariner has quit [Ping timeout: 246 seconds]
jon_atack has joined #bitcoin-core-dev
the_mariner has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
adil has quit [Quit: adil]
szkl has quit [Quit: Connection closed for inactivity]
<Chris_Stewart_5>
i think is_op_success() might be an exception. I've oscillated between parameterizing it with SigVersion/leaf_version. Currently have it as SigVersion in the c++ codebase and will have to do leaf_version in python. Ig your abstraction still holds true tho IIUC
<Chris_Stewart_5>
actually i think the errors now being caused walk me in the right direction of implementation still needed. Thanks!
<Chris_Stewart_5>
sipa: Something you've mentioned before is don't touch consensus code piecemeal. Do you feel the same way about the python test framework? For instance something i'm going to need to do is add a param to 'taproot_tree_helper' to allow for a specific leaf version in script.py . Does that make sense to pull out into a separate PR or not?
<sipa>
Chris_Stewart_5: certainly the argument "consensus code requires very thorough review, don't do it if unnecessary" doesn't hold... but unless it's an independent improvement to the test, perhaps people won't be inclined to review it
<Chris_Stewart_5>
Eh, i'll give it a shot and ig if it doesn't get reviewed i'll pull it into a mega PR
Guyver2 has left #bitcoin-core-dev [Closing Window]
<Chris_Stewart_5>
thanks for the advice
AaronvanW has quit [Remote host closed the connection]
<furszy>
darosior: I'm still interested, but I think the focus should be on the wallet migration bugs first for v27 (check #28037). Otherwise, the legacy wallet removal timeline will need to be pushed back for another release.
<bitcoin-git>
[bitcoin] ryanofsky opened pull request #29370: assumeutxo: Get rid of faked nTx and nChainTx values (master...pr/nofake) https://github.com/bitcoin/bitcoin/pull/29370
<darosior>
furszy: fair enough.
<darosior>
Let me know when you start consider reviewing it so i can make some time on my end to get a momentum
achow101 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Christewart opened pull request #29371: test: Add `leaf_version` parameter to `taproot_tree_helper()` (master...2024-02-01-scriptpy-leafver) https://github.com/bitcoin/bitcoin/pull/29371
SpellChecker has quit [Remote host closed the connection]
bob_x2 has quit [Read error: Connection reset by peer]
SpellChecker has joined #bitcoin-core-dev
bob_x2 has joined #bitcoin-core-dev
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<stevenroose>
Does regtest have a strange emission schedule? I thought it had the same as mainchain, so it would basically always reward 50 btc for a block.. But I have a chain that seems to have passed 6 halvings at height 1000 something
<bitcoin-git>
[bitcoin] mzumsande opened pull request #29372: fix intermittent failure in `rpc_setban.py --v2transport`, run it in CI (master...202402_fix_setban_v2transport) https://github.com/bitcoin/bitcoin/pull/29372
boris has joined #bitcoin-core-dev
fufu has quit [Quit: Om mani padme hum]
AaronvanW has quit [Remote host closed the connection]
boris has quit [Read error: Connection reset by peer]
boris has joined #bitcoin-core-dev
boris has quit [Ping timeout: 256 seconds]
AaronvanW has joined #bitcoin-core-dev
<josie>
darosior: I can start reviewing it, if youre also allocating time. ive seen the notation starting to pop in the wild more and it looks like the original issue requesting has had some recent activity
<josie>
(its also something i want)
pablomartin has joined #bitcoin-core-dev
boris has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.2.1]
boris has quit [Ping timeout: 256 seconds]
pablomartin4btc has joined #bitcoin-core-dev
boris has joined #bitcoin-core-dev
pablomartin has quit [Ping timeout: 264 seconds]
boris has quit [Ping timeout: 252 seconds]
<furszy>
darosior: 👍, absolutely.
pablomartin4btc has quit [Remote host closed the connection]