ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<bitcoin-git> [bitcoin] achow101 pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb25e0691f65...ce1c881ccc8f
<bitcoin-git> bitcoin/master 6714276 brunoerg: miniscript: Use `ToIntegral` instead of `ParseInt64`
<bitcoin-git> bitcoin/master ce1c881 Ava Chow: Merge bitcoin/bitcoin#30577: miniscript: Use `ToIntegral` instead of `Pars...
<bitcoin-git> [bitcoin] achow101 merged pull request #30577: miniscript: Use `ToIntegral` instead of `ParseInt64` (master...2024-07-miniscript-tointegral) https://github.com/bitcoin/bitcoin/pull/30577
jon_atack has quit [Ping timeout: 244 seconds]
jonatack has joined #bitcoin-core-dev
infernix has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 252 seconds]
pablomartin has joined #bitcoin-core-dev
pablomartin has quit [Client Quit]
nanotube has quit [Ping timeout: 252 seconds]
<bitcoin-git> [bitcoin] ryanofsky pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/ce1c881ccc8f...b38fb19b7eed
<bitcoin-git> bitcoin/master f14900b josibake: bench: add benchmark for signing with a taptweak
<bitcoin-git> bitcoin/master 5d507a0 josibake: tests: add key tweak smoke test
<bitcoin-git> bitcoin/master c39fd39 josibake: crypto: add KeyPair wrapper class
<bitcoin-git> [bitcoin] ryanofsky merged pull request #30051: crypto, refactor: add new KeyPair class (master...add-apply-taptweak-method) https://github.com/bitcoin/bitcoin/pull/30051
andrewtoth has quit [Ping timeout: 260 seconds]
RaphaelH has quit [Quit: Client closed]
mcey_ has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 260 seconds]
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
mcey_ has quit [Remote host closed the connection]
mcey_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/b38fb19b7eed...2987ba663758
<bitcoin-git> bitcoin/master 6e7e620 ismaelsadeeq: [doc]: add `30275` release notes
<bitcoin-git> bitcoin/master fa2f269 ismaelsadeeq: [rpc, fees]: add more detail on the fee estimation modes
<bitcoin-git> bitcoin/master 2987ba6 Ava Chow: Merge bitcoin/bitcoin#30525: doc, rpc : `#30275` followups
<bitcoin-git> [bitcoin] achow101 merged pull request #30525: doc, rpc : `#30275` followups (master...07-2024-estimatesmartfee-doc-update) https://github.com/bitcoin/bitcoin/pull/30525
BrandonOdiwuor has joined #bitcoin-core-dev
PatBoy has joined #bitcoin-core-dev
P8tBoy has quit [Ping timeout: 248 seconds]
qxs_ has quit [Ping timeout: 260 seconds]
kevkevin has quit [Remote host closed the connection]
qxs has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
pigeons has quit [Ping timeout: 264 seconds]
luke-jr_ has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 260 seconds]
someone235 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Talkless has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
noonien808310429 has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
PatBoy has quit [Quit: ZNC 1.8.2 - https://znc.in]
darosior has quit [Quit: Ping timeout (120 seconds)]
PatBoy has joined #bitcoin-core-dev
darosior has joined #bitcoin-core-dev
darosior has quit [Read error: Connection reset by peer]
someone235 has quit [Quit: Connection closed for inactivity]
darosior has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
Guyver2 has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 260 seconds]
aleggg has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
noonien808310429 has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
kevkevin has joined #bitcoin-core-dev
darosior has quit [Ping timeout: 248 seconds]
kevkevin has quit [Ping timeout: 276 seconds]
darosior has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 264 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Guyver2 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
k_naka has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
k_naka has quit [Client Quit]
andrewtoth_ has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 260 seconds]
kevkevin has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
jonatack has quit [Read error: Connection reset by peer]
adil has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] glozow pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/2987ba663758...676abd1af754
<bitcoin-git> bitcoin/master 4400c97 glozow: [doc] update documentation for new mempoolfullrbf default
<bitcoin-git> bitcoin/master 1f93e3c glozow: add deprecation warning for mempoolfullrbf
<bitcoin-git> bitcoin/master 676abd1 glozow: Merge bitcoin/bitcoin#30594: docs: doc update for mempoolfullrbf default +...
<bitcoin-git> [bitcoin] glozow merged pull request #30594: docs: doc update for mempoolfullrbf default + log deprecation (master...2024-07-fullrbf-docs) https://github.com/bitcoin/bitcoin/pull/30594
andrewtoth_ has quit [Ping timeout: 260 seconds]
adil has quit [Quit: adil]
mekster669493981 has quit [Quit: mekster669493981]
andrewtoth has joined #bitcoin-core-dev
mekster669493981 has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
PatBoy has quit [Quit: ZNC 1.8.2 - https://znc.in]
PatBoy has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Quit: Client closed]
preimage has joined #bitcoin-core-dev
achow101 has joined #bitcoin-core-dev
andrewtoth_ has joined #bitcoin-core-dev
andrewtoth has quit [Remote host closed the connection]
pigeons has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
<Murch[m]> The Testnet 4 PR, #29775, has nine stale ACKs 😅, would be cool if maybe one or two more regular contributors could take a look—it seems close to RTM to me
<gribble> https://github.com/bitcoin/bitcoin/issues/29775 | Testnet4 including PoW difficulty adjustment fix by fjahr · Pull Request #29775 · bitcoin/bitcoin · GitHub
<instagibbs> looking for testing or code review at this point? most the stale acks appear to be testing
<gmaxwell> Murch[m]: fwiw, looks like there are idiots already trying to amass tn4 coins on bct.
<Murch[m]> instagibbs: I think code review
<Murch[m]> gmaxwell: Could you be more specific?
<gmaxwell> Murch[m]: I'm not involved enough in the project to even consider suggesting not moving forward with that PR as is, but ISTM that it might be necessary to include a zillion coin premine in testnets going forward to deal with that stuff.
<sipa> gmaxwell: i'm not sure how that would help?
<Murch[m]> My understanding is that a lot of the blocks so far were mined by Wiz and Portlandhodl, and there are three faucets already. A few people trying to collect testnet coins already for (allegedly) testing doesn’t seem like a big issue
<Murch[m]> sipa: I think he means as a deterrent for them getting value
<sipa> i think the deterrent is "we switched from testnet3 to testnet4, and if testnet4 becomes unusable, we'll do it again"
<sipa> some people trying to acquire them is probably inevitable
<sipa> but if the goal is a more controlled distribution of coins, there is signet
<gmaxwell> sipa: if you trade these for value you'll just be making bitcoin core project wealthy, not yourself.
<Murch[m]> gmaxwell: I read the thread, it seems like there is really just one person that asks where to get testnet coins "because they wanted to test without having to sync Testnet3". How did you get from there to "people trying to amass tn4 coins"?
<gmaxwell> Murch[m]: I didn't actually read the thread, as it was just a nussance begging post. In that case it seems I might be false positiving there, ... historically many of those threads have looked like "I need coins for testing" "okay here is a testnet cent" "NO NO I NEED HUNDREDS OF COINS" "but it's divisible" "but my TESTING requires more coins!" ... and so on. :P
<gmaxwell> so apologies for the likely false alarm there.
<sipa> it's something we can consider for testnet5 i think, but at this point it's a question of getting tn4 in 28.0, or delaying things further
<Murch[m]> Yeah sure, that’s been very annoying lately especially with the Babylon testnets etc.
<Murch[m]> That’s why we are working on Testnet 4
<sipa> and i think getting tn4 in is likely much more harmful to the trading-testnet crowd than delaying
<Murch[m]> Yeah 💯
<gmaxwell> yeah, point withdrawn. Though I'm not entirely sure how much they care what core is shipping but who knows. I think what matters to the degens is what the exchanges have up, maybe they'll happily stay on 3 and its problem solved.
<Murch[m]> I mean, if they continue to assign Testnet 3 value, they can have it 😁
<gmaxwell> yeah not your problem.
<gmaxwell> one could also just circulate to tn5 before its a problem. The pattern I think with tn3 was that some people first quietly amassed a lot of coins, and then did things like setup an exchange. So periodically rotating may help.
<Murch[m]> Yeah, it would have probably been better if we had sunset Testnet 3 a bit sooner, but now that we have exercised that muscle, it should also be easier to do it again
<Murch[m]> What would be a better cadence? Maybe a new testnet every three years or so?
<sipa> could even have a preprogrammed end date (a consensus rule that makes blocks with a timestamp after X invalid)
<Murch[m]> That might be annoying, because it forces someone to work on it (although that might also be the point). Gives me "Ethereum Difficulty Bomb" jeebies
<instagibbs> integration into and uptake of a new testnet takes time, I wouldn't be too glib about testnet creation, though N years sunsetting may be something to consider
<gmaxwell> instagibbs: I think testnet has largely been failed for a couple years now.. but fortunately regtest and the signet stuff gave people many other options, so it didn't matter much.
<instagibbs> Oh I agree, just saying it should probably be more than 3, I guess :)
<gmaxwell> or more effort should be put into fixing things so people can use alternatives.
<gmaxwell> fundimentally TN vs alternatives I think is only really required for testing that involves mining, and the diff1 rule (even with fix) kinda degrades it for that purpose.
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
<gmaxwell> otherwise people should be able to use regtest (for local tests) or some signet thing, and should have a much better testing expirence with either than any TN like thing could give.
vostrnad has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
monlovesmango has joined #bitcoin-core-dev
Guest24 has joined #bitcoin-core-dev
Guest24 has quit [Client Quit]
bugs_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] achow101 pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/676abd1af754...da083d4bbdb3
<bitcoin-git> bitcoin/master 74a04f9 Fabian Jahr: testnet: Introduce Testnet4
<bitcoin-git> bitcoin/master 0100907 Fabian Jahr: testnet: Add Testnet4 difficulty adjustment rules fix
<bitcoin-git> bitcoin/master 6bfa260 Fabian Jahr: testnet: Add timewarp attack prevention for Testnet4
<bitcoin-git> [bitcoin] achow101 merged pull request #29775: Testnet4 including PoW difficulty adjustment fix (master...2024-04-testnet-4-fix) https://github.com/bitcoin/bitcoin/pull/29775
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
Emc99 has quit [Quit: Client closed]
dermoth_ has joined #bitcoin-core-dev
dermoth has quit [Remote host closed the connection]
monlovesmango has quit [Remote host closed the connection]
dermoth_ is now known as dermoth
<bitcoin-git> [bitcoin] vostrnad closed pull request #29309: Add a `-permitbarepubkey` option (master...permitbarepubkey) https://github.com/bitcoin/bitcoin/pull/29309
monlovesmango has joined #bitcoin-core-dev
vostrnad has quit [Ping timeout: 256 seconds]
monlovesmango has quit [Client Quit]
jonatack has quit [Read error: Connection reset by peer]
jonatack has joined #bitcoin-core-dev
bugs_ has quit [Quit: Leaving]
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/da083d4bbdb3...0f68a05c084b
<bitcoin-git> bitcoin/master a3cb309 Cory Fields: refactor: use recommended type hiding on multi_index types
<bitcoin-git> bitcoin/master 0f68a05 glozow: Merge bitcoin/bitcoin#30194: refactor: use recommended type hiding on mult...
<bitcoin-git> [bitcoin] glozow merged pull request #30194: refactor: use recommended type hiding on multi_index types (master...multi_index_types) https://github.com/bitcoin/bitcoin/pull/30194
pigeons has quit [Read error: Connection reset by peer]
pigeons has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
mcey_ has quit [Ping timeout: 265 seconds]
<bitcoin-git> [bitcoin] justinvforvendetta closed pull request #30564: get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9 (master...master) https://github.com/bitcoin/bitcoin/pull/30564
<bitcoin-git> [bitcoin] justinvforvendetta opened pull request #30602: Revert "depends: Fetch miniupnpc sources from an alternative website" (master...master) https://github.com/bitcoin/bitcoin/pull/30602
<bitcoin-git> [bitcoin] justinvforvendetta closed pull request #30602: Revert "depends: Fetch miniupnpc sources from an alternative website" (master...master) https://github.com/bitcoin/bitcoin/pull/30602
<bitcoin-git> [bitcoin] justinvforvendetta opened pull request #30603: Revert "depends: Fetch miniupnpc sources from an alternative website" (master...master) https://github.com/bitcoin/bitcoin/pull/30603
<bitcoin-git> [bitcoin] fjahr opened pull request #30604: doc, chainparams: 29775 follow-ups (master...2024-08-t4-follow-up) https://github.com/bitcoin/bitcoin/pull/30604
noonien808310429 has quit [Quit: The Lounge - https://thelounge.chat]
noonien808310429 has joined #bitcoin-core-dev
<Murch[m]> From what I understand, distributing coins in Signet has also been a bit of a pain point
nanotube has joined #bitcoin-core-dev
Talkless has quit [Remote host closed the connection]
<bitcoin-git> [bitcoin] sipa opened pull request #30605: Cluster linearization: separate tests from tests-of-tests (master...202408_cluster_tests) https://github.com/bitcoin/bitcoin/pull/30605
<bitcoin-git> [bitcoin] aguycalled opened pull request #30606: Create wallet from seed (master...create_wallet_from_seed) https://github.com/bitcoin/bitcoin/pull/30606
<bitcoin-git> [bitcoin] maflcko closed pull request #30606: Create wallet from seed (master...create_wallet_from_seed) https://github.com/bitcoin/bitcoin/pull/30606
<bitcoin-git> [bitcoin] theStack opened pull request #30607: contrib: support reading XORed blocks in linearize-data.py script (master...202408-contrib-block_xor_support_for_linearize-data) https://github.com/bitcoin/bitcoin/pull/30607
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
S3RK_ has quit [Ping timeout: 260 seconds]
S3RK has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] furszy closed pull request #30418: assumeUTXO: snapshot load, update VERSION msg height (master...2024_assumeUTXO_update_starting_height) https://github.com/bitcoin/bitcoin/pull/30418
jespada has quit [Ping timeout: 245 seconds]
willcl-ark has quit [Quit: left]
willcl-ark has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]