ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
zeropoint has quit [Quit: leaving]
abubakarsadiq has quit [Quit: Connection closed for inactivity]
cncr04s has quit [Ping timeout: 272 seconds]
cncr04s has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
bitdex has quit [Ping timeout: 260 seconds]
bitdex has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 246 seconds]
lbia has quit [Ping timeout: 255 seconds]
lbia has joined #bitcoin-core-dev
BiteriaFedoral has joined #bitcoin-core-dev
BiteriaFedoral has quit [Changing host]
BiteriaFedoral has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
jlest has joined #bitcoin-core-dev
jlest has joined #bitcoin-core-dev
jlest has quit [Ping timeout: 276 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
BiteriaFedoral has quit [Quit: Client closed]
mcey has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Client Quit]
bitdex has quit [Ping timeout: 260 seconds]
TallTim has quit [Ping timeout: 246 seconds]
SpellChecker has quit [Ping timeout: 260 seconds]
SpellChecker_ has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 255 seconds]
SpellChecker_ has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] maflcko closed pull request #29198: OP_CHECKTEMPLATEVERIFY, OP_CHECKSIGFROMSTACK(VERIFY), OP_INTERNALKEY validation (LNHANCE) (master...lnhance) https://github.com/bitcoin/bitcoin/pull/29198
TallTim has joined #bitcoin-core-dev
Guyver2 has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
aleggg has quit [Ping timeout: 260 seconds]
aleggg has joined #bitcoin-core-dev
noonien808310429 has quit [Ping timeout: 255 seconds]
noonien808310429 has joined #bitcoin-core-dev
memset has quit [Remote host closed the connection]
TheRec_ has joined #bitcoin-core-dev
instagibbs4 has joined #bitcoin-core-dev
emcy__ has joined #bitcoin-core-dev
cncr04s_ has joined #bitcoin-core-dev
TheRec has quit [Ping timeout: 246 seconds]
cncr04s has quit [Ping timeout: 246 seconds]
instagibbs has quit [Read error: Connection reset by peer]
harding has quit [Quit: No Ping reply in 180 seconds.]
mcey_ has quit [Ping timeout: 246 seconds]
pigeons has quit [Ping timeout: 246 seconds]
Earnestly has quit [Ping timeout: 246 seconds]
instagibbs4 is now known as instagibbs
pigeons_ has joined #bitcoin-core-dev
Earnestly has joined #bitcoin-core-dev
harding has joined #bitcoin-core-dev
Guest37 has joined #bitcoin-core-dev
Guest37 has quit [Write error: Broken pipe]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2c7a4231db35...f4a10911c70e
<bitcoin-git> bitcoin/master 49f9b64 Hodlinator: refactor: Testnet4 - Replace uint256S("str") -> uint256{"str"}
<bitcoin-git> bitcoin/master f4a1091 merge-script: Merge bitcoin/bitcoin#30721: refactor: Testnet4 - Replace uint256S("str") ...
<bitcoin-git> [bitcoin] fanquake merged pull request #30721: refactor: Testnet4 - Replace uint256S("str") - uint256{"str"} (master...2024-08/uint256_testnet4_scripted_diff) https://github.com/bitcoin/bitcoin/pull/30721
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f4a10911c70e...128ade02e445
<bitcoin-git> bitcoin/master 8dec4e1 brunoerg: fuzz: fix timeout in `crypto_fschacha20poly1305`
<bitcoin-git> bitcoin/master 128ade0 merge-script: Merge bitcoin/bitcoin#30725: fuzz: fix timeout in `crypto_fschacha20poly13...
<bitcoin-git> [bitcoin] fanquake merged pull request #30725: fuzz: fix timeout in `crypto_fschacha20poly1305` (master...2024-08-fix-timeout-cryptochacha) https://github.com/bitcoin/bitcoin/pull/30725
<bitcoin-git> [bitcoin-detached-sigs] fanquake pushed 1 commit to 28.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/commit/c717a70a90ba
<bitcoin-git> bitcoin-detached-sigs/28.x c717a70 fanquake: 28.x: macOS sig for rc1
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/128ade02e445...80f00cafdeef
<bitcoin-git> bitcoin/master fadf0a7 MarcoFalke: refactor: Remove Span operator==, Use std::ranges::equal
<bitcoin-git> bitcoin/master fad0cf6 MarcoFalke: refactor: Use std::ranges::equal in GetNetworkForMagic
<bitcoin-git> bitcoin/master 80f00ca merge-script: Merge bitcoin/bitcoin#29071: refactor: Remove Span operator==, Use std::ra...
<bitcoin-git> [bitcoin] fanquake merged pull request #29071: refactor: Remove Span operator==, Use std::ranges::equal (master...2312-less-span-) https://github.com/bitcoin/bitcoin/pull/29071
<bitcoin-git> [bitcoin] fanquake pushed 3 commits to 26.x: https://github.com/bitcoin/bitcoin/compare/7b7041019ba5...0a2a5c4ba62e
<bitcoin-git> bitcoin/26.x 7d5764f fanquake: doc: update release notes for 26.x
<bitcoin-git> bitcoin/26.x 0a2a5c4 merge-script: Merge bitcoin/bitcoin#30722: [26.x] Fix compilation with GCC 15
<bitcoin-git> [bitcoin] fanquake merged pull request #30722: [26.x] Fix compilation with GCC 15 (26.x...26_fix_gcc15) https://github.com/bitcoin/bitcoin/pull/30722
<bitcoin-git> [bitcoin] fanquake pushed 69 commits to master: https://github.com/bitcoin/bitcoin/compare/80f00cafdeef...338bc2cd261b
<bitcoin-git> bitcoin/master a2317e2 Hennadii Stepanov: cmake: Add root `CMakeLists.txt` file
<bitcoin-git> bitcoin/master 7068388 Hennadii Stepanov: cmake: Introduce interface libraries to encapsulate common flags
<bitcoin-git> bitcoin/master fe5cdac Hennadii Stepanov: cmake: Print compiler and linker flags in summary
<bitcoin-git> [bitcoin] fanquake merged pull request #30454: build: Introduce CMake-based build system (master...240716-cmake) https://github.com/bitcoin/bitcoin/pull/30454
Guest2 has joined #bitcoin-core-dev
Guest2 has quit [Client Quit]
<vasild> CMake \o/ -- T H A N K Y O U -- everybody and hebasto!
<glozow> πŸŽ‰
<bitcoin-git> [bitcoin] fanquake opened pull request #30729: build: fix version number post CMake (master...fix_version_number) https://github.com/bitcoin/bitcoin/pull/30729
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/338bc2cd261b...e45913ea8b06
<bitcoin-git> bitcoin/master fa0e1e4 MarcoFalke: fuzz: Add missing fuzz targets to cmake build
<bitcoin-git> bitcoin/master e45913e merge-script: Merge bitcoin/bitcoin#30712: fuzz: Add missing fuzz targets to cmake build
<bitcoin-git> [bitcoin] fanquake merged pull request #30712: fuzz: Add missing fuzz targets to cmake build (master...2408-fuzz-cmake) https://github.com/bitcoin/bitcoin/pull/30712
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e45913ea8b06...92c787f33de1
<bitcoin-git> bitcoin/master 680f05e fanquake: build: fix version number post CMake
<bitcoin-git> bitcoin/master 92c787f merge-script: Merge bitcoin/bitcoin#30729: build: fix version number post CMake
<bitcoin-git> [bitcoin] fanquake merged pull request #30729: build: fix version number post CMake (master...fix_version_number) https://github.com/bitcoin/bitcoin/pull/30729
<laanwj> nice !!!
SpellChecker has quit [Quit: bye]
SpellChecker has joined #bitcoin-core-dev
<hebasto> Thanks to all reviewers!
<bitcoin-git> [bitcoin] hebasto closed pull request #30465: depends: Set `CMAKE_SYSTEM_VERSION` for CMake builds (master...240716-deps-cmake) https://github.com/bitcoin/bitcoin/pull/30465
<bitcoin-git> [bitcoin] hebasto closed pull request #30477: depends: Amend handling flags environment variables (master...240718-deps-env) https://github.com/bitcoin/bitcoin/pull/30477
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #30730: guix: Bump time machine to 53396a22afc04536ddf75d8f82ad2eafa5082725 (master...bump_time_machine_gcc_12_4_0) https://github.com/bitcoin/bitcoin/pull/30730
instagibbs has quit [Ping timeout: 264 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
instagibbs has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #30731: build: remove old MSVC build system (master...drop_msvc_old) https://github.com/bitcoin/bitcoin/pull/30731
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/92c787f33de1...2eb358b25f62
<bitcoin-git> bitcoin/master 371910a Hennadii Stepanov: depends: Fix CMake-generated `libzmq.pc` file
<bitcoin-git> bitcoin/master 2eb358b merge-script: Merge bitcoin/bitcoin#30508: depends: Fix CMake-generated `libzmq.pc` file
<bitcoin-git> [bitcoin] fanquake merged pull request #30508: depends: Fix CMake-generated `libzmq.pc` file (master...240723-zmq-pc) https://github.com/bitcoin/bitcoin/pull/30508
Guyver2 has left #bitcoin-core-dev [Closing Window]
emcy__ has quit [Remote host closed the connection]
mcey has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2eb358b25f62...0c90fc644395
<bitcoin-git> bitcoin/master 04fb085 fanquake: build: remove old MSVC build system
<bitcoin-git> bitcoin/master 0c90fc6 merge-script: Merge bitcoin/bitcoin#30731: build: remove old MSVC build system
<bitcoin-git> [bitcoin] fanquake merged pull request #30731: build: remove old MSVC build system (master...drop_msvc_old) https://github.com/bitcoin/bitcoin/pull/30731
<glozow> Everything tagged with "Needs CMake port" should be rebased now, right?
SpellChecker has quit [Quit: bye]
<TheCharlatan> rebasing might be a good idea anyway so reviewers don't have to switch tooling.
SpellChecker has joined #bitcoin-core-dev
bw_______ has left #bitcoin-core-dev [#bitcoin-core-dev]
angusp has quit [Remote host closed the connection]
angusp has joined #bitcoin-core-dev
<vasild> this ^
<bitcoin-git> [bitcoin] l0rinc opened pull request #30732: cmake: Improve cxx and linker flag caching (master...l0rinc/hash-collisions) https://github.com/bitcoin/bitcoin/pull/30732
<instagibbs> what's the cmake equiv of --enable-debug :)
<hebasto> -DCMAKE_BUILD_TYPE=Debug
<glozow> Should I leave my Makefile.am changes in my PRs until autotools is removed, or take them out now?
<hebasto> while rebasing, switching to new tools is reasonable
<instagibbs> hebasto I think that's missing from dev docs, figured out everything else so far...
<hebasto> docs are subjects for amending
<hebasto> PRs will be opened shortly
<instagibbs> oh nice party
<vasild> ;-)
<bitcoin-git> [bitcoin] l0rinc opened pull request #30733: Remove unused src_dir param from run_tests (master...l0rinc/test-runner-param-cleanup) https://github.com/bitcoin/bitcoin/pull/30733
<hebasto> thanks vasild
<bitcoin-git> [bitcoin] l0rinc opened pull request #30734: Fix a few likely documentation typos (master...l0rinc/log-typo) https://github.com/bitcoin/bitcoin/pull/30734
<bitcoin-git> [bitcoin] maflcko closed pull request #30732: cmake: improve cxx and linker flag caching (master...l0rinc/hash-collisions) https://github.com/bitcoin/bitcoin/pull/30732
<bitcoin-git> [bitcoin] maflcko reopened pull request #30732: cmake: improve cxx and linker flag caching (master...l0rinc/hash-collisions) https://github.com/bitcoin/bitcoin/pull/30732
<bitcoin-git> [bitcoin] maflcko opened pull request #30735: cmake: Add option to use C++23 for testing (master...2408-23) https://github.com/bitcoin/bitcoin/pull/30735
andrewtoth has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hodlinator opened pull request #30737: test: Fix RANDOM_CTX_SEED use with parallel tests (master...2024-08/RANDOM_CTX_SEED_jobs_fix_alt) https://github.com/bitcoin/bitcoin/pull/30737
bugs_ has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #30738: doc: fixup macOS build docs for CMake (master...macos_cmake_docs) https://github.com/bitcoin/bitcoin/pull/30738
preimage has joined #bitcoin-core-dev
Guest22 has joined #bitcoin-core-dev
Guest22 has quit [Client Quit]
<bitcoin-git> [bitcoin] fanquake opened pull request #30739: doc: update dev note examples for CMake (master...dev_notes_cmake) https://github.com/bitcoin/bitcoin/pull/30739
<bitcoin-git> [bitcoin] glozow pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c90fc644395...f175a737c9e1
<bitcoin-git> bitcoin/master 3c53e59 fanquake: doc: fixup macOS build docs for CMake
<bitcoin-git> bitcoin/master f175a73 glozow: Merge bitcoin/bitcoin#30738: doc: fixup macOS build docs for CMake
<bitcoin-git> [bitcoin] glozow merged pull request #30738: doc: fixup macOS build docs for CMake (master...macos_cmake_docs) https://github.com/bitcoin/bitcoin/pull/30738
<achow101> darhtbot is busy today
<bitcoin-git> [bitcoin-detached-sigs] achow101 pushed 1 commit to 28.x: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/c717a70a90ba...58e8aa11919d
<bitcoin-git> bitcoin-detached-sigs/28.x 58e8aa1 Ava Chow: 28.0: win sig for rc1
<bitcoin-git> [bitcoin-detached-sigs] achow101 pushed tag v28.0rc1: https://github.com/bitcoin-core/bitcoin-detached-sigs/compare/v28.0rc1
<bitcoin-git> [crc32c-subtree] fanquake opened pull request #8: Sync to upstream (bitcoin-fork...sync_to_upstream) https://github.com/bitcoin-core/crc32c-subtree/pull/8
<bitcoin-git> [bitcoin] maflcko opened pull request #30740: ci: Re-add configs removed in cmake migration (master...2408-ci-cmake) https://github.com/bitcoin/bitcoin/pull/30740
jon_atack has quit [Ping timeout: 260 seconds]
<bitcoin-git> [bitcoin] glozow pushed 15 commits to master: https://github.com/bitcoin/bitcoin/compare/f175a737c9e1...f93d5553d1e8
<bitcoin-git> bitcoin/master 7e86541 Ava Chow: descriptors: Add PubkeyProvider::Clone
<bitcoin-git> bitcoin/master 0d55dea Ava Chow: descriptors: Add DescriptorImpl::Clone
<bitcoin-git> bitcoin/master a5f39b1 Ava Chow: descriptors: Change ParseScript to return vector of descriptors
<bitcoin-git> [bitcoin] glozow merged pull request #22838: descriptors: Be able to specify change and receiving in a single descriptor string (master...multipath-descs) https://github.com/bitcoin/bitcoin/pull/22838
<bitcoin-git> [bitcoin] l0rinc opened pull request #30741: Update documentation generation example in developer-notes.md (master...lorinc/build-documentation) https://github.com/bitcoin/bitcoin/pull/30741
jonatack has joined #bitcoin-core-dev
zeropoint has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 260 seconds]
SpellChecker has joined #bitcoin-core-dev
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
<sipa> i go offline for a few days, and we switch build systems?!
<sipa> i should do this more oftrn
<bitcoin-git> [bitcoin] fanquake pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/f93d5553d1e8...d184fc3ba411
<bitcoin-git> bitcoin/master fae7e37 MarcoFalke: test: Correct the random seed log on a prevector test failure
<bitcoin-git> bitcoin/master fa2cb65 MarcoFalke: test: Add m_rng alias for the global random context
<bitcoin-git> bitcoin/master fab023e MarcoFalke: test: refactor: Make unsigned promotion explicit
<bitcoin-git> [bitcoin] fanquake merged pull request #30571: test: [refactor] Use m_rng directly (master...2408-test-rng) https://github.com/bitcoin/bitcoin/pull/30571
<laanwj> we'd quickly run out of build systems to switch to
<fanquake> i also reckon 2 will be enough to maintain for the next couple year heh
<laanwj> are we going to keep both of them?
<hebasto> not in the master branch
<laanwj> phew
<fanquake> nah, but we've gotta keep all the release branches working
<fanquake> so 28.x release date from 18 months or so
<fanquake> until we actually don't have autotools
<laanwj> yes, that makes sense
<fanquake> 28.x release date *plus 18 months or so
<laanwj> would be kind of silly to backport the build system switch
<fanquake> hopefully we wont have to backport too much across the build system boundaries
<fanquake> no more clean cherry-picking
<laanwj> at least nothing that changes the set of compiled files too much
<laanwj> i guess usually bugfixes won't
<laanwj> maybe softforks ... πŸ˜…
<bitcoin-git> [bitcoin] TheCharlatan opened pull request #30742: kernel: Use spans instead of vectors for passing block headers to validation functions (master...headersSpan) https://github.com/bitcoin/bitcoin/pull/30742
<bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d184fc3ba411...4ee1940e849e
<bitcoin-git> bitcoin/master 7ee5c3c LΕ‘rinc: Fix a few likely documentation typos
<bitcoin-git> bitcoin/master 4ee1940 merge-script: Merge bitcoin/bitcoin#30734: doc: fix a few likely documentation typos rel...
<bitcoin-git> [bitcoin] fanquake merged pull request #30734: doc: fix a few likely documentation typos related to CMake migration (master...l0rinc/log-typo) https://github.com/bitcoin/bitcoin/pull/30734
<bitcoin-git> [bitcoin] fanquake opened pull request #30743: depends: build libevent with `-D_GNU_SOURCE` (master...libevent_non_gnu_c) https://github.com/bitcoin/bitcoin/pull/30743
Talkless has joined #bitcoin-core-dev
<_aj_> laanwj: if we just have a long delay between lock-in and activation like with taproot, no need for sf backports
<laanwj> aj: true, good point
mcey_ has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 255 seconds]
anrichp has joined #bitcoin-core-dev
anrichp has quit [Remote host closed the connection]
<achow101> 28.0rc1 bins are up
cncr04s has joined #bitcoin-core-dev
cncr04s_ has quit [Read error: Connection reset by peer]
cncr04s has quit [Quit: See you real soon!]
Talkless has quit [Remote host closed the connection]
cncr04s has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] l0rinc closed pull request #30619: doc: Change `nproc` in docs to `getconf _NPROCESSORS_ONLN` (master...paplorinc/nproc) https://github.com/bitcoin/bitcoin/pull/30619
<bitcoin-git> [bitcoin] hebasto opened pull request #30744: doc: Fix typo in `build-unix.md` (master...240828-typo) https://github.com/bitcoin/bitcoin/pull/30744
<sdaftuar> cmake looks awesome so far -- nice work everyone. just experienced the joys of having separate build directories for fuzzing versus running other tests! :)
<hebasto> sdaftuar: thanks
dermoth_ has joined #bitcoin-core-dev
dermoth has quit [Remote host closed the connection]
dermoth_ is now known as dermoth
<achow101> Is there an easy way to turn on every WITH_ option that doesn't require writing them all out?
<TheCharlatan> you could contribute a preset?
Guest36 has joined #bitcoin-core-dev
Guest36 has quit [Ping timeout: 256 seconds]
dongcarl has quit [Quit: Ping timeout (120 seconds)]
dongcarl has joined #bitcoin-core-dev
S3RK has joined #bitcoin-core-dev
S3RK_ has quit [Ping timeout: 272 seconds]
<instagibbs> sdaftuar similarly, having debug builds right alongside release, and no need to disable asm for fuzz debug anymore, so good πŸ‘
bugs_ has quit [Quit: Leaving]
preimage has quit [Quit: WeeChat 4.4.1]
<achow101> eh? we've had out of tree builds for a while
<sdaftuar> achow101: I don't believe it worked to run the tests (maybe the functional tests specifically?) in out of tree builds -- or at least if it did, i could never figure out how
<achow101> sdaftuar: you could with test_runner.py and specifying the test as an argument
<sdaftuar> 🀷
jonatack has quit [Ping timeout: 246 seconds]
jonatack has joined #bitcoin-core-dev
toys has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]