ChanServ changed the topic of #bitcoin-core-dev to: Bitcoin Core development discussion and commit log | Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ | Weekly Meeting Thursday @ 14:00 UTC | Meeting topics http://gnusha.org/bitcoin-core-dev/proposedmeetingtopics.txt
<bitcoin-git> [bitcoin] achow101 pushed 15 commits to master: https://github.com/bitcoin/bitcoin/compare/0f68a05c084b...27a770b34b8f
<bitcoin-git> bitcoin/master df34a94 Andrew Toth: refactor: encapsulate flags access for dirty and fresh checks
<bitcoin-git> bitcoin/master 9715d3b Andrew Toth: refactor: encapsulate flags get access for all other checks
<bitcoin-git> bitcoin/master 8737c0c Andrew Toth: refactor: encapsulate flags setting with AddFlags and ClearFlags
<bitcoin-git> [bitcoin] achow101 merged pull request #28280: Don't empty dbcache on prune flushes: 30% faster IBD (master...sync-dirty) https://github.com/bitcoin/bitcoin/pull/28280
preimage has quit [Quit: WeeChat 4.3.5]
bitdex has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 260 seconds]
luke-jr_ has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 248 seconds]
pigeons has quit [Ping timeout: 244 seconds]
PatBoy has quit [Quit: ZNC 1.8.2 - https://znc.in]
PatBoy has joined #bitcoin-core-dev
luke-jr has joined #bitcoin-core-dev
luke-jr_ has quit [Ping timeout: 252 seconds]
Guest20 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Guest20 has quit [Quit: Client closed]
abubakarsadiq has joined #bitcoin-core-dev
mcey has joined #bitcoin-core-dev
emcy__ has quit [Remote host closed the connection]
Guest31 has joined #bitcoin-core-dev
Guest31 has quit [Client Quit]
BrandonOdiwuor has joined #bitcoin-core-dev
BrandonOdiwuor has quit [Client Quit]
BrandonOdiwuor has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
Talkless has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Earnestly has quit [Read error: Connection reset by peer]
kevkevin has quit [Ping timeout: 248 seconds]
Guyver2 has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 248 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 244 seconds]
BrandonOdiwuor has quit [Ping timeout: 256 seconds]
gribble has quit [Remote host closed the connection]
gribble has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
Earnestly has joined #bitcoin-core-dev
Guyver2 has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto closed pull request #29790: [DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system -- WIP (master...240402-cmake-DA) https://github.com/bitcoin/bitcoin/pull/29790
kevkevin has quit [Ping timeout: 260 seconds]
Guest20 has joined #bitcoin-core-dev
Guest20 has quit [Client Quit]
mudsip has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
mudsip has quit []
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 272 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 245 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 276 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
noonien808310429 has quit [Read error: Connection reset by peer]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 252 seconds]
kevkevin has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake opened pull request #30609: guix: bump time-machine to 7bf1d7aeaffba15c4f680f93ae88fbef25427252 (master...guix_nuke_openssl_1_x_python_2) https://github.com/bitcoin/bitcoin/pull/30609
<bitcoin-git> [bitcoin] fjahr closed pull request #30516: Assumeutxo: Sanitize block height in metadata (master...2024-07-au-blockheight-san) https://github.com/bitcoin/bitcoin/pull/30516
bitdex has quit [Quit: = ""]
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Client Quit]
kevkevin has quit [Ping timeout: 252 seconds]
nanotube has quit [Ping timeout: 244 seconds]
andrewtoth has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
nanotube has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 260 seconds]
<achow101> #proposedmeetingtopic Future of priority projects
kashifs has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
Emc99 has joined #bitcoin-core-dev
<achow101> #startmeeting
<achow101> #bitcoin-core-dev Meeting: achow101 _aj_ amiti ariard aureleoules b10c BlueMatt brunoerg cfields darosior dergoegge dongcarl fanquake fjahr furszy gleb glozow hebasto instagibbs jamesob jarolrod jonatack josibake kallewoof kanzure kouloumos kvaciral laanwj LarryRuane lightlike luke-jr MacroFake Murch phantomcircuit pinheadmz promag provoostenator ryanofsky sdaftuar S3RK stickies-v sipa sr_gi theStack TheCharlatan vasild
<sdaftuar> hi
<tdb3> hi
<b10c> hi
<glozow> hi
<brunoerg> hi
<Murch[m]> hi
<fjahr> hi
<sr_gi[m]1> hi
<lightlike> hi
<furszy> hi
<stickies-v> hi
<hebasto> hi
<achow101> There is one preproposed meeting topic, any last minute ones to add?
<willcl-ark> hi
<jonatack> hi
dzxzg has joined #bitcoin-core-dev
<fjahr> I will yapp on about assumeutxo one more time :)
<achow101> #topic package relay updates (glozow)
<glozow> #30110 still priority. It hasn't actually gotten any review comments yet, so I'm not thinking it'll be in 28.0
<gribble> https://github.com/bitcoin/bitcoin/issues/30110 | refactor: TxDownloadManager + fuzzing by glozow · Pull Request #30110 · bitcoin/bitcoin · GitHub
<glozow> That's all for me
<achow101> #topic cluster mempool updates (sdaftuar)
<sdaftuar> cluster mempool is progressing! #30285 was merged a few days ago. #30286 is up next and has gotten some review already
<gribble> https://github.com/bitcoin/bitcoin/issues/30285 | cluster mempool: merging & postprocessing of linearizations by sipa · Pull Request #30285 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30286 | cluster mempool: optimized candidate search by sipa · Pull Request #30286 · bitcoin/bitcoin · GitHub
<sdaftuar> happy to take questions but that is it from me
<achow101> #topic legacy wallet removal updates (achow101)
<achow101> Since 28.0 is coming up, I'd like to get https://github.com/bitcoin-core/gui/pull/824 and #30265 in.
<gribble> https://github.com/bitcoin/bitcoin/issues/30265 | wallet: Fix listwalletdir listing of migrated default wallets and generated backup files by achow101 · Pull Request #30265 · bitcoin/bitcoin · GitHub
<achow101> these are more like bug fixes though so I think don't have to make the feature freeze deadline
<achow101> Otherwise, haven't gotten any review on the other PRs
<achow101> #topic Ad-hoc high priority for review
<theStack> hi
<achow101> Anything to add or remove from https://github.com/orgs/bitcoin/projects/1/views/4
<sipa> hi
<achow101> #topic 28.0 release priorities
<achow101> Feature freeze is scheduled for this Monday
<achow101> anything we should add or remove to the milestone?
<fjahr> I know I’ve been harping on about this for a while but since we are so close, it would be great if we could tag the remaining important Assumeutxo PRs for v28. #29519 already has two ACKs. #28553 would be necessary too and we had intense discussions over the last two days so I hope we can lay this to rest quickly now. Technicallyyyy both of these are fixing bugs in the existing assumeutxo feature (signet/testnet3) so I
<fjahr> don’t think they would necessarily even need to make it in before feature freeze. And then of course #30598 which technicallyyyy is updating chain params which is also something we usually do after feature freeze :p
<gribble> https://github.com/bitcoin/bitcoin/issues/29519 | p2p: For assumeutxo, download snapshot chain before background chain by mzumsande · Pull Request #29519 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/28553 | validation: assumeutxo params mainnet by Sjors · Pull Request #28553 · bitcoin/bitcoin · GitHub
<gribble> https://github.com/bitcoin/bitcoin/issues/30598 | assumeutxo: Drop block height from metadata by fjahr · Pull Request #30598 · bitcoin/bitcoin · GitHub
<fjahr> Most importantly I think a lot of people have been involved in, improved and better understood assumeutxo over the last 6 months (again see #29616) and the vibe I have been getting from others is that there is agreement that the feature is ready for mainnet use, especially since setting an initial height at 840k is really low risk.
<gribble> https://github.com/bitcoin/bitcoin/issues/29616 | AssumeUTXO Mainnet Readiness Tracking · Issue #29616 · bitcoin/bitcoin · GitHub
<fjahr> Ah, I see the issue for #30598 was already added
<gribble> https://github.com/bitcoin/bitcoin/issues/30598 | assumeutxo: Drop block height from metadata by fjahr · Pull Request #30598 · bitcoin/bitcoin · GitHub
<achow101> fjahr: added all 3
<fjahr> achow101: thank you!
<hebasto> the 28.0 milestone in the GUI repo -- https://github.com/bitcoin-core/gui/milestone/13
<achow101> fjahr: was that your assumeutxo topic?
<sipa> i'd really like to see #30043 in sooner than later, but it can use more review (unsure if before feature freeze is reasonable)
<gribble> https://github.com/bitcoin/bitcoin/issues/30043 | net: Replace libnatpmp with built-in PCP+NATPMP implementation by laanwj · Pull Request #30043 · bitcoin/bitcoin · GitHub
<achow101> sipa: I think it might not make it for feature freeze
<achow101> maybe for 29.0?
<fjahr> achow101: yepp, nothing else to add
<sipa> achow101: agreed
<achow101> #topic Future of priority projects (achow101)
<achow101> At the last CoreDev, we had a discussion about priority projects. I recall that the general sentiment was that it was getting less effective since we moved to doing online polling and such.
<achow101> IIRC we concluded that for the next set of priority projects, we would determine them in person at the October CoreDev
<sipa> that would be my preference
<fjahr> I think this is something that is best discussed in an in-person meeting but as an idea: it might be an interesting experiment to see what happens to priority projects if there isn’t one champion but 2-3 instead. If there are not 2-3 people interested in or capable of championing for a project, then maybe it’s not a good fit (yet).
<achow101> So I think once we past feature freeze on Monday, the current priority projects will be cleared, and we'll not have any until next CoreDev
<sipa> fjahr: my view is that *any* vote for a priority project should mean "i commit to actively contributing/reviewing PRs related to this feature if it ends up winning"
<glozow> achow101: that makes sense to me
<fjahr> sipa: that would be ideal but doesn't seem to be the reality :/
<sipa> fjahr: that seems to be a communication issue to me
<fjahr> maybe there should be the option or urge for people to not put in all of their votes if they don't want to do that
bezel_ has joined #bitcoin-core-dev
bezel_ has quit [Client Quit]
<fjahr> but best discussed in person probably..
<sipa> fjahr: yeah
<jonatack> would contributors not attending coredev be asked for input?
<sipa> i think it makes sense to start proposals/nominations before coredev, and then continue permitting voting by org members after... but the benefit of actually having the fast interactive discussion in person seems evident to me
<fjahr> I guess these are different side of a spectrum on forming teams around a priority project, which I think would be a good direction for experimenting
<fjahr> *sides
<lightlike> i don't think that the voting modus has much to do with the effectiveness. I think if there aren't enough people who would be willing change what they will work on based on the outcome of the vote, the vote doesn't really make a difference.
dzxzg has quit [Ping timeout: 272 seconds]
<achow101> I think a big component of why it worked the first time was because we did it in person and the vote gave people the motivation to shill their projects and convince others to work on it while we were all in the same place
<jonatack> it could possibly furthermore be argued that both coredev and additional project management processes can be centralization pressures, to an extent. so while they can be more or less somewhat effective, my preference is more in the direction of ad hoc rather than process
<Murch[m]> I wouldn’t perceive it as a vote in that sense: it’s more of taking a census of what people intend to work on, and giving projects with a lot of contributors a focus in the meetings.
<fjahr> lightlike: I think sipa's point is less about the mode of voting but actually buy in from the voters
<achow101> jonatack: tbh this is pretty ad hoc. we're making up the process as we go :p
<jonatack> achow101: :)
<furszy> I think we should just take it as a public way of forming working groups with weekly updates on the most voted ones.
<achow101> anyways, the point is that we'll try something different for 29.0, and it will likely be centered around discussions that occur at CoreDev
<achow101> Any other topics?
willcl-ark has quit [Quit: left]
<glozow> fwiw, I disagree that trying to communicate what our plans are to form working groups is centralization pressure. We can be decentralized without being disorganized.
<jonatack> achow101: sure. if/when in doubt, suggest less process over more. side benefit: more interesting, less mechanical meetings
<achow101> #endmeeting
kashifs has quit [Quit: Client closed]
Emc99 has quit [Quit: Client closed]
<achow101> jonatack: we did that for years before the first batch of priority projects and "more interesting, less mechanical meetings" is categorically untrue
<achow101> those meetings were boring as hell and very mechanical, with me being the only person talking because I was running them
willcl-ark has joined #bitcoin-core-dev
willcl-ark has joined #bitcoin-core-dev
<jonatack> achow101: i'm referring to meetings earlier than that. certainly, that's my opinion.
<achow101> and clearly something stopped working between then and for the few years prior to priority projects. I don't think going back to that is going to help anyone, nor is sticking with what we currently do
<achow101> changing things up might mean "process", but I think that trying to organize to get stuff done is better than the cycle of stalling that we were stuck in for years
<fjahr> It's tricky, I would say that assumeutxo was a success as in we got a lot done over the last 6 months without any organizational structure and without it even being a priority project. But I wouldn't say that this is repeatable because there were also years of lingering for that project before that. Ideally things don't take that long to begin with and for that I think amore structure is necessary.
<jonatack> sure, "change" is fine and the way of things.
<jonatack> (fine, as in, to be expected)
<ajonas> The purpose of priority projects is not to tell people what to do, but rather to help contributors collaborate in a more efficient way. The exercise of writing down goals and checking in on them has an effect.
Guyver2 has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
Guyver2 has left #bitcoin-core-dev [Closing Window]
puchka has joined #bitcoin-core-dev
abubakarsadiq has quit [Quit: Connection closed for inactivity]
preimage has joined #bitcoin-core-dev
TheCharlatan has joined #bitcoin-core-dev
mcey_ has joined #bitcoin-core-dev
Sjors[m]11 has joined #bitcoin-core-dev
uasf has joined #bitcoin-core-dev
mcey has quit [Ping timeout: 260 seconds]
zeropoint has joined #bitcoin-core-dev
Earnestly has quit [Ping timeout: 255 seconds]
jamesob443688173 has joined #bitcoin-core-dev
jamesob15 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 255 seconds]
kevkevin has quit [Remote host closed the connection]
dermoth has quit [Read error: Connection reset by peer]
dermoth has joined #bitcoin-core-dev
<sipa> the line "m_ibd_chainstate->ForceFlushStateToDisk();" in ChainstateManager::MaybeCompleteSnapshotVal
<sipa> idation
<sipa> since the flush/sync separation, is it desirable/necessary that this call wipes the cache, or does just writing changes to disk suffice?
andrewtoth has quit [Remote host closed the connection]
andrewtoth has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
oneeyedalien has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa opened pull request #30610: validation: do not wipe utxo cache for stats/scans/snapshots (master...202408_force_sync) https://github.com/bitcoin/bitcoin/pull/30610
Earnestly has joined #bitcoin-core-dev
oneeyedalien has quit [Ping timeout: 260 seconds]
jonatack has joined #bitcoin-core-dev
pigeons has quit [Ping timeout: 248 seconds]
oneeyedalien has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] andrewtoth opened pull request #30611: validation: write chainstate to disk every hour (master...write-chainstate-every-hour) https://github.com/bitcoin/bitcoin/pull/30611
<bitcoin-git> [bitcoin] andrewtoth closed pull request #15218: validation: sync chainstate to disk after syncing to tip (master...flush-after-ibd) https://github.com/bitcoin/bitcoin/pull/15218
puchka has quit [Ping timeout: 255 seconds]
Talkless has quit [Ping timeout: 252 seconds]
zeropoint has quit [Quit: leaving]
oneeyedalien has quit [Quit: Leaving]
<bitcoin-git> [bitcoin] whitslack opened pull request #30612: Fixes for GCC 15 compatibility (master...gcc15-fixes) https://github.com/bitcoin/bitcoin/pull/30612
bugs_ has quit [Quit: Leaving]
TallTim_ has joined #bitcoin-core-dev
TallTim has quit [Ping timeout: 245 seconds]
zeropoint has joined #bitcoin-core-dev
abubakarsadiq has joined #bitcoin-core-dev
<bitcoin-git> [gui-qml] johnny9 opened pull request #414: qml: uncomment DebugMessageHandler install (main...re-enable-debuglog) https://github.com/bitcoin-core/gui-qml/pull/414
<bitcoin-git> [gui-qml] johnny9 closed pull request #414: qml: uncomment DebugMessageHandler install (main...re-enable-debuglog) https://github.com/bitcoin-core/gui-qml/pull/414
<bitcoin-git> [gui-qml] johnny9 reopened pull request #414: qml: uncomment DebugMessageHandler install (main...re-enable-debuglog) https://github.com/bitcoin-core/gui-qml/pull/414
pigeons has joined #bitcoin-core-dev
preimage has quit [Quit: WeeChat 4.3.5]
kevkevin has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev