<bitcoin-git>
[bitcoin] maflcko opened pull request #30703: test: Avoid duplicate curl call in get_previous_releases.py (master...2408-test-less-curl) https://github.com/bitcoin/bitcoin/pull/30703
anrichp has quit [Remote host closed the connection]
kevkevin has joined #bitcoin-core-dev
Guest89 has joined #bitcoin-core-dev
Guest89 has quit [Client Quit]
kevkevin has quit [Ping timeout: 276 seconds]
bitdex has quit [Quit: = ""]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
jonatack has quit [Ping timeout: 246 seconds]
noonien808310429 has joined #bitcoin-core-dev
andrewtoth has joined #bitcoin-core-dev
jlest has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Ping timeout: 246 seconds]
jlest has quit [Ping timeout: 252 seconds]
jlest has joined #bitcoin-core-dev
jlest has joined #bitcoin-core-dev
bugs_ has joined #bitcoin-core-dev
kevkevin has joined #bitcoin-core-dev
<sdaftuar>
do we have any tests for the script cache? (i noticed that if i don't do anything in the ConsensusScriptChecks function used in mempool validation, that no tests seem to fail, so wondering if i'm missing something)
jlest has quit [Ping timeout: 276 seconds]
<gmaxwell>
sdaftuar: Is your problem the fact that all the mempool script checks are strictly more strict than the consensus ones? they are supposed to be but for belt and suspenders both sets are run in case some non-consensus flag accidentally makes the rules more permissive.
<sdaftuar>
no, that's not what i'm getting at -- i just want to make sure that if i refactor things and break the cache, that something will fail to let me know we've lost the performance optimization.
<gmaxwell>
ohh
<sdaftuar>
apparently, i have in the past thought about testing this code before! just saw there was a commit from 2017 that i authored which purported to do some testing, but i have clearly forgotten about it :)
<instagibbs>
I mean it's far worse if it breaks and starts saying things are cached that arent :)
<sdaftuar>
sure, sure :)
flooded has quit [Remote host closed the connection]
<gmaxwell>
meh, that will get caught by tests. performance regression on the other hand might go unnoticed and then a year from now someone goes "oh this cache doesn't help at all, lets remove it." :P
flooded has quit [Remote host closed the connection]
flooded has joined #bitcoin-core-dev
preimage has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
pigeons has quit [Ping timeout: 252 seconds]
Guyver2 has left #bitcoin-core-dev [Closing Window]
jarthur has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 260 seconds]
jarthur_ has joined #bitcoin-core-dev
anrichp has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] maflcko opened pull request #30705: test: Avoid intermittent block download timeout in p2p_ibd_stalling (master...2408-test-stall-not-timeout) https://github.com/bitcoin/bitcoin/pull/30705
pablomartin has quit [Remote host closed the connection]
<sdaftuar>
glozow: thanks-- i had forgotten that i have inadvertently broken this before!
<sdaftuar>
the idea i'm working on now is a refactor too the way we add/remove things to the mempool, where we would construct a mempool changeset that consists of all the transactions we want to add and remove as an atomic change that gets applied all at once.
<sdaftuar>
in the case of package submission, we currently add transactions one at a time and call ConsensusScriptChecks() in between. but i was thinking that it ought to be ok to call it *after* everything is added to the mempool, and in the event a bug was triggered, go back and try to undo. that ought to be code which is impossible to trigger anyway...
<sdaftuar>
anyway i'm going to give that a shot, but if you happen to think of any fundamental problems with what i'm trying, please let me know before i go down a rabbit hole :)
<glozow>
Seems like a good idea. The only thing that might get in the way is `CheckInputsFromMempoolAndCache`(coins will go away after you submit things to mempool)
<glozow>
they are just sanity checks, so you could delete/move them of course
anrichp has quit [Ping timeout: 265 seconds]
<sdaftuar>
hmm, haven't looked at this in a while but my recollection is that in CIFMAC, being spent in the mempool doesn't cause a coin that is created in the mempool to be marked as spent?
<sdaftuar>
ie the coinsviewmempool only creates outputs for things in the mempool, but doesn't mark them as spent
abubakarsadiq has quit [Quit: Connection closed for inactivity]
Earnestly has quit [Quit: WeeChat 4.3.0-dev]
Earnestly has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 260 seconds]
andrewtoth has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
andrewtoth has quit [Ping timeout: 260 seconds]
mcey_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
emcy__ has quit [Ping timeout: 272 seconds]
pablomartin has joined #bitcoin-core-dev
Talkless has quit [Read error: Connection reset by peer]
<bitcoin-git>
[bitcoin] Christewart closed pull request #29221: Implement 64 bit arithmetic op codes in the Script interpreter (master...64bit-arith) https://github.com/bitcoin/bitcoin/pull/29221
bugs_ has quit [Quit: Leaving]
preimage has quit [Quit: WeeChat 4.4.1]
hello3nep has joined #bitcoin-core-dev
jlest has joined #bitcoin-core-dev
jlest has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 closed pull request #30702: contrib: add dockerfile for building image fron source code (master...master) https://github.com/bitcoin/bitcoin/pull/30702
kevkevin has quit [Remote host closed the connection]
jlest has quit [Ping timeout: 265 seconds]
kevkevin has joined #bitcoin-core-dev
kevkevin has quit [Remote host closed the connection]
pablomartin has quit [Ping timeout: 246 seconds]
tinova43 has joined #bitcoin-core-dev
Eric3 has joined #bitcoin-core-dev
michaelfolkson2 has joined #bitcoin-core-dev
jon_atack has joined #bitcoin-core-dev
tinova4 has quit [Quit: Ping timeout (120 seconds)]
jonatack has quit [Read error: Connection reset by peer]