< bitcoin-git>
[bitcoin] sipa opened pull request #20661: Only relay torv3 addresses to addrv2-capable peers (master...202012_torv2_relay_only_addrv2) https://github.com/bitcoin/bitcoin/pull/20661
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20653: doc: Move addr relay comment in net to correct place (master...2012-docNetAddrRelay) https://github.com/bitcoin/bitcoin/pull/20653
< bitcoin-git>
bitcoin/master a35a346 MarcoFalke: Merge #20653: doc: Move addr relay comment in net to correct place
< bitcoin-git>
bitcoin/master fa86217 MarcoFalke: doc: Move add relay comment in net to correct place
< gribble>
https://github.com/bitcoin/bitcoin/issues/16702 | p2p: supplying and using asmap to improve IP bucketing in addrman by naumenkogs · Pull Request #16702 · bitcoin/bitcoin · GitHub
< aj>
personally, i'm bothered by https://github.com/bitcoin/bitcoin/pull/20599#issuecomment-741631081 ; my opinion is that we should be thoroughly reviewing all p2p changes because there's potential for interactions, so going easy on "boring" PRs seems very unsafe. beyond that, there's a lot of not very beneficial refactoring PRs, that are also causing extra dev and review rework on PRs that change the
< jonatack>
ariard: in general, i can think of many outstanding reviews (and there are some outstanding reviewers). Coverage of great reviews was actually proposed one year ago for Bitcoin Optech: https://github.com/bitcoinops/bitcoinops.github.io/issues/301
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20653: doc: Move add relay comment in net to correct place (master...2012-docNetAddrRelay) https://github.com/bitcoin/bitcoin/pull/20653
< jonatack>
make -C ../bitcoin/depends download SOURCES_PATH=`pwd`/cache/common
< achow101>
provoostenator: can you provide the bitcoin-7f9d623e0210-osx-unsigned.tar.gz for your build of #20638?
< gribble>
https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20599: net processing: Tolerate sendheaders and sendcmpct messages before verack (master...2020-12-tolerate-early-send-messages) https://github.com/bitcoin/bitcoin/pull/20599
< bitcoin-git>
bitcoin/master fff7d05 MarcoFalke: Merge #20599: net processing: Tolerate sendheaders and sendcmpct messages ...
< gribble>
https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< bitcoin-git>
[bitcoin] hebasto opened pull request #20650: depends: Drop workaround for a fixed bug in Qt build system (master...201214-xcb) https://github.com/bitcoin/bitcoin/pull/20650
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #20649: refactor: Remove nMyStartingHeight from CNode/Connman (master...2012-netNoMyHeight) https://github.com/bitcoin/bitcoin/pull/20649
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20624: net processing: Remove nStartingHeight check from block relay (master...2020-12-remove-starting-height) https://github.com/bitcoin/bitcoin/pull/20624
< bitcoin-git>
bitcoin/master f636008 John Newbery: [net processing] Clarify UpdatedBlockTip()
< bitcoin-git>
bitcoin/master 94d2cc3 John Newbery: [net processing] Remove unnecesary nNewHeight variable in UpdatedBlockTip()
< bitcoin-git>
bitcoin/master 8b57013 John Newbery: [net processing] Remove nStartingHeight check from block relay
< bitcoin-git>
[bitcoin] jonatack opened pull request #20646: p2p: do not disconnect post-verack sendaddrv2 on signet (master...signet-keep-post-verack-sendaddrv2-peers) https://github.com/bitcoin/bitcoin/pull/20646
< jonasschnelli>
achow101: still getting dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< jonasschnelli>
stat -c %s signed-app/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli>
achow101: fatal error: /home/jonasschnelli/bitcoin-depends2/depends/x86_64-apple-darwin20/native/bin/x86_64-apple-darwin20-codesign_allocate: size for '-a x86_64 258611375' not a multiple of 16
< bitcoin-git>
[bitcoin] sipa opened pull request #20644: Add patch to make codesign_allocate compatible with Apple's (master...202012_codesign_allocate_segalign) https://github.com/bitcoin/bitcoin/pull/20644
< jonasschnelli>
still getting: dist/Bitcoin-Qt.app: invalid or unsupported format for signature
< achow101>
jonasschnelli: if you do "printf "\xfa\xde\x0c\xc0" | dd of=dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt bs=1 seek=26391600 count=4 conv=notrunc" and then try to sign, does it work?
< gribble>
https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/20638 | build: Fix macOS code signing by pre-allocating space for the code signature during gitian build by achow101 · Pull Request #20638 · bitcoin/bitcoin · GitHub
< harding>
$ bitcoin-cli help scantxoutset | grep '"range"'
< harding>
jamesob: sorry, I meant the derived address range, which I think non-Bitcoin Core software usually calls the gap limit.
< Talkless>
Anyone using QtCreator to work with bitcoin core? It's code model does not find any of bitcoin core includes, all underlined. I've created project as Autotools.
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #20275: wallet: List all wallets in non-SQLite and non-BDB builds (master...pr/exist) https://github.com/bitcoin/bitcoin/pull/20275
< bitcoin-git>
bitcoin/master 6a7a636 Russell Yanofsky: refactor: Drop call to GetWalletEnv in wallet salvage code
< bitcoin-git>
bitcoin/master 6ee9cbd Russell Yanofsky: refactor: Replace ListWalletDir() function with ListDatabases()
< bitcoin-git>
bitcoin/master 5aaeb6c Russell Yanofsky: MOVEONLY: Move IsBDBFile, IsSQLiteFile, and ListWalletDir
< sipa>
if you run "codesign_allocate -i <gitian Bitcoin-Qt filename> -a x86_64 $((225312+1024)) -o <newname>" in linux, does the resulting binary work in macos?
< sipa>
what is the full output from that x86_64-apple-darwin-otool -l Bitcoin-Qt command?
2020-12-11
< sipa>
achow101: if you run "codesign_allocate -i <unsigned Bitcoin-Qt filename> -a x86_64 225312 -o <some temp file>
< sipa>
if you run "pagestuff -p Bitcoin-Qt | tail -2 | grep size | sed 's/[^0-9]*//g'", what do you get?
< sipa>
yeah, what if you run that on the unsigned Bitcoin-Qt binary?
< sipa>
x86_64-apple-darwin-otool -l Bitcoin-Qt
< achow101>
x86_64-apple-darwin-otool -l Bitcoin-Qt for segment "__LINKEDIT" says "vmsize 0x000000000007b000" but on the other it's "vmsize 0x000000000007c000"
< jonasschnelli>
I have verified the signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz and it works
< jonasschnelli>
I double checked and I can confirm that I have signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< jonasschnelli>
but I signed 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< jonasschnelli>
But yes,... 46cfa036d365d69db2a3b78377621d6b214f2d78f3082f9c7ebd7a9b89cfc599 bitcoin-osx-signed.dmg has an invalid code signature
< jonasschnelli>
I got 998dddf3c0f9b568fc0c39e61e3d61d2843dfb968016b7ceaf23aca94ace2542 bitcoin-osx-signed.dmg as the only one
< jonasschnelli>
I codesigned 5e3a08ae8195190d6f1b12e3e1e9d710e7ad385941a6e8d04e3391f12deddb11 bitcoin-0.21.0rc3-osx-unsigned.tar.gz
< prusnak>
Big Sur says Bitcoin Core installed from bitcoin-0.21.0rc3-osx.dmg is broken and should be moved to the bin; that said this happens on M1 system, so maybe on x86-64 it's fine
< mj_node>
@wumpus sorry for that, and I will make sure to go to #bitcoin-core-dev
< wumpus>
in any case, this isn't a support channel, unless you're doing development and having questions about the code for that reason this is not the place, use #bitcoin next time