< bitcoin-git>
bitcoin/master d595b4a fanquake: gui: move coin control OK to the right
< bitcoin-git>
bitcoin/master ab6d18e Jonas Schnelli: Merge #16113: gui: move coin control "OK" to the right hand side of the di...
< bitcoin-git>
[bitcoin] jonasschnelli merged pull request #16113: gui: move coin control "OK" to the right hand side of the dialog (master...ok_right_have_side) https://github.com/bitcoin/bitcoin/pull/16113
< wumpus>
I guess we should cancel the meeting tomorrow, because of ascension day?
< bitcoin-git>
[bitcoin] promag opened pull request #16118: gui: Enable open wallet menu on setWalletController (master...2019-05-null-walletcontroller) https://github.com/bitcoin/bitcoin/pull/16118
< promag>
fanquake: any command in the console crashes?
< fanquake>
promag: yea, it doesn't have to be valid, just a couple random letters etc will cause it
< promag>
but it should be possible to run commands right?
< promag>
like abortrescan ?
< fanquake>
promag: right
< promag>
you believe it should be in that PR?
< promag>
looks like it's a different fix
< promag>
that one disables the menu
< fanquake>
promag: Yea I guess that PR can probably be left as is. I can open a separate issue for the console stuff for discussion, and a different fix can follow.
< promag>
I'm in the middle of another task, then I can try to reproduce that
< promag>
note that nSize on line 11 is 123145439612064 :/
< luke-jr>
promag: when in doubt, run in Valgrind
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #16120: test: Compile json to hex separately, at most once (master...1905-testJson) https://github.com/bitcoin/bitcoin/pull/16120
< jb55>
*memory corrupt makes anything possible*
< Chris_Stewart_5>
wd
< wumpus>
OK let's just do the meeting tomorrow then, we'll see who shows up, we already have coredev/breaking bitcoin next week so I guess it makes more sense to skip that one
< bitcoin-git>
[bitcoin] fanquake closed pull request #16120: test: Compile json to hex separately, at most once (master...1905-testJson) https://github.com/bitcoin/bitcoin/pull/16120
< bitcoin-git>
[bitcoin] promag opened pull request #16122: gui: Enable console line edit on setClientModel (master...2019-05-null-completer) https://github.com/bitcoin/bitcoin/pull/16122
< promag>
fanquake: I think you could remove GUI label from #16107