< ossifrage> I did a checkout today, a clean and a reconfigure but I'm failing to build with: make[2]: *** No rule to make target 'checkpoints.cpp', needed by 'libbitcoin_server_a-checkpoints.o'. Stop.
< ossifrage> Looks like I have something left behind from the old build, not caught by the clean
< gmaxwell> achow101: I think junk is permitted by the network so long as you don't use it.
< fanquake> dongcarl Looks like we dont export GZIP_ENV anywhere (as far as I can see), however it seems like everywhere we are using gzip we are passing -9n explicitly.
< fanquake> I also see what you mean about the overriding in the makefile. Where the options would essentially become --best, which seems to be equivalent to -9.
< dongcarl> Right. It's the `-n` that gives us the determinism
< fanquake> Yea
< dongcarl> Confused about how this hasn't caused differences in gitian sigs...
< fanquake> "When compressing, do not save the original file name and timestamp by default."
< fanquake> What would be causing the difference?
< dongcarl> the timestamp
< fanquake> dongcarl but we are still passing -n for gitian sigs?
< fanquake> In the descriptors when we call gzip, we pass -9n
< dongcarl> Oh! Because we re-`gzip` it!
< fanquake> Yea, so each invocation of gzip here: https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-descriptors/gitian-linux.yml has -9n passed to it.
< fanquake> I agree that it's confusion given that the GZIP export is seemingly redundant?
< fanquake> *confusing
< dongcarl> Working on something where I remove all the re-gzipping, cuz `tar` got a `--sort=name` flag now
< fanquake> The GZIP env var is also deprecated, so if we'll seemingly have to lose it at some point anyways.
< fanquake> Is that guix related?
< dongcarl> > GZIP export is seemingly redundant
< dongcarl> We might need to change to a wrapper cuz perhaps some determinism in the depends tree might depend on this deprecated env var
< dongcarl> fanquake: Sort of Guix related, could be merged in by itself. Doing a cleanup of the descriptors and build system as I go along.
< fanquake> dongcarl cool. Happy to help out / test if required!
< dongcarl> :-)
< jb55> any ideas on best practice for multiimporting HW wallet keys into core's keypool when you don't know which keys have been used already? perhaps there could be a way to have an semi-intelligent multiimport that will only add the key into the keypool if it hasn't received anything yet?
< jb55> if that makes sense
< achow101> jb55: maybe something that does scantxout with the descriptor to mark which keys are unused, and import the unused ones?
< jb55> achow101: yeah something like that, I'm not too familiar with the codebase but I imagine you would have to hold onto everything until the very end before you add it to the pool or not...
< jb55> achow101: will core re-use keypool-imported addresses if they've been used already? if not then there's no issue.
< achow101> jb55: only if you rescan after importing
< achow101> rescanning will remove used things from the keypool
< jb55> ah interesting
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/667a8617418d...40c66bb3d15b
< bitcoin-git> bitcoin/master fa3c651 MarcoFalke: [refactor] interfaces: Add missing LockAnnotation for cs_main
< bitcoin-git> bitcoin/master 40c66bb MarcoFalke: Merge #15855: [refactor] interfaces: Add missing LockAnnotation for cs_mai...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15855: [refactor] interfaces: Add missing LockAnnotation for cs_main (master...1904-interfacesLock) https://github.com/bitcoin/bitcoin/pull/15855
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/40c66bb3d15b...6f4ba6492a12
< bitcoin-git> bitcoin/master 05bfee3 Russell Yanofsky: util_SettingsMerge test cleanup
< bitcoin-git> bitcoin/master 4b33115 Russell Yanofsky: Add unit test NextString, ForEachNoDup functions
< bitcoin-git> bitcoin/master f6bb11f Russell Yanofsky: Add test for ArgsManager::GetChainName
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15988: Add test for ArgsManager::GetChainName (master...pr/testset2) https://github.com/bitcoin/bitcoin/pull/15988
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6f4ba6492a12...3503a69ba237
< bitcoin-git> bitcoin/master a407b6f John Newbery: [tests] Make random seed logged and settable
< bitcoin-git> bitcoin/master 3503a69 MarcoFalke: Merge #15963: [tests] Make random seed logged and settable
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15963: [tests] Make random seed logged and settable (master...2019-05-test-deterministic-randomness) https://github.com/bitcoin/bitcoin/pull/15963
< bitcoin-git> [bitcoin] MarcoFalke pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3503a69ba237...65526fc8666f
< bitcoin-git> bitcoin/master ef2d515 John Newbery: [wallet] move-only: move CReserveKey to be next to CKeyPool
< bitcoin-git> bitcoin/master 37796b2 John Newbery: [docs] Add doxygen comment for CKeyPool
< bitcoin-git> bitcoin/master f1a77b0 John Newbery: [docs] Add doxygen comment for CReserveKey
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15777: [docs] Add doxygen comments for keypool classes (master...2019_04_keypool_comments) https://github.com/bitcoin/bitcoin/pull/15777
< tryphe> interesting systemd commit related to RDRAND (pretty sure this has been discussed in here before): https://github.com/systemd/systemd/issues/11810
< sdaftuar> gmaxwell: regarding the orphan transaction issue and the getdata randomization behavior-- it looks to me like we (a) do not put any delay on getdata requests for outbound peers announcing a tx for the first time and (b) have a fixed delay for inbound peers announcing a tx for the first time
< tryphe> err, sorry, this one -> https://github.com/systemd/systemd/pull/12536
< sdaftuar> gmaxwell: so i think in the case of a peer announcing a set of transactions that are new to us, we'll request those transactions in dependency order from that peer, except if an inbound peer's announcement is partially supserseded by a later announcement from an outbound peer for a subset of the transactions
< sdaftuar> gmaxwell: so that seems like it should be a relatively small effect (and is an effect we have to some degree already)
< bitcoin-git> [bitcoin] ccapo opened pull request #16024: [rpc] deriveaddresses: Correction of descriptor checksum in RPC example (master...2019-05-14-deriveaddresses-example-checksum) https://github.com/bitcoin/bitcoin/pull/16024