< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3001cc61cf11...ecbbb5cafef5
< bitcoin-git> bitcoin/master df0e97c Kristaps Kaupe: RPC: Hint for importmulti in help output of importpubkey and importaddress
< bitcoin-git> bitcoin/master ecbbb5c MarcoFalke: Merge #16071: RPC: Hint for importmulti in help output of importpubkey and...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16071: RPC: Hint for importmulti in help output of importpubkey and importaddress (master...hint-importmulti) https://github.com/bitcoin/bitcoin/pull/16071
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ecbbb5cafef5...953f75767727
< bitcoin-git> bitcoin/master d8bc47f Ulrich Kempken: depends: switch to secure download of all dependencies
< bitcoin-git> bitcoin/master 953f757 MarcoFalke: Merge #16049: depends: switch to secure download of all dependencies
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16049: depends: switch to secure download of all dependencies (master...Berkeley_DB_SSL_source) https://github.com/bitcoin/bitcoin/pull/16049
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/953f75767727...1c177c3a004f
< bitcoin-git> bitcoin/master 1609809 practicalswift: validation: Hold cs_main when reading chainActive in RewindBlockIndex
< bitcoin-git> bitcoin/master 1c177c3 MarcoFalke: Merge #16015: validation: Hold cs_main when reading chainActive in RewindB...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16015: validation: Hold cs_main when reading chainActive in RewindBlockIndex (master...missing-cs_main-in-RewindBlockIndex) https://github.com/bitcoin/bitcoin/pull/16015
< MarcoFalke> wumpus: Have you seen my reply to your concern in https://github.com/bitcoin/bitcoin/pull/15891#issuecomment-489614414 ?
< MarcoFalke> Just wondering if there is anything else I need to do
< MarcoFalke> The other feedback was purely stylistic
< bitcoin-git> [bitcoin] promag closed pull request #16065: refactor: Reuse block hash in AddToBlockIndex (master...2019-05-reuse-block-hash) https://github.com/bitcoin/bitcoin/pull/16065
< wumpus> MarcoFalke: I still don't really like it, I think finding a matching structure by BIP chain name was ok, don't see the need for an enum
< wumpus> I liked the data-driven approach where chain has a boolean flag instead of checking "if chain is testnet"
< wumpus> but maybe I'm alone in that, I really don't know
< sipa> wumpus: i agree; context?
< promag> MarcoFalke: jamesob: jonasschnelli: keeping #16065 closed but posted profile results
< gribble> https://github.com/bitcoin/bitcoin/issues/16065 | refactor: Reuse block hash in AddToBlockIndex by promag · Pull Request #16065 · bitcoin/bitcoin · GitHub
< jamesob> promag: cool, thanks
< jamesob> promag: btw which profiler is that? nice UI. mac os I'm assuming?
< promag> yes, instruments
< promag> I'm also learning to use it
< MarcoFalke> [11:34] <sipa> wumpus: i agree; context?
< MarcoFalke> sipa: please leave your concern here: https://github.com/bitcoin/bitcoin/pull/15891#issuecomment-489614414 , so it doesn't get lost
< MarcoFalke> btw, github notifications are down: https://www.githubstatus.com/incidents/nf4gcjtcsqdb
< bitcoin-git> [bitcoin] torkelrogstad opened pull request #16076: Docs: Add note on precedence of options in bitcoin.conf (master...patch-1) https://github.com/bitcoin/bitcoin/pull/16076
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/1c177c3a004f...fdc951ad040a
< bitcoin-git> bitcoin/master d2dbc7d João Barbosa: bench: Add benchmark for CRollingBloomFilter::reset
< bitcoin-git> bitcoin/master df9e15f João Barbosa: refactor: Improve CRollingBloomFilter::reset by using std::fill
< bitcoin-git> bitcoin/master fdc951a Wladimir J. van der Laan: Merge #16073: refactor: Improve CRollingBloomFilter::reset by using std::f...
< bitcoin-git> [bitcoin] laanwj merged pull request #16073: refactor: Improve CRollingBloomFilter::reset by using std::fill (master...2019-05-rollingbloomfilter-reset) https://github.com/bitcoin/bitcoin/pull/16073
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fdc951ad040a...12fd4bbd1ed9
< bitcoin-git> bitcoin/master be4efb1 João Barbosa: rpc: Mention getwalletinfo where a rescan is triggered
< bitcoin-git> bitcoin/master 12fd4bb MarcoFalke: Merge #16063: rpc: Mention getwalletinfo where a rescan is triggered
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #15891: test: Require standard txs in regtest by default (master...1904-testRequireStandard) https://github.com/bitcoin/bitcoin/pull/15891
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15891: test: Require standard txs in regtest by default (master...1904-testRequireStandard) https://github.com/bitcoin/bitcoin/pull/15891
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #16063: rpc: Mention getwalletinfo where a rescan is triggered (master...2019-05-rescan-info) https://github.com/bitcoin/bitcoin/pull/16063