< bitcoin-git> [bitcoin] theStack opened pull request #17502: test: add unit test for non-standard bare multisig txs (master...20191118-test_check-for-non-standard-txs-bare-multisig) https://github.com/bitcoin/bitcoin/pull/17502
< bitcoin-git> [bitcoin] laanwj pushed 1 commit to 0.19: https://github.com/bitcoin/bitcoin/compare/890dc0a7cccd...1bc9988993ee
< bitcoin-git> bitcoin/0.19 1bc9988 Wladimir J. van der Laan: doc: Generate manpages for 0.19.0.1
< wumpus> I'm going to tag 0.19.0.1 in a minute, can everyone please help checking that the branch is sane
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7dbc33f61764...94f0749f9130
< bitcoin-git> bitcoin/master 0ec9671 TheCharlatan: Add TheCharlatan's pgp key
< bitcoin-git> bitcoin/master 94f0749 Wladimir J. van der Laan: Merge #17436: Add TheCharlatan's pgp key
< bitcoin-git> [bitcoin] laanwj merged pull request #17436: Add TheCharlatan's pgp key (master...gitianKey) https://github.com/bitcoin/bitcoin/pull/17436
< provoostenator> I'm able to build it and it shows the right version.
< wumpus> thanks!
< bitcoin-git> [bitcoin] laanwj opened pull request #17503: doc: Remove bitness from bitcoin-qt help message and manpage (master...2019_11_nobitness) https://github.com/bitcoin/bitcoin/pull/17503
< sipsorcery> wumpus: build from master good for me
< wumpus> sipsorcery: but we're not releaseing from master :) what about 0.19 branch?
< sipsorcery> ah ok, will try that
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/94f0749f9130...1baf7d181931
< bitcoin-git> bitcoin/master bc728d1 Carl Dong: depends: qt: Fix C{,XX} pickup
< bitcoin-git> bitcoin/master 1baf7d1 Wladimir J. van der Laan: Merge #17466: depends: qt: Fix C{,XX} pickup
< bitcoin-git> [bitcoin] laanwj merged pull request #17466: depends: qt: Fix C{,XX} pickup (master...2019-11-qt-CC-CXX-pickup) https://github.com/bitcoin/bitcoin/pull/17466
< promag> wumpus: trying 0.19 too
< wumpus> thank u
< bitcoin-git> [bitcoin] promag opened pull request #17505: Fix unsigned integer overflow in LoadMempool (master...2019-11-loadmempool-ubsan-uint-overflow) https://github.com/bitcoin/bitcoin/pull/17505
< bitcoin-git> [bitcoin] promag closed pull request #17505: Fix unsigned integer overflow in LoadMempool (master...2019-11-loadmempool-ubsan-uint-overflow) https://github.com/bitcoin/bitcoin/pull/17505
< promag> wumpus: regarding #17500, considering the goal is to remove the circular dependency, which can be done with just https://github.com/bitcoin/bitcoin/pull/17500#discussion_r347153585 I don't agree with the other changes - particularly with the one setting the parent temporarily to BitcoinGUI
< gribble> https://github.com/bitcoin/bitcoin/issues/17500 | refactor, qt: Nuke walletframe circular dependency by hebasto . Pull Request #17500 . bitcoin/bitcoin . GitHub
< wumpus> promag: sure, I'd definitely prefer a smaller PR if it accomplishes the same, I just mean if the argument needs to be added anyhow, aligning the other initializers doesn't seem too bad
< promag> I just mean if the argument needs to be added anyhow -> it doesn't
< wumpus> then comment that instead of the style change :)
< wumpus> if the *entire change* is unnecessary then obviously the style change is too
< wumpus> but that's more like a 'implementation concept NACK', no need to comment individual lines then :)
< promag> hebasto: don't take me wrong, I just that these "fix" changes should be as small as possible
< wumpus> yes, it's a good aim
< promag> hebasto: afaik instancing a widget with null parent doesn't make it a window - at least until you show() it
< wumpus> please check that very carefully
< wumpus> if you're not sure, err on the safe side
< promag> hebasto: and it's fine to create without a parent and setting it later
< wumpus> don't base that on an assumption
< wumpus> (I think it's the case though that both are equivalent)
< wumpus> but this qt ownership hierarchy stuff is pretty subtle sometimes
< wumpus> "breaking a circular dependency", though nice in itself, is not something you'd want to introduce a bug in
< promag> heh
< promag> I've created a dummy qwidget project
< promag> the generated code is:
< promag> centralWidget = new QWidget(MainWindow); MainWindow->setCentralWidget(centralWidget);
< promag> hebasto: my apologies
< wumpus> fanquake: let's kill the OpenSSL dependency today
< fanquake> wumpus sounds good
< bitcoin-git> [bitcoin] laanwj pushed 12 commits to master: https://github.com/bitcoin/bitcoin/compare/1baf7d181931...0bb37e437e9c
< bitcoin-git> bitcoin/master b51bae1 fanquake: doc: minor corrections in random.cpp
< bitcoin-git> bitcoin/master cea3902 Pieter Wuille: [MOVEONLY] Move perfmon data gathering to new randomenv module
< bitcoin-git> bitcoin/master 723c796 Pieter Wuille: [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid
< bitcoin-git> [bitcoin] laanwj merged pull request #17270: Feed environment data into RNG initializers (master...201910_seedrandom) https://github.com/bitcoin/bitcoin/pull/17270
< wumpus> MarcoFalke: pretty smart to do the aarch64 gitian cross build test for a windows target, at least that rules out library/g++ version differences, will havea a closer look at the differences later
< wumpus> fanquake: maybe rebase #17265 on top of current master, and remove draft status
< gribble> https://github.com/bitcoin/bitcoin/issues/17265 | Remove OpenSSL by fanquake . Pull Request #17265 . bitcoin/bitcoin . GitHub
< fanquake> wumpus sure. Will do that shortly.
< wumpus> thanks!
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0bb37e437e9c...24647a09e710
< bitcoin-git> bitcoin/master fa6e01b MarcoFalke: ci: Use clang-8 for fuzzing to run on aarch64 ci systems
< bitcoin-git> bitcoin/master fa2ec9f MarcoFalke: fuzz: Bump timeout in test_runner to accomodate for slow arm64 CPUs
< bitcoin-git> bitcoin/master 24647a0 Wladimir J. van der Laan: Merge #17470: ci: Use clang-8 for fuzzing to run on aarch64 ci systems
< bitcoin-git> [bitcoin] laanwj merged pull request #17470: ci: Use clang-8 for fuzzing to run on aarch64 ci systems (master...1911-ciFuzzClang8) https://github.com/bitcoin/bitcoin/pull/17470
< wumpus> LXD is a thing now?!?
< wumpus> oh it's basically a friendly wrapper on top of LXC and uses LXC underneath, phew, I was afraid for a moment they had introduced yet another linux-on-linux virtualization layer
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24647a09e710...63fac52f31ea
< bitcoin-git> bitcoin/master 2f5f7d6 darosior: GuessVerificationProgress: cap the ratio to 1
< bitcoin-git> bitcoin/master 63fac52 Wladimir J. van der Laan: Merge #17328: GuessVerificationProgress: cap the ratio to 1
< bitcoin-git> [bitcoin] laanwj merged pull request #17328: GuessVerificationProgress: cap the ratio to 1 (master...fixup_getblockchaininfo) https://github.com/bitcoin/bitcoin/pull/17328
< bitcoin-git> [bitcoin] laanwj pushed tag v0.19.0.1: https://github.com/bitcoin/bitcoin/compare/v0.19.0.1
< wumpus> ^^ v0.19.0.1 tagged
< sipsorcery> wumpus: 0.19 build good for me (eventually, had Qt version issues in my environment)
< wumpus> sipsorcery: great!
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/63fac52f31ea...ca1eeba0b058
< bitcoin-git> bitcoin/master 1c23ea5 fanquake: test: fix bitcoind already running warnings on macOS
< bitcoin-git> bitcoin/master ca1eeba Wladimir J. van der Laan: Merge #17488: test: fix "bitcoind already running" warnings on macOS
< bitcoin-git> [bitcoin] laanwj merged pull request #17488: test: fix "bitcoind already running" warnings on macOS (master...macos_pidof_test_runner_warning) https://github.com/bitcoin/bitcoin/pull/17488
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ca1eeba0b058...6fde676f647e
< bitcoin-git> bitcoin/master feb5075 fanquake: build: use osslsigncode 2.0 in gitian
< bitcoin-git> bitcoin/master 6fde676 Wladimir J. van der Laan: Merge #16669: build: use new fork of osslsigncode for windows gitian signi...
< bitcoin-git> [bitcoin] laanwj merged pull request #16669: build: use new fork of osslsigncode for windows gitian signing (master...osslsigncode_2_0) https://github.com/bitcoin/bitcoin/pull/16669
< fanquake> I reckon just about every OpenSSL related file has been touched in some way since I opened the removal PR
< wumpus> crazy
< wumpus> so some people have been doing wasted work, at the least
< fanquake> heh, just some shuffling in docs and things
< fanquake> I think the fact that my machine is somewhat bogged down gitian building is also adding to frustrations
< wumpus> at least a gitian build will be slightly lighter after openssl no longer needs to be built !
< fanquake> Yea. depends is starting to look pretty slim now
< fanquake> wumpus #17265 should be reviewable now
< gribble> https://github.com/bitcoin/bitcoin/issues/17265 | Remove OpenSSL by fanquake . Pull Request #17265 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fde676f647e...397c6d32c8f8
< bitcoin-git> bitcoin/master e161bc7 Wladimir J. van der Laan: doc: Remove bitness from bitcoin-qt help message and manpage
< bitcoin-git> bitcoin/master 397c6d3 MarcoFalke: Merge #17503: doc: Remove bitness from bitcoin-qt help message and manpage...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17503: doc: Remove bitness from bitcoin-qt help message and manpage (master...2019_11_nobitness) https://github.com/bitcoin/bitcoin/pull/17503
< fanquake> Actually it's not quite. There's some documentation fixups need after #17270
< gribble> https://github.com/bitcoin/bitcoin/issues/17270 | Feed environment data into RNG initializers by sipa . Pull Request #17270 . bitcoin/bitcoin . GitHub
< fanquake> RandAddSeedSleep no longer exists
< wumpus> there's always documentation fixups needed after a big change
< bitcoin-git> [bitcoin] fanquake opened pull request #17507: random: mark RandAddPeriodic and SeedPeriodic as noexcept (master...random_followups) https://github.com/bitcoin/bitcoin/pull/17507
< * fanquake> sprinkles some noexcepts
< wumpus> "None of the RNG code should ever throw any exception." I like that
< wumpus> my gitian sigs are going to take somewhat longer, somehow I'm running out of disk space on the gitian VM after regenerating the base image last time, had to nuke everything (and might need to do so again if I can't build with this amount of space anymore)
< wumpus> does that thing really need to be 12G?
< sipsorcery> my gitian vm is using 35G but that includes old builds and repo branches.
< wumpus> hehe, the base image + copy is already 24GB, then there's the OS itself, caches and builds. I removed the old builds and the trusty image so maybe it will work now.
< wumpus> but I think it could do with much less peak usage if it removed intermediate build results (esp in the linux build, which builds for a larger number of platforms)
< wumpus> please don't keep increasing the size of the base image instead :)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/397c6d32c8f8...30521302f90e
< bitcoin-git> bitcoin/master 49f4c7f practicalswift: tests: Add fuzzing harness for various PSBT related functions
< bitcoin-git> bitcoin/master 3052130 MarcoFalke: Merge #17136: tests: Add fuzzing harness for various PSBT related function...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17136: tests: Add fuzzing harness for various PSBT related functions (master...fuzzers-psbt) https://github.com/bitcoin/bitcoin/pull/17136
< bitcoin-git> [bitcoin] Sjors opened pull request #17509: gui: save and load PSBT (master...2019/11/gui-psbt-save) https://github.com/bitcoin/bitcoin/pull/17509
< jnewbery> Can we add #14384 to high priority blockers? It's blocking PRs from marco and me
< gribble> https://github.com/bitcoin/bitcoin/issues/14384 | Fire TransactionRemovedFromMempool callbacks from mempool by l2a5b1 . Pull Request #14384 . bitcoin/bitcoin . GitHub
< jnewbery> (should be pretty close anyway. Already has two ACKs on the current head commit (ariard and me) and an ACK on an old branch (MarcoFalke))
< jonatack> jnewbery: will look at it this evening
< bitcoin-git> [bitcoin] achow101 opened pull request #17510: Add copy constructor and copy operator= to CScript to remove ubsan suppression (master...cscript-undef) https://github.com/bitcoin/bitcoin/pull/17510
< bitcoin-git> [bitcoin] ryanofsky reopened pull request #12763: Add RPC Whitelist Feature from #12248 (master...whitelistrpc) https://github.com/bitcoin/bitcoin/pull/12763
< bitcoin-git> [bitcoin] emilengler closed pull request #17498: Add permission whitelisting system (master...2019-11-whitelist-permission-system) https://github.com/bitcoin/bitcoin/pull/17498
< achow101> Is #17290 ready to merge? has 2 acks
< gribble> https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 . Pull Request #17290 . bitcoin/bitcoin . GitHub
< bitcoin-git> [bitcoin] sipa opened pull request #17511: Add bounds checks before base58 decoding (master...201911_boundedbase58) https://github.com/bitcoin/bitcoin/pull/17511