< elichai2>
does `-reindex-chainstate` re-verifies all transactions?
< sipa>
yes
< elichai2>
(always used `-reindex` but I see that this might be faster)
< elichai2>
thanks :)
< sipa>
-reindex-chainstate deletes the chainstate, so it needs to be recreated
< sipa>
-reindex additionally also deletes the block index
< elichai2>
testing 0.19.0.1 with `assumevalid=0` and ` -reindex-chainstate` now :)
< elichai2>
jamesob: i'm seeing quite bad performance with `std::_Rb_tree<CBlockIndex*, CBlockIndex*, std::_Identity<CBlockIndex*>, CBlockIndexWorkComparator, std::allocator<CBlockIndex*> >...` which i'm pretty sure is this set: `std::set<CBlockIndex*, CBlockIndexWorkComparator>& block_index_candidates)`
< elichai2>
might be worth looking into more in relation to the hashmap PRs
< instagibbs_>
provoostenator, was wondering if we want to formalize/wrap the "is private keys disabled" checks for watchonly into something more visible? Say in the future we want to update how the wallet handles this, we have to hunt for all these checks....
< instagibbs_>
IsWatchonlyWalletMode() or there abouts
< wumpus>
instagibbs_: good idea
< instagibbs_>
The list is pretty small for now, but if/when these PRs make it in, I can do that
< instagibbs_>
remaining non-WIP list, I think, is 17587, 16373, and 17492
< jamesob>
elichai2: do you have a profile indicating that it's a bottleneck?
< elichai2>
is it possible to share profiles? I have a quick one (10MB). but it might be specific to `-reindex-chainstate` and negligble in real world application (that's why I said looking more into it)
< elichai2>
but in my profile it's pretty high up the list
< instagibbs_>
remind me: does the Core wallet consider sh_pkh(not witness) ismine?
< sipa>
instagibbs_: i believe nit
< sipa>
*not
< sipa>
but i'm not entirely sure
< bitcoin-git>
[bitcoin] instagibbs opened pull request #17621: IsUsedDestination should count any known single-key address (master...actually_no_reuse) https://github.com/bitcoin/bitcoin/pull/17621
< instagibbs_>
achow101, bet you know
< achow101>
instagibbs_: pretty sure it doesn't
< achow101>
you on't have the p2pkh script in mapScripts so it won't find that script
< achow101>
*don't
< provoostenator>
If anyone wants to learn in real time from PracticalSwift how to actually compile with -fsanitize=memory, follow along with #17620