< bitcoin-git>
[bitcoin] jkczyz opened pull request #17557: util: Refactor message hashing into a utility function (master...2019-11-hash-message) https://github.com/bitcoin/bitcoin/pull/17557
< fanquake>
jonasschnelli: what's the eta on some 0.19.0.1 macOS sigs?
< fanquake>
I see Cory pushed up some windows sigs earlier today.
< MarcoFalke>
my irc went down today, so I lost any PMs that I haven't had replied to
< bitcoin-git>
[bitcoin] sandakersmann opened pull request #17561: doc: Changed MiniUPnPc link to https in dependencies.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17561
< luke-jr>
instagibbs_: "As of today, this fix has NOT been backported to older versions. When/if v0.15.3 and v0.16.4 are released, they may also include a fix, but due to the minor severity of this vulnerability, it does not merit a dedicated release on its own." https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-June/017040.html
< luke-jr>
instagibbs_: if you disagree and want to do the work, I have no objection to a 0.16.4 ;)
< instagibbs_>
hehe
< luke-jr>
I suppose I could have reiterated that 0.16 is unfixed in the disclosure. Oh well
< instagibbs_>
I wouldn't be doing a majority of the release work, so that's on others really
< luke-jr>
instagibbs_: it seems if you want 0.16.4, you would have to be doing it ;)
< luke-jr>
at least that's the impression I got
< harding>
luke-jr: I think it's too minor for BitcoinCore.org; but if other people want it published, I'm happy to help.
< meshcollider>
I'm going to merge some PRs today finally
< meshcollider>
Topics?
< achow101>
finally
< achow101>
what metrics does SRD have to meet in order to be merged?
< achow101>
see #17526
< gribble>
https://github.com/bitcoin/bitcoin/issues/17526 | Use Single Random Draw In addition to knapsack as coin selection fallback by achow101 . Pull Request #17526 . bitcoin/bitcoin . GitHub
< meshcollider>
I don't know, acks from coin selection people I guess
< achow101>
we kind of got stuck on what "better" meant with the last time we tried this, so I wanted to try to define "better" concretely
< jonatack>
not a coin selection person yet, apart from reading murch's work, but started reviewing and testing #17290
< gribble>
https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 . Pull Request #17290 . bitcoin/bitcoin . GitHub
< achow101>
just gonna beg for review and merges on wallet box stuff
< meshcollider>
Yep today I have some time finally to get stuff merged
< meshcollider>
Apologies for the lack of activity this week
< jonatack>
FWIW, i plan to follow jnewbery's review of my getaddressinfo PR and propose to deprecate both the label field, and the `purpose` part of the labels array
< jonatack>
so 2 deprecations, anyone opposed can lmk to save time :)
< jonatack>
e.g. getaddressinfo labels would return a flat array of label strings only
< achow101>
jonatack: you should look into supporting multiple labels too
< jonatack>
achow101: yes, plan to
< meshcollider>
+1
< bitcoin-git>
[bitcoin] jnewbery opened pull request #17562: Validation: Remove ConnectTrace and PerBlockConnectTrace (master...2019-11-remove-connect-trace) https://github.com/bitcoin/bitcoin/pull/17562
< warren>
The new mailing list host OSUOSL requests that we limit the authorized persons who can request support tickets to a small number. This is because they need a simple way to avoid processing bad/fraudulent requests. Currently proposed is a few people who put effort into helping mailing list infrastructure or moderation in the past few years. Those persons are all at different companies or independent spanning USA and Asian timezones. It
< warren>
would be good if a well known developer from the Europe timezone also helped. Please contact me directly.
< gribble>
https://github.com/bitcoin/bitcoin/issues/17387 | wallet_importmulti: use addresses of the same type as being imported by achow101 . Pull Request #17387 . bitcoin/bitcoin . GitHub
< meshcollider>
I'll get to it ;)
< achow101>
alright, i'll just wait another 5 months then
< sipa>
achow101: my first PR in bitcoin core took 5 months to be merged, and that was 2011 :p
< wumpus>
at least we have somewhat more reviewers now
< wumpus>
but also tons more PR
< wumpus>
s
< fanquake>
?
< sipa>
we also have tests now
< luke-jr>
? tests
< wumpus>
yess
< wumpus>
fanquake: I think the environ issue is completely unrelated to #17538, though it is to #17525
< fanquake>
I think we'd potentially have to add an exception for environ
< fanquake>
I agree that the libc bumping only solves for getauxval()
< wumpus>
or remove the exported symbol check entirely, it was introduced back in the day because we had two conflicting OpenSSL implementations (one statically linkes, one part of system Qt), but with static linking of Qt this changed
< fanquake>
Ok.
< fanquake>
I was also somewhat relatedly thinking about extending the library checker to also work for the macOS binaries
< wumpus>
in general it's good to set the correct symbol privacy, but it's not something that can result in incompatibilities anymore, I think
< wumpus>
on the short term, adding environ as ane xception is probebly easiest
< wumpus>
but not as part of bumping the libc version, it's cimpletley unrelated to that
< fanquake>
Yep. I will gitian build master for linux and check all the symbols / libs, and can follow up with environ
< wumpus>
thanks!
< fanquake>
In the mean time, I'm going to merge #17550
< bitcoin-git>
bitcoin/master 55295fb Joao Barbosa: wallet: Lock address type in ReserveDestination
< bitcoin-git>
bitcoin/master 3958295 Joao Barbosa: wallet: LearnRelatedScripts only if KeepDestination
< bitcoin-git>
bitcoin/master 7127c31 Samuel Dobson: Merge #17237: wallet: LearnRelatedScripts only if KeepDestination
< bitcoin-git>
[bitcoin] meshcollider merged pull request #17237: wallet: LearnRelatedScripts only if KeepDestination (master...2019-10-wallet-reservedestination) https://github.com/bitcoin/bitcoin/pull/17237
< bitcoin-git>
[bitcoin] vasild opened pull request #17563: lib: fix a compiler warning: unused GetDevURandom() (master...unused-GetDevURandom) https://github.com/bitcoin/bitcoin/pull/17563
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #17564: rpc: Use mempool from node context instead of global (master...1911-rpcNoTxPoolGlobal) https://github.com/bitcoin/bitcoin/pull/17564
< bitcoin-git>
bitcoin/master 6a2e6b0 Gregory Sanders: Remove out of date comments for CalculateMaximumSignedTxSize
< bitcoin-git>
bitcoin/master 2a97d2b Samuel Dobson: Merge #17553: wallet: Remove out of date comments for CalculateMaximumSign...
< bitcoin-git>
[bitcoin] meshcollider merged pull request #17553: wallet: Remove out of date comments for CalculateMaximumSignedTxSize (master...calc_max_size_comment) https://github.com/bitcoin/bitcoin/pull/17553
< bitcoin-git>
bitcoin/master 7d7bf2f fanquake: build: set minimum supported macOS to 10.12
< bitcoin-git>
bitcoin/master a6f5b6f fanquake: Merge #17550: build: set minimum supported macOS to 10.12
< bitcoin-git>
[bitcoin] fanquake merged pull request #17550: build: set minimum supported macOS to 10.12 (master...macOS_10_12_minimum) https://github.com/bitcoin/bitcoin/pull/17550
< meshcollider>
quick review beg for #17387 please
< gribble>
https://github.com/bitcoin/bitcoin/issues/17387 | wallet_importmulti: use addresses of the same type as being imported by achow101 . Pull Request #17387 . bitcoin/bitcoin . GitHub
< bitcoin-git>
bitcoin/master b84e776 Andrew Chow: wallet_importmulti: use addresses of the same type as being imported
< bitcoin-git>
bitcoin/master 4effd67 Samuel Dobson: Merge #17387: wallet_importmulti: use addresses of the same type as being ...
< bitcoin-git>
[bitcoin] meshcollider merged pull request #17387: wallet_importmulti: use addresses of the same type as being imported (master...tests-fix-getaddrinfo-type-consistency) https://github.com/bitcoin/bitcoin/pull/17387
< bitcoin-git>
[bitcoin] darosior opened pull request #17566: Switch to weight units for all feerates computation (master...feerate_in_weight) https://github.com/bitcoin/bitcoin/pull/17566
< meshcollider>
oops darosior's PR needs rebase already, its only been open 8 minutes
< darosior>
^^
< darosior>
Rebased
< wumpus>
at least it's not due to some collision in a linter file
< fanquake>
heh
< luke-jr>
wumpus: but it is?
< luke-jr>
jk
< jnewbery>
I'd like to shill jkczyz's PR #16688 for those who haven't seen it. CValidationInterface logging (together with the thread logging that we've had since #15849 courtesy of jamesob) make it really easy to see what's going on with the various threads in bitcoind.
< warren>
Regarding new lists, I should have been more specific that the server is for only FOSS and strongly preferred to be pertaining to open common infrastructure, specifications or standards. If you want lists for a niche or commercial project you probably should instead use Google Groups. More thought will be put into guidelines but this is the rough idea I think.