< meshcollider>
wumpus, achow101: the thing with #17290 is that it only has 2 people review it, but no one else seems to want to touch coin selection
< gribble>
https://github.com/bitcoin/bitcoin/issues/17290 | Enable BnB coin selection for preset inputs and subtract fee from outputs by achow101 . Pull Request #17290 . bitcoin/bitcoin . GitHub
< achow101>
touch it then :)
< meshcollider>
I'm happy to merge it if no one will complain about it not getting enough review, but I'm not confident enough with coin selection myself to review it properly
< meshcollider>
instagibbs and provoostenator are both good reviewers though
< provoostenator>
I spammed morcos's #12605 to get some more reviews.
< bitcoin-git>
[bitcoin] theStack opened pull request #17532: test: add functional test for non-standard txs with too large scriptSig (master...20191120-test-check-for-too-large-scriptsig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17532
< bitcoin-git>
bitcoin/master 47101bb Ben Woosley: scripted-diff: Rename CPubKey and CKey::*_KEY_SIZE and COMPRESSED_*_KEY_SI...
< bitcoin-git>
bitcoin/master 0580f86 Ben Woosley: Fixup whitespace
< bitcoin-git>
bitcoin/master 36191a8 Wladimir J. van der Laan: Merge #12461: scripted-diff: Rename key size consts to be relative to thei...
< bitcoin-git>
[bitcoin] laanwj merged pull request #12461: scripted-diff: Rename key size consts to be relative to their class (master...key-size-consts) https://github.com/bitcoin/bitcoin/pull/12461
< wumpus>
it helps that it needs to be merged to get gitian working again
< wumpus>
getauxval implementation is pretty scary (dl_hwcap etc interfaces with the dynamic linker / crt code): https://code.woboq.org/userspace/glibc/misc/getauxval.c.html, I don't think implementing it as part of the compatibility wrapper is a realistic alternative
< bitcoin-git>
[bitcoin] laanwj closed pull request #17531: Bump minimum libc to 2.19 for release binaries (master...2019_11_bump_libc) https://github.com/bitcoin/bitcoin/pull/17531
< fanquake>
Well. I guess we'll revert those changes out of random then?
< wumpus>
I'll leave it to someone else
< wumpus>
leveldb needs it too on ARM
< wumpus>
at least the new one
< wumpus>
(e.g. to find out if crc32c acceleration is available)
< wumpus>
there's no way around requiring it at some point
< fanquake>
Right. So the 1.22 upgrade is blocked but the same problem right now?
< MarcoFalke>
wumpus: Sorry for not providing context. I think 2.17 should be good
< wumpus>
but I don't like this eternal race to the bottom of version support, I really don't have the energy for this
< wumpus>
MarcoFalke: ok
< MarcoFalke>
I think debian and red hat are the only lts versions
< MarcoFalke>
*LTS
< fanquake>
MarcoFalke: 2.17 doesn't fix the issues right?
< bitcoin-git>
bitcoin/master 8944c1d dannmat: Changed tooltips of receive form to highlight difference between Label and...
< bitcoin-git>
bitcoin/master 26744ae Wladimir J. van der Laan: Merge #17446: gui: Changed tooltip for 'Label' & 'Message' text fields to ...
< bitcoin-git>
[bitcoin] laanwj merged pull request #17446: gui: Changed tooltip for 'Label' & 'Message' text fields to be more clear (master...Nov-19-Remove-Message-Input) https://github.com/bitcoin/bitcoin/pull/17446
< kanzure>
re: "unannounced server migration", there has been substantial warning for a while now, but linux foundation did not give us an exact date
< kanzure>
and they just did it without notifying me. sorry i couldn't provide more timely information.
< wumpus>
I had the same problem with my Odroid C2 but managed to fix it by powering it from a power brick instead of USB, but that's a problem with that particular board not a generic one :shrug:
< bitcoin-git>
bitcoin/master 8f2d773 Sebastian Falbesoner: test: add functional test for non-standard txs with too large scriptSig
< bitcoin-git>
bitcoin/master 3671c57 fanquake: Merge #17532: test: add functional test for non-standard txs with too larg...
< bitcoin-git>
[bitcoin] fanquake merged pull request #17532: test: add functional test for non-standard txs with too large scriptSig (master...20191120-test-check-for-too-large-scriptsig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17532
< bitcoin-git>
[bitcoin] jonatack opened pull request #17535: test: add block height test to listsinceblock.py (master...rpc-wallet-blockheight-followups) https://github.com/bitcoin/bitcoin/pull/17535
< bitcoin-git>
[bitcoin] emilengler opened pull request #17536: test: Add test for rpc_whitelist (master...2019-11-jeremyrubin-whitelistrpc-meta) https://github.com/bitcoin/bitcoin/pull/17536
< MarcoFalke>
I am pretty sure the test framwork needs at least getblockcount permissions to check when the rpc thread is running
< MarcoFalke>
rpcwhitelistdefault=1 disables all rpcs, right? So that wouldn't work.
< emilengler>
MarcoFalke: user1 has the permisson to getblockcount
< emilengler>
MarcoFalke: I'm actually not 100% sure let me try
< emilengler>
Yes it restricts accesss to all RPC commands
< emilengler>
It rutrns an 403 then
< MarcoFalke>
I guess 403 is sufficient, as long as it is not a timeout or conenction error?
< emilengler>
Yes
< emilengler>
But still I need to change it after the test was already launceh
< emilengler>
It would require a restart of bitcond
< emilengler>
bitcoind*
< MarcoFalke>
Yeah, just call `(re)start_node` and fixup `wait_for_rpc_connection` to return on 403
< emilengler>
I'm a bit confused, where should I call (re)start_node and how can I modify the cli args then?
< emilengler>
After run_tests()?
< emilengler>
run_test()*
< instagibbs_>
can someone remind me/show an example of wallet endpoint selection for python framework
< MarcoFalke>
emilengler: If you want to modify the conf file, you'd have to stop the node and then start it again
< MarcoFalke>
Same for command line args
< MarcoFalke>
instagibbs_: wallet_multiwallet
< MarcoFalke>
.py
< instagibbs_>
dank
< sipa>
are release linux binaries build with zmq support included?
< instagibbs_>
for players at home: "node.get_wallet_rpc(new_wallet_name)"
< MarcoFalke>
sipa: yes
< sipa>
MarcoFalke: statically linked?
< MarcoFalke>
I would believe everything in the gitian binaries is statically linked
< emilengler>
MarcoFalke: Which function restarts the node?
< MarcoFalke>
the function in the test_framework `def restart_node(...`
< MarcoFalke>
or `def stop_node` and `def start_node`
< instagibbs_>
"CHECK_NONFATAL(condition) should be used instead of assert for RPC code." what. I don't see any instances of that string in the codebase....
< instagibbs_>
(linter output)
< instagibbs_>
or is that like... paraphrasing that it shouldn't blow up and rather return an error in json
< MarcoFalke>
instagibbs_: Have you run `git grep CHECK_NONFATAL bitcoin/master`?
< MarcoFalke>
There should be plenty
< instagibbs_>
oh, guess i havent rebased in a long time, thanks
< bitcoin-git>
[bitcoin] theStack opened pull request #17541: test: add functional test for non-standard bare multisig txs (master...20191120-test-for-bare-multisig-in-mempool_accept) https://github.com/bitcoin/bitcoin/pull/17541
< bitcoin-git>
[bitcoin] brakmic opened pull request #17542: build: Create test utility library from src/test/util/ (master...test-util-lib) https://github.com/bitcoin/bitcoin/pull/17542
< fanquake>
sipa did you have a particular question in regards to zmq?
< bitcoin-git>
[bitcoin] ariard opened pull request #17543: Wallet: undo conflicts properly in case of blocks disconnection (master...2019-11-fix-wallet-unconflicts) https://github.com/bitcoin/bitcoin/pull/17543
< fanquake>
sipa yea I am. For a little while longer yet.
< bitcoin-git>
bitcoin/master fa00393 MarcoFalke: ci: Make all filesystem operations inside docker
< bitcoin-git>
bitcoin/master fab1333 MarcoFalke: ci: Remove git from required packages on host
< bitcoin-git>
bitcoin/master fa493ef MarcoFalke: ci: Make ci system read-only on the git work tree
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #17423: ci: Make ci system read-only on the git work tree (master...1911-ciRo) https://github.com/bitcoin/bitcoin/pull/17423
< bitcoin-git>
[bitcoin] fanquake opened pull request #17545: build: remove libanl.so.1 from ALLOWED_LIBRARIES (master...remove_libanl_from_allowed_symbols) https://github.com/bitcoin/bitcoin/pull/17545