< bitcoin-git> [bitcoin] kallewoof closed pull request #12911: wallet: Show fee in results for signrawtransaction* for segwit inputs (master...sign-show-fees) https://github.com/bitcoin/bitcoin/pull/12911
< bitcoin-git> [bitcoin] MarcoFalke pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/ccb2c9e7891a...6fb4bbfb0e5f
< bitcoin-git> bitcoin/master eb7c50c practicalswift: tests: Add common Consume* fuzzing functions
< bitcoin-git> bitcoin/master 65a52a0 practicalswift: tests: Add fuzzing harness for CScript operations
< bitcoin-git> bitcoin/master e7ddbd9 practicalswift: tests: Add fuzzing harness for CScriptNum operations
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18176: tests: Add fuzzing harness for CScript and CScriptNum operations (master...fuzzers-script_ops) https://github.com/bitcoin/bitcoin/pull/18176
< bitcoin-git> [bitcoin] practicalswift closed pull request #16136: Add an optional extra level of checking: ASSUME(...) - an opt-in side-effect safe assert(...) (master...check) https://github.com/bitcoin/bitcoin/pull/16136
< bitcoin-git> [bitcoin] practicalswift closed pull request #17639: tests: Add "make check-valgrind" to run the unit tests under Valgrind (master...make-check-valgrind) https://github.com/bitcoin/bitcoin/pull/17639
< bitcoin-git> [bitcoin] practicalswift closed pull request #17208: Make all tests pass UBSan without using any UBSan suppressions (master...ubsan-warnings) https://github.com/bitcoin/bitcoin/pull/17208
< bitcoin-git> [bitcoin] practicalswift closed pull request #17894: tests: Avoid accumulating allocated memory in a global state if LogPrintf is called when fuzzing (master...fuzzers-deserialize-enable-logging) https://github.com/bitcoin/bitcoin/pull/17894
< vasild> We use std::rename() (https://github.com/bitcoin/bitcoin/blob/master/src/util/system.cpp#L897) assuming that the destination will be overwritten if it exists. However, according to https://en.cppreference.com/w/cpp/io/c/rename "If new_filename exists, the behavior is implementation-defined."
< vasild> I guess its ok for the time being, but better switch to std::filesystem::rename() once C++17 hits the tree.
< bitcoin-git> [bitcoin] fanquake closed pull request #13972: Remove 16 bits from versionbits signalling system (BIP320) (master...reservedbits2) https://github.com/bitcoin/bitcoin/pull/13972
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6fb4bbfb0e5f...1a97c9a483e5
< bitcoin-git> bitcoin/master cbf2d75 João Barbosa: qa: Add getdescriptorinfo functional test
< bitcoin-git> bitcoin/master 1a97c9a MarcoFalke: Merge #15443: qa: Add getdescriptorinfo functional test
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #15443: qa: Add getdescriptorinfo functional test (master...2019-02-qa-feature-descriptor) https://github.com/bitcoin/bitcoin/pull/15443
< bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/1a97c9a483e5...5d92ac26ed89
< bitcoin-git> bitcoin/master 1d0a87e fanquake: build: remove chrono package from depends Boost
< bitcoin-git> bitcoin/master bd37f2b fanquake: build: remove Boost Chrono detection from build system
< bitcoin-git> bitcoin/master e21fa54 fanquake: test: remove Boost Chrono installation from CI
< bitcoin-git> [bitcoin] fanquake merged pull request #18264: build: Remove Boost Chrono (master...dump_boost_chrono) https://github.com/bitcoin/bitcoin/pull/18264
< bitcoin-git> [bitcoin] practicalswift opened pull request #18308: depends: Make it possible to build Boost dependency using a toolset other than gcc (./b2 toolset=gcc) (master...b2-toolset-clang) https://github.com/bitcoin/bitcoin/pull/18308
< bitcoin-git> [bitcoin] n-thumann opened pull request #18309: zmq: Add support to listen on multiple interfaces (master...zmq-listen-multiple-interfaces) https://github.com/bitcoin/bitcoin/pull/18309
< bitcoin-git> [bitcoin] jonatack opened pull request #18310: doc: asmap release note (master...asmap-release-note) https://github.com/bitcoin/bitcoin/pull/18310
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5d92ac26ed89...cf4cb28efcf8
< bitcoin-git> bitcoin/master ffff9dc MarcoFalke: test: Explain why test logging should be used
< bitcoin-git> bitcoin/master cf4cb28 MarcoFalke: Merge #18305: test: Explain why test logging should be used
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18305: test: Explain why test logging should be used (master...2003-docWhyTestLog) https://github.com/bitcoin/bitcoin/pull/18305
< jonatack> instagibbs: totalFee in rpc bumpfee was deprecated in 0.19 and should be removed for 0.20, yes?
< bitcoin-git> [bitcoin] instagibbs opened pull request #18311: Bumpfee test fix (master...bumpfee_test_fix) https://github.com/bitcoin/bitcoin/pull/18311
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cf4cb28efcf8...b5c7665e3083
< bitcoin-git> bitcoin/master 2e4edc6 Gregory Sanders: Add some test logging to wallet_bumpfee.py
< bitcoin-git> bitcoin/master f1b4503 Gregory Sanders: bumpfee test: exit loop at proper time with new fee value being compared
< bitcoin-git> bitcoin/master b5c7665 MarcoFalke: Merge #18311: Bumpfee test fix
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18311: Bumpfee test fix (master...bumpfee_test_fix) https://github.com/bitcoin/bitcoin/pull/18311
< bitcoin-git> [bitcoin] dannmat closed pull request #18291: Changed the date format on Block Syncing overlay (master...mar-20-date-format-string) https://github.com/bitcoin/bitcoin/pull/18291
< bitcoin-git> [bitcoin] jonatack opened pull request #18312: wallet: remove deprecated totalFee argument from fee bumping (master...rpc-bumpfee-remove-deprecated-totalFee) https://github.com/bitcoin/bitcoin/pull/18312
< promag> fanquake ryanofsky provoostenator: #18280
< gribble> https://github.com/bitcoin/bitcoin/issues/18280 | wallet: UnregisterValidationInterface before SyncWithValidationInterfaceQueue by promag · Pull Request #18280 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] promag closed pull request #15341: rpc: Support specifying change address in bumpfee (master...2019-01-bumpfee-changeaddress) https://github.com/bitcoin/bitcoin/pull/15341
< bitcoin-git> [bitcoin] za-kk opened pull request #18313: gui: fix font inconsistency on send coins form (master...march-gui-font) https://github.com/bitcoin/bitcoin/pull/18313
< ysangkok> ryanofsky: vasild linked a line in that function, so he knows there is a RenameOver link. I believe he is pointing out that its contents is 'implementation-defined' on non-Win32, since that part of the function uses std::rename.