< bitcoin-git>
[bitcoin] dongcarl opened pull request #18478: build: Automatically include both `git`-tracked and bootstrapped files. (master...2020-03-adventures-in-reconciling-automake-and-git) https://github.com/bitcoin/bitcoin/pull/18478
< ryanofsky>
gwillen: where is the option on github commit pages to "create a branch from it"?
< ryanofsky>
the only way i've found to download orphan commits on github not on a known tag or branch is to use web api and reconstruct tree and commit objects locally
< gwillen>
ryanofsky: yeah it's slightly tricky, I'm not sure whether or how you can easily reach it directly from the GUI
< gwillen>
then if you change the "commit" in the URL to "commits", you get a different view, like, the branch view from that tip
< gwillen>
then if you click "Tree: NNNNNNN" you should be able to commit a branch, if you have that permission on the repo you're looking at
< gwillen>
er, create* a branch
< kallewoof>
I can't restart travis jobs for some reason.
< sipa>
kallewoof: try logging out and back in
< kallewoof>
sipa: that fixed it. thanks!
< sipa>
i've experienced it as well since a few days
< sipa>
i don't know what causes it
< fanquake>
sipa: can you block Domel1985
< sipa>
again?
< fanquake>
In the bitcoin/bitcoin repo now
< sipa>
ah, from different repo
< sipa>
Done.
< bitcoin-git>
[bitcoin] luke-jr opened pull request #18479: RPC: Show fee in results for signrawtransaction* for segwit inputs (master...rpc_sign_show_fees) https://github.com/bitcoin/bitcoin/pull/18479
< wumpus>
vasild: yup tarballs work fine for 'orphaned' commits, downloading patches/diffs also works, but never found a trick to be able to do it with git itself
< wumpus>
(or alternatively, to download a tarball w/ .git directory, or say, a git bundle for a commit range)
< vasild>
I have already forked the repo in my github account, so I cannot fork it a second time to check whether the orphaned commits will be copied into my fork (where I would have write permissions)
< wumpus>
oh interesting! that's at least something, though, I'd most frequently wanted it for other people's commits and don't tend to have write access to them
< lucaferr>
How does peer protocol command "notfound" behave when a "getdata" request only partially matches. Will it return a partial result plus "notfound", or will it only return "notfound"?
< wumpus>
haaaah fork their repository first, of course
< wumpus>
lucaferr: it either returns a (partial) result or "notfound" never both IIRC
< lucaferr>
wumpus: great, thank you
< vasild_>
wumpus: but when I go to https://github.com/practicalswift/bitcoin and try to "Fork" it into my account I am redirected to vasild/bitcoin (nothing gets forked)
< jonasschnelli>
Can we consider #18160 a bugfix? I'd like to get that into 0.20?
< sipa>
lucaferr: it will respond with tx/blocks for the found things, and a notfound for the rest
< lucaferr>
sipa: ah, ok. So the arity will match between the requested inventory vectors and the notfound inventory plus data messages (tx or block)?
< wumpus>
sipa: oh you're right, I was confused with how 'reject' messages used to be handled
< lucaferr>
wumpus, sipa: thanks to both for replying :)
< bitcoin-git>
[bitcoin] theStack opened pull request #18481: test: add BIP37 'filterclear' test to p2p_filter.py (master...20200330-test-add-BIP37-filterclear-message) https://github.com/bitcoin/bitcoin/pull/18481
< wumpus>
jonasschnelli: yes, I think it's a fix of some kind
< wumpus>
jonasschnelli: I was holding it off because of the idea to merge #17905 first, which isn't merged yet, seems too late to merge both now (and do a last-minute rebase of the latter)