< vasild> ryanofsky: ysangkok: yes, RenameOver() uses std::rename(). I presume "all" platforms overwrite the destination, but maybe not in an atomic manner. Better to switch to the C++17 variant (once we enable C++17).
< elichai2> MarcoFalke: I like your new github avatar ;)
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b5c7665e3083...16dfaed1b732
< bitcoin-git> bitcoin/master 4444edc MarcoFalke: ci: Enable all functional tests in valgrind
< bitcoin-git> bitcoin/master 16dfaed MarcoFalke: Merge #18304: ci: Enable all functional tests in valgrind
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18304: ci: Enable all functional tests in valgrind (master...2003-ciAllVal) https://github.com/bitcoin/bitcoin/pull/18304
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/16dfaed1b732...f1064c1b0d10
< bitcoin-git> bitcoin/master fd1dae1 practicalswift: tests: Add fuzzing harness for ProcessMessage(...)
< bitcoin-git> bitcoin/master 9220a0f practicalswift: tests: Add one specialized ProcessMessage(...) fuzzing binary per message ...
< bitcoin-git> bitcoin/master f1064c1 MarcoFalke: Merge #17989: tests: Add fuzzing harness for ProcessMessage(...). Enables ...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17989: tests: Add fuzzing harness for ProcessMessage(...). Enables high-level fuzzing of the P2P layer. (master...fuzzers-net-process_message) https://github.com/bitcoin/bitcoin/pull/17989
< bitcoin-git> [bitcoin] practicalswift opened pull request #18314: tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot). Increase fuzzing coverage. (master...fuzzers-deserialize-more) https://github.com/bitcoin/bitcoin/pull/18314
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/f1064c1b0d10...9c507a77f7a1
< bitcoin-git> bitcoin/master ac73afb Jon Atack: doc: asmap release note
< bitcoin-git> bitcoin/master 9c507a7 MarcoFalke: Merge #18310: doc: asmap release note
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18310: doc: asmap release note (master...asmap-release-note) https://github.com/bitcoin/bitcoin/pull/18310
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18300: fuzz: Add option to merge input dir to test runner (master...Mf1902-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/18300
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18300: fuzz: Add option to merge input dir to test runner (master...Mf1902-fuzzMerge) https://github.com/bitcoin/bitcoin/pull/18300
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9c507a77f7a1...b813fbe804a3
< bitcoin-git> bitcoin/master 2a6bce4 Carnhof Daki: doc: Add a note about backporting
< bitcoin-git> bitcoin/master b813fbe MarcoFalke: Merge #17159: doc: Add a note about backporting
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17159: doc: Add a note about backporting (master...cdk/doc-backports) https://github.com/bitcoin/bitcoin/pull/17159
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b813fbe804a3...90b3e59caf2e
< bitcoin-git> bitcoin/master 155a11f Elichai Turkel: doc: Added running functional tests in valgrind
< bitcoin-git> bitcoin/master 90b3e59 MarcoFalke: Merge #17833: doc: Added running functional tests in valgrind
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #17833: doc: Added running functional tests in valgrind (master...patch-1) https://github.com/bitcoin/bitcoin/pull/17833
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/90b3e59caf2e...377eed564e10
< bitcoin-git> bitcoin/master 7ba9622 Travin Keith: doc: Minor grammatical changes and flow improvements
< bitcoin-git> bitcoin/master 377eed5 MarcoFalke: Merge #18170: doc: Minor grammatical changes and flow improvements
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18170: doc: Minor grammatical changes and flow improvements (master...patch-2) https://github.com/bitcoin/bitcoin/pull/18170
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/377eed564e10...2926cbcebb70
< bitcoin-git> bitcoin/master c1e0742 Albert: doc: Warn about wallet.dat re-use and backups
< bitcoin-git> bitcoin/master 2926cbc MarcoFalke: Merge #18219: doc: Add warning against wallet.dat re-use
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18219: doc: Add warning against wallet.dat re-use (master...doc-wallet-copy) https://github.com/bitcoin/bitcoin/pull/18219
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2926cbcebb70...414f6c496d9c
< bitcoin-git> bitcoin/master fa12447 MarcoFalke: doc: Explain rebase/squash policy in CONTRIBUTING.md
< bitcoin-git> bitcoin/master 414f6c4 Wladimir J. van der Laan: Merge #18283: doc: Explain rebase policy in CONTRIBUTING.md
< bitcoin-git> [bitcoin] laanwj merged pull request #18283: doc: Explain rebase policy in CONTRIBUTING.md (master...2003-docRebase) https://github.com/bitcoin/bitcoin/pull/18283
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/414f6c496d9c...d20d5dc82426
< bitcoin-git> bitcoin/master fab7d14 MarcoFalke: test: Check that wait_until returns if time point is in the past
< bitcoin-git> bitcoin/master d20d5dc Wladimir J. van der Laan: Merge #18285: test: Check that wait_until returns if time point is in the ...
< bitcoin-git> [bitcoin] laanwj merged pull request #18285: test: Check that wait_until returns if time point is in the past (master...2002-debugBoost) https://github.com/bitcoin/bitcoin/pull/18285
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d20d5dc82426...3b21a7863411
< bitcoin-git> bitcoin/master ddc7e42 Hennadii Stepanov: build: Set minimum Automake version to 1.13
< bitcoin-git> bitcoin/master 3b21a78 Wladimir J. van der Laan: Merge #18290: build: Set minimum Automake version to 1.13
< bitcoin-git> [bitcoin] laanwj merged pull request #18290: build: Set minimum Automake version to 1.13 (master...20200307-automake-version) https://github.com/bitcoin/bitcoin/pull/18290
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3b21a7863411...24a727e23e41
< bitcoin-git> bitcoin/master faae5a9 MarcoFalke: test: Add bad-txns-*-toolarge test cases to invalid_txs
< bitcoin-git> bitcoin/master 24a727e Wladimir J. van der Laan: Merge #18255: test: Add bad-txns-*-toolarge test cases to invalid_txs
< bitcoin-git> [bitcoin] laanwj merged pull request #18255: test: Add bad-txns-*-toolarge test cases to invalid_txs (master...2003-testTooLarge) https://github.com/bitcoin/bitcoin/pull/18255
< luke-jr> wumpus: I'm not a Windows-minded dev.. :P
< bitcoin-git> [bitcoin] jonatack opened pull request #18316: util: HelpExampleRpc formatting (master...json-rpc-example-template-formatting) https://github.com/bitcoin/bitcoin/pull/18316
< wumpus> luke-jr: sorry, just meant you have more PRs regarding windows
< wumpus> as maintainer I definitely know too that this is often not by choice :)
< luke-jr> XD
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/24a727e23e41...0eebe45cf7c6
< bitcoin-git> bitcoin/master 3e32499 Yusuf Sahin HAMZA: Change example addresses to bech32
< bitcoin-git> bitcoin/master 0eebe45 MarcoFalke: Merge #18208: rpc: Change RPCExamples to bech32
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18208: rpc: Change RPCExamples to bech32 (master...fix-rpc-examples) https://github.com/bitcoin/bitcoin/pull/18208
< hebasto> jonasschnelli: it seems https://bitcoinbuilds.org has a problem with boost on ARM...
< bitcoin-git> [bitcoin] sipa opened pull request #18317: Serialization improvements step 6 (all except wallet/gui) (master...202003_noncastserial_6) https://github.com/bitcoin/bitcoin/pull/18317
< bitcoin-git> [bitcoin] MarcoFalke pushed 13 commits to master: https://github.com/bitcoin/bitcoin/compare/0eebe45cf7c6...249114b1a6a4
< bitcoin-git> bitcoin/master 7b169ca practicalswift: tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot), ui...
< bitcoin-git> bitcoin/master 516cc6f practicalswift: tests: Remove unit test from fuzzing harness
< bitcoin-git> bitcoin/master 46ef4cf practicalswift: tests: Re-arrange test cases in parse_univalue to increase coverage
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18314: tests: Add deserialization fuzzing of SnapshotMetadata (utxo_snapshot). Increase fuzzing coverage. (master...fuzzers-deserialize-more) https://github.com/bitcoin/bitcoin/pull/18314
< hebasto> what is the current status of #17104?
< gribble> https://github.com/bitcoin/bitcoin/issues/17104 | build: `make dist` uses `git archive` by ch4ot1c · Pull Request #17104 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18318: test: Bump rpc timeout in feature_assumevalid to avoid valgrind timeouts (master...2003-ciBumpTimeouts) https://github.com/bitcoin/bitcoin/pull/18318
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/249114b1a6a4...58c72880ff70
< bitcoin-git> bitcoin/master 8a2a652 David O'Callaghan: Remove redundant type information from rpc docs
< bitcoin-git> bitcoin/master 58c7288 MarcoFalke: Merge #18268: rpc: Remove redundant types from descriptions
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18268: rpc: Remove redundant types from descriptions (master...#18258_rpc_doc_type_cleanup) https://github.com/bitcoin/bitcoin/pull/18268
< wumpus> hebasto: good question!
< wumpus> hebasto: I'd really like to see progress on that but I don't know enough about build system internals to comment on it
< hebasto> wumpus: it seems its author (ch4ot1c) is not active on gh since december
< hebasto> wumpus: label it "Up for grabs" ?
< wumpus> ok
< Chris_Stewart_5> sdaftuar_: In regards to your wtxid proposal, what is the reason for adding new messages rather than just repurposing the protocol version field or service identifier as bitvectors?
< sipa> Chris_Stewart_5: limited namespace
< sipa> version numbers are sequential, making arbitrary subsets of features hard, and changing them to be bitvectors would make them grow much faster
< sipa> service flags are only used for discoverable properties (as those are rumoured on the P2P network in addr messages)
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #13693: [test] Add coverage to estimaterawfee and estimatesmartfee (master...test-estimatefee) https://github.com/bitcoin/bitcoin/pull/13693
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #13693: [test] Add coverage to estimaterawfee and estimatesmartfee (master...test-estimatefee) https://github.com/bitcoin/bitcoin/pull/13693
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18319: fuzz: Add missing ECC_Start to key_io test (master...2003-fuzzKeyIo) https://github.com/bitcoin/bitcoin/pull/18319
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/58c72880ff70...309b0c4c1931
< bitcoin-git> bitcoin/master 111880a Ben Woosley: [test] Add coverage to estimaterawfee and estimatesmartfee
< bitcoin-git> bitcoin/master 309b0c4 MarcoFalke: Merge #13693: [test] Add coverage to estimaterawfee and estimatesmartfee
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/309b0c4c1931...5c73645ac79f
< bitcoin-git> bitcoin/master bbbbb53 MarcoFalke: fuzz: Add missing ECC_Start to key_io test
< bitcoin-git> bitcoin/master 5c73645 MarcoFalke: Merge #18319: fuzz: Add missing ECC_Start to key_io test
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18319: fuzz: Add missing ECC_Start to key_io test (master...2003-fuzzKeyIo) https://github.com/bitcoin/bitcoin/pull/18319
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #13693: [test] Add coverage to estimaterawfee and estimatesmartfee (master...test-estimatefee) https://github.com/bitcoin/bitcoin/pull/13693
< bitcoin-git> [bitcoin] dongcarl opened pull request #18320: guix: Remove now-unnecessary gcc make flag (master...2020-03-fix-ssp-in-guix) https://github.com/bitcoin/bitcoin/pull/18320
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5c73645ac79f...9cc7eba1b565
< bitcoin-git> bitcoin/master fa72d27 MarcoFalke: test: Bump walletpassphrase timeouts in wallet_createwallet to avoid valgr...
< bitcoin-git> bitcoin/master fa9b304 MarcoFalke: test: Bump rpc timeout in feature_assumevalid to avoid valgrind timeouts
< bitcoin-git> bitcoin/master 9cc7eba MarcoFalke: Merge #18318: test: Bump rpc timeout in feature_assumevalid to avoid valgr...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18318: test: Bump rpc timeout in feature_assumevalid to avoid valgrind timeouts (master...2003-ciBumpTimeouts) https://github.com/bitcoin/bitcoin/pull/18318
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18322: refactor: Add params to node context (master...2003-nodeParams) https://github.com/bitcoin/bitcoin/pull/18322
< bitcoin-git> [bitcoin] niftynei opened pull request #18323: http nit (master...nifty/http-nit) https://github.com/bitcoin/bitcoin/pull/18323
< promag> so valgrind job in travis can take more than 2hours?
< aj> wow drahtbot got a vocab upgrade
< sipa> ?
< sipa> ha