< bitcoin-git>
[bitcoin] luke-jr opened pull request #18469: Build: Move wallet RPCs to their own libbitcoin_walletrpcs module (master...libbitcoin_walletrpcs) https://github.com/bitcoin/bitcoin/pull/18469
< elichai2>
what's the smallest possible transaction someone can construct? I guess the smallest is spending a utxo that has OP_TRUE, with an empty scriptSig, and no outputs. (means: version(4)+ txInCount(1) + TxIn(prevout(36)+script_length(1)+script(0)+nSequence(4)) + TxOutCount(1)+TxOut(0) + txWitness(0)+lockTime(4) == 51?)
< harding>
elichai2: I don't think you can have an empty TxOut.
< promag>
hebasto: I was not aware of minimumDuration
< hebasto>
promag: no minimumDuration on macOS?
< lucaferr>
When sending getdata with a number of inv references, how does notfound behave? Let’s say some references are valid and some notfound. Will it fail the whole request with notfound or provide some block/tx?
< promag>
hebasto: the progress popups ups and goes away just before the error dialog
< promag>
hebasto: apparently it's platform specific
< promag>
hebasto: latest commit should prevent the progress dialog showing up
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18470: net: Make stale tip check time type-safe, extend test (master...2003-testEviction) https://github.com/bitcoin/bitcoin/pull/18470
< promag>
hebasto: :) \o/
< hebasto>
promag: :)
< * luke-jr>
stabs static linking
< luke-jr>
ryanofsky: it would be nice to avoid building dead code (wallet/rpc*) until bitcoin-wallet actually uses it?
< bitcoin-git>
bitcoin/master e980214 pierrenn: serialization: prevent int overflow for big Coin::nHeight
< bitcoin-git>
bitcoin/master 6a11d9e fanquake: Merge #18433: serialization: prevent int overflow for big Coin::nHeight
< bitcoin-git>
[bitcoin] fanquake merged pull request #18433: serialization: prevent int overflow for big Coin::nHeight (master...fix-coin-serialize) https://github.com/bitcoin/bitcoin/pull/18433
< fanquake>
I know I owe review comments and have PRs that need changes. Have an email back log & will try dead with it all tomorrow. Sorry if I'm holding anyone up.
< hebasto>
ryanofsky: thank you for knowledge sharing
< luke-jr>
ryanofsky: any idea why bench_bitcoin is failing to link? :/
< stevenroose>
All feerates in Core are calculated on the actual tx size with witnesses, right? Never on the witness-free size and only on weight if explicit "per weight", that correct?
< sipa>
stevenroose: it's alwaya vsize based (which includes the witness size in its computation)
< bitcoin-git>
[bitcoin] promag opened pull request #18471: qa: Test shared validation interface (master...2020-03-test-shared-validation-interface) https://github.com/bitcoin/bitcoin/pull/18471
< luke-jr>
[19:29:48] <vasild> run git pull from the cron every 1 minute, forever, and never git-gc? ;-) <-- basically I do this
< luke-jr>
hourly tho
< vasild_>
luke-jr: you pull all PRs, refs/pull/*?
< luke-jr>
vasild_: refs/pull/*/head
< luke-jr>
I stopped caring about the /merge ones a while ago
< luke-jr>
too noisy and I've never seen a use for them
< vasild>
I think git-gc sometimes runs automatically, did you somehow disable it git gc.auto 0?
< luke-jr>
yes, globally
< vasild>
:)
< bitcoin-git>
[bitcoin] MarcoFalke opened pull request #18474: test: check that peer is connected when calling sync_* (master...2003-qaCheckConnSync) https://github.com/bitcoin/bitcoin/pull/18474
< jonatack>
luke-jr: same here
< jonatack>
before igoring the merged, previously i periodically ran git !git branch --merged | grep -v '\\*' | xargs -n 1 git branch -d to clear them out
< jeremyrubin>
This isn't correct or semantic IMO because we need to have next_it = update_it initially and update_it should not go into the new_cache_line, soi there isn't a great way to set that within the for loop.
< jeremyrubin>
Around the for loop handeling; that was my response
< hebasto>
jeremyrubin: moved it to UPDATED...
< hebasto>
jeremyrubin: "we need to have next_it = update_it initially" -- that is in my suggestion
< hebasto>
"update_it should not go into the new_cache_line" -- that is too, no?
< jonatack>
luke-jr: true, afaik it removes them from the git branch list but they can still be git checked out again
< sipa>
achow101: was it you who found how to access old github commits?
< stevenroose>
(1) estimation gives a feerate below -mintxfee and -minrelaytxfee and (2) fundraw with feerate: 1100sat/vB creates txs that -minrelaytxfee=1100sat/vB doesn't accept
< sipa>
stevenroose: huh
< gwillen>
sipa: yeah it was me
< gwillen>
if you can still open the commit on the github webpage, you can create a branch from it and check out the branch, but you can't check out a dangling commit directly
< gwillen>
vasild: ^
< gwillen>
I believe you can also fork the repo first and create the branch from the commit in a private fork, then check the branch out from there
< gwillen>
your way has fewer steps but my way gets the local copy into your actual local git repo, which is nice