< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/7f9dedb22dcd...0dc6218c7911
< bitcoin-git> bitcoin/master 100213c practicalswift: util: Fail to parse space-only strings in ParseMoney(...) (instead of pars...
< bitcoin-git> bitcoin/master 0dc6218 MarcoFalke: Merge #18270: util: Fail to parse whitespace-only strings in ParseMoney(.....
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18270: util: Fail to parse whitespace-only strings in ParseMoney(...) (instead of parsing as zero) (master...parsemoney-followup) https://github.com/bitcoin/bitcoin/pull/18270
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18038: P2P: Mempool tracks locally submitted transactions to improve wallet privacy (master...2020-01-unbroadcast) https://github.com/bitcoin/bitcoin/pull/18038
< bitcoin-git> [bitcoin] MarcoFalke reopened pull request #18038: P2P: Mempool tracks locally submitted transactions to improve wallet privacy (master...2020-01-unbroadcast) https://github.com/bitcoin/bitcoin/pull/18038
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/0dc6218c7911...e3154aacf444
< bitcoin-git> bitcoin/master d7930c4 practicalswift: tests: Add fuzzing harness for functions/classes in protocol.h
< bitcoin-git> bitcoin/master 7834c3b practicalswift: tests: Add fuzzing harness for functions/classes in chain.h
< bitcoin-git> bitcoin/master e3154aa MarcoFalke: Merge #18445: tests: Add fuzzing harnesses for functions/classes in chain....
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18445: tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h (master...fuzzers-misc-3) https://github.com/bitcoin/bitcoin/pull/18445
< bitcoin-git> [bitcoin] fjahr opened pull request #18446: test: Add test for wtxid transaction relay (master...pr18044test) https://github.com/bitcoin/bitcoin/pull/18446
< aj> fjahr: ooo
< fanquake> aaah
< aj> glen mcgrath
< fanquake> #legend
< bitcoin-git> [bitcoin] pierreN opened pull request #18447: test: add coverage for script parse error in ParseScript (master...fix-test-badscript) https://github.com/bitcoin/bitcoin/pull/18447
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3154aacf444...54646167db5e
< bitcoin-git> bitcoin/master 2b0fcff Pieter Wuille: Make VerifyWitnessProgram use a Span stack
< bitcoin-git> bitcoin/master 5464616 fanquake: Merge #18388: Make VerifyWitnessProgram use a Span stack
< bitcoin-git> [bitcoin] fanquake merged pull request #18388: Make VerifyWitnessProgram use a Span stack (master...202003_span_witstack) https://github.com/bitcoin/bitcoin/pull/18388
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/54646167db5e...b53af72b8276
< bitcoin-git> bitcoin/master 9ab14e4 pierrenn: Limit decimal range of numbers ParseScript accepts
< bitcoin-git> bitcoin/master b53af72 Wladimir J. van der Laan: Merge #18416: util: Limit decimal range of numbers ParseScript accepts
< bitcoin-git> [bitcoin] laanwj merged pull request #18416: util: Limit decimal range of numbers ParseScript accepts (master...fix-parsescript-numop-overflow) https://github.com/bitcoin/bitcoin/pull/18416
< fanquake> ! [rejected] master -> master (fetch first)
< fanquake> error: failed to push some refs to 'git@github.com:bitcoin/bitcoin'
< fanquake> 😢
< sipa> fanquake: collision!
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b53af72b8276...7eed413e72a2
< bitcoin-git> bitcoin/master ef35604 Sebastian Falbesoner: rpc: fix broken RPCExamples for waitforblock(height)
< bitcoin-git> bitcoin/master 7eed413 fanquake: Merge #18398: rpc: fix broken RPCExamples for waitforblock(height)
< bitcoin-git> [bitcoin] fanquake merged pull request #18398: rpc: fix broken RPCExamples for waitforblock(height) (master...20200321-rpc-fix-broken-rpcexamples-for-waitforblock-height) https://github.com/bitcoin/bitcoin/pull/18398
< picard276> https://pastebin.com/kdQPkELNif anyone can see why i am getting a 16: mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)failure...It's a p2sh transaction that was created on bitcoin core v0.16, 2 of 3 multisig, where 2 of the pub keys are uncompressed. I am trying to broadcast the transaction on
< picard276> bitcoin core v0.17 and v0.18 and i am getting the 16 error
< sipa> picard276: that most likely means that the signature is simply incorrect (or the wrong message was signed); please ask on bitcoin.stackexchange.com; this channel is not for support or generic bitcoin questions
< picard276> thanks
< pnn_m> hi guys, I'm `pierreN` on github. I've been trying to contribute to core since this week. thanks for people helping me 🙂
< fanquake> pnn_m: thanks for the contributions!
< pnn_m> yes I'm trying to start small with `good first issue` haha. it's nice to be able to chat directly on IRC so I joined the channel.
< pnn_m> wumpus (IRC): sorry for not getting your last comment (on why `atoi64` can overflow). in anycase it's true that `ParseInt32` (since the value can be signed) could be more adapted. I could open a new PR for that if you'd prefer ?
< vasild> Could somebody with MacOS help me and run this: "grep -r posix_fallocate /usr/include/". I couldn't find a man page for posix_fallocate() for MacOS online which probably means the function is not present, but I find it really hard to believe that. Thanks!
< jonatack> vasild: i'm not really a mac user, but i have one from 2012 running macOS 10.14.6 for testing bitcoin core, i don't have a usr/include dir, but grepping /usr is only finding results in usr/local/
< jonatack> and `man posix_fallocate` returns no manual entry
< fanquake> jonatack: you’ll probably want to look in your SDK dir
< vasild> no /usr/include :-O
< vasild> jonatack: but do you have the function in /usr/local/include?
< jonatack> vasild: so far it finds matches in third-party libs
< vasild> I see
< jonatack> python, erlang, mysql...
< jonatack> fanquake: thanks, looking
< fanquake> vasild: no posix_fallocate(). posix funcs I can see are here: https://gist.github.com/fanquake/30de56ff980b401b1f53e894bc376fee
< jonatack> ... clang, sqlite
< vasild> fanquake: Thanks! I guess this means that indeed posix_fallocate() is not available :/
< jonatack> fanquake: vasild: confirmed, no posix_fallocate matches for me in SDK dir either
< vasild> ack, thanks!
< bitcoin-git> [bitcoin] theStack opened pull request #18448: rpc: fix/add missing RPCExamples for "Util" RPCs (master...20200326-rpc-add-fix-rpcexamples-in-misc-category) https://github.com/bitcoin/bitcoin/pull/18448
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18449: util: Remove unused itostr (master...2003-utilNoIToStr) https://github.com/bitcoin/bitcoin/pull/18449
< bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/7eed413e72a2...bdc2644b72d6
< bitcoin-git> bitcoin/master faf2c5a MarcoFalke: build: Remove unused USE_COVERAGE
< bitcoin-git> bitcoin/master fac71e3 MarcoFalke: build: link fuzz/test_runner.py for out-of-tree builds
< bitcoin-git> bitcoin/master faf7d4f MarcoFalke: build: Add cov_fuzz target
< bitcoin-git> [bitcoin] laanwj merged pull request #18107: build: Add cov_fuzz target (master...2002-buildCovFuzz) https://github.com/bitcoin/bitcoin/pull/18107
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bdc2644b72d6...210b533a1144
< bitcoin-git> bitcoin/master dcda81c pierrenn: test: add coverage for script parse error in ParseScript
< bitcoin-git> bitcoin/master 210b533 MarcoFalke: Merge #18447: test: Add coverage for script parse error in ParseScript
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18447: test: Add coverage for script parse error in ParseScript (master...fix-test-badscript) https://github.com/bitcoin/bitcoin/pull/18447
< instagibbs> is travis alive?
< instagibbs> I'm only seeing appveyor in #17509 f.e.
< gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
< provoostenator> instagibbs: maybe they flagged me, though I'm not seeing an indication of that either
< provoostenator> Travis has the annoying habbit of silently stopping builds when they flag either an account or a project.
< provoostenator> "Hey why is Heroku not deploying my pushes to master anymore?" -> oh
< instagibbs> ok on website it looks like it's queued
< fjahr> instagibbs: provoostenator: it's more of an Github issue with Travis than a Travis issue alone, I have reported it a few days ago and it's supposed to be under review
< fjahr> It's been happening for 3-4 days at least
< promag> travis didn't pick latest #18338 :/
< gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] practicalswift opened pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git> [bitcoin] practicalswift closed pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git> [bitcoin] practicalswift reopened pull request #18450: util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting (master...locale-independence) https://github.com/bitcoin/bitcoin/pull/18450
< bitcoin-git> [bitcoin] jonatack opened pull request #18451: rpc: remove deprecated getunconfirmedbalance (master...remove-deprecated-rpc-getunconfirmedbalance) https://github.com/bitcoin/bitcoin/pull/18451
< bitcoin-git> [bitcoin] hebasto opened pull request #18452: qt: Fix shutdown when waitfor* cmds are called from RPC console (master...20200327-waitfor) https://github.com/bitcoin/bitcoin/pull/18452
< hebasto> promag: log in to https://travis-ci.org
< hebasto> it seems gh just not display travis data...
< jonatack> wallet meeting?
< provoostenator> I'm around
< provoostenator> Though reviewing descriptor wallet PR.
< achow101> wallet meeting?
< achow101> any wallet fixes for 0.20?
< jonatack> looks like #17509 is rfm
< gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
< achow101> #startmeeting
< lightningbot> Meeting started Fri Mar 27 19:04:42 2020 UTC. The chair is achow101. Information about MeetBot at http://wiki.debian.org/MeetBot.
< lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
< provoostenator> jonatack: I guess that missed the feature freeze?
< jonatack> ah
< jonatack> hi
< fjahr> hi
< provoostenator> hi
< achow101> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball ariard digi_james amiti fjahr
< achow101> jeremyrubin emilengler jonatack hebasto jb55
< bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/210b533a1144...f2c416bcf5f8
< bitcoin-git> bitcoin/master b837b33 Wladimir J. van der Laan: net: Fail instead of truncate command name in CMessageHeader
< bitcoin-git> bitcoin/master ff9c671 Russell Yanofsky: refactor: Work around GCC 9 `-Wredundant-move` warning
< bitcoin-git> bitcoin/master f2c416b Wladimir J. van der Laan: Merge #16995: Fix gcc 9 warnings
< achow101> #topic: wallet bug fixes for 0.20
< achow101> #17509 seems to be a feature, not a buf fix
< gribble> https://github.com/bitcoin/bitcoin/issues/17509 | gui: save and load PSBT by Sjors · Pull Request #17509 · bitcoin/bitcoin · GitHub
< achow101> so I think it's too late for 0.20
< bitcoin-git> [bitcoin] laanwj merged pull request #16995: Fix gcc 9 warnings (master...2019_09_resolve_gcc_warnings) https://github.com/bitcoin/bitcoin/pull/16995
< hebasto> hi
< achow101> nly two wallet related PRs listed for 0.20, #18338 and #18160
< gribble> https://github.com/bitcoin/bitcoin/issues/18338 | Fix wallet unload race condition by promag · Pull Request #18338 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
< jonatack> they both have an ack and seem not too bad to review
< hebasto> reviewing 18338
< jonatack> correction 18160 seems to have 3 acks
< jonatack> make that 4... i can't count this evening apparently
< achow101> doesn't look like there are any other wallet PRs that are really bug fixes
< bitcoin-git> [bitcoin] laanwj closed pull request #17645: gui: increases default GraphRange of Network Traffic to 12 hours. (master...GraphRange) https://github.com/bitcoin/bitcoin/pull/17645
< achow101> possibly #18095
< gribble> https://github.com/bitcoin/bitcoin/issues/18095 | Fix crashes and infinite loop in ListWalletDir() by uhliksk · Pull Request #18095 · bitcoin/bitcoin · GitHub
< achow101> any other topics?
< achow101> seems not
< jonatack> fjahr: achow101: which pr do you want review on first
< achow101> #endmeeting
< lightningbot> Meeting ended Fri Mar 27 19:18:38 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
< achow101> jonatack: I'd go with #18160 first
< gribble> https://github.com/bitcoin/bitcoin/issues/18160 | gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged by promag · Pull Request #18160 · bitcoin/bitcoin · GitHub
< jonatack> 👍
< promag> sorry missed the meeting
< bitcoin-git> [bitcoin] jonatack opened pull request #18453: cli: enable -getinfo to fetch wallet balance from getbalances() (master...call-getbalances-for-getinfo-balance) https://github.com/bitcoin/bitcoin/pull/18453
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18454: net: Make addr relay mockable, add test (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18454