< bitcoin-git> [bitcoin] promag closed pull request #18487: wip: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487
< bitcoin-git> [bitcoin] promag reopened pull request #18487: wip: rpc: Fix rpcRunLater race in walletpassphrase (master...2020-04-fix-rpcrunlater-race) https://github.com/bitcoin/bitcoin/pull/18487
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d2db25233cf0...eb773f106314
< bitcoin-git> bitcoin/master 7777703 MarcoFalke: doc: Explain new test logging
< bitcoin-git> bitcoin/master eb773f1 MarcoFalke: Merge #18486: doc: Explain new test logging
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18486: doc: Explain new test logging (master...2004-docTestLogging) https://github.com/bitcoin/bitcoin/pull/18486
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/eb773f106314...67a72466e1c0
< bitcoin-git> bitcoin/master fa90647 MarcoFalke: test: Wait for both veracks in add_p2p_connection
< bitcoin-git> bitcoin/master faf1d04 MarcoFalke: test: Remove redundant sync_with_ping after add_p2p_connection
< bitcoin-git> bitcoin/master 67a7246 MarcoFalke: Merge #18247: test: Wait for both veracks in add_p2p_connection
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18247: test: Wait for both veracks in add_p2p_connection (master...2003-qaMininodeVerackRace) https://github.com/bitcoin/bitcoin/pull/18247
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18489: Rebrand to Bitcoin Corrr (master...2004-rebrandCorrr) https://github.com/bitcoin/bitcoin/pull/18489
< phantomcircuit> Client: HexChat 2.14.2 • OS: Debian 10.3 • CPU: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (800MHz) • Memory: Physical: 15.1 GiB Total (14.0 GiB Free) Swap: 15.4 GiB Total (15.4 GiB Free) • Storage: 778.7 GB / 1.9 TB (1.2 TB Free) • VGA: 8086:5917 @ 8086:5914 • Uptime: 11h 21m 47s
< phantomcircuit> oops
< sipa> "VGA"
< luke-jr> lol
< luke-jr> OS: GNU/Linux 4.19.112-gentoo-64kPages/ppc64le - KDE Plasma 5.18.3 - CPU: 64x IBM POWER9 (DD2.3) - Processes: 962 - Uptime: 8d 2h 34m - Users: 57 - Load Average: 1.00 - Memory Usage: 43869MB/65219MB (67%)
< phantomcircuit> i wonder where it got that screen resolution from
< luke-jr> looks more like a PCI id?
< phantomcircuit> luke-jr, indeed
< bitcoin-git> [bitcoin] luke-jr opened pull request #18490: Bugfix: Check PE libraries case-insensitively (master...bugfix_symcheck_pe_case) https://github.com/bitcoin/bitcoin/pull/18490
< bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/67a72466e1c0...b97e3a73498b
< bitcoin-git> bitcoin/master faa9491 MarcoFalke: ci: Use Focal for fuzzers
< bitcoin-git> bitcoin/master b97e3a7 fanquake: Merge #18477: ci: Use Focal for fuzzers
< bitcoin-git> [bitcoin] fanquake merged pull request #18477: ci: Use Focal for fuzzers (master...2003-ciFixFocalForFuzz) https://github.com/bitcoin/bitcoin/pull/18477
< bitcoin-git> [bitcoin] pierreN opened pull request #18491: tests: add fuzing harness for custom abs value functions (master...test-abs-ub) https://github.com/bitcoin/bitcoin/pull/18491
< promag> wumpus: please #18487
< gribble> https://github.com/bitcoin/bitcoin/issues/18487 | rpc: Fix rpcRunLater race in walletpassphrase by promag · Pull Request #18487 · bitcoin/bitcoin · GitHub
< promag> it's a simple change
< promag> just release cs_main and cs_wallet before calling rpcRunLater
< promag> and I'm pretty confident that it avoids a deadlock case (makes node dead)
< wumpus> okay, thanks for investigating that one, added 0.20 milestone
< promag> thanks wumpus
< binary01> hello- does anyone know how to get ripemd160 hash using python3 hashlib?
< jonasschnelli> binary01: AFAIK hashlib does not support Rimemd160
< jonasschnelli> *ripemd160
< jonasschnelli> anyhow,... question is offtopic
< jonasschnelli> binary01: I guess you can use the OpenSSL provided algorithms:
< jonasschnelli> (with new)
< jonasschnelli> h = hashlib.new('ripemd160')
< binary01> hi jonas. thanks for your reply. i am trying that but getting incorrect hash
< jonasschnelli> binary01: incorrect hash sound strange. Byteorder?
< darosior> hashlib does support it
< darosior> But you need to use new('ripemd160') :-)
< binary01> when i try to to h.update on the hash i get error.. Unicode-objects must be encoded before hashing
< binary01> so i add .encode('utf-8') at the end
< binary01> hash doesnt match
< darosior> You need to pass bytes
< darosior> But let's get to #bitcoin as it's not core-related
< binary01> so i tried putting 'b' in front
< binary01> still getting wrong hash
< bitcoin-git> [bitcoin] laanwj opened pull request #18492: qt: Translations update pre-branch (master...2020_04_pre_branch_translations) https://github.com/bitcoin/bitcoin/pull/18492
< elichai2> wumpus: Trying to understand the change that a lot of languages got their `_CountryCode` removed (ie `bitcoin_nl_NL.ts` or `bitcoin_he_IL.ts`)
< elichai2> were they duplicates and now removed? something else?
< wumpus> elichai2: a lot of pseudo-languages were removed, this was already a while ago, but was never applied to master
< wumpus> e.g. there were a lot of dialects that didn't make sense, or had no signifiant translations, or were completely faulty
< wumpus> nl_NL for example makes no sense that's simply the main language
< wumpus> and "nl" is used as fallback for say, nl_BE
< wumpus> binary01: if you're doing bitcoin things with python it makes sense to take a look at python-bitcoinlib, they've been doing this for ages and implemented all the hash and script stuff in python
< wumpus> (but they too use hashlib.new('ripemd160'), that must work)
< elichai2> wumpus: make sense. Thanks!
< binary01> wumpus, thanks but i got it working with hashlib
< wumpus> ok great!
< bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b97e3a73498b...41fa2926d86a
< bitcoin-git> bitcoin/master 740614e Wladimir J. van der Laan: qt: Translations update pre-branch
< bitcoin-git> bitcoin/master 41fa292 Wladimir J. van der Laan: Merge #18492: qt: Translations update pre-branch
< bitcoin-git> [bitcoin] laanwj merged pull request #18492: qt: Translations update pre-branch (master...2020_04_pre_branch_translations) https://github.com/bitcoin/bitcoin/pull/18492
< bitcoin-git> [bitcoin] vasild opened pull request #18493: rpc: Remove deprecated "size" from mempool txs (master...remove_deprecated_rpc_tx_size) https://github.com/bitcoin/bitcoin/pull/18493
< fanquake> vasild: I doubt that change is going into 0.20, so you won’t need to add release notes to the wiki.
< vasild> in general, am I supposed to edit the wiki myself?
< fanquake> Although I do see we said it would be removed, so I guess it was forgotten about.
< fanquake> Yes you should be able to edit it to add release notes.
< vasild> yes, I think it was forgotten. In any case, if not in 0.20 (too late?), then we remove it in 0.21
< vasild> fanquake: ack, about editing the wiki, I presume after a given PR gets merged :)
< fanquake> Is that the only RPC with a 0.20 notice?
< fanquake> I meant left in the code that we said would be removed in 0.20
< vasild> wait, you mean the only rpc that is supposed to be deleted in 0.20?
< vasild> (and same on line 914 too)
< fanquake> Probably worth adding an additional commit(s) to take care of those TODOs and can be discussed in the PR
< vasild> I havent looked at those TODO comments yet, but they look unrelated to the "size" removal. Better deal with them in a separate PR.
< wumpus> heh yes, please edit the wiki only after something is merged, let's not get ahead of things
< wumpus> removing deprecated things is not really a hurry so i'd also say let's delay that to after the branch-off
< bitcoin-git> [bitcoin] jonatack opened pull request #18494: test: replace (send_message + sync_with_ping) with send_and_ping (master...send_and_ping) https://github.com/bitcoin/bitcoin/pull/18494
< bitcoin-git> [bitcoin] vasild opened pull request #18495: rpc: Remove deprecated migration code (master...remove_deprecated_migration_code) https://github.com/bitcoin/bitcoin/pull/18495
< bitcoin-git> [bitcoin] jonatack opened pull request #18496: test: remove redundant sync_with_ping after add_p2p_connection (master...remove-redundant-sync_with_ping-calls) https://github.com/bitcoin/bitcoin/pull/18496
< wumpus> I'll hold off the actual branch off / rc1 until after the meeting tomorrow, so we can discuss last-minute fixes
< vasild> wumpus: I agree, none of #18493 or #18495 code removals seem to classify for a "last minue sneak in"
< gribble> https://github.com/bitcoin/bitcoin/issues/18493 | rpc: Remove deprecated "size" from mempool txs by vasild · Pull Request #18493 · bitcoin/bitcoin · GitHub
< gribble> https://github.com/bitcoin/bitcoin/issues/18495 | rpc: Remove deprecated migration code by vasild · Pull Request #18495 · bitcoin/bitcoin · GitHub
< luke-jr> IMO the build issue should probably be a blocker
< luke-jr> #18465
< gribble> https://github.com/bitcoin/bitcoin/issues/18465 | bitcoin-tx (and probably others) fails to build without libevent · Issue #18465 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #18498: test: enable opening partial p2p connections where useful (master...allow-peer-conn-sans-sync) https://github.com/bitcoin/bitcoin/pull/18498
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18499: rpc: Make rpc documentation not depend on rpc args (master...2004-rpcStaticDoc) https://github.com/bitcoin/bitcoin/pull/18499
< bitcoin-git> [bitcoin] dongcarl closed pull request #18478: build: Automatically include both `git`-tracked and bootstrapped files. (master...2020-03-adventures-in-reconciling-automake-and-git) https://github.com/bitcoin/bitcoin/pull/18478
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18500: chainparams: Bump assumed valid hash (master...2004-chainparamsBump) https://github.com/bitcoin/bitcoin/pull/18500
< Kiminuo> Hi, is Practicalswift (https://github.com/practicalswift) here by any chance under some other nickname? Well heck, I'll just ask right away. I have tried to run `src/test/fuzz/process_message qa-assets/fuzz_seed_corpus/process_message/` as explained here https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md#fuzzing-harnesses-fuzzing-output-and-fuzzing-corpora. I got some some new coverages. Is that valuable enough to make a PR? Still I
< Kiminuo> should probably learn more about fuzzing first here https://llvm.org/docs/LibFuzzer.html ...
< jonatack_> Kiminuo: there is also doc/fuzzing.md as a resource, if you haven't seen it yet. It was recently updated
< Kiminuo> jonatack_, it's in my previous message ...?
< Kiminuo> :)
< Kiminuo> Yeah, well, I guess, I'll have to read more about it
< jonatack_> heh, long message, didn't see that far :)
< Kiminuo> Age of tweets :-((
< ariard> if you try to ibd between 2 regtest nodes, CanDirectFetch fails because time of mined block is far ahead of genesis, is this intentional and known?