< bitcoin-git>
[bitcoin] robot-visions opened pull request #18772: rpc: calculate fee in getblock using BlockUndo data (master...getblock-fee) https://github.com/bitcoin/bitcoin/pull/18772
< bitcoin-git>
[bitcoin] fanquake closed pull request #17822: refactor: Use uint16_t instead of unsigned short (master...akh_uint16_t) https://github.com/bitcoin/bitcoin/pull/17822
< meshcollider>
I'm nearly finished reviewing #16528 so it'll be RTM tomorrow, if anyone else wants to review it before I merge it please do so today, more eyes the better for such a big change :)
< hebasto>
are we still supporting Ubuntu 14.04 LTS Trusty Tahr? i.e. is it expected that downloaded bitcoin-qt v0.20 will run on it?
< luke-jr>
hebasto: at least trusty's compilers can't do C++11..
< hebasto>
luke-jr: yeah, but it is still possible to download binaries from bitcoincore.org
< hebasto>
is it worth to clear mention in 0.20 release notes ubuntu 14.04 end of support?
< luke-jr>
hebasto: what EOS are you referring to?
< luke-jr>
has something changed in 0.20 in this regard?
< hebasto>
I mean trusty's support by us. Nothing particular changed. But ability to not test on trusty seems good for dev community, no?
< hebasto>
I doubt if any of devs run bitcoin-qt 0.20rc1 on trusty...
< luke-jr>
hebasto: I doubt any of devs run it on most platforms..
< kanzure>
are all of these stale issues getting closed?
< kanzure>
or rather, of the issues getting closed, are they all stales?
< hebasto>
tested gitian bitcoin-qt 0.20rc1 on trusty vm. Seems ok :D
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18775: tests: Add fuzzing harnesses for various classes/functions in policy/ (CBlockPolicyEstimator, IsRBFOptIn(…), etc.) (master...fuzzers-policy) https://github.com/bitcoin/bitcoin/pull/18775
< jonatack>
I've been reviewing and thinking about #18038 this afternoon/evening, will finish tomorrow. It looks like the txn resend timing dates back to 2013 or earlier... that's a long time.
< fanquake>
kanzure: The majority are pretty stale. I’d say there are a few being closed that are probably still actual issues. i.e #15062 was closed and the same issue seems to have reappeared today in #18776
< gribble>
https://github.com/bitcoin/bitcoin/issues/15062 | (Ubuntu xenial armhf) fatal error in "psbt_updater_test": memory access violation at address: 0xd503e0e4: no mapping at fault address · Issue #15062 · bitcoin/bitcoin · GitHub
< gribble>
https://github.com/bitcoin/bitcoin/issues/18776 | macOS v0.19.1 failing test: memory access violation at address: 0x02800000: no mapping at fault address · Issue #18776 · bitcoin/bitcoin · GitHub
< meshcollider>
achow101: here?
< achow101>
meshcollider: eh?
< meshcollider>
What's the point of IsHDEnabled in a descriptor wallet?
< achow101>
to be compatible with rpcs and things that are looking for IsHDEnabled
< achow101>
you could, in theory, have a descriptor wallet with a bunch of imported single key things. that would not be HD