< fanquake> Thanks for the answers ryanofsky 👍
< jeremyrubin> Testing question! Is there any good reason why CScript(["part A"]) + CScript(["part B"]) != CScript(["part A", "part B"])?
< jeremyrubin> The testing suite does expect that a adding a CScript is a push rather than a concat
< jeremyrubin> But I don't think we expose an API for concatenating two scripts, do we?
< jeremyrubin> It's odd that we implicitly cast CScript to bytes, that should be done explicitly where it's used
< jeremyrubin> Alternatively, we have the join API (which is disabled), but CScript().join([clause A, clause B]) isn't so bizzare
< sipa>
< jeremyrubin> hmmm?
< jeremyrubin> Empty?
< bitcoin-git> [bitcoin] fanquake pushed 17 commits to master: https://github.com/bitcoin/bitcoin/compare/a5623ba89f05...ed3b8eada803
< bitcoin-git> bitcoin/master 570d769 Carl Dong: guix: Build support for Windows
< bitcoin-git> bitcoin/master 91897c9 Carl Dong: guix: Improve guix-build.sh documentation
< bitcoin-git> bitcoin/master df953a4 Carl Dong: guix: Appease shellcheck.
< bitcoin-git> [bitcoin] fanquake merged pull request #17595: guix: Enable building for `x86_64-w64-mingw32` target (master...2019-09-guix-staging-win-mingw-6.0.0) https://github.com/bitcoin/bitcoin/pull/17595
< bitcoin-git> [bitcoin] fanquake closed pull request #15268: doc: suggest using timeoutstopsec in systemd file during IBD (master...systemd-tweaks) https://github.com/bitcoin/bitcoin/pull/15268
< bitcoin-git> [bitcoin] fanquake closed pull request #17272: [POLICY] Make multiple OP_RETURNS in a single TX standard (master...allow-multi-op_return) https://github.com/bitcoin/bitcoin/pull/17272
< jonasschnelli> achow101: I passed a -upgrade to gbuild and even get a different shasum for bitcoin-0.20.0rc1-osx-unsigned.tar.gz
< jonasschnelli> (won't match yours as well)
< bitcoin-git> [bitcoin] rebroad opened pull request #18604: Display command line usage to console without requiring X Windows (master...UsageToConsoleIfNotWin32) https://github.com/bitcoin/bitcoin/pull/18604
< bitcoin-git> [bitcoin] fanquake opened pull request #18605: [WIP] build: Link time garbage collection (master...link_time_garbage_collection) https://github.com/bitcoin/bitcoin/pull/18605
< jonatack__> fwiw this was the first time that building gitian sigs for macos/osx worked for me out of the box
< jonatack> 🤷
< jonatack> with gcc version 8.3.0 (Debian 8.3.0-6)
< MarcoFalke> jonasschnelli achow101 What is your build log?
< MarcoFalke> Could diff the two
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ed3b8eada803...76143bf714ab
< bitcoin-git> bitcoin/master 2599d13 Vasil Dimov: rpc: Remove deprecated migration code
< bitcoin-git> bitcoin/master 76143bf MarcoFalke: Merge #18495: rpc: Remove deprecated migration code
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18495: rpc: Remove deprecated migration code (master...remove_deprecated_migration_code) https://github.com/bitcoin/bitcoin/pull/18495
< Talkless> Was there ever "fees" field inside "getinfo" ? I can't find that proof in old releases...
< Talkless> not sure what this plugin had in mind
< Talkless> Is there a way to get total pending fees (without looping through raw mempool)?
< bitcoin-git> [bitcoin] pierreN opened pull request #18606: test: check that bitcoin-cli autocomplete is in sync (master...feature-auto-cli) https://github.com/bitcoin/bitcoin/pull/18606
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18607: rpc: Fix named arguments in documentation (master...2004-rpcDoc) https://github.com/bitcoin/bitcoin/pull/18607
< achow101> jonasschnelli: your install.log indicates that the image already has a ton of packages already installed, so maybe it isn't clean so another version of gcc is being picked up?
< jonasschnelli> achow101: yeah. I have set back the base image.
< jonasschnelli> Your probably right,.. after also deleting the depends cache, I was getting the same hash.
< jonasschnelli> I manually installed packages on the base image to speed up nighly gitian builds... but not the ideal way for determinism
< achow101> ah, that makes sense
< jonasschnelli> 0.20.0rc1 macOS detached signatures are now available. Start your engines.
< achow101> did you tag or should I?
< jonasschnelli> achow101: oh yes. Please do.
< achow101> gitian builders: v0.20.0rc1 detached sigs are pushed
< jonasschnelli> thanks achow101: almost forgot about the required tag.
< hebasto> achow101: updatee comment -- using LXC
< hebasto> *updated
< bitcoin-git> [bitcoin] ryanofsky opened pull request #18608: refactor: Remove CAddressBookData::destdata (master...pr/nodest) https://github.com/bitcoin/bitcoin/pull/18608
< achow101> hebasto: I think lxc and kvm just have a bunch more packages installed by default. so at least one of those requires automake so automake ends up being installed too
< hebasto> achow101: it seems so
< bitcoin-git> [bitcoin] hebasto opened pull request #18609: test: Remove REJECT message code (master...20200412-test-reject) https://github.com/bitcoin/bitcoin/pull/18609
< bitcoin-git> [bitcoin] theStack opened pull request #18610: scripted-diff: test: replace command with msgtype (naming) (master...20200410-scripted-diff-test-rename-command-to-msgtype) https://github.com/bitcoin/bitcoin/pull/18610
< bitcoin-git> [bitcoin] brakmic opened pull request #18611: cli: show default values in config args log (master...compare-params) https://github.com/bitcoin/bitcoin/pull/18611
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18612: script: Remove undocumented and unused operator+ (master...2004-scriptNoAdd) https://github.com/bitcoin/bitcoin/pull/18612
< bitcoin-git> [bitcoin] JeremyRubin opened pull request #18613: WIP: Make CScript addition concatenative (master...fix-testing-cscript) https://github.com/bitcoin/bitcoin/pull/18613
< bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/76143bf714ab...59d62492900f
< bitcoin-git> bitcoin/master 1356a45 Sebastian Falbesoner: test: complete impl. of msg_merkleblock and wait_for_merkleblock
< bitcoin-git> bitcoin/master 8543828 Sebastian Falbesoner: refactor: test: improve wait_for{header,merkleblock} interface
< bitcoin-git> bitcoin/master 59d6249 MarcoFalke: Merge #18593: test: complete impl. of msg_merkleblock and wait_for_merkleb...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18593: test: complete impl. of msg_merkleblock and wait_for_merkleblock (master...20200410-test-complete-merkleblock-message-and-wait-function) https://github.com/bitcoin/bitcoin/pull/18593
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/59d62492900f...a2b282c9d058
< bitcoin-git> bitcoin/master b1b0cfe Hennadii Stepanov: test: Remove REJECT message code
< bitcoin-git> bitcoin/master a2b282c MarcoFalke: Merge #18609: test: Remove REJECT message code
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18609: test: Remove REJECT message code (master...20200412-test-reject) https://github.com/bitcoin/bitcoin/pull/18609
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/a2b282c9d058...c49971f3c9b1
< bitcoin-git> bitcoin/master fa404f1 MarcoFalke: test: Check that the version message does not leak the local address of th...
< bitcoin-git> bitcoin/master c49971f MarcoFalke: Merge #18584: test: Check that the version message does not leak the local...
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18584: test: Check that the version message does not leak the local address (master...2003-qaAddrRelay) https://github.com/bitcoin/bitcoin/pull/18584
< bitcoin-git> [bitcoin] MarcoFalke closed pull request #18555: wallet: Abort when assumption fails in debug mode (master...2004-walletAssumeAbortDebug) https://github.com/bitcoin/bitcoin/pull/18555