< bitcoin-git> [bitcoin] achow101 opened pull request #18589: Fix naming of macOS SDK and clarify version (master...fix-osx-sdk-extract) https://github.com/bitcoin/bitcoin/pull/18589
< bitcoin-git> [bitcoin] sipa opened pull request #18591: Add C++17 build to Travis (master...202004_c++17) https://github.com/bitcoin/bitcoin/pull/18591
< bitcoin-git> [bitcoin] brakmic opened pull request #18592: rpc: replace raw pointers with shared_ptrs (master...rpcwallet-replace-pointers) https://github.com/bitcoin/bitcoin/pull/18592
< emzy> I get an error while gitian building the macos binaries. It happens while comiling boost libs. "./boost/config/detail/posix_features.hpp:18:15: fatal error: 'unistd.h' file not found"
< fanquake> emzy: it means the macOS SDK can't be found
< emzy> But it is there.
< emzy> And it worked for v0.19.1
< fanquake> We've moved to the 10.14 SDK
< emzy> I have gitian-builder/inputs/MacOSX10.14.sdk.tar.gz
< fanquake> Check that when it is untarred, it is the correct name. achow101 ran into a similar issue, see #18589
< gribble> https://github.com/bitcoin/bitcoin/issues/18589 | Fix naming of macOS SDK and clarify version by achow101 · Pull Request #18589 · bitcoin/bitcoin · GitHub
< fanquake> The sdk needs to be named MacOSX10.14.sdk, if it isn't, depends wont find it.
< emzy> That's it. tnx. "Gitian requires that tar.gz contains a folder named MacOSX10.14.sdk" that is wrong. It is named MacOSX.sdk insted.
< emzy> I will fix that manualy.
< hebasto> MarcoFalke: wumpus: mind assigning 0.21.0 milestone to #18077 ?
< gribble> https://github.com/bitcoin/bitcoin/issues/18077 | net: Add NAT-PMP port forwarding support by hebasto · Pull Request #18077 · bitcoin/bitcoin · GitHub
< bitcoin-git> [bitcoin] jonatack opened pull request #18594: cli: display multiwallet balances in -getinfo (master...cli-getinfo-multiwallet-balances) https://github.com/bitcoin/bitcoin/pull/18594
< bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3eb8b1c3924c...a5623ba89f05
< bitcoin-git> bitcoin/master f29bd54 MarcoFalke: Revert "Merge #16367: Multiprocess build support"
< bitcoin-git> bitcoin/master a5623ba MarcoFalke: Merge #18588: Revert "Merge #16367: Multiprocess build support"
< bitcoin-git> [bitcoin] MarcoFalke merged pull request #18588: Revert "Merge #16367: Multiprocess build support" (master...2004-buildMultiProcess) https://github.com/bitcoin/bitcoin/pull/18588
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18596: [WIP] test: Revert windows workaround temporarily (master...2004-testWin) https://github.com/bitcoin/bitcoin/pull/18596
< bitcoin-git> [bitcoin] MarcoFalke opened pull request #18597: test: Extend wallet_dump test to cover comments (master...2004-qaWalletDump) https://github.com/bitcoin/bitcoin/pull/18597
< wumpus> hebasto:done
< hebasto> wumpus: thanks!
< luke-jr> wumpus: #18572 should get 0.20-tagged
< gribble> https://github.com/bitcoin/bitcoin/issues/18572 | Wallet: Accept "changedata" db key as an alias to "destdata" by luke-jr · Pull Request #18572 · bitcoin/bitcoin · GitHub
< achow101> emzy: did you change your gpg key? It seems to be different from the one that I can find for you and I can't find this key anywhere
< emzy> yes.
< emzy> But like 3 mounths ago. Not my first sig. with it.
< achow101> ah. anywhere I can get that key?
< emzy> you can't get it from the keyservers?
< achow101> no
< achow101> I've tried sks, ubuntu, and mit and none of them have it
< emzy> I will reupload it
< emzy> achow101: I hope it will distribute in the gpg servers. I also send you a mail with the gpg key.
< achow101> thanks
< bitcoin-git> [bitcoin] achow101 opened pull request #18598: gitian: Add missing automake package to gitian-win-signer.yml (master...fix-gitian-win-signer) https://github.com/bitcoin/bitcoin/pull/18598
< jonasschnelli> somehow my macOS gitian hash for the unsigned tarball is different: https://bitcoin.jonasschnelli.ch/gitian/builds/78/bitcoin-core-osx-0.20-build.assert
< jonasschnelli> I need to figure this out first before signing the macOS build
< jonasschnelli> maybe it has to do with my local notarization changes.
< jonasschnelli> (which should be reverted)
< achow101> what are the contents of that tarball?
< jonasschnelli> achow101: the macOS binary
< jonasschnelli> I got sha256 fbdb266c071605451b4b8ffb2d90d50e9735f9a6c3d3fc0f32560ca62c326fa7 for dist/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
< jonasschnelli> achow101: can you check yours?
< jonasschnelli> (I wonder is that file is different)
< achow101> it's the same
< achow101> here's the hashes of everything in the tarball https://0bin.net/paste/sn42iQsq07c4YkDt#dVs-BBH4j0gTfuyO4N2ZG+nCq/ypoVS1DTpGk5kVMnV
< jonasschnelli> thanks... i'll compare
< jonasschnelli> codesign_allocate is different, genisoimage as well
< jonasschnelli> as well as pagestuff
< jonasschnelli> strange
< achow101> where do those come from? the sdk?
< jonasschnelli> probably depends...
< jonasschnelli> I have little time now,... but I don't feel comfortable signing this now... will investigate tmr/later.
< jonasschnelli> achow101: if you find out something, plz pm me.
< achow101> ok
< jonasschnelli> (or highlight me)
< jonasschnelli> I have re-done the mac build and got the same output: https://bitcoin.jonasschnelli.ch/gitian/build/79
< achow101> jonasschnelli: it looks like we have different gcc versions
< achow101> the .comment section of each of those has GCC: (Ubuntu 8.3.0-6ubuntu1~18.04.1) 8.3.0 for you and GCC: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 for me
< achow101> how that happened, I'm not sure
< achow101> jonasschnelli: do you have the install.log for your build?
< fanquake> wumpus / sipa can you block tsp186
< sipa> fanquake: done
< fanquake> achow101: you have GCC version comments in your macOS binary?
< bitcoin-git> [bitcoin] ariard opened pull request #18600: [wallet] Track conflicted transactions removed from mempool and fix UI notifications (master...2020-03-wallet-track-conflicts) https://github.com/bitcoin/bitcoin/pull/18600
< bitcoin-git> [bitcoin] promag opened pull request #18601: wallet: Refactor WalletRescanReserver constructor to take wallet refe… (master...2020-04-walletrescanreserver) https://github.com/bitcoin/bitcoin/pull/18601
< achow101> fanquake: in bitcoin-qt itself, no
< achow101> but I see them in the codesign_allocate, dmg, genisoimage, and pagestuff binaries that are in the osx-unsigned.tar.gz
< achow101> those comments are the primary difference, though some of them have a few other differences which I am attributing to the different gcc versions
< fanquake> ok