< bitcoin-git>
[bitcoin] fanquake closed pull request #17494: utils: Use GetProcessWorkingSetSizeEx to get limit for Win32LockedPageAllocator (master...windows_page_allocator_getlimit) https://github.com/bitcoin/bitcoin/pull/17494
< wumpus>
PSA: 2FA-required policy has been enabled for the "bitcoin" organization
< wumpus>
still need to convince one person to enable it to do the same for bitcoin-core
< bitcoin-git>
bitcoin/master b91e4ae Hennadii Stepanov: Do not expose and consider -logthreadnames when it does not work
< bitcoin-git>
bitcoin/master acb4fa0 Wladimir J. van der Laan: Merge #18665: Do not expose and consider -logthreadnames when it does not ...
< bitcoin-git>
[bitcoin] laanwj merged pull request #18665: Do not expose and consider -logthreadnames when it does not work (master...200416-logthreads) https://github.com/bitcoin/bitcoin/pull/18665
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18736: tests: Add fuzzing harnesses for various classes/functions in util/ (master...fuzzers-2020-04-21) https://github.com/bitcoin/bitcoin/pull/18736
< bitcoin-git>
bitcoin/master a7a6f1f MarcoFalke: Merge #18575: bench: Remove requirement that all benches use same testing ...
< bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18575: bench: Remove requirement that all benches use same testing setup (master...2004-benchNoGlobalReg) https://github.com/bitcoin/bitcoin/pull/18575
< bitcoin-git>
[bitcoin] hebasto opened pull request #18738: build: Suppress Qt 5.12 warnings on Ubuntu Focal (master...200422-qt-warn) https://github.com/bitcoin/bitcoin/pull/18738
< vasild>
hebasto: #18738 will also hide warnings in bitcoin core itself. It is unfortunate to have to lower standards for bitcoin core because some external library emits warnings. I think it is likely that some of our external dependencies (qt, boost, whatever) will produce warnings with some compiler.
< vasild>
Wouldn't it be better if we can (optionally) shut warnings from external libraries, but have them enabled for bitcoin core?
< hebasto>
vasild: I hope the fix will be merged into upstream Qt 5.12 branch soon, as it done on 5.13 already.
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18739: doc: Document how to fuzz Bitcoin Core using Honggfuzz (master...honggfuzz) https://github.com/bitcoin/bitcoin/pull/18739
< vasild>
hebasto: this one maybe, but what about in general?
< vasild>
I am with qt 5.14 and it spits lots of warnings with clang 10. IMO some version of qt|boost will always emit warnings with some compiler.
< vasild>
"I'm really not a fan of disabling warnings for 3rd party headers, but I'm not completely opposed" --> what we end up doing is disabling warnings in 3rd party headers AND in bitcoin core.
< vasild>
hebasto: I looked at it briefly, will review more carefully and test it maybe tomorrow. It is always good to extend the reach of our Werror by adding more -Werror=foo.
< vasild>
However, what is even better IMO is to extend it to a full -Werror (not just partial -Werror=only_for_this -Werror=and_this)
< jonatack>
Yes. At least reviewers can use -Weverything -Wall -Werror etc etc if they like (I do)
< bitcoin-git>
[bitcoin] ryanofsky opened pull request #18743: depends: Add --sysroot option to mac os native compile flags (master...pr/sysroot) https://github.com/bitcoin/bitcoin/pull/18743
< bitcoin-git>
[bitcoin] practicalswift opened pull request #18744: tests: Add fuzzing harnesses for various classes/functions in primitives/ (master...fuzzers-2020-04-22) https://github.com/bitcoin/bitcoin/pull/18744