bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #23450: doc: update SECURITY.md inline with recent changes to bitcoincore.org (master...update_sec_md) https://github.com/bitcoin/bitcoin/pull/23450
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
copumpkin has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23464: doc: remove mention of system univalue from build-unix.md (master...22646_followup) https://github.com/bitcoin/bitcoin/pull/23464
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
<Guest9>
is there a recommendation on whether new contributors should join anonymously or otherwise, perhaps for CONTRIBUTING.md? I could find https://twitter.com/_jonasschnelli_/status/1451268523616051201 but the risks seem difficult to fully know as a new contributor, and most seem to work under their full name. Sorry if this is off-topic though.
Evolver has quit [Ping timeout: 268 seconds]
elichai2 has quit [Ping timeout: 264 seconds]
hebasto has quit [Ping timeout: 268 seconds]
fanquake has quit [Ping timeout: 268 seconds]
schmidty has quit [Ping timeout: 245 seconds]
jarolrod has quit [Ping timeout: 268 seconds]
josibake has quit [Ping timeout: 268 seconds]
glozow has quit [Ping timeout: 268 seconds]
ajonas has quit [Ping timeout: 268 seconds]
hendi has quit [Ping timeout: 268 seconds]
blkncd has quit [Ping timeout: 268 seconds]
jkczyz has quit [Ping timeout: 268 seconds]
fjahr has quit [Ping timeout: 268 seconds]
sugarpuff_ has quit [Ping timeout: 264 seconds]
amiti has quit [Ping timeout: 264 seconds]
fjahr has joined #bitcoin-core-dev
Evolver has joined #bitcoin-core-dev
elichai2 has joined #bitcoin-core-dev
blkncd has joined #bitcoin-core-dev
glozow has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
amiti has joined #bitcoin-core-dev
schmidty has joined #bitcoin-core-dev
sugarpuff_ has joined #bitcoin-core-dev
ajonas has joined #bitcoin-core-dev
josibake has joined #bitcoin-core-dev
jarolrod has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
hendi has joined #bitcoin-core-dev
jkczyz has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
glozow has quit [Read error: Connection reset by peer]
fanquake has quit [Read error: Connection reset by peer]
bw has quit [Read error: Connection reset by peer]
brunoerg has quit [Ping timeout: 268 seconds]
fanquake has joined #bitcoin-core-dev
glozow has joined #bitcoin-core-dev
bw has joined #bitcoin-core-dev
glozow has quit [Ping timeout: 268 seconds]
fanquake has quit [Ping timeout: 268 seconds]
bw has quit [Ping timeout: 268 seconds]
glozow has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
bw has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
fanquake has quit [Ping timeout: 256 seconds]
Jackielove4u has quit [Ping timeout: 256 seconds]
stick has quit [Ping timeout: 260 seconds]
moneyball_ has quit [Ping timeout: 268 seconds]
jarolrod has quit [Ping timeout: 244 seconds]
elichai2 has quit [Ping timeout: 244 seconds]
josibake has quit [Ping timeout: 260 seconds]
lsilva_ has quit [Ping timeout: 260 seconds]
hendi has quit [Ping timeout: 256 seconds]
ajonas has quit [Ping timeout: 256 seconds]
jarolrod has joined #bitcoin-core-dev
moneyball_ has joined #bitcoin-core-dev
lsilva_ has joined #bitcoin-core-dev
Jackielove4u has joined #bitcoin-core-dev
Evolver has quit [Ping timeout: 244 seconds]
ajonas has joined #bitcoin-core-dev
bw has quit [Ping timeout: 268 seconds]
glozow has quit [Ping timeout: 268 seconds]
stick has joined #bitcoin-core-dev
glozow has joined #bitcoin-core-dev
fanquake has joined #bitcoin-core-dev
josibake has joined #bitcoin-core-dev
sugarpuff_ has quit [Ping timeout: 260 seconds]
elichai2 has joined #bitcoin-core-dev
sugarpuff_ has joined #bitcoin-core-dev
Evolver has joined #bitcoin-core-dev
bw has joined #bitcoin-core-dev
hendi has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] lsilva01 opened pull request #23465: Remove CChainParams and CTxMemPool params from ATMP (master...remove_pool_params_atmp) https://github.com/bitcoin/bitcoin/pull/23465
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
bitdex has quit [Ping timeout: 276 seconds]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
kvaciral[m] has quit [*.net *.split]
notmandatory has quit [*.net *.split]
notmandatory has joined #bitcoin-core-dev
kvaciral[m] has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
Enki[m] has quit [*.net *.split]
stick[m] has quit [*.net *.split]
Murch[m] has quit [*.net *.split]
otoburb has quit [*.net *.split]
da2ce7 has quit [*.net *.split]
ryanofsky has quit [*.net *.split]
phantomcircuit has quit [*.net *.split]
glix has quit [*.net *.split]
kcalvinalvin has quit [*.net *.split]
EPiSKiNG- has quit [*.net *.split]
roasbeef has quit [*.net *.split]
roasbeef has joined #bitcoin-core-dev
ryanofsky has joined #bitcoin-core-dev
glix has joined #bitcoin-core-dev
otoburb has joined #bitcoin-core-dev
phantomcircuit has joined #bitcoin-core-dev
EPiSKiNG- has joined #bitcoin-core-dev
da2ce7 has joined #bitcoin-core-dev
Murch[m] has joined #bitcoin-core-dev
kcalvinalvin has joined #bitcoin-core-dev
stick[m] has joined #bitcoin-core-dev
Enki[m] has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
<laanwj>
Guest9: no, there is recommendation on that, it's not up to the open source project to make that. you need to make that kind of potentially very important decisions for yourself, and for what it's worth, no one really knows what the risks are
<laanwj>
"seems to work under their full name" doesn't mean that much, they could have made up a plausible sounding name
<bitcoin-git>
bitcoin/master 7eb5b25 W. J. van der Laan: doc: Mention that BerkeleyDB is for legacy wallet in build-unix
<bitcoin-git>
bitcoin/master 170e268 fanquake: Merge bitcoin/bitcoin#23446: doc: Mention that BerkeleyDB is for legacy wa...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #23446: doc: Mention that BerkeleyDB is for legacy wallet in build-unix (master...2021-11-unix-build-doc-legacy) https://github.com/bitcoin/bitcoin/pull/23446
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake merged pull request #22076: build: Fix `make apk` if ccache enabled, and enable it on CI (master...210526-apk) https://github.com/bitcoin/bitcoin/pull/22076
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rockhouse has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
_andrewtoth_ has quit [Remote host closed the connection]
_andrewtoth_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
dermoth has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
andrewtoth_ has joined #bitcoin-core-dev
_andrewtoth_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
Guest18 has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto closed pull request #23463: ci: Increase --timeout-factor in the native Windows CI task (master...211107-timeout) https://github.com/bitcoin/bitcoin/pull/23463
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guyver2 has quit [Ping timeout: 244 seconds]
Guyver2_ is now known as Guyver2
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Ping timeout: 276 seconds]
<michaelfolkson2>
In case Taproot activation chat gets noisy in the run up to activation later this week I'm thinking #bitcoin-dev may be better location for Taproot activation chat. So yeah would be interesting to have discussion somewhere on IRC and that's probably best place imo
AaronvanW has quit [Remote host closed the connection]
bomb-on has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jamesob opened pull request #23468: make Python bindings externally usable (master...2021-10-python-packaging) https://github.com/bitcoin/bitcoin/pull/23468
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
lukedashjr has joined #bitcoin-core-dev
luke-jr has quit [Ping timeout: 250 seconds]
bomb-on has quit [Quit: aллилѹіа!]
bomb-on has joined #bitcoin-core-dev
lukedashjr is now known as luke-jr
dougefish has quit [Quit: dougefish]
dougefish has joined #bitcoin-core-dev
Victorsueca has quit [Ping timeout: 268 seconds]
bomb-on has quit [Quit: aллилѹіа!]
Talkless has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
andrewtoth_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
brunoerg has quit [Ping timeout: 264 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has quit [Quit: Leaving...]
Chris_Stewart_5 has joined #bitcoin-core-dev
Guest67 has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<Chris_Stewart_5>
I'm attempting to work through test cases for BIP341 (script_assets_test.json), what is this scriptSig? The comment next to it is "comment": "legacy/pk-wrongkey" and the output script is p2sh, here is the scriptSig: 47304402204d87b96e7f61a568c98e329d1de4e065b1a3fd79323db707dfbe41216d7316f002201882165181d5f79bdb90c3d7f19bac0d1488b2e1bb8e4d217658e7eaf102e3d28143410442f7110c668193b072c2ac20b92ef6127383c166ea8d
brunoerg has joined #bitcoin-core-dev
<Chris_Stewart_5>
I'm guessing it is testing p2sh(witv1), but i can't really see where the witv1 spk is nested inside of that scriptSig
<sipa>
no, it's just literally p2wsh (wit v0) spending
<Chris_Stewart_5>
So `prevouts` in this case is `4d8a96010000000017a914e5275b7f57782589ebe0b2b6aeef381eda57379b87` which seems to have a p2sh in it (`17a914e...87`) IIRC? Or am i misusing prevouts here? The output inside of hte `tx` field seems to p2wpkh
bomb-on has quit [Quit: aллилѹіа!]
<sipa>
right
Guest9 has quit [Quit: leaving]
brunoerg has quit [Remote host closed the connection]
bomb-on has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
<sipa>
p2wsh you mean?
<sipa>
and what do you mean by "output inside of the the tx" ?
<Chris_Stewart_5>
Well i was hoping you can tell me as the test vectors are a little confusing. In the `tx` field of json, if you parse it, their is a single output that is p2wpkh. In the `prevouts` field it appears to be p2sh to me.
<Chris_Stewart_5>
4d8a960100000000 (amt i believe?) 17a914e5275b7f57782589ebe0b2b6aeef381eda57379b87 (p2sh script)
<sipa>
that sounds reasonable
<sipa>
the output doesn't matter
<sipa>
it's random
<sipa>
the input in this case is presumably a p2sh-p2wsh script
<Chris_Stewart_5>
my understanding is there is multiple prevouts in some cases because -- IIRC -- the signature checking algorithm signs all outputs by default now
<sipa>
they are the UXTOs being spent
<sipa>
you obviously can't verify a transaction without those
<Chris_Stewart_5>
Ah, when you said 'output' above you mean the output in the `tx` field
<sipa>
yes, in bip341/bip342, the sighash algorithm is a function of all utxos spent by the entire transaction
<sipa>
not just the utxo spent by the input you are signing
<Chris_Stewart_5>
ok let me look closer at the redeem script.
masta`` has quit [Quit: Going offline, see ya! (www.adiirc.com)]
vysn has quit [Ping timeout: 250 seconds]
limping has joined #bitcoin-core-dev
<Chris_Stewart_5>
Ok, i pasted a truncated redeem script earlier, here is the full: 47304402204d87b96e7f61a568c98e329d1de4e065b1a3fd79323db707dfbe41216d7316f002201882165181d5f79bdb90c3d7f19bac0d1488b2e1bb8e4d217658e7eaf102e3d28143410442f7110c668193b072c2ac20b92ef6127383c166ea8d1e5699af9c371827f98bcbb86a991458282101ebf8602d6082e953340925a5327b474566e82d41fd98e1ac
<Chris_Stewart_5>
When parsing the compact size uint (47), that translates to `71` bytes. It appears that the scriptSig provided is 140 bytes in length.
<Chris_Stewart_5>
So (unless i did something wrong!) it seems that the scriptSig might be serialized incorrectly? Or perhaps there is a new rule i am unaware of
<sipa>
what line in the json file are you talking about?
<sipa>
there is nothing strange here... the scriptSig contains two pushes
<sipa>
the first is a 71-byte ECDSA signature
<sipa>
the second is the push of the redeemScript, which is: 0442f7110c668193b072c2ac20b92ef6127383c166ea8d1e5699af9c371827f98bcbb86a991458282101ebf8602d6082e953340925a5327b474566e82d41fd98e1 OP_CHECKSIG
<sipa>
so it's a P2SH-P2PK
<sipa>
with an uncompressed pubkey
<Chris_Stewart_5>
What is the 0x47?
<sipa>
the push of the 71 bytes
<Chris_Stewart_5>
(first byte in scriptSig)
<sipa>
the scriptSig is: <304402204d87b96e7f61a568c98e329d1de4e065b1a3fd79323db707dfbe41216d7316f002201882165181d5f79bdb90c3d7f19bac0d1488b2e1bb8e4d217658e7eaf102e3d28143> <0442f7110c668193b072c2ac20b92ef6127383c166ea8d1e5699af9c371827f98bcbb86a991458282101ebf8602d6082e953340925a5327b474566e82d41fd98e1ac>
<sipa>
in disassembled form
<sipa>
this is just how P2SH works...
<sipa>
sorry, i missed a byte there
<sipa>
the scriptSig is: <304402204d87b96e7f61a568c98e329d1de4e065b1a3fd79323db707dfbe41216d7316f002201882165181d5f79bdb90c3d7f19bac0d1488b2e1bb8e4d217658e7eaf102e3d281> <410442f7110c668193b072c2ac20b92ef6127383c166ea8d1e5699af9c371827f98bcbb86a991458282101ebf8602d6082e953340925a5327b474566e82d41fd98e1ac>
<sipa>
and the last push is the redeemScript, which itself disassembles to: <0442f7110c668193b072c2ac20b92ef6127383c166ea8d1e5699af9c371827f98bcbb86a991458282101ebf8602d6082e953340925a5327b474566e82d41fd98e1> OP_CHECKSIG
<Chris_Stewart_5>
Ok, so how is this different than p2sh(witSPKv1) for taproot? My understanding is that this is a valid redeem script that trivially passes. If the P2PK had a leading OP_1 and no OP_CHECKSIG it would be a trivially true p2sh(witSPKV1)?
<sipa>
there is nothing witv1 here
<sipa>
this is literally just a P2SH test case
<sipa>
nothing taproot related
<Chris_Stewart_5>
I understand that now, but is very similar to another corner case i would imagine is tested in these test vectors?
Guest23 has joined #bitcoin-core-dev
<Guest23>
wtf is this
<Guest23>
<aptsecure> Also Bitcoin 0.8.1 released by Gavin Andresen who was stupid enough to give write access to some Blockstream people who stabbed him in the back and revoked his access to the repository, Gavin was the person Satoshi entrusted in supervising Bitcoin's development not this Blockstream monkeys
<sipa>
Chris_Stewart_5: as the code i linked you says: # Also add a few legacy spends into the mix, so that transactions which combine taproot and pre-taproot spends get tested too.
<sipa>
but other than that, it's also just a useful test for the P2SH code
<Guest23>
it seems to me that Bitcoin is under attack
<Guest23>
<aptsecure> you know, since 2015 the Bitcoin protocol dramatically changed by one single entity Blockstream Inc which literally paid millions to "Bitcoin Core" developers to impelemt segwit, lightning and all kinds of crap... before 2015 there was just Bitcoin, "Bitcoin Core" is invented by Blockstream
<Chris_Stewart_5>
I think we are talking past each other. I will come back if this test case appears in the vectors. Thanks for your time Pieter.
<sipa>
Chris_Stewart_5: i'm very confused... you are talking about a case in the test vectors?
Guest23 was banned on #bitcoin-core-dev by ChanServ [Guest23!*@*]
Guest23 was kicked from #bitcoin-core-dev by ChanServ [User is banned from this channel]
<Chris_Stewart_5>
1. You've answered my question, you are right it p2sh(p2pk)
<Chris_Stewart_5>
3. When looking at BIP341 you confirm that for future soft fork extensibility you have p2sh(witSPKV1) is trivially true
<blockvomitinc>
you going to return write access to Gavin Andresen
<blockvomitinc>
Blockstream muotherfuckers
blockvomitinc was banned on #bitcoin-core-dev by ChanServ [*!*@129.227.219.5]
blockvomitinc was kicked from #bitcoin-core-dev by ChanServ [User is banned from this channel]
<sipa>
Chris_Stewart_5: right
<Chris_Stewart_5>
4. You assume that is what's going on in the test case, especially since this is in the 'success' json object. I didn't look closely enough at the script and notice the slight difference between p2tr and p2pk in a redeem script
<Chris_Stewart_5>
So like all good test cases for corner cases, it confuses the person implementing them :-). Again, thank you for your time
<sipa>
there are other tests to verify that p2sh-p2tr is not constraining
<Chris_Stewart_5>
I assumed so, which is why i kept asking
<sipa>
look for applic/keypath and applic/scriptpath
<sipa>
under this comment in feature_taproot.py:
<sipa>
# == Test that BIP341 spending only applies to witness version 1, program length 32, no P2SH ==
<Chris_Stewart_5>
Is there any glossary for these comments? They don't mean much to me. Is the `feature_taproot.py` file the best reference?