morcos has quit [Remote host closed the connection]
morcos has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
copumpkin has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
grettke has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
mdrollette has quit [Quit: bye]
murrayn has joined #bitcoin-core-dev
murrayn has quit [Changing host]
murrayn has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
grettke has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
yanmaani has quit [Ping timeout: 276 seconds]
<luke-jr> is it intentional that test-security-check.py doesn't work in standard environments?
yanmaani has joined #bitcoin-core-dev
<luke-jr> fanquake:
<fanquake> elaborate on doesn’t work and standard
Guest98 has joined #bitcoin-core-dev
busybusybusy has quit [Read error: Connection reset by peer]
Guest98 has quit [Quit: Ping timeout (120 seconds)]
tralfaz has joined #bitcoin-core-dev
davterra has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
achow101 has quit [Quit: Bye]
achow101 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 245 seconds]
<luke-jr> fanquake: it depends on a number of non-standard ld options; eg --no-nxcompat
<luke-jr> (curiously, standard binutils *does* have a --disable-nxcompat option)
<fanquake> Sure. We patch in support for those no-* variants into our release binutils, same as Debian does
<fanquake> So they are nonstandard, but always present in our release environment, which is primarily where the (test)-security-check scripts need to be run
<luke-jr> as long as it's intentional ☺
<fanquake> as for the disable-nxcompat in binutils, that is only a quite recent addition
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/7efc62853957...994aaaa88d41
<bitcoin-git> bitcoin/master e58598e John Newbery: [addrman] Add doxygen comment to AddrMan::Add()
<bitcoin-git> bitcoin/master 2658eb6 John Newbery: [addrman] Rename Add_() to AddSingle()
<bitcoin-git> bitcoin/master 2095df7 John Newbery: [addrman] Add Add_() inner function, fix Add() return semantics
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake merged pull request #23380: addrman: Fix AddrMan::Add() return semantics and logging (master...2021-10-addrman-add-logging) https://github.com/bitcoin/bitcoin/pull/23380
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
nanotube has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/994aaaa88d41...3fc3641043be
<bitcoin-git> bitcoin/master 26a50ab Russell Yanofsky: refactor: Split InterpretOption into Interpret{Key,Value} functions
<bitcoin-git> bitcoin/master b8c069b Russell Yanofsky: refactor: Add explicit DISALLOW_NEGATION ArgsManager flag to clarify flag ...
<bitcoin-git> bitcoin/master c5d7e34 Russell Yanofsky: scripted-diff: disable unimplemented ArgsManager BOOL/INT/STRING flags
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] fanquake merged pull request #22766: refactor: Clarify and disable unused ArgsManager flags (master...pr/argscripts) https://github.com/bitcoin/bitcoin/pull/22766
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
provoostenator has quit [Ping timeout: 268 seconds]
provoostenator has joined #bitcoin-core-dev
achow101 has quit [Quit: Bye]
achow101 has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
cfields has quit [*.net *.split]
hebasto has quit [*.net *.split]
ajonas has quit [*.net *.split]
elichai2 has quit [*.net *.split]
ajonas has joined #bitcoin-core-dev
cfields has joined #bitcoin-core-dev
hebasto has joined #bitcoin-core-dev
elichai2 has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
cdecker[m] has quit [*.net *.split]
kakolainen[m] has quit [*.net *.split]
Henry151 has quit [*.net *.split]
dvd has quit [*.net *.split]
takinbo has quit [*.net *.split]
emzy has quit [*.net *.split]
andytoshi has quit [*.net *.split]
shiza has quit [*.net *.split]
emzy has joined #bitcoin-core-dev
andytoshi has joined #bitcoin-core-dev
takinbo has joined #bitcoin-core-dev
dvd has joined #bitcoin-core-dev
Henry151 has joined #bitcoin-core-dev
shiza has joined #bitcoin-core-dev
kakolainen[m] has joined #bitcoin-core-dev
cdecker[m] has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Client Quit]
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Client Quit]
mikehu44 has joined #bitcoin-core-dev
tla2k21 has quit [Remote host closed the connection]
tla2k21 has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
tla2k21 has quit [Remote host closed the connection]
Guyver2 has joined #bitcoin-core-dev
tla2k21 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Talkless has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
masta`` has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
AaronvanW has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
rex4539 has quit [Remote host closed the connection]
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
bodom has joined #bitcoin-core-dev
<bodom> Hi there! I am trying to understand an hex scriptpubkey: "6a04665678a0" bitcoin core API decodes it into ASM as "OP_RETURN -544757350" but, to my understanding, it should be "OP_RETURN -1602726298". Where i am wrong? This is driving me crazy.
<bodom> -544757350 is 9aa987df to my understanding and i can't get where it is coming from
goatpig has quit [Ping timeout: 268 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23408: fuzz: Rework ConsumeScript (master...2111-fuzzScript) https://github.com/bitcoin/bitcoin/pull/23408
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
goatpig has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
<bodom> finally realized it, thanks
<bodom> i was swapping one bit :D
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
mikehu44 has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Guest16 has joined #bitcoin-core-dev
Guest16 has quit [Client Quit]
Guest7137 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23409: refactor: Take Span in SetSeed (master...2111-refKey) https://github.com/bitcoin/bitcoin/pull/23409
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest9861 has joined #bitcoin-core-dev
<Guest9861> Hi, I'm wondering if anyone would be ready for a block size increase to 10mb?
<sturles> No
<sturles> (Why?)
<Guest9861> Okay, care to explain why?
<sturles> Why increase the block size?
<Guest9861> Well I figure that would allow everyone on earth roughly 1 transaction per year.
<sturles> Not if they want to run their own node..
<Guest9861> Could you elaborate? I don't see what effect running ones own node would have on transaction throughput.
<sturles> Because it would be too expensive to run a node. The need for blockchain transactions is going down. Most people on earth would use LN instead.
<Guest9861> Can I safely store bitcoin on LN long term?
<Guest9861> It just seems like during the next wave of adoption transaction fees are going to spike back up to $50
<sturles> Long enough. Only a small fraction of earthlings would realistically be able to store a non-dust amount of BTC for the long term.
<Guest9861> Are you aware of the fact that the average earthling has a net worth of around $70k?
Guest7137 has quit [Quit: Client closed]
<sturles> Are you aware of how this wealth is distributed?
<Guest9861> Checking one sec
brunoerg has joined #bitcoin-core-dev
<Guest9861> okay so median is still about $7500
<sipa> off topic here
<sturles> Yep.
<Guest9861> Sorry sipa
<sipa> this channel is about development of the bitcoin core implementation
<Guest9861> I'm advocating for bigger blocks at some point
<Guest9861> Not necessarily now
<sipa> if you want to propose consensus changes, please get community consensus on it first, e.g. by discussing on the bitcoin-dev mailinglist
<sturles> The blocksize is currently not a bottleneck IMHO, and improvements are already beeing done with taproot and Schnorr signatures.
<sipa> please, take this elsewhere
<Guest9861> Okay thanks! I let you get back on topic now!
yanmaani has quit [Remote host closed the connection]
yanmaani has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
cdecker[m] has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> bitcoin/master 7986faf Hennadii Stepanov: test: Fix segfault in the psbt_wallet_tests/psbt_updater_test
<bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/3fc3641043be...5adc5c02800f
<bitcoin-git> bitcoin/master 68018e4 Hennadii Stepanov: test: Avoid excessive locking of `cs_wallet`
<bitcoin-git> bitcoin/master 5adc5c0 MarcoFalke: Merge bitcoin/bitcoin#23403: test: Fix segfault in the psbt_wallet_tests/p...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke merged pull request #23403: test: Fix segfault in the psbt_wallet_tests/psbt_updater_test (master...210331-psbt) https://github.com/bitcoin/bitcoin/pull/23403
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Guest9861 has quit [Quit: Client closed]
grettke has joined #bitcoin-core-dev
<josibake> is there a way to re-trigger a failed ci task? i am so far unable to reproduce a ci failure locally, so was hoping in the meanwhile to also retry the failed task on cirrus as a sanity check
Guyver2_ has joined #bitcoin-core-dev
<josibake> ah, nvm, figured it out! just needed to be signed into cirrus-labs to see the re-run option
chaotic_good has quit [Quit: ZNC 1.8.2+deb1+focal2 - https://znc.in]
chaotic_good has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
Guyver2_ is now known as Guyver2
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
Guyver2_ is now known as Guyver2
Guest73 has joined #bitcoin-core-dev
Guest73 has quit [Client Quit]
<sipa> achow101: thoughts on what needs to be done to merge the LEGACY and P2SH_SEGWIT OutputType into a BASE58 OutputType?
Talkless has quit [Quit: Konversation terminated!]
<sipa> for descriptor wallets, if it has an active descriptor for both, i'd say it can preferably pick the P2SH_SEGWIT one, and fall back to the LEGACY one, and turn that into the new BASE58 one
<sipa> not sure what's needed for legacy wallets
<sipa> can it just silently treat BASE58 as P2SH_SEGWIT was treated before?
<sipa> i'm kind of assuming it's leading to misconceptions like https://github.com/bitcoin-core/gui/pull/459
<hebasto> sipa: is it a time to mention BIPs 380..386 in the https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md ?
<sipa> hebasto: i guess they should be
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
gene has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] hebasto opened pull request #23410: doc: Add output script descriptors BIPs 380..386 (master...211101-bips) https://github.com/bitcoin/bitcoin/pull/23410
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jespada has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
goatpig has quit [Remote host closed the connection]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] MarcoFalke opened pull request #23411: refactor: Avoid integer overflow in ApplyStats when activating snapshot (master...2111-fuzzIntAmt) https://github.com/bitcoin/bitcoin/pull/23411
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44_ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
mikehu44 has quit [Ping timeout: 268 seconds]
mikehu44 has joined #bitcoin-core-dev
mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
jespada has joined #bitcoin-core-dev
jespada has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
benny33 has joined #bitcoin-core-dev
benny33 has quit [Client Quit]
<achow101> sipa: I think some legacy wallet users will still want to be able to get legacy addresses
<sipa> i don't see the point of maintaining that feature
<sipa> though, my issue is mostly with descriptor wallets
<sipa> in legacy wallets, the outputtype directly picks the derivation
<sipa> in descriptor wallets, i don't think there is a need for more than one active descriptor per addresstype (base58/bech32/bech32m), as the choice of which derivation is corresponds to is just wallet config
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
<achow101> why not have BASE58 be a new output type entirely which will have its own active descriptor? If a wallet doesn't have a BASE58, then we can silently upgrade it by making p2sh-segwit the base58 one, with the fallback to legacy
luke-jr has quit [Quit: ZNC - http://znc.sourceforge.net]
luke-jr has joined #bitcoin-core-dev
<sipa> that's probably easier
<achow101> for new wallets, we can not set active descriptors for p2sh-segwit and legacy, and for old wallets, not remove those records so they can be downgraded
<achow101> it might be even easier to just rename P2SH_SEGWIT as BASE58? and add that the active LEGACY descriptor can be BASE58 if there is not already one.
<achow101> that would even maintain partial downgradability
<sipa> you'd need some special rules about inferring outputtype from descriptors, where now both legacy and p2sh-segwit become valid for base58
<achow101> if (type == LEGACY) return BASE58
Alina-malina has quit [Ping timeout: 246 seconds]
sipsorcery has joined #bitcoin-core-dev
<sipa> renaming p2sh-segwit to base58 also has this problem: what if you invoke `getnewaddress` with p2sh-segwit"
<sipa> as address type?
<achow101> perhaps alias then?
<sipa> if that still gets mapped to OutputType::BASE58, you get the following issue:
<sipa> in a descriptor wallet configured to have pkh() descriptor for base58, it'd return a P2PKH address, despite p2sh-segwit being requested
<achow101> are you planning on having getnewaddress still support legacy and p2sh-segwit output types?
<sipa> for descriptor wallets, there wouldn't be a need (especially not newly created ones)
rex4539 has quit [Remote host closed the connection]
<sipa> i'm just pointing out that renaming P2SH_SEGWIT to BASE58 (but then still mapping the "p2sh-segwit" string to BASE58) can lead to unexpected behavior
rex4539 has joined #bitcoin-core-dev
<achow101> ah
<achow101> I think it would be possible to limit the acceptable strings by wallet type
<achow101> e.g. p2sh-segwit and legacy are disallowed values for descriptor wallets
<sipa> yeah; but i think that's easier if BASE58 is a separate output type from P2SH_SEGWIT and LEGACY
<achow101> ok
ishaqm has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
kexkey has joined #bitcoin-core-dev
Alina-malina has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
___nick___ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 268 seconds]
___nick___ has quit [Client Quit]
___nick___ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
sipsorcery has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
ishaqm has quit [Remote host closed the connection]
ishaqm has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Talkless has joined #bitcoin-core-dev
laanwj has quit [Quit: WeeChat 3.3]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
DeanGuss has quit [Quit: buhbye]
DeanGuss has joined #bitcoin-core-dev
DeanGuss has quit [Changing host]
DeanGuss has joined #bitcoin-core-dev
pigeons has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git> [bitcoin] sipa opened pull request #23413: Replace MakeSpan helper with Span deduction guide (master...202111_span_deduct) https://github.com/bitcoin/bitcoin/pull/23413
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 268 seconds]
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
___nick___ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
roconnor has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
Guyver2_ is now known as Guyver2
brunoerg has joined #bitcoin-core-dev
ademan[m] has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Talkless has quit [Quit: Konversation terminated!]
Xandrah has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
brunoerg has joined #bitcoin-core-dev
kexkey has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
gene has quit [Ping timeout: 276 seconds]
sipsorcery has quit [Ping timeout: 268 seconds]
kexkey has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
jespada has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
jespada has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]