<jonatack>
michaelfolkson: the reply by prayank seems reasonable; perhaps handle the question over there unless there is an issue with bitcoin core itself.
<michaelfolkson>
jonatack: Cool, thanks
bw__ has quit []
bw has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
bitdex_ has quit [Quit: = ""]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Ping timeout: 264 seconds]
bomb-on has quit [Read error: Connection reset by peer]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #23573: refactor: cast bool operand to int to silence compiler warning (master...silence-Wbitwise-instead-of-logical-warnings) https://github.com/bitcoin/bitcoin/pull/23573
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
goatpig has quit [Remote host closed the connection]
hsmiths has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] RandyMcMillan opened pull request #481: qt:rpcconsole:accessibility - new shortcuts enable single hand gesture (master...console-shortcuts) https://github.com/bitcoin-core/gui/pull/481
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sudoforge has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
roconnor has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 264 seconds]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
grettke has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 245 seconds]
bairen has quit [Ping timeout: 276 seconds]
bairen has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
gnaf has quit [Quit: Konversation terminated!]
bairen has quit [Remote host closed the connection]
AaronvanW has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
ovideus has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 260 seconds]
jtrag has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
jtrag has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
ovideus has quit [Client Quit]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 260 seconds]
grettke has joined #bitcoin-core-dev
gene has quit [Quit: gene]
gene has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 264 seconds]
AaronvanW has joined #bitcoin-core-dev
bitdex has quit [Ping timeout: 276 seconds]
belcher has quit [Ping timeout: 256 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 264 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 268 seconds]
gene has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 245 seconds]
gene has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
roconnor has quit [Changing host]
roconnor has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
kcalvinalvin has quit [*.net *.split]
da2ce7 has quit [*.net *.split]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
smartin has quit [Read error: Connection reset by peer]
smartin has joined #bitcoin-core-dev
kcalvinalvin has joined #bitcoin-core-dev
da2ce7 has joined #bitcoin-core-dev
belcher has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
goatpig has quit [Remote host closed the connection]
AaronvanW has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
smartin has quit [Read error: Connection reset by peer]
Talkless has quit [Quit: Konversation terminated!]
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
roconnor has quit [Ping timeout: 264 seconds]
<Kaizen_Kintsugi>
hai
<Kaizen_Kintsugi>
Wondering about building on M1 osx
<Kaizen_Kintsugi>
I'm reading in the build docs for osx that these instructions are for intel macs only
<hebasto>
Kaizen_Kintsugi: better to ask in #bitcoin-core-builds
<Kaizen_Kintsugi>
thx hebasto
<Kaizen_Kintsugi>
I'm on core-pr-reviews, core-dev, and core-builds is there any other essential channels I should be aware of?
<hebasto>
Kaizen_Kintsugi: #bitcoin-core-gui
<Kaizen_Kintsugi>
heb: ty
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 260 seconds]
arythmetic has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 245 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi has joined #bitcoin-core-dev
<dongcarl>
I keep running into cases where I need the polymorphism that a pointer provides but not the "null-ability"... In some cases I even want to prevent the possibility of nullptr. Wondering if others encounter this case too...
<sipa>
std::reference_wrapper<X> ?
<sipa>
or just a reference, depending on usage
<dongcarl>
seems like a const unique_ptr was what I needed...
<sipa>
👍
Guyver2 has left #bitcoin-core-dev [Closing Window]
Kaizen_Kintsugi has quit [Remote host closed the connection]
arythmetic has quit [Remote host closed the connection]
<jeremyrubin>
reference_wrapper does sound a bit more right, but if you need storage then it does sound like you want a unique_ptr, but const does not guarantee not null.... there's also the gsl::not_null paradigm which is what you want, but we don't have that (i'd ACK adding it though)
<dongcarl>
jeremyrubin: Yeah I've been looking at that... not_null might also help with interfaces where we don't actually expect a nullptr, but it's just a ptr for some historical reason (e.g. a lot of the CBlockIndex* calls)
<dongcarl>
gene: I think that's a compile-time test of if a particular type is literally the nullptr type
<gene>
i.e. writing a custom wrapper class around pointed-to types that uses std::is_null_pointer to check an internal pointer
Kaizen_Kintsugi has quit [Remote host closed the connection]
Kaizen_Kintsugi has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 264 seconds]
<gene>
dongcarl: jeremyrubin: that file looks pretty stand-alone, were you thinking just rip that out of the GSL lib?
<gene>
or adding all GSL?
jonatack has quit [Ping timeout: 260 seconds]
<dongcarl>
gene: Yeah it's nice it's all header-only. We could just take the pieces that make sense... Funnily enough we've got our own implementation of Expects and Ensures already... I've also seen a few reinventions of finally_action (e.g. RAIICallbacksRunning in ProcessQueue)
Guest60 has joined #bitcoin-core-dev
<gene>
dongcarl: for sure, will take a look at the Expects/Ensures impls
gene has quit [Quit: gene]
Guest60 has quit [Quit: Client closed]
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 264 seconds]
vysn has quit [Ping timeout: 250 seconds]
jtrag has quit [Remote host closed the connection]
<Kaizen_Kintsugi>
hmm
<Kaizen_Kintsugi>
I'm looking at the bitcoin test framework