#bitcoin-core-dev on 2021-11-13 — searchable irc log

00:01 bitcoin-git has joined #bitcoin-core-dev

00:01 <bitcoin-git> [bitcoin] theStack opened pull request #23501: test: various feature_nulldummy.py improvements (master...202111-test-nulldummy_improvements) https://github.com/bitcoin/bitcoin/pull/23501

00:01 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

00:03 brunoerg has quit [Ping timeout: 268 seconds]

00:04 brunoerg has joined #bitcoin-core-dev

00:05 sipsorcery has quit [Ping timeout: 265 seconds]

00:08 brunoerg has quit [Ping timeout: 245 seconds]

00:09 sipsorcery has joined #bitcoin-core-dev

00:15 Guest88 has quit [Ping timeout: 256 seconds]

00:19 javi404 has joined #bitcoin-core-dev

00:26 brunoerg has joined #bitcoin-core-dev

00:31 brunoerg has quit [Ping timeout: 268 seconds]

00:32 brunoerg has joined #bitcoin-core-dev

00:36 sipsorcery has quit [Read error: Connection reset by peer]

00:36 brunoerg has quit [Ping timeout: 264 seconds]

00:37 brunoerg has joined #bitcoin-core-dev

00:42 brunoerg has quit [Ping timeout: 268 seconds]

00:47 masta`` has quit [Read error: Connection reset by peer]

00:48 brunoerg has joined #bitcoin-core-dev

00:49 bfsfhkacjzgcytf has quit [Ping timeout: 260 seconds]

00:52 brunoerg has quit [Ping timeout: 245 seconds]

00:54 brunoerg has joined #bitcoin-core-dev

00:58 brunoerg has quit [Ping timeout: 268 seconds]

01:10 <achow101> sipa: I suppose there isn't some way to indicate in a tr() descriptor that the internal key is bogus?

01:16 brunoerg has joined #bitcoin-core-dev

01:20 brunoerg has quit [Ping timeout: 260 seconds]

01:25 <sipa> achow101: no, but there probably should be (both a standardized way of doing that, and a way to do that in descriptors)

01:27 brunoerg has joined #bitcoin-core-dev

01:31 brunoerg has quit [Ping timeout: 245 seconds]

01:37 brunoerg has joined #bitcoin-core-dev

01:42 brunoerg has quit [Ping timeout: 268 seconds]

01:43 brunoerg has joined #bitcoin-core-dev

01:44 jesseposner has quit [Quit: Textual IRC Client: www.textualapp.com]

01:48 brunoerg has quit [Ping timeout: 264 seconds]

01:58 bitcoin-git has joined #bitcoin-core-dev

01:58 <bitcoin-git> [bitcoin] achow101 opened pull request #23502: wallet: Avoid underpaying transaction fees when signing taproot spends (master...tr-low-fee-est) https://github.com/bitcoin/bitcoin/pull/23502

01:58 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

02:05 <roasbeef> achow101: so what's the logic behind that? if a node can serve all blocks (node_network), then it can also serve the last 288 (node_limited), so why set them both? seems wrong imo

02:05 brunoerg has joined #bitcoin-core-dev

02:06 <roasbeef> given node network subsumes node limited

02:08 <roasbeef> since "I can serve all blocks" also entails that you can serve the last 288, so it's a redundant bit/signal

02:08 <achow101> roasbeef: not sure. https://github.com/bitcoin/bitcoin/pull/10387#discussion_r142410638 sounds like there was probably some mailing list discussion about that

02:09 <roasbeef> heh, interesting they argued for the opposite: always set it since one implies the other

02:10 brunoerg has quit [Ping timeout: 268 seconds]

02:10 <roasbeef> well led to a bug fix in btwallet/lnd, so that's nice, but don't fault the OP of the code given that was a safe assumption (that they were exclusive)

02:16 brunoerg has joined #bitcoin-core-dev

02:20 brunoerg has quit [Ping timeout: 245 seconds]

02:22 brunoerg has joined #bitcoin-core-dev

02:25 AaronvanW has quit [Quit: Leaving...]

02:27 brunoerg has quit [Ping timeout: 268 seconds]

02:38 jesseposner has joined #bitcoin-core-dev

02:44 brunoerg has joined #bitcoin-core-dev

02:49 brunoerg has quit [Ping timeout: 268 seconds]

02:54 fulldecent has joined #bitcoin-core-dev

02:55 karonto has quit [Ping timeout: 256 seconds]

03:05 <sipa> roasbeef: nodes OR service flags together when rumoured addresses conflict

03:06 <sipa> i had forgotten myself that NODE_LIMITED didn't imply pruning, it only means being able to serve the last 288

03:06 brunoerg has joined #bitcoin-core-dev

03:08 <sipa> but this ORing logic kind of means you have to see service flags as independent capabilities, and you can't do things easily like interpreting a group of 2 bits as a 4-valued choice

03:11 brunoerg has quit [Ping timeout: 264 seconds]

03:12 brunoerg has joined #bitcoin-core-dev

03:13 Kaizen_Kintsugi has quit [Remote host closed the connection]

03:13 Kaizen_Kintsugi has joined #bitcoin-core-dev

03:17 brunoerg has quit [Ping timeout: 268 seconds]

03:17 brunoerg has joined #bitcoin-core-dev

03:18 Kaizen_Kintsugi has quit [Ping timeout: 268 seconds]

03:21 roconnor has quit [Remote host closed the connection]

03:21 brunoerg has quit [Ping timeout: 245 seconds]

03:28 brunoerg has joined #bitcoin-core-dev

03:29 ghost43 has quit [Remote host closed the connection]

03:30 ghost43 has joined #bitcoin-core-dev

03:32 Kaizen_Kintsugi has joined #bitcoin-core-dev

03:33 brunoerg has quit [Ping timeout: 268 seconds]

03:34 brunoerg has joined #bitcoin-core-dev

03:35 bfsfhkacjzgcytf has joined #bitcoin-core-dev

03:35 bfsfhkacjzgcytf has quit [Client Quit]

03:36 bfsfhkacjzgcytf has joined #bitcoin-core-dev

03:38 brunoerg has quit [Ping timeout: 245 seconds]

03:46 roconnor has joined #bitcoin-core-dev

03:55 brunoerg has joined #bitcoin-core-dev

03:59 fulldecent has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

04:00 brunoerg has quit [Ping timeout: 264 seconds]

04:29 brunoerg has joined #bitcoin-core-dev

04:33 brunoerg has quit [Ping timeout: 264 seconds]

04:51 brunoerg has joined #bitcoin-core-dev

04:56 brunoerg has quit [Ping timeout: 268 seconds]

04:58 jarthur has joined #bitcoin-core-dev

05:01 cmirror has quit [Remote host closed the connection]

05:01 cmirror has joined #bitcoin-core-dev

05:02 brunoerg has joined #bitcoin-core-dev

05:06 brunoerg has quit [Ping timeout: 245 seconds]

05:13 brunoerg has joined #bitcoin-core-dev

05:13 bfsfhkacjzgcytf has quit [Ping timeout: 256 seconds]

05:17 brunoerg has quit [Ping timeout: 264 seconds]

05:19 brunoerg has joined #bitcoin-core-dev

05:23 brunoerg has quit [Ping timeout: 260 seconds]

05:24 brunoerg has joined #bitcoin-core-dev

05:28 brunoerg has quit [Ping timeout: 245 seconds]

05:35 brunoerg has joined #bitcoin-core-dev

05:39 brunoerg has quit [Ping timeout: 245 seconds]

05:41 brunoerg has joined #bitcoin-core-dev

05:46 brunoerg has quit [Ping timeout: 268 seconds]

05:46 brunoerg has joined #bitcoin-core-dev

05:48 martinus has quit [Remote host closed the connection]

05:51 brunoerg has quit [Ping timeout: 264 seconds]

05:57 brunoerg has joined #bitcoin-core-dev

06:01 brunoerg has quit [Ping timeout: 245 seconds]

06:03 brunoerg has joined #bitcoin-core-dev

06:08 brunoerg has quit [Ping timeout: 264 seconds]

06:25 brunoerg has joined #bitcoin-core-dev

06:30 brunoerg has quit [Ping timeout: 268 seconds]

06:31 bfsfhkacjzgcytf has joined #bitcoin-core-dev

06:32 mikehu44 has joined #bitcoin-core-dev

06:36 seaner has quit [Remote host closed the connection]

06:36 brunoerg has joined #bitcoin-core-dev

06:41 brunoerg has quit [Ping timeout: 268 seconds]

06:43 roconnor has quit [Remote host closed the connection]

06:47 brunoerg has joined #bitcoin-core-dev

06:51 brunoerg has quit [Ping timeout: 264 seconds]

06:53 brunoerg has joined #bitcoin-core-dev

06:57 brunoerg has quit [Ping timeout: 268 seconds]

07:05 earnestly has quit [Ping timeout: 256 seconds]

07:13 sdfgsdfg has joined #bitcoin-core-dev

07:14 brunoerg has joined #bitcoin-core-dev

07:18 brunoerg has quit [Ping timeout: 245 seconds]

07:20 brunoerg has joined #bitcoin-core-dev

07:25 brunoerg has quit [Ping timeout: 265 seconds]

07:53 brunoerg has joined #bitcoin-core-dev

07:53 kallewoof has quit [Ping timeout: 268 seconds]

07:57 brunoerg has quit [Ping timeout: 264 seconds]

07:59 brunoerg has joined #bitcoin-core-dev

08:03 brunoerg has quit [Ping timeout: 245 seconds]

08:10 brunoerg has joined #bitcoin-core-dev

08:14 brunoerg has quit [Ping timeout: 245 seconds]

08:19 karonto has joined #bitcoin-core-dev

08:21 brunoerg has joined #bitcoin-core-dev

08:25 brunoerg has quit [Ping timeout: 264 seconds]

08:27 brunoerg has joined #bitcoin-core-dev

08:31 brunoerg has quit [Ping timeout: 265 seconds]

08:32 brunoerg has joined #bitcoin-core-dev

08:37 brunoerg has quit [Ping timeout: 268 seconds]

08:43 brunoerg has joined #bitcoin-core-dev

08:48 brunoerg has quit [Ping timeout: 260 seconds]

08:54 brunoerg has joined #bitcoin-core-dev

08:58 brunoerg has quit [Ping timeout: 264 seconds]

09:00 brunoerg has joined #bitcoin-core-dev

09:04 brunoerg has quit [Ping timeout: 245 seconds]

09:08 jarthur has quit [Quit: jarthur]

09:14 RubenSomsen has quit [Ping timeout: 256 seconds]

09:14 dergoegge has quit [Ping timeout: 256 seconds]

09:16 hendi has quit [Ping timeout: 264 seconds]

09:17 RubenSomsen has joined #bitcoin-core-dev

09:18 hendi has joined #bitcoin-core-dev

09:19 blkncd has quit [Ping timeout: 256 seconds]

09:20 karonto has quit [Quit: This computer has gone to sleep]

09:20 bitcoin-git has joined #bitcoin-core-dev

09:20 <bitcoin-git> [bitcoin] dougEfresh opened pull request #23503: ci, refactor: Use Ubuntu release date tags instead of release names (master...ci-ubuntu-date-tag) https://github.com/bitcoin/bitcoin/pull/23503

09:20 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

09:22 brunoerg has joined #bitcoin-core-dev

09:22 earnestly has joined #bitcoin-core-dev

09:23 blkncd has joined #bitcoin-core-dev

09:23 sdfgsdfg has quit [Quit: ZzzZ]

09:24 dergoegge has joined #bitcoin-core-dev

09:26 stick has quit [Ping timeout: 256 seconds]

09:26 brunoerg has quit [Ping timeout: 264 seconds]

09:26 bw has quit [Ping timeout: 264 seconds]

09:29 bw has joined #bitcoin-core-dev

09:29 stick has joined #bitcoin-core-dev

09:32 brunoerg has joined #bitcoin-core-dev

09:33 Guyver2 has joined #bitcoin-core-dev

09:37 brunoerg has quit [Ping timeout: 264 seconds]

09:38 brunoerg has joined #bitcoin-core-dev

09:43 brunoerg has quit [Ping timeout: 245 seconds]

09:57 Cory has joined #bitcoin-core-dev

10:03 kexkey has quit [Ping timeout: 245 seconds]

10:05 kexkey has joined #bitcoin-core-dev

10:05 brunoerg has joined #bitcoin-core-dev

10:10 brunoerg has quit [Ping timeout: 264 seconds]

10:13 karonto has joined #bitcoin-core-dev

10:17 brunoerg has joined #bitcoin-core-dev

10:21 brunoerg has quit [Ping timeout: 245 seconds]

10:28 brunoerg has joined #bitcoin-core-dev

10:28 bitcoin-git has joined #bitcoin-core-dev

10:28 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23504: ci: Replace soon EOL hirsute with jammy (master...2111-ciJammy) https://github.com/bitcoin/bitcoin/pull/23504

10:28 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:28 sdfgsdfg has joined #bitcoin-core-dev

10:29 goatpig has joined #bitcoin-core-dev

10:32 brunoerg has quit [Ping timeout: 265 seconds]

10:34 brunoerg has joined #bitcoin-core-dev

10:36 AaronvanW has joined #bitcoin-core-dev

10:38 brunoerg has quit [Ping timeout: 264 seconds]

10:46 sdfgsdfg has quit [Quit: ZzzZ]

10:51 brunoerg has joined #bitcoin-core-dev

11:10 brunoerg has quit [Ping timeout: 256 seconds]

11:16 brunoerg has joined #bitcoin-core-dev

11:21 brunoerg has quit [Ping timeout: 264 seconds]

11:27 brunoerg has joined #bitcoin-core-dev

11:27 sudoforge has quit [Ping timeout: 268 seconds]

11:32 brunoerg has quit [Ping timeout: 268 seconds]

11:33 brunoerg has joined #bitcoin-core-dev

11:38 brunoerg has quit [Ping timeout: 265 seconds]

11:38 brunoerg has joined #bitcoin-core-dev

11:43 brunoerg has quit [Ping timeout: 245 seconds]

11:49 brunoerg has joined #bitcoin-core-dev

11:54 brunoerg has quit [Ping timeout: 268 seconds]

11:55 brunoerg has joined #bitcoin-core-dev

11:56 seaona has joined #bitcoin-core-dev

12:00 brunoerg has quit [Ping timeout: 264 seconds]

12:11 karonto has quit [Quit: This computer has gone to sleep]

12:17 brunoerg has joined #bitcoin-core-dev

12:18 karonto has joined #bitcoin-core-dev

12:22 brunoerg has quit [Ping timeout: 256 seconds]

12:22 mikehu44 has quit [Quit: No Ping reply in 180 seconds.]

12:24 mikehu44 has joined #bitcoin-core-dev

12:34 karonto has quit [Quit: This computer has gone to sleep]

12:46 brunoerg has joined #bitcoin-core-dev

12:50 brunoerg has quit [Ping timeout: 265 seconds]

12:56 goatpig has quit [Ping timeout: 256 seconds]

12:59 fulldecent has joined #bitcoin-core-dev

13:02 mikehu44 has quit [Quit: No Ping reply in 180 seconds.]

13:03 mikehu44 has joined #bitcoin-core-dev

13:06 karonto has joined #bitcoin-core-dev

13:12 AaronvanW has quit [Quit: Leaving...]

13:16 seaona has quit [Ping timeout: 256 seconds]

13:16 mikehu44 has quit [Ping timeout: 265 seconds]

13:25 karonto has quit [Quit: This computer has gone to sleep]

13:29 Guyver2_ has joined #bitcoin-core-dev

13:31 Guyver2 has quit [Ping timeout: 256 seconds]

13:31 Guyver2_ is now known as Guyver2

13:32 seaona has joined #bitcoin-core-dev

13:33 dermoth has quit [Quit: Leaving]

13:33 _andrewtoth_ has quit [Remote host closed the connection]

13:34 _andrewtoth_ has joined #bitcoin-core-dev

13:36 brunoerg has joined #bitcoin-core-dev

13:37 bomb-on has joined #bitcoin-core-dev

13:40 brunoerg has quit [Ping timeout: 245 seconds]

13:43 bitcoin-git has joined #bitcoin-core-dev

13:43 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #23505: 🥕 (master...2111-versionbitsNoTaproot) https://github.com/bitcoin/bitcoin/pull/23505

13:43 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

13:51 mikehu44 has joined #bitcoin-core-dev

13:57 mikehu44 has quit [Quit: No Ping reply in 180 seconds.]

14:02 mikehu44 has joined #bitcoin-core-dev

14:10 brunoerg has joined #bitcoin-core-dev

14:12 bitdex has joined #bitcoin-core-dev

14:13 roconnor has joined #bitcoin-core-dev

14:15 brunoerg has quit [Ping timeout: 256 seconds]

14:17 goatpig has joined #bitcoin-core-dev

14:17 RDK has joined #bitcoin-core-dev

14:21 Guyver2 has quit [Remote host closed the connection]

14:23 seaona has quit [Ping timeout: 256 seconds]

14:31 andrewtoth_ has joined #bitcoin-core-dev

14:34 _andrewtoth_ has quit [Ping timeout: 276 seconds]

14:49 Guest64 has joined #bitcoin-core-dev

14:50 Guest64 has quit [Client Quit]

14:51 RDK has quit [Quit: Leaving]

14:54 karonto has joined #bitcoin-core-dev

15:02 brunoerg has joined #bitcoin-core-dev

15:06 brunoerg has quit [Ping timeout: 260 seconds]

15:22 fulldecent has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]

15:31 Guyver2 has joined #bitcoin-core-dev

15:51 brunoerg has joined #bitcoin-core-dev

15:56 brunoerg has quit [Ping timeout: 268 seconds]

16:02 gene has quit [Remote host closed the connection]

16:03 gene has joined #bitcoin-core-dev

16:07 sudoforge has joined #bitcoin-core-dev

16:36 Talkless has joined #bitcoin-core-dev

16:43 brunoerg has joined #bitcoin-core-dev

16:46 b10c has joined #bitcoin-core-dev

16:47 brunoerg has quit [Ping timeout: 265 seconds]

16:59 realies has quit [Ping timeout: 268 seconds]

17:02 realies has joined #bitcoin-core-dev

17:35 brunoerg has joined #bitcoin-core-dev

17:39 brunoerg has quit [Ping timeout: 268 seconds]

17:59 bitcoin-git has joined #bitcoin-core-dev

17:59 <bitcoin-git> [bitcoin] MarcoFalke closed pull request #22901: Improve mempool_package_limits.py (master...master) https://github.com/bitcoin/bitcoin/pull/22901

17:59 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

18:22 Kaizen_Kintsugi has quit [Remote host closed the connection]

18:22 Kaizen_Kintsugi has joined #bitcoin-core-dev

18:25 brunoerg has joined #bitcoin-core-dev

18:29 brunoerg has quit [Ping timeout: 265 seconds]

18:41 goatpig has quit [Ping timeout: 256 seconds]

18:48 bitcoin-git has joined #bitcoin-core-dev

18:48 <bitcoin-git> [bitcoin] hebasto opened pull request #23506: test: Make more shell scripts verifiable by the `shellcheck` tool (master...211113-lint-shell) https://github.com/bitcoin/bitcoin/pull/23506

18:48 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

19:14 prayank has joined #bitcoin-core-dev

19:15 brunoerg has joined #bitcoin-core-dev

19:17 gnaf has quit [Quit: Konversation terminated!]

19:20 brunoerg has quit [Ping timeout: 245 seconds]

19:20 <prayank> Hi CORE devs. I was planning to rename few things in code as web4 after Taproot activates and it will be good for Lightning Network (The only layer 2 that we focus on and still no way to create tokens or good privacy) Trust me it will work and few devs already working on LN agree on such things. We can even remove mempool to make bitcoin a complete meme. And lot of other features. Thanks. Happy weekend. Cheers.

19:20 prayank has quit [Quit: irc thread exit]

20:06 brunoerg has joined #bitcoin-core-dev

20:11 brunoerg has quit [Ping timeout: 268 seconds]

20:20 Guest31 has joined #bitcoin-core-dev

20:21 <Guest31> Hello! I have a doubt, where i find docs for understanding the bitcoin code core?

20:28 Guest31 has quit [Quit: Client closed]

20:39 brunoerg has joined #bitcoin-core-dev

20:44 brunoerg has quit [Ping timeout: 264 seconds]

20:50 bitcoin-git has joined #bitcoin-core-dev

20:50 <bitcoin-git> [bitcoin] mjdietzx opened pull request #23507: Refactor: Improve API design of `ScriptToUniv`, `TxToUniv` (master...ret_UniValue_instead_of_pass_by_ref) https://github.com/bitcoin/bitcoin/pull/23507

20:50 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

21:04 Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]

21:09 mikehu44 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]

21:10 goatpig has joined #bitcoin-core-dev

21:34 brunoerg has joined #bitcoin-core-dev

21:36 jarthur has joined #bitcoin-core-dev

21:39 brunoerg has quit [Ping timeout: 268 seconds]

21:40 sipsorcery has joined #bitcoin-core-dev

21:55 goatpig has quit [Ping timeout: 245 seconds]

22:12 brunoerg has joined #bitcoin-core-dev

22:15 brunoerg has quit [Remote host closed the connection]

22:25 Talkless has quit [Quit: Konversation terminated!]

22:31 brunoerg has joined #bitcoin-core-dev

22:36 brunoerg has quit [Ping timeout: 264 seconds]

22:39 earnestly has quit [Read error: Connection reset by peer]

22:40 earnestly has joined #bitcoin-core-dev

22:44 burjay has joined #bitcoin-core-dev

22:46 burjay has quit [Client Quit]

22:53 sipsorcery has quit [Ping timeout: 265 seconds]

23:06 brunoerg has joined #bitcoin-core-dev

23:10 brunoerg has quit [Ping timeout: 268 seconds]

23:25 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

23:25 dougefish_ has joined #bitcoin-core-dev

23:27 dougefish has quit [Ping timeout: 250 seconds]

23:34 Bilnon has joined #bitcoin-core-dev

23:35 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

23:37 Bilnon has quit [Client Quit]

23:38 brunoerg has joined #bitcoin-core-dev

23:43 brunoerg has quit [Ping timeout: 256 seconds]

23:58 brunoerg has joined #bitcoin-core-dev