bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
bfsfhkacjzgcytf8 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
bfsfhkacjzgcytf has quit [Ping timeout: 264 seconds]
bfsfhkacjzgcytf8 is now known as bfsfhkacjzgcytf
brunoerg has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 264 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
b10c has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Ping timeout: 268 seconds]
common has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
common has quit [Changing host]
common has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
stortz has joined #bitcoin-core-dev
stortz has quit [Quit: Client closed]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Guest4 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
<Guest4>
Hi. Is there any valid I2P address to connect to ? I am getting the error "I2P: Error connecting to wwbw7nqr3ahkqv62cuqfwgtneekvvpnuc4i4f6yo7tpoqjswvcwa.b32.i2p:0: Unexpected reply to "NAMING LOOKUP NAME=wwbw7nqr3ahkqv62cuqfwgtneekvvpnuc4i4f6yo7tpoqjswvcwa.b32.i2p": "NAMING REPLY RESULT=INVALID_KEY
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
AaronvanW has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
midnight_ is now known as midnight
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
Guest4 has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
AaronvanW has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Alien`T has quit [Quit: Intergalactic Zombie Hunter]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
AaronvanW has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
vysn has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Guest4 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
brunoerg has quit [Ping timeout: 256 seconds]
earnestly has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
rex4539 has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
AaronvanW has quit [Ping timeout: 264 seconds]
robot-dreams has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
rex4539 has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
brunoerg has quit [Ping timeout: 240 seconds]
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 268 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
Guest4 has quit [Ping timeout: 256 seconds]
AaronvanW has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 264 seconds]
mikehu44_ has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
goatpig has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
rex4539 has quit [Ping timeout: 276 seconds]
_andrewtoth_ has joined #bitcoin-core-dev
andrewtoth_ has quit [Remote host closed the connection]
vasild_ has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23551: build: actually set CXX and CXXFLAGS for native_b2 build (master...actually_set_native_b2_cxx) https://github.com/bitcoin/bitcoin/pull/23551
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
sudoforge has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
b10c has joined #bitcoin-core-dev
rex4539 has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
jonatack12 has quit [Ping timeout: 256 seconds]
smartin has joined #bitcoin-core-dev
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
yanmaani1 has quit [Remote host closed the connection]
yanmaani1 has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 276 seconds]
yanmaani1 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
karonto has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 264 seconds]
brunoerg has joined #bitcoin-core-dev
dougefish has quit [Ping timeout: 256 seconds]
kexkey__ has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
yanmaani2 has joined #bitcoin-core-dev
yanmaani1 has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
crptorioux has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
vysn has quit [Ping timeout: 268 seconds]
brunoerg has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
yanmaani2 has quit [Ping timeout: 276 seconds]
Eloygn has joined #bitcoin-core-dev
yanmaani2 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
rex4539 has quit [Remote host closed the connection]
rex4539 has joined #bitcoin-core-dev
crptorioux has quit [Quit: Client closed]
goatpig has quit [Ping timeout: 260 seconds]
karonto has quit [Quit: Leaving]
goatpig has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z0d has quit [Ping timeout: 265 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
smartin1 has joined #bitcoin-core-dev
smartin has quit [Read error: Connection reset by peer]
smartin1 is now known as smartin
brunoerg has quit []
Eloygn has quit [Quit: Leaving]
contrapumpkin has joined #bitcoin-core-dev
copumpkin has quit [Ping timeout: 250 seconds]
gnaf has joined #bitcoin-core-dev
jtrag has quit [Read error: Connection reset by peer]
jtrag has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 276 seconds]
yanmaani2 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
yanmaani2 has quit [Remote host closed the connection]
yanmaani2 has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit []
Guest4 has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
bairen has quit [Ping timeout: 276 seconds]
<Guest4>
Where can I get valid I2P addresses to connect?
bairen has joined #bitcoin-core-dev
<sipa>
Guest4: there are I2P addresses circulating on the network; if you run an I2P enabled node you'll learn of some
<sipa>
mine is hnbbyjpxx54623l555sta7pocy3se4sdgmuebi5k6reesz5rjp6q.b32.i2p
arythmetic has quit [Remote host closed the connection]
vasild has quit [Ping timeout: 276 seconds]
vasild has joined #bitcoin-core-dev
vasild has quit [Remote host closed the connection]
goatpig has quit [Remote host closed the connection]
<Guest4>
sipa: Thankls. But I am getting the error below when trying to connect.
<Guest4>
I2P: Error connecting to hnbbyjpxx54623l555sta7pocy3se4sdgmuebi5k6reesz5rjp6q.b32.i2p:0: Receive timeout (received 0 bytes without terminator before that)
<Guest4>
I2P: Control socket error: not connected
<Guest4>
The i2pd.service is active (running) and the config file has:
<Guest4>
i2pacceptincoming=true
<Guest4>
debug=tor
<Guest4>
debug=i2p
<Guest4>
onlynet=onion
<Guest4>
onlynet=i2p
<Guest4>
i2psam=127.0.0.1:7656
vasild has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
realies has quit [Ping timeout: 250 seconds]
realies has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guest22 has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
<provoostenator>
Tl&dr achow101 has many PR's, most need review :-)
<achow101>
I have one pre-proposed meeting topic
dougefish has joined #bitcoin-core-dev
<achow101>
are there additional topics we should discuss today?
<fjahr>
hi
<michaelfolkson>
hi
<achow101>
#topic how to estimate sizes for taproot inputs (achow101)
<core-meetingbot>
topic: how to estimate sizes for taproot inputs (achow101)
<sipa>
that's a hard one
<gene>
hi
<sipa>
one early idea from a while ago was that descriptors themselves can contain hints about which keys are available
<provoostenator>
That would suggest different participants have different descriptors.
<sipa>
indeed
<achow101>
sipa: how does miniscript deal with this problem?
<sipa>
the question is the same
<sipa>
sanket1729_: ping
<provoostenator>
Every wallet should be able to know what it can sign with?
<sipa>
miniscript as logic for doing size estimation given a set of availability information for keys/preimages
<sipa>
*has
<provoostenator>
The more tricky part is if a wallet can sign in 2 ways, but another wallet can only sign in 1
<achow101>
one part of this issue is that not all information is available to watch only wallets
<achow101>
I have a branch that does do better estimation if private keys are available as it will end up estimating with the branch it will sign with
<provoostenator>
Maybe WalletDescriptor can hold and serialize more info for this puprose?
<sipa>
it's perhaps metadata that should live outside of descriptors
<fjahr>
the underlying assumption of taproot is there is one cooperative path that should be the default, can't we assume the key spent then by default and only fall back to other hints when they are present?
<provoostenator>
WalletDescriptor tracks the range, creation time. Though it doesn't track if the descriptor is change or not. So I supporse this info could be elsewhere too
<achow101>
fjahr: the problem is how do you know when to fallback
<achow101>
in particular if the inputs are not being chosen by the user
<achow101>
#23502 implements going with the largest case, but this means it will overpay if there is a script path
<sipa>
and it's complicated further by the fact that in psbt-land, you may be choosing the transaction before knowing who can sign
<provoostenator>
For now we could be lazy and just assume the keypath is used, unless the send RPC specifies a script path?
dougefish_ has joined #bitcoin-core-dev
<provoostenator>
Similary a PSBT could specify the script path (needs a new field).
<provoostenator>
(send RPC or any of the other sending and signing RPC's)
<sipa>
for PSBT i think the problem decomposes into two separate ones
<achow101>
provoostenator: how would that work if you don't know what inputs will be chosen?
dougefish has quit [Ping timeout: 268 seconds]
<provoostenator>
You mean for SIGHASH_SINGLE type transactions?
<sipa>
one is the ability to tell walletcreatefundedstuffs which keys will be present at signing, to make it better estimate the signing cost
<provoostenator>
Or do you mean as part of coin selection?
<sipa>
coin selection
<provoostenator>
We'd have to asses for each coin which paths are available, seems indeed painful.
<sipa>
the other is making processpsbt only emit information about key/script paths whose signing cost falls within the intended feerate
<sipa>
so if it's instructed to construct something which assuming a key path will be used, it needn't include information about script paths at all (of which there could be tons)
<achow101>
sipa: the latter sounds doable, the first, not so much
<provoostenator>
I guess every wallet UTXO could be associated with entries in the wallet database the represent the fee and required keys for the keypath and each scriptpath?
<provoostenator>
(not the fee, but the weight to spend)
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #23556: build, qt: Fix regression in rendering on macOS Big Sur (master...211119-macstyle) https://github.com/bitcoin/bitcoin/pull/23556
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<provoostenator>
Or perhaps things can be simplified, because within each descriptor the rules are the same.
<achow101>
provoostenator: I don't think it would be necessary to associate anything with each utxo
<achow101>
it's all with the descriptors, we need to be able to figure out what will be available at signing for each descriptor
<sanket1729_>
hello
<sanket1729_>
achow101: the information about potentially available singing keys can be in the psbt right?
<sipa>
sanket1729_: that's too late
<sipa>
you need this information when doing coin selection
<achow101>
sanket1729_: yes, but the question is for constructing the PSBT in the first place
<achow101>
when inputs are being chosen
jtrag has quit [Remote host closed the connection]
<sanket1729_>
yeah, why can you not have that while inputs are chosen? You just choose the change output last?
<achow101>
one possibility is to add an option to all the fund/send rpcs that has a list of key (origins?) of the keys that will be available at signing?
jtrag has joined #bitcoin-core-dev
<provoostenator>
I just realized the availability is not static.
<provoostenator>
So yeah, providing it at coin selection time seems the only way.
dougefish_ has quit [Read error: Connection reset by peer]
dougefish has joined #bitcoin-core-dev
<provoostenator>
E.g. in a 3-of-3 setup with scriptpath(s) for 2-of-3 fallback, the wallet can't know if you have 2 or 3 signers available.
<sipa>
sanket1729_: there is no algorithmic difficulty here
<sipa>
more a logistical
<sipa>
how does the right information get to be available to the right things
<sipa>
e.g. do descriptors need metadata about all keys, whether they will or won't be oresent
<provoostenator>
Maybe by default we assume everything is available (keypath), and then there's an option to provide fingerprints.
<sipa>
what if that information changes
<provoostenator>
And/or explictly point to script paths
smartin has quit [Ping timeout: 260 seconds]
<achow101>
sipa: one thing that would be useful is for a way to say in a descriptor that the internal key is bogus
<provoostenator>
tr(null)
<sipa>
achow101: we definitely need that, but i think that's somewhat orthogonal
<sipa>
there should just be a convenient way of constructing script-only tr descriptors
<sipa>
the reason why i didn't include that already is because there are many ways of doing that
<sipa>
including ones that are more private
<sipa>
but more complex
<achow101>
sipa: it's kind of relevant as whether or not the script path is taken has a significant impact on the estimated size
smartin has joined #bitcoin-core-dev
<sipa>
right
<sanket1729_>
> sipa: one is the ability to tell walletcreatefundedstuffs which keys will be present at signing, to make it better estimate the signing cost. Is this hard to do logistically? Can we not use psbtv2 here?
<sipa>
sanket1729_: pabtv2 is just a format, the information has to come from somewhere
<sanket1729_>
But the change output does not need to fixed
dougefish has quit [Read error: Connection reset by peer]
<achow101>
sanket1729_: there is no guarantee that a change output exists
<sipa>
nor that it is recognizable
<achow101>
and coin selection now operates on effective values, so being able to calculate the fee for each input is necessary
<sipa>
or that it is acceptable for particular signers to modify it
<provoostenator>
And warn if you then try to sign scriptpath
<provoostenator>
Maybe we shouldn't even automatically pick a scriptpath for signing.
<sipa>
the problem is that signing isn't a single step
<provoostenator>
At least not until we figure out this fee dilemma.
<provoostenator>
Right, there's a dummy signer to get the fee estimate, and then the real signer?
<sipa>
it's not an issue as long as all tr supports in non-aggregated keys and single-key pk scripts
<sipa>
but just because you don't have the keypath private key, does not mean nobody had
dougefish has quit [Remote host closed the connection]
dougefish has joined #bitcoin-core-dev
<sipa>
meshcollider: btw, i'm reviewing the error location PR, but got sidetracked again
<provoostenator>
I think in a wallet without private keys, you can assume _someone_ has the keypath private key.
<provoostenator>
In a wallet with private keys, but where you don't have the internal key, it's tricker.
<meshcollider>
sipa: thanks! No worries :)
<provoostenator>
But from the above discussion I gather we should still pick the keypath and just assuem someone else signs it. Unless the user says otherwise
<achow101>
provoostenator: in a wallet with private keys, we can know there is a private key and choose the path that uses it
<achow101>
(assuming pk scripts only)
<provoostenator>
But that may not be desireable, because that path might be a fallback option.
<achow101>
but always assuming keypath might mean we underpay the fee accidentally
<provoostenator>
(I guess the example here would be a 1-of-2 threshold signature with single key fallbacks)
<sipa>
another possibility is not caring too much about it, because unless you have giant scripts/scriptsizes, it won't make a giant different to the vsize
<provoostenator>
We would have to assume it for both coin selection and signing.
<sipa>
also assuming a functioning block space market, which may be a dream...
<achow101>
sipa: the jump from keypath to any script path is pretty significant
<provoostenator>
And spending the wrong fee is not good for privacy.
<achow101>
(a basic script path is at least 1.5 times larger than keypath)
<provoostenator>
E.g. a 1.5 sat/byte transaction would strongly suggest there was a keypath.
<sipa>
provoostenator: i was assuming a functioning block space market; i agree that dealing with minrelay situation is harder
<sipa>
meshcollider: not sure you saw, but there are a bunch of unaddressed comments
<meshcollider>
sipa: they're all fairly minor / cleanups which I was planning to leave to a follow-up
<sipa>
ok, just wanted to make sure you saw
vysn has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 276 seconds]
yanmaani2 has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] DariusParvin opened pull request #23558: test: run rpc-generateblock.py even with wallet disabled (master...rpc-generateblock-to-miniwallet) https://github.com/bitcoin/bitcoin/pull/23558
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
arythmetic has quit [Remote host closed the connection]
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]
Guyver2 has left #bitcoin-core-dev [Closing Window]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
z0d has quit [Quit: ZZZzzz…]
bairen has quit [Remote host closed the connection]
bairen has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 276 seconds]
fulldecent has joined #bitcoin-core-dev
arythmetic has joined #bitcoin-core-dev
arythmetic has quit [Remote host closed the connection]