bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
gene has quit [Remote host closed the connection]
gene has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg opened pull request #23532: test: add functional test for -startupnotify (master...2021-11-test-startupnotify) https://github.com/bitcoin/bitcoin/pull/23532
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
gene has quit [Remote host closed the connection]
gene has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
b10c has quit [Quit: Connection closed for inactivity]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bfsfhkacjzgcytf has joined #bitcoin-core-dev
<kallewoof>
Probably known already, but Ubuntu 18 currently breaks on compiling when building master because gcc/g++ is too old. (As opposed to ./configure erroring with a 'compiler too old' message)
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Remote host closed the connection]
bitdex has joined #bitcoin-core-dev
<sipa>
hmm
<fanquake>
We could make the issue more obvious at configure time. kallewoof: I assume you're installing and using GCC 8, which is available on 18.04
<fanquake>
clang on bionic will work too
brunoerg has quit [Ping timeout: 250 seconds]
gene has quit [Remote host closed the connection]
rex4539 has quit []
<kallewoof>
fanquake: I did apt upgrade and re-tried and it failed, so now upgraded to 20
Guest83 has joined #bitcoin-core-dev
Guest83 has quit [Client Quit]
<kallewoof>
fwiw the error is when trying to include <charconv> which is too new apparently.
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
Gimble has quit [Ping timeout: 265 seconds]
G1mbIe has joined #bitcoin-core-dev
AlienTrooper has quit [Remote host closed the connection]
<luke-jr>
GCC 8 should work..?
G1mble has quit [Ping timeout: 265 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
<fanquake>
It does work
<fanquake>
we use it in our CI along with Clang 7
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #23534: wallet: Allow negtive effective value inputs when subtracting fee from outputs (master...no-change-fee-w-sffo) https://github.com/bitcoin/bitcoin/pull/23534
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<kallewoof>
GCC 8.1, to be precise. I already upgraded to latest distro one and I think it was at 7.5.0. Either way, it works now that I upgraded to 20.
sudoforge has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
MilesElite has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
MilesElite has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master fa54a40 MarcoFalke: doc: Pick better named args for MutableTransactionSignatureCreator
<bitcoin-git>
bitcoin/master 398fd63 MarcoFalke: Merge bitcoin/bitcoin#23525: doc: Pick better named args for MutableTransa...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #23525: doc: Pick better named args for MutableTransactionSignatureCreator (master...2111-docMutableTransactionSignatureCreator) https://github.com/bitcoin/bitcoin/pull/23525
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
grettke has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
brunoerg has joined #bitcoin-core-dev
AlienTrooper has joined #bitcoin-core-dev
AlienTrooper has quit [Changing host]
AlienTrooper has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
G1mbIe has quit [Quit: Leaving]
goatpig has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 250 seconds]
b10c has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mudsip has joined #bitcoin-core-dev
mudsip has quit [Client Quit]
Kaizen_Kintsugi_ has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
mudsip has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
mudsip has quit []
Guyver2 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake opened pull request #23535: PE: check for control flow instrumentation (master...test_for_pe_control_flow) https://github.com/bitcoin/bitcoin/pull/23535
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Alina-malina has quit [Ping timeout: 250 seconds]
Alina-malina has joined #bitcoin-core-dev
earnestly has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master 5ba9f1f Sebastian Falbesoner: test: refactor: rename NULLDUMMY-invalidation helper
<bitcoin-git>
bitcoin/master d14395b Jon Atack: net, doc: provide context for UnserializeV1Array()
<bitcoin-git>
bitcoin/master 2ef186a W. J. van der Laan: Merge bitcoin/bitcoin#22881: doc: provide context for CNetAddr::Unserializ...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj merged pull request #22881: doc: provide context for CNetAddr::UnserializeV1Array() and span.h with lifetimebound (master...span-lifetimebound) https://github.com/bitcoin/bitcoin/pull/22881
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
tripleslash has quit [Ping timeout: 250 seconds]
<BlueMatt>
is there an rpc for "public key -> p2wpkh address"?
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<sipa>
BlueMatt: i think decodescript, with a P2PK script, would work
<BlueMatt>
thanks. also, looks like trying to broadcast a p2wpkh spend signed with straight-up the wrong key gives a "Script failed an OP_EQUALVERIFY operation" which imo is a bit confusing, but whatever
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
gene has joined #bitcoin-core-dev
jarthur has joined #bitcoin-core-dev
danielsousaio has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
grettke has joined #bitcoin-core-dev
jonatack1 has joined #bitcoin-core-dev
gene has quit [Remote host closed the connection]
jonatack12 has joined #bitcoin-core-dev
gene has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 250 seconds]
jonatack1 has quit [Ping timeout: 265 seconds]
Talkless has joined #bitcoin-core-dev
<jnewbery>
hi everyone. I'm looking for volunteer hosts for PR review club. I'm not able to host next week, so if you're interested in hosting, please let me know
<michaelfolkson>
I'm happy to help with the notes so the volunteer just has to show up and discuss their PR rather than do any additional work
___nick___ has joined #bitcoin-core-dev
jespada has joined #bitcoin-core-dev
An0rak has quit []
rex4539 has quit [Ping timeout: 276 seconds]
rex4539 has joined #bitcoin-core-dev
danielsousaio has quit [Remote host closed the connection]
rex4539 has quit [Ping timeout: 276 seconds]
<provoostenator>
BlueMatt: easiest way is to make a descriptor (with checksum) and then call deriveaddresses on it
<BlueMatt>
provoostenator: lol the point is i wanted to do it without writing code :p
<BlueMatt>
sipa's suggestion worked, though, just prefix with length byte and suffix with 0xac
<provoostenator>
And hashing?
<BlueMatt>
dont need to
<BlueMatt>
decodescript takes the actual script np
Guyver2_ has joined #bitcoin-core-dev
<BlueMatt>
and gives a bc1 address form of it in segwit as a "keyhash"
<sipa>
BlueMatt: deriveaddresses "pk($HEXPBKEY)" probably works too
<sipa>
eh
<BlueMatt>
:shrug: decodescript worked
<sipa>
wpkh($HEXPUBKEay)
<BlueMatt>
with some elbow grease
<sipa>
ok!
Guyver2 has quit [Ping timeout: 250 seconds]
<BlueMatt>
point being "pubkey mismatch" errors on sendrawtransaction are confusing :p
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #23538: Replace strtol with ToIntegral in torcontrol (master...2111-torcontrol) https://github.com/bitcoin/bitcoin/pull/23538
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #23191: build: Disable -Wbraced-scalar-init, which is incompatible with -Wc++11-narrowing (master...2110-buildW) https://github.com/bitcoin/bitcoin/pull/23191
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
rex4539 has quit [Ping timeout: 276 seconds]
jtrag has joined #bitcoin-core-dev
jtrag has quit [Client Quit]
jtrag has joined #bitcoin-core-dev
tripleslash has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]
jtrag has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
sudoforge has quit [Ping timeout: 250 seconds]
Talkless has quit [Quit: Konversation terminated!]
sudoforge has joined #bitcoin-core-dev
jtrag has quit [Read error: Connection reset by peer]
jtrag has joined #bitcoin-core-dev
common has joined #bitcoin-core-dev
Common_ has joined #bitcoin-core-dev
common has quit [Changing host]
common has joined #bitcoin-core-dev
Common_ has quit [Client Quit]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 265 seconds]
Common_ has joined #bitcoin-core-dev
jtrag has quit [Remote host closed the connection]