<bitcoin-git>
bitcoin/master 37a16ff fanquake: refactor: fix clang-tidy named args usage
<bitcoin-git>
bitcoin/master 0da559e MarcoFalke: Merge bitcoin/bitcoin#24661: refactor: Use clang-tidy syntax for C++ named...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24661: refactor: Use clang-tidy syntax for C++ named arguments (master...rebase_23545) https://github.com/bitcoin/bitcoin/pull/24661
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
hsmiths has quit [Quit: Connection closed for inactivity]
<bitcoin-git>
[bitcoin] laanwj merged pull request #24746: refactor: remove macOS MAP_ANONYMOUS work around (master...macOS_has_MAP_ANONYMOUS) https://github.com/bitcoin/bitcoin/pull/24746
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 268 seconds]
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] jonatack opened pull request #24757: build, ci: add `DEBUG_LOCKCONTENTION` to --enable-debug and CI (master...add-DEBUG_LOCKCONTENTION-to-enable-debug) https://github.com/bitcoin/bitcoin/pull/24757
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jonatack>
question, does the CI have all logging categories enabled by default, like the unit tests? (and where is that configured?)
<jonatack>
(guessing yes, but didn't immediately see where it is defined)
<jonatack>
I suppose it uses the default tests configuration
ReCodee has joined #bitcoin-core-dev
ReCodee has quit [Client Quit]
<laanwj>
jonatack: it has "-debug", "-debugexclude=libevent", "-debugexclude=leveldb", this is configured in the TestNode constructor
<laanwj>
with the reasoning that libevent and leveldb are too noisy and mostly irrelevalt to debugging test failures
bitdex has quit [Quit: = ""]
<laanwj>
but yeah this isn't CI specific
<jonatack>
laanwj: thanks! found test/functional/test_framework/test_node.py:54:class TestNode(), which then led me to BasicTestingSetup::BasicTestingSetup in src/test/util/setup_common.cpp
<jonatack>
all good then
<jonatack>
(I had started in the /ci directory but yes, didn't see anything CI specific)
AaronvanW has joined #bitcoin-core-dev
dermoth has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #24758: Disable the syscall sandbox for bitcoin-qt and remove gui-related syscalls (master...2204-gui-box-🌊) https://github.com/bitcoin/bitcoin/pull/24758
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has quit [Ping timeout: 272 seconds]
dermoth has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
<hebasto>
vasild: 07:18:43 <hebasto> vasild: having a problem while importing your public key -- `gpg: key CE712013582E2230: new key but contains no user ID - skipped`. Not able to verify your commit signatures.
<vasild>
hebasto: yes, looking into a few pgp key servers now, but either they do not respond or I get http 503 service unavailable or my key is not there :(
<vasild>
which server do you look up?
<hebasto>
vasild: keys.openpgp.org
<jonatack>
sipa: thanks (context, vasild are i were discussing this, i pinged him to add cjdns to the release notes, he used 23.x in the link, and i then mentioned to maybe go with master for the case that #24710 isn't backported to 23.x... anyway, no big deal)
<jonatack>
i wondered if someone updates these to 23.0 before the notes are pulled back in from the devwiki
<vasild>
hebasto: looks like keys.openpgp.org distringuishes between "identity" and "non-identity" information and by default only stores and shows the non-identity one - the key itself, but not the emails (user ids): https://keys.openpgp.org/about. I will now try to "verify" the emails so that they are shown too
<vasild>
hebasto: should be good now, can you retry?
Guyver2__ has joined #bitcoin-core-dev
An0rak has joined #bitcoin-core-dev
Guyver2_ has quit [Ping timeout: 248 seconds]
jonatack has quit [Ping timeout: 248 seconds]
<hebasto>
vasild: it's ok now, ty
<vasild>
thanks, I was not aware that I should verify the emails separately from uploading the key to keys.openpgp.org
<vasild>
hmm, but the emails I received were not encrypted with my public key. What is stopping somebody from sneaking an additional email (his own) to my public key?
<hebasto>
that's why we should exchange our keys in person :)
<vasild>
yeah :)
instagibbs has joined #bitcoin-core-dev
<laanwj>
if you use any kind of more advanced scripting than "run a few commands in a row" please use python, not bash or shell, it's the same portability issues with external commands and built-ins every time
<laanwj>
everytime it has to go through all the passes "this doesn't work on macos" "this doesn't work on openbsd" etc
<fanquake>
i'd also suggest anyone using macOS to fix their dev environments by installing modern versions of tools that actually work
<laanwj>
"wait now we need the GNU variant of bladiewupf"
<fanquake>
heh, that is slightly harder to solve, but i'd recommend they just install and use (or at least have available) the gnu versions of tools.
<fanquake>
we check and use at least glibtoolize in that capacity
<fanquake>
although I agree that ultimately the more of this stuff we migrate to python the better
davterra has joined #bitcoin-core-dev
<laanwj>
python isn't perfect but as a glue language it works very well, it has the same implementation on every platform, and we already require it anyhow
<bitcoin-git>
bitcoin/master 3b82608 Vasil Dimov: options: add a comment for -listenonion and dedup a long expression
<bitcoin-git>
bitcoin/master 4d4dca4 Vasil Dimov: test: add regression test for bitcoin-core/gui/issues/567
<bitcoin-git>
bitcoin/master 47bac47 Hennadii Stepanov: Merge bitcoin-core/gui#569: test: add regression test for #567
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has quit [Remote host closed the connection]
<laanwj>
fanquake: in any case, yes, documenting what exact build environment macos users need seems to be important as well
Guyver2__ has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mxaddict opened pull request #24761: Updated funcs.mk to work with Windows Subsystem for Linux (master...temp-master) https://github.com/bitcoin/bitcoin/pull/24761
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Remote host closed the connection]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
sipsorcery has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] laanwj opened pull request #574: qt: Equalize notifySystray and notifyDBus interface (master...2022-04-notification-icon) https://github.com/bitcoin-core/gui/pull/574
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
<laanwj>
vasild: the email is just an extra verification step; the pgp protocol itself should make sure that no one can add identities to your key without them being signed, or at least, they won't be accepted by people pulling from the keyserver
brunoerg has quit [Ping timeout: 260 seconds]
AaronvanW has quit [Ping timeout: 246 seconds]
<laanwj>
re: https://github.com/bitcoin-core/gui/issues/573 did anyone check recently on MacOS and Qt whether the whole custom notification code is still needed? would be cool if we could get rid of all the platform specific notificator code
<fanquake>
I'm not entirely sure, but I know macOS has also been migrating to a new notification API, so it may just no-longer work
<laanwj>
that's a good reason to get rid of it too
<hebasto>
laanwj: last time I checked macos (not recently enough) -- it was required
<fanquake>
if we can drop that, and some other code, it's an even nicer cleanup, because we also no longer need to compile objcxx
<fanquake>
and can remove some additional build cruft
<hebasto>
moreover, Qt does not support macos new notification API
<hebasto>
even Qt 6
<laanwj>
so we might need *new* custom notification code, awesome
<hebasto>
yeap
<hebasto>
seems it depends on notarization though
<fanquake>
more macOS crap to deal with
<fanquake>
surely we are going to have to end up supporting both at the same time
<fanquake>
*aren't
sipsorcery has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
szkl has joined #bitcoin-core-dev
<laanwj>
macos: every time there's a chance that developers have caught up with the previous thing they introduce new thing
___nick___ has joined #bitcoin-core-dev
gnaf has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
gnaf has left #bitcoin-core-dev [#bitcoin-core-dev]