ronoaldo has quit [Quit: Konversation terminated!]
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
Kaizen_K_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] KevinMusgrave opened pull request #24934: refactor, miner: Delete call to UpdatePackagesForAdded at beginning of addPackageTxs (master...2022-04-delete-UpdatePackagesForAdded) https://github.com/bitcoin/bitcoin/pull/24934
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
Kaizen_K_ has quit [Ping timeout: 246 seconds]
vysn has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
belcher has quit [Ping timeout: 250 seconds]
anoymous has joined #bitcoin-core-dev
anoymous has quit [Client Quit]
belcher has joined #bitcoin-core-dev
bitdex has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
sudoforge has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Read error: Connection reset by peer]
Guest52 has joined #bitcoin-core-dev
vysn has joined #bitcoin-core-dev
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
Kaizen_K_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
<laanwj>
that would be good, the CI has been quite flaky lately, though i don't think that's the only cause
<laanwj>
it would be great to have one source of flakiness out of the way
mekster66949 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<provoostenator>
I still don't understand the moon fee math.
<provoostenator>
But if the CI works, I'm fine with just merging it.
<luke-jr>
ehh, let's not trust CI for review >_<
<lightlike>
yes me neither - thats why i mentioned it here instead of acking myself
<sipa>
sec, opening a PR to disable CI
<jonatack>
hehe
<luke-jr>
sipa: +1
<sipa>
more seriously: will try to review
<provoostenator>
If someone can explain the calculations in more clear language, I'm also happy to review of course.
Talkless has quit [Quit: Konversation terminated!]
<laanwj>
#topic 23.0 final
<core-meetingbot>
topic: 23.0 final
Kaizen_K_ has joined #bitcoin-core-dev
<laanwj>
i think it's about time to tag 23.0 final, no new issues have come up (afaik) since rc5, or rc4 for everything except windows
mudsip has joined #bitcoin-core-dev
<sipa>
nice
<fanquake>
finally got the windows cross compiler under control
<achow101>
ack
<hebasto>
ack
<fanquake>
🚀
<jeremyrubin>
exciting!
<sipa>
guix building standing by
<kvaciral>
awesome!
<sipa>
*builder
<laanwj>
okay!!! will do some last checks after the meeting and make the tag
<jonatack>
yay!
<glozow>
nice!
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
<laanwj>
ok, unless anyone has a last-last minute topic, i think that concludes the meeting
<laanwj>
thanks everyone for attending! btw, if you would like to be added to (or removed from) the highlight list in the beginning of the meeting let me know, it hasn't been updated in a bit
<achow101>
there isn't any complicated math going on, it's just that figuring out sizes from our decoding of transactions is difficult because of missing length prefixes (so these need to be computed again) and the fact that everything is doubled because hex
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mudsip has quit []
Kaizen_K_ has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/23.x fcf6c8f laanwj: doc: Update manual pages for 23.0
<bitcoin-git>
bitcoin/23.x 4253c61 laanwj: build: Bump to final
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
jesseposner has joined #bitcoin-core-dev
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<stick>
btw, does Approach ACK always imply Concept ACK?
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<jonatack>
stick: absent further explanation to the contrary i interpret it as implying concept ack (per contributing.md, "`Approach (N)ACK`, meaning `Concept ACK`, but "I do (not) agree with the approach of this change")
earnestly has quit [Ping timeout: 276 seconds]
Kaizen_K_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
anoymous has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
anoymous has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has quit [Remote host closed the connection]
earnestly has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
earnestly has quit [Ping timeout: 256 seconds]
AaronvanW has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
AaronvanW has quit [Ping timeout: 246 seconds]
AaronvanW has joined #bitcoin-core-dev
realies8 has joined #bitcoin-core-dev
realies has quit [Read error: Connection reset by peer]