bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 240 seconds]
evanlinjin has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke reopened pull request #18061: util: Pass size to ParseHex to assist preallocation (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jonatack has quit [Ping timeout: 256 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25025: test: Remove boost::split from rpc_tests.cpp (master...2204-test-boost-🏓) https://github.com/bitcoin/bitcoin/pull/25025
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
greypw2546 has quit [Quit: I'll be back!]
greypw2546 has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] aureleoules opened pull request #25026: rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height (master...2022-04-pruneblockchain-fetch-old-blocks) https://github.com/bitcoin/bitcoin/pull/25026
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #18061: util: Pass size to ParseHex to assist preallocation (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Valkyrie has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25029: rpc: Move fee estimation RPCs to separate file (master...2204-rpc-fees-😊) https://github.com/bitcoin/bitcoin/pull/25029
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has quit [Ping timeout: 240 seconds]
sudoforge has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 256 seconds]
<jamesob>
man, running the functional tests in-memory via tmpfs mount is something else. `./test/functional/test_runner.py --jobs=100 --cachedir=/mnt/tmp/cache --tmpdir=/mnt/tmp` completes in 1min37sec
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19757: net/net_processing: Convert net std::list buffers to std::forward_list (master...net-list-type) https://github.com/bitcoin/bitcoin/pull/19757
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #19985: net: Prevent routing of deprecated Site Local IPv6 (master...net-deprecate-site-local-ipv6) https://github.com/bitcoin/bitcoin/pull/19985
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke closed pull request #22525: docs: Update the explainer text for the listunspent RPC (master...master) https://github.com/bitcoin/bitcoin/pull/22525
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
ronoaldo has joined #bitcoin-core-dev
preemz has joined #bitcoin-core-dev
<laanwj>
jamesob: i think a big part of that is that fsyncs/fdatasyncs are free on tmpfs
<laanwj>
but yes the difference is shocking
<jeremyrubin>
can that be the default behavior?
<laanwj>
it's an OS level thing that only exists on linux, and configured as root
<laanwj>
so, no, the tests don't have any influence on that level
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
<laanwj>
but you might be able to get near it by short-circuiting some libc calls not strictly necessary for testing (like anything concerning sync), and assuming enough memory for page cache is available, dunno, it depends on the exact reason
<laanwj>
there's an "eatmydata" command that may be useful for this
<bitcoin-git>
[bitcoin] scgbckbone opened pull request #25032: normalize PSBT entry instead of external signer master fingerprint (master...upper_master_fp_cor_cmp) https://github.com/bitcoin/bitcoin/pull/25032
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] scgbckbone opened pull request #25033: add explicit condition fo master fingerprint to be lowercase hex (master...explicit_master_fp_str_encoding_in_docs) https://github.com/bitcoin/bitcoin/pull/25033
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
salvatoshi has quit [Ping timeout: 256 seconds]
real_or_random has quit [Quit: ZNC 1.8.2 - https://znc.in]
Valkyrie has quit [Remote host closed the connection]
<_aj_>
dongcarl: want to be the coin flip to decide if #24595 should be split into separate "add chainparams to chainman" and "drop g_versionbitscache global" PRs, per MarcoFalke's suggestion?
<gribble>
https://github.com/bitcoin/bitcoin/issues/24595 | deploymentstatus: move g_versionbitscache global to ChainstateManager by ajtowns · Pull Request #24595 · bitcoin/bitcoin · GitHub
* jeremyrubin
hides
___nick___ has joined #bitcoin-core-dev
___nick___ has quit [Client Quit]
evanlinjin has quit [Ping timeout: 240 seconds]
___nick___ has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
jonatack has quit [Quit: Connection closed]
<MarcoFalke>
fun fact: Our unit tests that call TrimStringView may corrupt memory, so I tried clangs lifetimebound, but that won't catch this issue
<MarcoFalke>
Maybe we should switch to rust after all
<MarcoFalke>
(or someone should fix lifetimebound in clang)
<laanwj>
this is exactly what i was worried about with the functions that return stringview
<laanwj>
maybe it's better to forbid that for now
evanlinjin has joined #bitcoin-core-dev
<laanwj>
i don't think we particularly need the extra bit of performance, better to err on the safe side
BUSY has quit [Ping timeout: 260 seconds]
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<MarcoFalke>
Oh nvm, the unit tests are fine because the memory is only free'd after the "full-expression" and apparently BOOST_CHECK_EQUAL counts as full-expression
<MarcoFalke>
Still, would be good to add the attribute in a working form
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
<dongcarl>
_aj_: Nah I think the changes are pretty straightforward, and we should keep it together if possible
<dongcarl>
s@should keep it together if possible@can keep it together@
BUSY has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
<_aj_>
dongcarl: cool
* dongcarl
should rereview
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
<jamesob>
dongcarl: very controversial use of sed separators there
SpellChecker_ has joined #bitcoin-core-dev
SpellChecker has quit [Ping timeout: 240 seconds]
brunoerg has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
<dongcarl>
jamesob: Hehe I usually use '@' just so there's no ambiguity when I have to work with file paths
doppo has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
doppo has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Quit: Konversation terminated!]
evanlinjin has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 240 seconds]
jonatack has joined #bitcoin-core-dev
evanlinjin has quit [Quit: Konversation terminated!]
evanlinjin has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
sipsorcery has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mzumsande opened pull request #25034: test: add missing stop_node call to feature_coinstatsindex (master...20224_coinstatsindex_fix) https://github.com/bitcoin/bitcoin/pull/25034
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Talkless has joined #bitcoin-core-dev
___nick___ has quit [Ping timeout: 276 seconds]
<jamesob>
dongcarl: smart!
Valkyrie has joined #bitcoin-core-dev
Valkyrie has quit [Remote host closed the connection]
a1ph4byte has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
preemz has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
a1ph4byte has quit [Quit: Client closed]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
gnaf has quit [Quit: Konversation terminated!]
evanlinjin has joined #bitcoin-core-dev
yanmaani2 has joined #bitcoin-core-dev
yanmaani1 has quit [Remote host closed the connection]
sipsorcery has quit [Ping timeout: 250 seconds]
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
AaronvanW has quit [Quit: Leaving...]
Talkless has quit [Quit: Konversation terminated!]