bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] rnapoles opened pull request #24985: doc,test: Compilation for 64-bit Windows with msys2 (master...msys2-windows-build) https://github.com/bitcoin/bitcoin/pull/24985
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Willtech has quit [Quit: Willtech]
Willtech has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
AaronvanW has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
Guest6680 has joined #bitcoin-core-dev
Guest6680 has quit [Client Quit]
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
a1ph4byte18 has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
hashfunc1ebd has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
a1ph4byte18 has quit [Ping timeout: 252 seconds]
a1ph4byte has quit [Ping timeout: 252 seconds]
brunoerg has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
hashfunc1ebd has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 256 seconds]
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has joined #bitcoin-core-dev
x88x88x has quit [Remote host closed the connection]
mikehu44_ has quit [Ping timeout: 256 seconds]
x88x88x has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
sudoforge has quit [Ping timeout: 256 seconds]
a1ph4byte has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
AaronvanW has quit [Ping timeout: 246 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
mikehu44_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
<vasild>
midnight: Hello :)
sipsorcery has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<PaperSword>
Hello
<laanwj>
provoostenator: simply said because the "ghi" script it uses (https://github.com/gkrizek/ghi) is based on github's original bot which didn't have a persistent IRC mode either, PRs welcome though :)
<laanwj>
speaking of element, it would be straightforward on matrix to keep the notificator in the room, IRC's lack of persistent sessions between connections makes it harder to do
<laanwj>
that said, ghi doesn't currently have a matrix backend either
<laanwj>
hebasto: yeah, and time to create a 0.24 issue
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<_aj_>
vasild: "nothing can justify that" -- so even if it avoided 1000 remote exploits and made everything 100 times fast it would still be unacceptable? i'm not sure if there's some language thing here, but i find it really hard to understand your take on locking
<laanwj>
_aj_: it depends, i don't know the particular context, but say, sometimes understanding of things advances and some things turn out to be really never suitable for use and always bad design, recursive mutexes probably fit in that category
jonatack has quit [Ping timeout: 272 seconds]
<_aj_>
laanwj: GuardMutex is literally just an empty subclass of Mutex so that AssertLockNotHeld(Mutex) can have stronger thread safety annotations than AssertLockNotedHeld(GuardMutex) while otherwise behaving exactly the same
<_aj_>
err, GlobalMutex
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has quit [Remote host closed the connection]
<_aj_>
laanwj: (i mean replacing "GlobalMutex g_x_mutex; X x GUARDED_BY(g_x_mutex);" with "class ProtectedX { Mutex m; X x GUARDED_BY(m); .. }; ProtectedX g_x;" is an improvement that does away with GlobalMutex, but also involves moving the code that accesses "x" into the new class, which is a bunch more work than a scripted diff)
<_aj_>
vasild: negative assertions don't work with global scope mutexes; as it stands we don't have any AssertLockNotHeld(g_cs_x) except when g_cs_x is already a recursivemutex so the first two commits work without specially annotating the global non-recursive mutexes. but adding negative annotations for LOCK can't be done on global mutexes
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #18061: util: Pass size to ParseHex to assist preallocation (master...2020-02-remove-strlen) https://github.com/bitcoin/bitcoin/pull/18061
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #15729: rpc: Raise error in getbalance if minconf is not zero (master...2019-04-drop-getbalance-minconf) https://github.com/bitcoin/bitcoin/pull/15729
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #20277: test: Extend p2p_ibd_tx_relay.py to verify no-transaction are requested during IBD (master...2020-10-ibd-txrelay) https://github.com/bitcoin/bitcoin/pull/20277
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jespada_ has quit [Ping timeout: 260 seconds]
jespada has joined #bitcoin-core-dev
evanlinjin has quit [Quit: Konversation terminated!]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #20752: [fuzzer] generate new seeds in an infinite loop with random parameters (master...2020-12-fuzz-test-runner-infinite-generate) https://github.com/bitcoin/bitcoin/pull/20752
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
aleggg has quit [Ping timeout: 240 seconds]
aleggg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #21260: wallet: indicate whether a transaction is in the mempool (master...show-conflicted-transactions-not-in-mempool) https://github.com/bitcoin/bitcoin/pull/21260
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] fanquake closed pull request #21284: rpc: add the add_inputs option to bumpfee/psbtbumpfee (master...add-add-inputs-option-to-bumpfee) https://github.com/bitcoin/bitcoin/pull/21284
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has joined #bitcoin-core-dev
evanlinjin has quit [Client Quit]
Guyver2_ has quit [Quit: Going offline, see ya! (www.adiirc.com)]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
salvatoshi has quit [Ping timeout: 272 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 250 seconds]
real_or_random has quit [Quit: ZNC 1.8.2 - https://znc.in]
jonatack has quit [Ping timeout: 256 seconds]
vasild has quit [Ping timeout: 240 seconds]
vasild has joined #bitcoin-core-dev
<josibake>
does anyone have a guide/docs for getting setup with tracepoints? i just realized that despite compiling with --enable-usdt, the functional tests are skipping due to tracepoints not being enabled
a1ph4byte has quit [Quit: Client closed]
roconnor_ has joined #bitcoin-core-dev
roconnor has quit [Ping timeout: 250 seconds]
roconnor_ is now known as roconnor
<Murch>
b10c recently made me aware that you needed to also install systemtap
Talkless has joined #bitcoin-core-dev
<Murch>
I think it was only mentioned in the install documentation, but not in the tracepoint readme
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<b10c>
Murch: yeah, we should have some getting started documentation in there
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<josibake>
murch: that was indeed the missing piece. i got it running but it is spitting out warnings about macros being redfined. looks like the tests are running fine, tho.
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<Murch>
Yeah, that threw me off at first as well, but the three warnings in the beginning are just that, the script runs fine after
<achow101>
does it still require sudo?
<josibake>
achow101: yes, i had to run the test with sudo to get around the BPF permissions check
a1ph4byte has joined #bitcoin-core-dev
<josibake>
murch: looks like the warnings are a known issue and you can get rid of them by compiling bcc from source
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24993: contrib: close file after manipulating it in `linearize-data` (master...2022-04-contrib-close-file) https://github.com/bitcoin/bitcoin/pull/24993
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<josibake>
i just compiled bcc from source and ran the functional tests without any warnings from bcc. might be good to mention this if we add docs for "getting started" with bcc