<fanquake>
I don't think we should be adding unnecessary changes to PRs we might want to backport.
<jonatack>
fanquake: i replied in the pull
<fanquake>
I don't understand your explanation, or why the first two commits are need, if my branch works without the additional changes
<jonatack>
fanquake: you're adding missing headers in net.h in the same commit as the primary change. those are only related because it happens that net.h was relying on headers in sync.h (see the commit message in the first commit)
brunoerg has joined #bitcoin-core-dev
<laanwj>
i'm starting to regret we added the syscall sandbox at all
<laanwj>
it's just unmaintainable
<fanquake>
I'm not sure what the problem is with adding needed-for-compilation headers in the same commit as the "primary change"? That change is really the only one we care about, and that needs backporting.
<vasild>
laanwj: yes, sure, the email addresses themselves are signed by my private key; I am stupid
<bitcoin-git>
[bitcoin] jonatack opened pull request #24770: Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive (master...change-lock-logging-to-DEBUG_LOCKCONTENTION-one-commit) https://github.com/bitcoin/bitcoin/pull/24770
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<jonatack>
can rebase the fixes in the original pull over after
brunoerg has quit [Ping timeout: 268 seconds]
<fanquake>
Surely we don't need 3 pulls. If there are other unrelated / uneeded (for backporting) changes in 24734, just take them out, and put them in 24757, which is already a followup
<fanquake>
all we need in 24734 is the single code change, that fixes the problem, and id
<fanquake>
*I'd say also the documentation commit
<fanquake>
any unrelated frills / followups / changes etc can go into 24757
<jonatack>
There are good changes in the original pull that would be worthy to merge if not backport. It doesn't make any difference whether those are open now or later, it entails a separate pull in either case
<jonatack>
One for backport, one for the non-backported things
<fanquake>
yea, and they will be merged, in the followup you already have open
brunoerg has joined #bitcoin-core-dev
<jonatack>
ok updating
brunoerg has quit [Ping timeout: 240 seconds]
Alina-ma- has joined #bitcoin-core-dev
Alina-malina has quit [Ping timeout: 260 seconds]
<fanquake>
the newly opened PR should be closed
<fanquake>
just move the unrelated changes out of 24734 and into 24757.
<jonatack>
I've complied making the new pull 2 commits, instead of just 1 commit to ease backport. Why does it matter which PR is the full one and which is the backport one?
brunoerg has joined #bitcoin-core-dev
<fanquake>
because there was no need for a new PR at all, when you could just move the unrelated changes to the followup you already had open.
<fanquake>
I don't know what "full" one even means here. Wouldn't that be the followup that was already open, with the CI and additional changes
<fanquake>
Ideally, we keep discussion, in the PR that's already open, rather than fragmenting it even further, and making this set of changes more spread out / confusing
<jonatack>
What follow-up? There are only two PRs. The original one and the minimalized one.
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Talkless has joined #bitcoin-core-dev
AaronvanW has quit [Remote host closed the connection]
sipsorcery has quit [Ping timeout: 252 seconds]
sipsorcery has joined #bitcoin-core-dev
szkl has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] hebasto opened pull request #24775: build: Do not modify `common.init.vcxproj` directly (master...220405-toolset) https://github.com/bitcoin/bitcoin/pull/24775
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
sipsorcery has quit [Remote host closed the connection]
sipsorcery has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] brunoerg opened pull request #24776: docs: update `/rest/chaininfo` doc according to `getblockchaininfo` (master...2022-04-rest-doc-improv) https://github.com/bitcoin/bitcoin/pull/24776
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
vysn has quit [Ping timeout: 268 seconds]
TerminalTapper has joined #bitcoin-core-dev
<theStack>
is anyone else here seeing the GitHub "Add a suggestion" button for code review comments disabled? not a big deal, a diff can be posted anyways, just wondering if I'm doing something wrong
<hebasto>
theStack: me too
<hebasto>
it seems the button is not active in commit-by-commit view
<lightlike>
hasn't it been like this always/for a long time, that you'd have to got to the "Files changed" view to add suggestions?
<hebasto>
lightlike: yeap
<hebasto>
I mean, to see that button active :)
TerminalTapper has quit [Ping timeout: 260 seconds]
<theStack>
oh, i thought that it was also possible on the commit-by-commit view earlier (like weeks ago); good to know that it works with the "Files changed" view, i never used that one for adding comments/suggestions, but will from now on i guess
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
<provoostenator>
That should have been sipa; Matrix bridge bug...
<sipa>
sjors: hmm
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Remote host closed the connection]
Guest38 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Guest38 has quit [Quit: Client closed]
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 252 seconds]
sipsorcery has quit [Ping timeout: 240 seconds]
gnaf has quit [Quit: Konversation terminated!]
Kaizen_K_ has quit [Ping timeout: 250 seconds]
vysn has quit [Ping timeout: 248 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 268 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] fjahr opened pull request #24778: lint: Convert Python dead code linter test to Python (master...202204-dead-py) https://github.com/bitcoin/bitcoin/pull/24778
brunoerg has quit [Ping timeout: 268 seconds]
ronoaldo has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
szkl has quit [Quit: Connection closed for inactivity]