<bitcoin-git>
bitcoin/master f58c1f1 MacroFake: Merge bitcoin/bitcoin#24739: test: Fix intermittent test failure in wallet...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #24739: test: Fix intermittent test failure in wallet_listreceivedby.py (master...2204-test-fail-🍰) https://github.com/bitcoin/bitcoin/pull/24739
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has joined #bitcoin-core-dev
evanlinjin__ has joined #bitcoin-core-dev
evanlinjin_ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
salvatoshi has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
<laanwj>
why embarassed? spradic failures can indicate a real problem like a race condition
belcher has quit [Ping timeout: 276 seconds]
belcher has joined #bitcoin-core-dev
<laanwj>
agreed, usually it's just timeout nonsense, but still
<fanquake>
laanwj: was just being sarcastic
<laanwj>
kay :)
jarthur has quit [Quit: jarthur]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
Guyver2 has joined #bitcoin-core-dev
baldur has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
SpellChecker has joined #bitcoin-core-dev
SpellChecker has quit [Client Quit]
SpellChecker has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
brunoerg has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
<laanwj>
with all the PR spam about one word, i wonder if we can't just remove the "What is bitcoin" section from the readme, everyone has their own ideas about it anywhere, replace it with a small blurb what bitcoin core (this specific software) does
<laanwj>
there's zero argument about that, and if there is, one can simly check the code
jonatack has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
evanlinjin__ has quit [Ping timeout: 240 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
evanlinjin__ has joined #bitcoin-core-dev
cold has quit [Ping timeout: 240 seconds]
midnight has quit [Ping timeout: 260 seconds]
midnight has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
cold has joined #bitcoin-core-dev
Flow has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
Flow has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
cryptoquick8 has joined #bitcoin-core-dev
cryptoquick has quit [Ping timeout: 260 seconds]
cryptoquick8 is now known as cryptoquick
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
<PaperSword>
I don't quite have a statement on the "What is bitcoin" section. Search engine SEO might be a reason to leave it. Plus it does implicitly separate the bitcoin protocol from the software.
<PaperSword>
If that section does remain long term it might be nice to link the whitepaper instead of leaving it to the user to find it. Just my 2 sats
<fanquake>
we aren't going to link to the whitepaper. that we removed on purpose, and not a discussion we need to rehash
<PaperSword>
sorry I was not around for that.
<fanquake>
No worries. You can find all the relevant discussion on GitHub
<PaperSword>
So I can see the commit where it was removed. How would I go about finding the discussing associated with that action.
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
evanlinjin__ has quit [Ping timeout: 240 seconds]
vasild has quit [Remote host closed the connection]
vasild has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]
evanlinjin has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] mruddy opened pull request #25000: gui: avoid unclean exit due to permissions issues when setting start on system startup (master...issue_24953) https://github.com/bitcoin/bitcoin/pull/25000
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] mruddy closed pull request #25000: gui: avoid unclean exit due to permissions issues when setting start on system startup (master...issue_24953) https://github.com/bitcoin/bitcoin/pull/25000
<MarcoFalke>
sipa: Should I open a new pull or push to your repo? (:sweat-smile:)
<sipa>
@MarcoFalke Ha, do I even have that enabled?
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] sipa closed pull request #24764: Modernize util/strencodings and util/string: `string_view` and `optional` (master...202204_stringview) https://github.com/bitcoin/bitcoin/pull/24764
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<MarcoFalke>
heh, it is enabled by default for maintainers for anyone that opens a pull
<sipa>
Anyway, closed it - feel free to open your own.
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke opened pull request #25001: Modernize util/strencodings and util/string: `string_view` and `optional` (master...2204-span-stuff-🐘) https://github.com/bitcoin/bitcoin/pull/25001
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<MarcoFalke>
thx, done
evanlinjin has quit [Remote host closed the connection]
evanlinjin has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitdex has quit [Quit: = ""]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] mruddy opened pull request #595: gui: avoid unclean exit due to permissions issues when setting start on system startup (master...issue_24953) https://github.com/bitcoin-core/gui/pull/595
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
AaronvanW has quit [Quit: Leaving...]
jungly has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[gui] hebasto merged pull request #589: Getting ready to Qt 6 (7/n). Do not pass `WalletModel*` to a queued connection (master...220420-walletmodel) https://github.com/bitcoin-core/gui/pull/589
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master 61457c1 Hennadii Stepanov: refactor: Guard `RPCConsole::{add,remove}Wallet()` with `ENABLE_WALLET`
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
realies has quit [Ping timeout: 256 seconds]
SpellChecker has quit [Remote host closed the connection]
SpellChecker has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] furszy opened pull request #25005: wallet: remove extra wtx lookup in 'AvailableCoins' + several code improvements. (master...2022_availableBalance_improvements) https://github.com/bitcoin/bitcoin/pull/25005
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
mikehu44 has quit [Ping timeout: 256 seconds]
jarthur has joined #bitcoin-core-dev
jarthur has quit [Quit: jarthur]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
bitcoin/master c1d165a Pieter Wuille: Make ParseHex use string_view
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #18642: Use std::chrono for the time to rotate destination of addr messages + tests (master...2020_04_mock_addr_rotation_time) https://github.com/bitcoin/bitcoin/pull/18642
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
franks has quit [Ping timeout: 276 seconds]
evanlinjin has quit [Ping timeout: 240 seconds]
jungly has quit [Ping timeout: 240 seconds]
stijn has joined #bitcoin-core-dev
stijn has quit [Client Quit]
realies has joined #bitcoin-core-dev
<laanwj>
achow101: someone noticed!
<achow101>
was that intentional?
<laanwj>
no entirely, though i have had my doubts whether it still was worth the trouble, as it's so many lines, and people are encouraged to write release notes for things that are notable or impactful enough
<laanwj>
but also for 23.0 i simply forgot it and no one reminded me
<laanwj>
but this works as a way to see if people miss it; you're the first to mention it at all
<jeremyrubin>
i think the PR list is a good idea, the acknowledgement less so :)
<jeremyrubin>
i usually do scan through the PR list
<achow101>
it's sometimes useful
<achow101>
it mostly just felt like the release notes were too short and I finally figured out why
salvatoshi has joined #bitcoin-core-dev
<Murch>
Definitely useful for downstream users. I would go over the list when I was evaluating whether a Bitcoin Core release may cause additional upgrade hurdles for the backend integration at my previous employer's
<instagibbs>
ditto
<sipa>
Murch: Arguably, if that were the case, those things should be listed in the actual release notes, though.
evanlinjin has joined #bitcoin-core-dev
salvatoshi has quit [Remote host closed the connection]
salvatoshi has joined #bitcoin-core-dev
<Murch>
Not if you're running a patched version of Bitcoin Core for some reason
bfsfhkacjzgcytf9 has quit [Ping timeout: 240 seconds]
<sipa>
Ah, fair.
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] achow101 opened pull request #25011: tests: Do not always create a descriptor wallet in wallet_createwallet (master...fix-legacy-createwallet-test) https://github.com/bitcoin/bitcoin/pull/25011
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
evanlinjin has quit [Ping timeout: 240 seconds]
Guest59 has joined #bitcoin-core-dev
Guest59 has quit [Client Quit]
Talkless has quit [Quit: Konversation terminated!]
salvatoshi has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
salvatoshi has joined #bitcoin-core-dev
Guest61 has joined #bitcoin-core-dev
Guest61 has quit [Client Quit]
bomb-on has joined #bitcoin-core-dev
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
sipsorcery has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 272 seconds]
jonatack has quit [Ping timeout: 276 seconds]
sipsorcery has quit [Ping timeout: 250 seconds]
sipsorcery has joined #bitcoin-core-dev
DeanGuss has quit [Quit: buhbye]
bitdex has joined #bitcoin-core-dev
DeanGuss has joined #bitcoin-core-dev
DeanGuss has quit [Changing host]
DeanGuss has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 250 seconds]
cryptoquick0 has joined #bitcoin-core-dev
cryptoquick has quit [Ping timeout: 240 seconds]
cryptoquick0 is now known as cryptoquick
a1ph4byte has quit [Quit: Client closed]
cryptoquick has quit [Quit: Ping timeout (120 seconds)]
cryptoquick has joined #bitcoin-core-dev
sipa has quit [Ping timeout: 240 seconds]
Murch has quit [Ping timeout: 240 seconds]
whitehorse[m] has quit [Ping timeout: 240 seconds]