Jackielove4u has quit [Quit: Connection closed for inactivity]
vysn has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
ronoaldo has quit [Quit: Konversation terminated!]
brunoerg has quit [Ping timeout: 260 seconds]
An0rak has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
NorrinRadd has quit [Ping timeout: 256 seconds]
geyaeb2 has quit [Quit: WeeChat 3.4.1]
geyaeb has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
AaronvanW has quit [Quit: Leaving...]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
szkl has quit [Quit: Connection closed for inactivity]
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] whiteh0rse opened pull request #24840: test: port 'lint-shell.sh' to python (master...24783-port-lint-shell-to-python) https://github.com/bitcoin/bitcoin/pull/24840
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
AaronvanW has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
NorrinRadd has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
Willtech has quit [Read error: Connection reset by peer]
Willtech has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
sudoforge has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 260 seconds]
nanotube has quit [Ping timeout: 260 seconds]
nanotube has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 250 seconds]
jarthur has joined #bitcoin-core-dev
jarthur_ has joined #bitcoin-core-dev
jarthur has quit [Ping timeout: 240 seconds]
Jackielove4u has joined #bitcoin-core-dev
gnaf has quit [Quit: Konversation terminated!]
sudoforge has quit [Ping timeout: 250 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]
bfsfhkacjzgcytf9 has quit [Ping timeout: 250 seconds]
Guyver2 has joined #bitcoin-core-dev
Willtech has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
kexkey has quit [Ping timeout: 256 seconds]
kexkey has joined #bitcoin-core-dev
goatpig has joined #bitcoin-core-dev
meshcollider has quit [Ping timeout: 240 seconds]
___nick___ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
mikehu44 has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
dougefish2 has joined #bitcoin-core-dev
jonatack has quit [Ping timeout: 248 seconds]
bomb-on has quit [Read error: Connection reset by peer]
realies has quit [Quit: Ping timeout (120 seconds)]
realies has joined #bitcoin-core-dev
bomb-on has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jonatack has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto closed pull request #305: Display send/recv in Bps instead of totals in the debug window (master...SendRecvSpeed-gui) https://github.com/bitcoin-core/gui/pull/305
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto closed pull request #494: Replace testnet with signet as a default network for Android (master...211201-signet) https://github.com/bitcoin-core/gui/pull/494
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[gui] w0xlt opened pull request #583: Add translator comments to `TransactionDesc::FormatTxStatus` (master...translator_comments_transactiondesc) https://github.com/bitcoin-core/gui/pull/583
TheRec has joined #bitcoin-core-dev
TheRec has quit [Changing host]
TheRec has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] Kvaciral opened pull request #24844: lint: Convert lint-whitespace.sh to Python (master...lint-whitespace-port) https://github.com/bitcoin/bitcoin/pull/24844
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[gui] hebasto opened pull request #584: Getting ready to Qt 6 (5/n). Do not assume `qDBusRegisterMetaType` return type (master...220413-metatype) https://github.com/bitcoin-core/gui/pull/584
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] furszy opened pull request #24845: wallet: createTransaction, return proper error description for "too-long-mempool-chain" + introduce generic Result classes (master...2022_wallet_operationresult) https://github.com/bitcoin/bitcoin/pull/24845
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
Talkless has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Skyz has joined #bitcoin-core-dev
bitcoin-git has joined #bitcoin-core-dev
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
<bitcoin-git>
[bitcoin] jamesob opened pull request #24846: developer-notes: allow lowerCamelCase for methods (master...jamesob-22-04-dev-notes-methods) https://github.com/bitcoin/bitcoin/pull/24846
Skyz has quit [Quit: Client closed]
vysn has quit [Ping timeout: 240 seconds]
goatpig has quit [Remote host closed the connection]
An0rak has quit [Ping timeout: 240 seconds]
earnestly has quit [Read error: Connection reset by peer]
sipsorcery has quit [Ping timeout: 250 seconds]
earnestly has joined #bitcoin-core-dev
sipsorcery has joined #bitcoin-core-dev
lowhope has quit [Ping timeout: 256 seconds]
jarthur_ is now known as jarthur
Talkless has quit [Quit: Konversation terminated!]
An0rak has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 260 seconds]
sipsorcery has joined #bitcoin-core-dev
lowhope has joined #bitcoin-core-dev
ghost43 has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master 0cea7b1 /dev/fd0: print `(none)` if no warnings in -getinfo
<bitcoin-git>
bitcoin/master 3bbc46d laanwj: Merge bitcoin/bitcoin#24632: add `(none)` in -getinfo `Warnings:` if no wa...
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] laanwj merged pull request #24632: add `(none)` in -getinfo `Warnings:` if no warning returned (master...getinfo-warning) https://github.com/bitcoin/bitcoin/pull/24632
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
hashfuncb3b has joined #bitcoin-core-dev
geyaeb has quit [Ping timeout: 240 seconds]
geyaeb has joined #bitcoin-core-dev
<theStack>
laanwj: i just noticed that our functional test framework maps `importprivkey` to `importdescriptors` for descriptor wallets (class RPCOverloadWrapper)
<theStack>
so maybe my assumption that it only works for legacy wallets is just wrong... i will try in a bit
bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]
jarthur has quit [Ping timeout: 250 seconds]
<laanwj>
theStack: that would explain things
<laanwj>
i mean after all it's passing, it doesn't explicitly request a bdb wallet, and descriptor wallets are the default nowadays?
<laanwj>
this really confused me, but yes, that it maps the method could well be the explanation
<theStack>
right now it does explicitly request bdb, there is a call to "self.skip_if_no_bdb()"
<theStack>
would be nice if it works with both legacy and descriptor wallets though
<theStack>
oh wait, skip_if_no_bdb doesn't mean that a run with descriptor wallets is prevented right... hm
<theStack>
(locally calling the test with --descriptors fails for me, so i'm even more confused :D)
jarthur has joined #bitcoin-core-dev
<laanwj>
skip_if_no_bdb means 'skip if bitcoind is not built with bdb', it does not do amnything else
shesek has joined #bitcoin-core-dev
<laanwj>
that's very strange as --descriptors defaults to true
<laanwj>
you're right though, it does
<laanwj>
can't we make this test work without wallet?
<laanwj>
it doesn't ever check the wallet, what does it use it for
<theStack>
looks like the default used is BDB, ("# Prefer BDB unless it isn't available"), see test_framework.py:216 oO probably this should be changed to default to descriptor wallets
<theStack>
the signet mining script calls the `walletprocesspsbt` RPC, that's why a wallet is needed on the node
<laanwj>
that's super surprising after first defaulting the other way around
<laanwj>
ohh it's internal to the script, that makes sense
<theStack>
and that seems also to be the call that fails if a descriptor wallet is used, i'm trying to find out why...
<laanwj>
but the answer to my initial question "how does a functional test explicitly request a bdb wallet?" seems to be "it doesn't", it's decided from outside, all it can do is skip the test if self.options.descriptors==True
ExEric3 has quit [Read error: Connection reset by peer]
ExEric3 has joined #bitcoin-core-dev
<theStack>
yes, i agree
<theStack>
interesting that the CI didn't fail, i thought we have a target that only has descriptor wallet support but not legacy wallet (didn't check though)
<theStack>
ah, but then the test is skipped due to bdb missing
An0rak has quit [Ping timeout: 250 seconds]
<laanwj>
yes, if bdb is available it will apparently run with that, if bdb is missing it skips due to skip_if_no_bdb
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
<theStack>
so, it seems that the problem is that the descriptor wallet can't sign the 1-of-1 multisig script
<theStack>
if i change the signetchallenge to a p2wpkh script, it works with both legacy and descriptor wallet
Guyver2 has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<theStack>
(1-of-1 multisig doesn't make sense of course, but for some reason i wrongly assumed that signet requests a multisig challenge)
sipsorcery has joined #bitcoin-core-dev
hashfuncb3b has quit [Ping timeout: 250 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
bomb-on has quit [Quit: aллилѹіа!]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
sipsorcery has quit [Ping timeout: 248 seconds]
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<laanwj>
1-of-1 multisig heh
shesek has quit [Remote host closed the connection]
shesek has joined #bitcoin-core-dev
<sipa>
Trivia: is 0-of-0 OP_CHECKMULTISIG-based multisig allowed?
shesek_ has joined #bitcoin-core-dev
<theStack>
i would have guessed no, but looking at the code it seems like it is allowed by consensus rules, but we don't treat it as standard?
shesek has quit [Remote host closed the connection]
<theStack>
(if that is true, i wonder how many 0-of-0 multisig outputs can be found on the main chain :D)