#bitcoin-core-dev on 2022-04-19 — searchable irc log

00:01 sipsorcery has quit [Remote host closed the connection]

00:01 sipsorcery has joined #bitcoin-core-dev

00:09 gossie has quit [Ping timeout: 260 seconds]

00:14 bitcoin-git has joined #bitcoin-core-dev

00:14 <bitcoin-git> [bitcoin] Kvaciral opened pull request #24916: lint: Convert lint-python-utf8-encoding.sh to Python (master...lint-python-utf8-encoding-port) https://github.com/bitcoin/bitcoin/pull/24916

00:14 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

00:15 Willtech has quit [Ping timeout: 250 seconds]

00:21 shesek has quit [Remote host closed the connection]

00:21 shesek has joined #bitcoin-core-dev

00:22 gossie has joined #bitcoin-core-dev

00:24 sipsorcery has quit [Read error: Connection reset by peer]

00:29 roasbeef has quit [Quit: Lost terminal]

00:36 <PaperSword> The hashes are available, I seem to be doing something wrong when sending data over the TRACE definition as only 63 of the 64 hex chars in the has are printed out, I tested this by using Printf directly in code and it displays the correct hash and can be verified as an unconfirmed tx

00:39 roasbeef has joined #bitcoin-core-dev

00:39 brunoerg has quit [Remote host closed the connection]

00:42 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

00:44 brunoerg has joined #bitcoin-core-dev

00:48 vysn has joined #bitcoin-core-dev

00:48 brunoerg has quit [Ping timeout: 240 seconds]

00:51 brunoerg has joined #bitcoin-core-dev

00:53 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

00:55 brunoerg has quit [Ping timeout: 248 seconds]

00:57 brunoerg has joined #bitcoin-core-dev

00:57 boxframes_ has quit [Quit: Leaving]

01:06 kexkey has quit [Quit: kexkey]

01:38 shesek has quit [Remote host closed the connection]

01:38 shesek has joined #bitcoin-core-dev

01:39 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

01:59 brunoerg has quit [Ping timeout: 246 seconds]

02:01 brunoerg has joined #bitcoin-core-dev

02:18 shesek has quit [Remote host closed the connection]

02:18 shesek has joined #bitcoin-core-dev

02:22 bitdex has quit [Ping timeout: 240 seconds]

02:24 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

02:25 bitdex has joined #bitcoin-core-dev

02:27 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:32 Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]

02:39 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:40 bitdex has quit [Ping timeout: 240 seconds]

02:41 bitdex has joined #bitcoin-core-dev

02:43 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

02:48 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:56 shesek has quit [Remote host closed the connection]

02:56 shesek has joined #bitcoin-core-dev

03:11 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

03:11 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

03:18 brunoerg has quit [Ping timeout: 250 seconds]

03:19 shesek has quit [Remote host closed the connection]

03:19 shesek has joined #bitcoin-core-dev

03:20 brunoerg has joined #bitcoin-core-dev

03:23 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

03:30 bitdex has quit [Ping timeout: 240 seconds]

03:33 bitdex has joined #bitcoin-core-dev

03:49 shesek has quit [Remote host closed the connection]

03:49 shesek has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:05 shesek has quit [Remote host closed the connection]

04:05 shesek has joined #bitcoin-core-dev

04:14 bitdex has quit [Ping timeout: 240 seconds]

04:19 bitdex has joined #bitcoin-core-dev

04:26 brunoerg has quit [Ping timeout: 240 seconds]

04:28 brunoerg has joined #bitcoin-core-dev

04:33 yanmaani has quit [Ping timeout: 240 seconds]

04:51 shesek has quit [Remote host closed the connection]

04:51 shesek has joined #bitcoin-core-dev

05:02 yanmaani has joined #bitcoin-core-dev

05:10 shesek has quit [Remote host closed the connection]

05:10 shesek has joined #bitcoin-core-dev

05:12 geyaeb2 has quit [Remote host closed the connection]

05:13 geyaeb2 has joined #bitcoin-core-dev

05:24 shesek_ has joined #bitcoin-core-dev

05:25 shesek has quit [Remote host closed the connection]

05:27 shesek__ has joined #bitcoin-core-dev

05:30 shesek_ has quit [Remote host closed the connection]

05:32 shesek_ has joined #bitcoin-core-dev

05:33 shesek__ has quit [Remote host closed the connection]

05:36 bfsfhkacjzgcytf9 has quit [Ping timeout: 248 seconds]

05:41 shesek_ has quit [Remote host closed the connection]

05:41 shesek_ has joined #bitcoin-core-dev

05:54 shesek_ has quit [Remote host closed the connection]

05:54 shesek_ has joined #bitcoin-core-dev

06:18 shesek_ has quit [Remote host closed the connection]

06:18 shesek_ has joined #bitcoin-core-dev

06:23 anoymous_ has joined #bitcoin-core-dev

06:26 anoymous_ has left #bitcoin-core-dev [#bitcoin-core-dev]

06:30 anoymous has joined #bitcoin-core-dev

06:31 anoymous has left #bitcoin-core-dev [#bitcoin-core-dev]

06:34 brunoerg has quit [Ping timeout: 248 seconds]

06:35 anoymous_ has joined #bitcoin-core-dev

06:35 anoymous1 has joined #bitcoin-core-dev

06:35 brunoerg has joined #bitcoin-core-dev

06:37 anoymous1 has left #bitcoin-core-dev [#bitcoin-core-dev]

06:38 anoymous2 has joined #bitcoin-core-dev

06:41 anoymous2 has quit [Client Quit]

06:41 anoymous1 has joined #bitcoin-core-dev

06:47 anoymous1 has quit [Quit: Lost terminal]

06:47 salvatoshi has joined #bitcoin-core-dev

06:52 anoymous_ has quit [Quit: leaving]

06:53 anoymous has joined #bitcoin-core-dev

07:01 anoymous has quit [Quit: Lost terminal]

07:19 bitdex has quit [Ping timeout: 240 seconds]

07:20 bitdex has joined #bitcoin-core-dev

07:31 shesek_ has quit [Remote host closed the connection]

07:31 shesek_ has joined #bitcoin-core-dev

07:35 Guyver2 has joined #bitcoin-core-dev

07:40 brunoerg has quit [Ping timeout: 260 seconds]

07:49 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

07:51 jonatack has joined #bitcoin-core-dev

07:53 brunoerg has joined #bitcoin-core-dev

07:53 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

07:58 bitdex has quit [Ping timeout: 240 seconds]

08:15 TallTim_ has joined #bitcoin-core-dev

08:17 TallTim has quit [Ping timeout: 260 seconds]

08:19 bitcoin-git has joined #bitcoin-core-dev

08:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/57a73d71a36c...907659770bd2

08:19 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

08:19 <bitcoin-git> bitcoin/master 9076597 MarcoFalke: Merge bitcoin/bitcoin#24913: bench: Add a benchmark for wallet loading

08:19 <bitcoin-git> bitcoin/master 464a162 Andrew Chow: bench: Add a benchmark for wallet loading

08:19 bitcoin-git has joined #bitcoin-core-dev

08:19 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

08:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24913: bench: Add a benchmark for wallet loading (master...bench-wallet-load) https://github.com/bitcoin/bitcoin/pull/24913

08:24 <b10c> PaperSword: I'm assuming you're using a bpftrace script for debugging. By default, bpftrace can only handle strings of 63chars+null terminator. Setting the env var BPFTRACE_STRLEN=65 should work.

08:27 <b10c> That said, it's preferred to do the hex encoding in the tracing script. The txid should be passed as pointer to the byte array. See e.g. the validation:block_connected tracepoint (block hash) or the utxocache:add/spent/uncache tracepoints

08:33 shesek_ has quit [Remote host closed the connection]

08:33 shesek_ has joined #bitcoin-core-dev

08:47 AaronvanW has joined #bitcoin-core-dev

08:53 An0rak has joined #bitcoin-core-dev

08:55 brunoerg has quit [Ping timeout: 240 seconds]

08:57 shesek_ has quit [Remote host closed the connection]

08:57 shesek_ has joined #bitcoin-core-dev

08:57 brunoerg has joined #bitcoin-core-dev

09:02 brunoerg has quit [Ping timeout: 240 seconds]

09:04 brunoerg has joined #bitcoin-core-dev

09:09 bitdex has joined #bitcoin-core-dev

09:18 dviola has joined #bitcoin-core-dev

09:19 <PaperSword> b10c: Just woke up from a power nap, your solution is correct. Firstly I am using bpftrace where the default max string length is limited to 63bytes + Null termination. That was causing the issues regarding the Hexadecimal display of a TXID.

09:21 morcos has quit [Remote host closed the connection]

09:21 morcos has joined #bitcoin-core-dev

09:23 shesek_ has quit [Remote host closed the connection]

09:23 shesek_ has joined #bitcoin-core-dev

09:25 sudoforge has quit [Ping timeout: 256 seconds]

09:35 sudoforge has joined #bitcoin-core-dev

09:36 AaronvanW has quit [Quit: Leaving...]

09:37 bitcoin-git has joined #bitcoin-core-dev

09:37 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

09:37 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24917: Make BlockManager::LoadBlockIndex private (master...2204-priv-🔚) https://github.com/bitcoin/bitcoin/pull/24917

09:40 sudoforge has quit [Ping timeout: 276 seconds]

10:00 bitcoin-git has joined #bitcoin-core-dev

10:00 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24918: test: Remove unused taproot node from wallet_taproot.py (master...2204-rem-🎙) https://github.com/bitcoin/bitcoin/pull/24918

10:00 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:12 bitcoin-git has joined #bitcoin-core-dev

10:12 <bitcoin-git> bitcoin/master ff78833 MarcoFalke: Merge bitcoin/bitcoin#24776: docs: update /rest/chaininfo doc referring to...

10:12 <bitcoin-git> bitcoin/master b941dec brunoerg: docs: update `/rest/chaininfo` doc referring to RPC help

10:12 <bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/907659770bd2...ff78833d3c86

10:12 <bitcoin-git> bitcoin/master 1d95b5c brunoerg: doc: cleanups to mempool rest endpoints

10:12 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:13 bitcoin-git has joined #bitcoin-core-dev

10:13 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24776: docs: update /rest/chaininfo doc referring to RPC help (master...2022-04-rest-doc-improv) https://github.com/bitcoin/bitcoin/pull/24776

10:13 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:18 shesek_ has quit [Remote host closed the connection]

10:18 shesek_ has joined #bitcoin-core-dev

10:19 bitcoin-git has joined #bitcoin-core-dev

10:19 <bitcoin-git> [bitcoin] hebasto opened pull request #24919: doc: Fix a link after to `test/lint/lint-python.py` (master...220419-docs) https://github.com/bitcoin/bitcoin/pull/24919

10:19 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:19 AaronvanW has joined #bitcoin-core-dev

10:26 bitdex has quit [Ping timeout: 240 seconds]

10:28 bitdex has joined #bitcoin-core-dev

10:32 bitcoin-git has joined #bitcoin-core-dev

10:32 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ff78833d3c86...013daed9acca

10:32 <bitcoin-git> bitcoin/master e245c5c Hennadii Stepanov: doc: Fix a link to `test/lint/lint-python.py`

10:32 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:32 <bitcoin-git> bitcoin/master 013daed MarcoFalke: Merge bitcoin/bitcoin#24919: doc: Fix a link to `test/lint/lint-python.py`...

10:33 bitcoin-git has joined #bitcoin-core-dev

10:33 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24919: doc: Fix a link to `test/lint/lint-python.py` (master...220419-docs) https://github.com/bitcoin/bitcoin/pull/24919

10:33 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

10:39 shesek_ has quit [Remote host closed the connection]

10:39 shesek_ has joined #bitcoin-core-dev

11:06 shesek_ has quit [Remote host closed the connection]

11:06 shesek_ has joined #bitcoin-core-dev

11:15 bitcoin-git has joined #bitcoin-core-dev

11:15 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24921: Add time helpers for std::chrono::steady_clock and FastRandomContext::rand_uniform_delay (master...2204-steady-clock-🎎) https://github.com/bitcoin/bitcoin/pull/24921

11:15 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:41 bitcoin-git has joined #bitcoin-core-dev

11:41 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/013daed9acca...b297b945f761

11:41 <bitcoin-git> bitcoin/master fafb479 MarcoFalke: contrib: make gen_key_io_test_vectors deterministic

11:41 <bitcoin-git> bitcoin/master b297b94 laanwj: Merge bitcoin/bitcoin#21279: scripted-diff: Regenerate key_io data determi...

11:41 <bitcoin-git> bitcoin/master fa506ad MarcoFalke: scripted-diff: Regenerate key_io data deterministically

11:41 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

11:41 bitcoin-git has joined #bitcoin-core-dev

11:41 <bitcoin-git> [bitcoin] laanwj merged pull request #21279: scripted-diff: Regenerate key_io data deterministically (master...2102-testDetGen) https://github.com/bitcoin/bitcoin/pull/21279

11:41 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:19 bitcoin-git has joined #bitcoin-core-dev

12:19 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:19 <bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b297b945f761...8d3743a365b9

12:19 <bitcoin-git> bitcoin/master 917a89a Sebastian Falbesoner: test: use MiniWallet for p2p_segwit.py

12:19 <bitcoin-git> bitcoin/master 8d3743a MarcoFalke: Merge bitcoin/bitcoin#24896: test: use MiniWallet for p2p_segwit.py

12:19 bitcoin-git has joined #bitcoin-core-dev

12:19 <bitcoin-git> [bitcoin] MarcoFalke merged pull request #24896: test: use MiniWallet for p2p_segwit.py (master...202204-test-run_p2p_segwit_without_wallet) https://github.com/bitcoin/bitcoin/pull/24896

12:19 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:26 bitdex has quit [Ping timeout: 240 seconds]

12:37 bitcoin-git has joined #bitcoin-core-dev

12:37 <bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8d3743a365b9...e0ff55a83621

12:37 <bitcoin-git> bitcoin/master e0ff55a fanquake: Merge bitcoin/bitcoin#24871: refactor: Simplify GetTime

12:37 <bitcoin-git> bitcoin/master 0000a63 MarcoFalke: Simplify GetTime

12:37 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:38 bitcoin-git has joined #bitcoin-core-dev

12:38 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

12:38 <bitcoin-git> [bitcoin] fanquake merged pull request #24871: refactor: Simplify GetTime (master...2204-time-🖤) https://github.com/bitcoin/bitcoin/pull/24871

13:23 SpellChecker_ has quit [Remote host closed the connection]

13:23 dougefish has quit [Remote host closed the connection]

13:24 SpellChecker has joined #bitcoin-core-dev

13:25 dougefish has joined #bitcoin-core-dev

13:40 vysn has quit [Ping timeout: 250 seconds]

14:00 bitcoin-git has joined #bitcoin-core-dev

14:00 <bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e0ff55a83621...f8b2e9bcfc76

14:00 <bitcoin-git> bitcoin/master 07ddecb Hennadii Stepanov: refactor: Use [[maybe_unused]] attribute

14:00 <bitcoin-git> bitcoin/master f8b2e9b laanwj: Merge bitcoin/bitcoin#24772: refactor: Use [[maybe_unused]] attribute

14:00 <bitcoin-git> bitcoin/master 55e0fc8 Hennadii Stepanov: refactor: Drop unneeded workarounds aimed to silence unused warning

14:00 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:00 bitcoin-git has joined #bitcoin-core-dev

14:00 <bitcoin-git> [bitcoin] laanwj merged pull request #24772: refactor: Use [[maybe_unused]] attribute (master...220405-void) https://github.com/bitcoin/bitcoin/pull/24772

14:00 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:00 SpellChecker has quit [Remote host closed the connection]

14:01 SpellChecker has joined #bitcoin-core-dev

14:06 TallTim_ is now known as TallTim

14:40 vysn has joined #bitcoin-core-dev

14:40 sudoforge has joined #bitcoin-core-dev

14:41 sipsorcery has joined #bitcoin-core-dev

14:44 bitcoin-git has joined #bitcoin-core-dev

14:44 <bitcoin-git> bitcoin/master 184e56d Vasil Dimov: net: add new method Sock::SetSockOpt() that wraps setsockopt()

14:44 <bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/f8b2e9bcfc76...6300b9556ec9

14:44 <bitcoin-git> bitcoin/master a2c4a7a Vasil Dimov: net: use Sock::SetSockOpt() instead of standalone SetSocketNoDelay()

14:44 <bitcoin-git> bitcoin/master d65b6c3 Vasil Dimov: net: use Sock::SetSockOpt() instead of setsockopt()

14:44 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:44 bitcoin-git has joined #bitcoin-core-dev

14:44 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:44 <bitcoin-git> [bitcoin] laanwj merged pull request #24357: refactor: make setsockopt() and SetSocketNoDelay() mockable/testable (master...mockable_SetSocketNoDelay_and_setsockopt) https://github.com/bitcoin/bitcoin/pull/24357

14:49 Alina-malina has quit [Remote host closed the connection]

14:54 bitcoin-git has joined #bitcoin-core-dev

14:54 <bitcoin-git> [bitcoin] TheQuantumPhysicist opened pull request #24922: Isolate the storage abstraction layer from the application/serialization layer (master...feat/storage-isolation) https://github.com/bitcoin/bitcoin/pull/24922

14:54 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

14:58 Alina-malina has joined #bitcoin-core-dev

15:04 <jeremyrubin> laanwj: wrt rc5 -> release, i of course know theres no set window, i was more asking how much time after not finding an error the plan is to tag / release it. e.g., what's the window for reporting errors?

15:09 orville has joined #bitcoin-core-dev

15:18 morcos has quit [Quit: ZNC 1.8.2+deb1+bionic2 - https://znc.in]

15:19 morcos has joined #bitcoin-core-dev

15:21 ronoaldo has joined #bitcoin-core-dev

15:26 ML26 has joined #bitcoin-core-dev

15:41 Guest98 has joined #bitcoin-core-dev

15:51 ML26 has quit [Quit: Client closed]

15:59 <MarcoFalke> Usually one week +- a few days since the last rc

15:59 <laanwj> yeah 1-2 weeks

15:59 <MarcoFalke> So I think we can tag final some time this week?

16:06 bitcoin-git has joined #bitcoin-core-dev

16:06 <bitcoin-git> [bitcoin] MarcoFalke opened pull request #24923: Rework logging timer (master...2204-log-time-📬) https://github.com/bitcoin/bitcoin/pull/24923

16:06 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

16:10 salvatoshi has quit [Ping timeout: 276 seconds]

16:11 vysn has quit [Ping timeout: 250 seconds]

16:11 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

16:13 <fanquake> Probably

16:14 shesek_ has quit [Remote host closed the connection]

16:14 shesek_ has joined #bitcoin-core-dev

16:14 gribble has quit [Remote host closed the connection]

16:16 Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]

16:24 gribble has joined #bitcoin-core-dev

16:26 dhruv has quit [Remote host closed the connection]

16:30 AaronvanW has quit [Quit: Leaving...]

16:30 dhruv has joined #bitcoin-core-dev

16:34 shesek_ has quit [Remote host closed the connection]

16:34 Talkless has joined #bitcoin-core-dev

16:35 shesek_ has joined #bitcoin-core-dev

16:37 anoymous has joined #bitcoin-core-dev

16:42 anoymous has left #bitcoin-core-dev [#bitcoin-core-dev]

17:01 bitcoin-git has joined #bitcoin-core-dev

17:01 <bitcoin-git> [bitcoin] achow101 opened pull request #24924: bench: Make WalletLoading benchmark run faster (master...reduce-wallet-load-bench-runtime) https://github.com/bitcoin/bitcoin/pull/24924

17:01 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:13 shesek_ has quit [Remote host closed the connection]

17:14 shesek_ has joined #bitcoin-core-dev

17:16 orville has quit [Quit: Going offline, see ya! (www.adiirc.com)]

17:18 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

17:21 tyranoc4 has joined #bitcoin-core-dev

17:21 <tyranoc4> :part

17:21 tyranoc4 has left #bitcoin-core-dev [#bitcoin-core-dev]

17:24 nanotube has quit [Ping timeout: 256 seconds]

17:32 bitcoin-git has joined #bitcoin-core-dev

17:32 <bitcoin-git> [gui] hebasto merged pull request #580: Getting ready to Qt 6 (3/n). Do not use `QKeyEvent` copy constructor (master...220409-event) https://github.com/bitcoin-core/gui/pull/580

17:32 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:33 bitcoin-git has joined #bitcoin-core-dev

17:33 <bitcoin-git> bitcoin/master 37e49cc Hennadii Stepanov: Merge bitcoin-core/gui#580: Getting ready to Qt 6 (3/n). Do not use `QKeyE...

17:33 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8103fffe5cc6...37e49cc1b56b

17:33 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:33 <bitcoin-git> bitcoin/master 3ec6504 Hennadii Stepanov: qt: Do not use `QKeyEvent` copy constructor

17:33 bitcoin-git has joined #bitcoin-core-dev

17:33 <bitcoin-git> [bitcoin] hebasto merged pull request #24906: miniscript: the 'd:' wrapper must not be 'u' (master...miniscript_fix) https://github.com/bitcoin/bitcoin/pull/24906

17:33 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:37 bitcoin-git has joined #bitcoin-core-dev

17:37 <bitcoin-git> [gui] hebasto merged pull request #584: Getting ready to Qt 6 (5/n). Do not assume `qDBusRegisterMetaType` return type (master...220413-metatype) https://github.com/bitcoin-core/gui/pull/584

17:37 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:37 bitcoin-git has joined #bitcoin-core-dev

17:37 <bitcoin-git> bitcoin/master 6cf4dc7 Hennadii Stepanov: qt: Do not assume `qDBusRegisterMetaType` return type

17:37 <bitcoin-git> [bitcoin] hebasto pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/37e49cc1b56b...254f3cc3684c

17:37 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

17:37 <bitcoin-git> bitcoin/master 254f3cc Hennadii Stepanov: Merge bitcoin-core/gui#584: Getting ready to Qt 6 (5/n). Do not assume `qD...

17:38 sipsorcery has quit [Ping timeout: 240 seconds]

17:41 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

17:45 sipsorcery has joined #bitcoin-core-dev

17:47 An0rak has quit []

17:57 shesek_ has quit [Remote host closed the connection]

17:57 shesek_ has joined #bitcoin-core-dev

18:06 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:11 Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]

18:22 shesek_ has quit [Remote host closed the connection]

18:23 shesek_ has joined #bitcoin-core-dev

18:28 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:32 Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]

18:48 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:50 Kaizen_K_ has joined #bitcoin-core-dev

18:50 bitcoin-git has joined #bitcoin-core-dev

18:50 <bitcoin-git> [bitcoin] PastaPastaPasta opened pull request #24925: refactor: make GetRand a template, remove GetRandInt by PastaPastaPasta (master...refactor-random-2) https://github.com/bitcoin/bitcoin/pull/24925

18:50 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

18:52 Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]

18:55 Kaizen_K_ has quit [Ping timeout: 276 seconds]

18:58 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

19:00 shesek_ has quit [Remote host closed the connection]

19:00 shesek_ has joined #bitcoin-core-dev

19:12 Talkless has quit [Quit: Konversation terminated!]

19:13 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

19:26 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

19:28 Kaizen_K_ has joined #bitcoin-core-dev

19:30 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

19:33 salvatoshi has joined #bitcoin-core-dev

19:36 An0rak has joined #bitcoin-core-dev

19:42 Kaizen_K_ has quit [Remote host closed the connection]

19:47 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

19:54 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

19:58 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

20:01 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

20:04 alty22 has joined #bitcoin-core-dev

20:05 Guest98 has quit [Quit: Client closed]

20:05 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

20:13 alty22 has quit [Quit: Client closed]

20:15 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

20:18 shesek_ has quit [Remote host closed the connection]

20:18 shesek_ has joined #bitcoin-core-dev

20:31 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

20:35 Kaizen_K_ has joined #bitcoin-core-dev

20:38 Kaizen_Kintsugi_ has quit [Ping timeout: 256 seconds]

20:40 Guyver2 has quit [Ping timeout: 256 seconds]

20:42 Kaizen_K_ has quit [Remote host closed the connection]

20:42 shesek_ has quit [Remote host closed the connection]

20:43 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

21:11 bitcoin-git has joined #bitcoin-core-dev

21:11 <bitcoin-git> [bitcoin] Crypt-iQ opened pull request #24926: mempool: use mapNextTx.lower_bound in removeRecursive (master...mapnexttx_04192022) https://github.com/bitcoin/bitcoin/pull/24926

21:11 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]

21:19 <jeremyrubin> btw does anyone have any ideas why CI is confused on this run https://github.com/bitcoin/bitcoin/pull/21702/checks?check_run_id=5612819653

21:19 <jeremyrubin> the error makes no sense -- the variable is clearly pindex, not rindex

21:20 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

21:21 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

21:29 bomb-on has joined #bitcoin-core-dev

21:29 <jonatack> jeremyrubin: if helpful, building your branch locally (rebased to current master) with debian testing clang 15 i see the same "validation.cpp:1965:29: error: use of undeclared identifier 'pindex'"

21:30 <jeremyrubin> very weird

21:30 <jeremyrubin> can you look and see what's even at that line of code?

21:30 salvatoshi has quit [Ping timeout: 276 seconds]

21:30 <jonatack> (without the suggested alternative)

21:30 <sipa> the "rindex" is just the compiler suggesting that perhaps you mean something else here; presumably, it's wrong

21:30 <jeremyrubin> oh

21:31 <jeremyrubin> it looks like MarcoFalke renamed it somewhat recently?

21:31 <jeremyrubin> and this is the merge test?

21:32 Kaizen_Kintsugi_ has quit [Ping timeout: 250 seconds]

21:32 <jonatack> line is.... if (DeploymentActiveAt(*pindex, consensusparams, Consensus::DEPLOYMENT_CHECKTEMPLATEVERIFY)) {

21:32 <jeremyrubin> ugh

21:32 <jonatack> (i don't see where you are passing it in)

21:32 <jeremyrubin> this is a super annoying one

21:33 <theStack> funny that the compilers comes up with "rindex", considering that we don't even have an identifier named like that oO (maybe somewhere hidden deep in the includes of standard library or boost etc. though...)

21:33 <jeremyrubin> since it seems this patch is not in 23.0?

21:33 <jeremyrubin> but it is in master

21:33 <jeremyrubin> so i need to diverge the branches for backports

21:34 <jonatack> yeah GetBlockScriptFlags doesn't have a pindex arg (iiuc, it's kind of late)

21:34 <sipa> theStack: it is part of glibc, see https://linux.die.net/man/3/rindex

21:34 <jeremyrubin> jonatack: it did, 25 days ago though

21:34 <jonatack> jeremyrubin: right

21:34 <jonatack> life in the fast lane

21:35 <theStack> sipa: ah, that's interesting!

21:35 <jeremyrubin> jonatack: i now am maintaining no fewer than 4 CTV branches

21:36 <jeremyrubin> 0.22, 0.23, signet, and now master

21:36 <jeremyrubin> (ノಠ益ಠ)ノ彡┻━┻

21:36 <jonatack> gg

21:37 <jonatack> jeremyrubin: right, per git blame it changed in commit faadc60 "refactor: Pass const reference instead of pointer to GetBlockScriptFlags"

21:45 <jonatack> indeed not in v23, went in after the branch-off

21:49 <jeremyrubin> sigh

21:50 <jeremyrubin> what's the best way to do this? would it be to have a patch that only goes in to the current master so that patches across the now-backport 0.23 are more similar to the master?

21:50 <jeremyrubin> or is it to just fix the patch on master?

21:51 <jeremyrubin> my preference is to just have a fixup patch since that makes any future rebasing simpler as i can drop that patch, but then that breaks bisecting?

21:53 <jeremyrubin> i have a feeling that either pick generates some amount of someone being not happy with the reviewability so want to minimize that

21:53 <jeremyrubin> patch to rename block_index to pindex?

21:54 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

21:54 <jeremyrubin> keeps patchsets similar, no breakage of bisecting, can be changed back later?

21:55 <jeremyrubin> MarcoFalke: wdyt?

21:59 bomb-on_ has joined #bitcoin-core-dev

22:00 bomb-on__ has joined #bitcoin-core-dev

22:02 bomb-on____ has joined #bitcoin-core-dev

22:02 bomb-on has quit [Ping timeout: 240 seconds]

22:03 bomb-on_ has quit [Ping timeout: 248 seconds]

22:04 bomb-on__ has quit [Ping timeout: 248 seconds]

22:05 bomb-on has joined #bitcoin-core-dev

22:08 bomb-on____ has quit [Ping timeout: 248 seconds]

22:14 An0rak has quit []

22:17 tripleslash has quit [Ping timeout: 240 seconds]

22:20 sipsorcery has quit [Ping timeout: 240 seconds]

22:21 tripleslash has joined #bitcoin-core-dev

22:21 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

22:22 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

22:24 Victorsueca has quit [Quit: Gone frying asparagus or my Windows had a BSOD]

22:24 Victorsueca has joined #bitcoin-core-dev

22:38 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

22:39 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

22:43 sipsorcery has joined #bitcoin-core-dev

22:50 bomb-on has quit [Quit: aллилѹіа!]

22:52 brunoerg has quit [Remote host closed the connection]

22:57 brunoerg has joined #bitcoin-core-dev

23:01 brunoerg has quit [Ping timeout: 240 seconds]

23:05 brunoerg has joined #bitcoin-core-dev

23:10 brunoerg has quit [Ping timeout: 240 seconds]

23:12 brunoerg has joined #bitcoin-core-dev

23:17 sipsorcery has quit [Ping timeout: 240 seconds]

23:37 bitdex has joined #bitcoin-core-dev

23:44 bitcoin-git has joined #bitcoin-core-dev

23:44 <bitcoin-git> [bitcoin] glozow opened pull request #24927: Add test util to populate mempool with random transactions, fix #24634 bug (master...2022-04-test-util-populate-mempool) https://github.com/bitcoin/bitcoin/pull/24927

23:44 bitcoin-git has left #bitcoin-core-dev [#bitcoin-core-dev]