#bitcoin-core-dev on 2022-05-14 — searchable irc log

00:47 bitdex has joined #bitcoin-core-dev

00:47 common has joined #bitcoin-core-dev

00:48 common has quit [Remote host closed the connection]

00:48 brunoerg has quit [Ping timeout: 248 seconds]

00:48 common has joined #bitcoin-core-dev

01:03 brunoerg has joined #bitcoin-core-dev

01:20 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

01:23 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

01:27 Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]

01:31 sipsorcery has joined #bitcoin-core-dev

01:42 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

01:44 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

01:44 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

01:48 sipsorcery has quit [Remote host closed the connection]

01:59 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

02:00 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:03 AaronvanW has quit [Ping timeout: 252 seconds]

02:04 Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]

02:05 brunoerg has quit [Ping timeout: 240 seconds]

02:17 AaronvanW has joined #bitcoin-core-dev

02:18 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:20 brunoerg has joined #bitcoin-core-dev

02:24 Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]

02:35 BlackandPr0ud has joined #bitcoin-core-dev

02:40 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:47 Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]

02:56 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

02:57 belcher has quit [Ping timeout: 276 seconds]

03:00 BlackandPr0ud has left #bitcoin-core-dev [#bitcoin-core-dev]

03:04 ZeroMaster has quit [Ping timeout: 246 seconds]

03:07 ZeroMaster has joined #bitcoin-core-dev

03:11 belcher has joined #bitcoin-core-dev

03:55 AaronvanW has quit [Ping timeout: 260 seconds]

04:00 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

04:00 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

04:01 cmirror has quit [Remote host closed the connection]

04:01 cmirror has joined #bitcoin-core-dev

04:03 mikehu44 has joined #bitcoin-core-dev

04:09 mikehu44_ has joined #bitcoin-core-dev

04:10 AaronvanW has joined #bitcoin-core-dev

04:12 sudoforge has quit [Ping timeout: 248 seconds]

04:12 mikehu44 has quit [Ping timeout: 260 seconds]

04:15 brunoerg has quit [Ping timeout: 248 seconds]

04:31 brunoerg has joined #bitcoin-core-dev

04:43 AaronvanW has quit [Ping timeout: 260 seconds]

04:51 Cory has quit [Ping timeout: 276 seconds]

05:08 Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]

05:17 djb27 has joined #bitcoin-core-dev

05:21 <bitcoin-git> [bitcoin] david-bakin opened pull request #25132: Add BIP-341 specified constraints as asserts in `ComputeTaprootMerkel… (master...compute-taproot-merkle-root-asserts) https://github.com/bitcoin/bitcoin/pull/25132

05:22 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

05:30 djb27 has quit [Quit: Leaving]

05:31 bitdex has quit [Ping timeout: 240 seconds]

05:34 brunoerg has quit [Ping timeout: 240 seconds]

05:39 bitdex has joined #bitcoin-core-dev

05:52 mikehu44_ has quit [Ping timeout: 240 seconds]

06:03 brunoerg has joined #bitcoin-core-dev

06:05 zeropoint has joined #bitcoin-core-dev

06:07 geyaeb has quit [Remote host closed the connection]

06:08 zeropoint has quit [Client Quit]

06:12 bitdex has quit [Ping timeout: 240 seconds]

06:13 bitdex has joined #bitcoin-core-dev

06:20 <david-bakin> I have a PR where I just pushed a commit and the 'lint' check fails as follows: "Failed to start an instance! CreateContainerError: context deadline exceeded" - seems to be a CI pipeline error. Is there a way to kick this to rerun this one test?

06:20 <david-bakin> https://github.com/bitcoin/bitcoin/pull/25097 - test log is at https://cirrus-ci.com/task/5376399086190592

06:26 Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]

06:40 AaronvanW has joined #bitcoin-core-dev

06:47 jarthur has quit [Quit: jarthur]

06:54 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

07:00 Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]

07:07 brunoerg has quit [Ping timeout: 240 seconds]

07:07 bitdex has quit [Ping timeout: 240 seconds]

07:09 bitdex has joined #bitcoin-core-dev

07:15 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

07:22 brunoerg has joined #bitcoin-core-dev

07:47 Guyver2 has joined #bitcoin-core-dev

08:11 sipsorcery has joined #bitcoin-core-dev

08:12 Talkless has joined #bitcoin-core-dev

08:18 bitdex has quit [Ping timeout: 240 seconds]

08:18 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

08:23 bitdex has joined #bitcoin-core-dev

08:25 brunoerg has quit [Ping timeout: 248 seconds]

08:33 ziggie has quit [Quit: Connection closed for inactivity]

08:34 bomb-on has joined #bitcoin-core-dev

08:41 brunoerg has joined #bitcoin-core-dev

08:44 AaronvanW has quit [Remote host closed the connection]

08:47 sipsorcery has quit [Ping timeout: 248 seconds]

08:48 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

08:53 Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]

09:03 kexkey has quit [Ping timeout: 248 seconds]

09:04 kexkey has joined #bitcoin-core-dev

09:04 bomb-on has quit [Quit: aллилѹіа!]

09:07 Guyver2 has left #bitcoin-core-dev [Closing Window]

09:07 AaronvanW has joined #bitcoin-core-dev

09:21 bomb-on has joined #bitcoin-core-dev

09:22 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

09:31 sipsorcery has joined #bitcoin-core-dev

09:42 brunoerg has quit [Ping timeout: 252 seconds]

10:09 sipsorcery has quit [Ping timeout: 252 seconds]

10:09 brunoerg has joined #bitcoin-core-dev

10:10 bomb-on has quit [Read error: Connection reset by peer]

10:26 Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]

10:34 bitdex has quit [Ping timeout: 240 seconds]

10:37 bitdex has joined #bitcoin-core-dev

10:38 ZeroMaster has quit [Ping timeout: 240 seconds]

10:40 AaronvanW has quit [Remote host closed the connection]

10:42 ZeroMaster has joined #bitcoin-core-dev

10:57 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

11:01 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

11:02 AaronvanW has joined #bitcoin-core-dev

11:17 bcdarc_ has joined #bitcoin-core-dev

11:17 sdaftuar2 has quit [Ping timeout: 256 seconds]

11:17 bcdarc has quit [Ping timeout: 248 seconds]

11:19 sdaftuar2 has joined #bitcoin-core-dev

11:21 bitdex has joined #bitcoin-core-dev

11:24 sipsorcery has joined #bitcoin-core-dev

11:27 brunoerg has joined #bitcoin-core-dev

11:43 bcdarc has joined #bitcoin-core-dev

11:45 sdaftuar2 has joined #bitcoin-core-dev

11:47 AaronvanW has quit [Remote host closed the connection]

12:02 common has quit [Ping timeout: 240 seconds]

12:18 hirish_ has quit [Quit: ZNC - https://znc.in]

12:18 bitdex has quit [Ping timeout: 240 seconds]

12:18 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

12:18 AaronvanW has joined #bitcoin-core-dev

12:19 bitdex has joined #bitcoin-core-dev

12:20 sipsorcery has quit [Ping timeout: 252 seconds]

12:23 hirish has joined #bitcoin-core-dev

12:29 brunoerg has quit [Ping timeout: 248 seconds]

12:31 sipsorcery has joined #bitcoin-core-dev

12:41 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

12:45 Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]

12:46 <jonatack> david-bakin: it looks like there are commits to squash in that pull (e.g. the fix CI and merge ones), could do that and then re-push

12:47 <jonatack> (I would have restarted the job but don't see a re-run button available to click in this case)

12:48 <jonatack> (also: ne need to update the copyright header years; those are handled in one go by the run of an annual script)

12:48 <jonatack> *no need

12:51 AaronvanW has quit [Ping timeout: 240 seconds]

12:58 brunoerg has joined #bitcoin-core-dev

13:05 sudoforge has joined #bitcoin-core-dev

13:15 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

13:17 sipsorcery has quit [Ping timeout: 252 seconds]

13:31 <bitcoin-git> [bitcoin] aureleoules closed pull request #25026: rpc: Make pruneblockchain fetch old blocks if height is lower than pruned height (master...2022-04-pruneblockchain-fetch-old-blocks) https://github.com/bitcoin/bitcoin/pull/25026

13:32 bitdex has quit [Ping timeout: 240 seconds]

14:02 brunoerg has quit [Ping timeout: 252 seconds]

14:19 Kaizen_Kintsugi_ has quit [Ping timeout: 252 seconds]

14:31 brunoerg has joined #bitcoin-core-dev

14:47 AaronvanW has joined #bitcoin-core-dev

14:48 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

14:53 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

15:08 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

15:16 AaronvanW has quit [Ping timeout: 248 seconds]

15:34 brunoerg has quit [Ping timeout: 248 seconds]

15:45 AaronvanW has joined #bitcoin-core-dev

16:03 brunoerg has joined #bitcoin-core-dev

16:05 <david-bakin> jonatack - ok, you're saying just trigger it again - is it the practice by the way to do the squash commits before sending the PR to review (as opposed to letting github do it when the PR is merged)?

16:06 <sipa> I restarted it for you.

16:13 <david-bakin> ty

16:27 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

16:27 ExEric3 has quit [Remote host closed the connection]

16:28 ExEric3 has joined #bitcoin-core-dev

16:48 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

16:53 Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]

16:55 david-bakin has quit [Remote host closed the connection]

17:02 david-bakin has joined #bitcoin-core-dev

17:06 david-bakin has quit [Remote host closed the connection]

17:06 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

17:08 KolbyML has quit [Read error: Connection reset by peer]

17:08 david-bakin has joined #bitcoin-core-dev

17:09 brunoerg has quit [Ping timeout: 252 seconds]

17:15 Heston has left #bitcoin-core-dev [Leaving]

17:25 brunoerg has joined #bitcoin-core-dev

17:46 mekster66949 has quit [Quit: mekster66949]

17:47 sipsorcery has joined #bitcoin-core-dev

17:48 mekster66949 has joined #bitcoin-core-dev

17:55 Guest99 has joined #bitcoin-core-dev

17:57 Guest99 has quit [Client Quit]

17:58 Guest99 has joined #bitcoin-core-dev

17:58 Guest99 has quit [Client Quit]

18:08 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

18:22 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:26 Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]

18:27 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:37 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

18:37 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:41 jarthur has joined #bitcoin-core-dev

18:41 brunoerg has quit [Remote host closed the connection]

18:55 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

18:56 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

18:58 brunoerg has joined #bitcoin-core-dev

19:02 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

19:30 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

19:50 sipsorcery has quit [Ping timeout: 248 seconds]

20:01 sipsorcery has joined #bitcoin-core-dev

20:02 brunoerg has quit [Ping timeout: 240 seconds]

20:03 reardencode has quit [Ping timeout: 256 seconds]

20:04 reardencode has joined #bitcoin-core-dev

20:23 jesseposner has quit [Ping timeout: 276 seconds]

20:24 jesseposner has joined #bitcoin-core-dev

20:31 Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]

20:31 brunoerg has joined #bitcoin-core-dev

20:43 cmirror has joined #bitcoin-core-dev

20:45 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

20:49 reardencode has quit [Ping timeout: 240 seconds]

20:49 z9z0b3t1_ has joined #bitcoin-core-dev

20:53 z9z0b3t1c has quit [Ping timeout: 250 seconds]

20:55 reardencode has joined #bitcoin-core-dev

20:56 <bitcoin-git> [bitcoin] amadeuszpawlik opened pull request #25136: Torcontrol opt check (master...torcontrol_opt_check) https://github.com/bitcoin/bitcoin/pull/25136

21:14 <jonatack> david-bakin: yes, squash and make it review-ready per CONTRIBUTING.md (in the repo root)

21:16 <jonatack> *squash into the final version of (hygienic) commits -- don't hesitate to look at and review other pull requests to see the project conventions

21:17 <jonatack> and each commit should pass CI (linters, tests) on its own

21:18 Talkless has quit [Quit: Konversation terminated!]

21:19 Talkless has joined #bitcoin-core-dev

21:19 Talkless has quit [Client Quit]

21:45 brunoerg has quit [Remote host closed the connection]

22:00 <david-bakin> ok, thanks jonatack

22:02 brunoerg has joined #bitcoin-core-dev

22:07 brunoerg has quit [Ping timeout: 260 seconds]

22:19 sipsorcery has quit [Ping timeout: 248 seconds]

22:22 brunoerg has joined #bitcoin-core-dev

22:24 hashfuncd0e has joined #bitcoin-core-dev

22:45 AaronvanW has quit [Remote host closed the connection]

23:00 Kaizen_Kintsugi_ has quit [Ping timeout: 248 seconds]

23:02 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

23:16 AaronvanW has joined #bitcoin-core-dev

23:23 brunoerg has quit [Ping timeout: 248 seconds]

23:38 brunoerg has joined #bitcoin-core-dev

23:38 aleggg has quit [Ping timeout: 240 seconds]

23:39 aleggg has joined #bitcoin-core-dev

23:48 Kaizen_Kintsugi_ has quit [Remote host closed the connection]

23:48 Kaizen_Kintsugi_ has joined #bitcoin-core-dev

23:49 AaronvanW has quit [Ping timeout: 248 seconds]