Kaizen___ has quit [Remote host closed the connection]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
bytes1440000 has left #bitcoin-core-dev [#bitcoin-core-dev]
earnestly has quit [Ping timeout: 272 seconds]
z9z0b3t1c has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
brunoerg has joined #bitcoin-core-dev
hashfunc1204 has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 260 seconds]
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 244 seconds]
bitdex has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 276 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
realies has quit [Ping timeout: 246 seconds]
brunoerg has joined #bitcoin-core-dev
realies has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
z9z0b3t1_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
z9z0b3t1c has quit [Ping timeout: 256 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 240 seconds]
szkl has joined #bitcoin-core-dev
cmirror has quit [Remote host closed the connection]
cmirror has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 246 seconds]
mikehu44 has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
<david-bakin>
I just got a linker error from `ld`which ld
<david-bakin>
oops
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
brunoerg has quit [Ping timeout: 272 seconds]
<david-bakin>
I just got a linker error from `ld`: "DWARF error: invalid or unhandled FORM value: 0x25" - now, web search tells me this happens when clang's using dwarf v5 and some tool isn't set up for it. I see in 00_setup_env_native_valgrind.h that they had this problem with valgrind so they set `CXXFLAGS=-fdebug-default-version=4` to get around this. BUT!
<david-bakin>
1) if I pass that to configure then all the _other_ CXXFLAGS are overridden - none show up. So how do I set configure to ADD this to the CXXFLAGS?
<david-bakin>
and 2) should I be doing this anyway? If I go through with this in this PR won't it change everyone's build? So ... do I simply need to avoid the C++ construct that triggers this?
<david-bakin>
I'm using clang 15.0.0 and GNU ld 2.37. Should I be using a different toolchain?
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
chinggg has joined #bitcoin-core-dev
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 246 seconds]
dongcarl has quit [Ping timeout: 260 seconds]
dongcarl has joined #bitcoin-core-dev
hashfunc1204 has quit [Ping timeout: 260 seconds]
<david-bakin>
NVM I just rewrote C++ code until the problem went away.
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 248 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 244 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 272 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
brunoerg has quit [Ping timeout: 260 seconds]
brunoerg has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
brunoerg has quit [Ping timeout: 244 seconds]
szkl has quit [Quit: Connection closed for inactivity]
z9z0b3t1c has joined #bitcoin-core-dev
Guest4630 has joined #bitcoin-core-dev
<laanwj>
from what i've seen uusally if you get DWARF errors it means you have to clean your tree, it means object files from different compilers are used together in a way they shouldn't
<laanwj>
oh, yes, it could also mean your linker is not compatible with the debug information your compiler generates
<laanwj>
it shouldn't be related to anything you wrote at the C++ level, nothing you do at that level should (unless a bug in the toolchain) result in a DWARF error
brunoerg has joined #bitcoin-core-dev
<laanwj>
jonatack ran into a similar error with clang 15 recently #25120
<laanwj>
jonatack: wait, i don't get it, why make CDBWrapper a struct instead of a class?
<laanwj>
i don't really know what the guidance is for making something a struct or a class but anything that *inherits* from a parent class seems definitely in class territory to me
<laanwj>
i mean, DB
jonatack has quit [Ping timeout: 244 seconds]
<laanwj>
CDBWrapper is a class, BaseIndex::DB is derived from it, so should imo be a class too
Aaronvan_ has quit [Remote host closed the connection]
kexkey has quit [Ping timeout: 248 seconds]
kexkey has joined #bitcoin-core-dev
<laanwj>
this PR keeps confusing me on small c++ details
<laanwj>
i'm sorry to say but i'm not sure it's really worth it or just a very marginal improvement
<jonatack>
laanwj: will drop that accessory change in the last commit
greypw2546 has quit [Quit: I'll be back!]
greypw2546 has joined #bitcoin-core-dev
bfsfhkacjzgcytf9 has joined #bitcoin-core-dev
salvatoshi has quit [Ping timeout: 240 seconds]
<jonatack>
Done. I think it's a good simplification, encapsulation improvement, and code clarification that helps new virtual functions be added in the right place rather than by default next to existing ones (that were misplaced). This came up in review feedback over several PRs.
<hebasto>
has bitcoin-git bot just got another holiday?
<laanwj>
jonatack: thanks!
<laanwj>
hebasto: i didn't give if time off i'll check
<laanwj>
i'm not entirely sure what happened (the matrix side was throwing an error resolving the room alias), restarting the bot seems to have solved it
<hebasto>
thanks!
AaronvanW has joined #bitcoin-core-dev
z9z0b3t1c has joined #bitcoin-core-dev
z9z0b3t1_ has quit [Ping timeout: 250 seconds]
<bitcoin-git>
[bitcoin] hebasto opened pull request #25175: refactor: Improve thread safety analysis by propagating some negative capabilities (master...220520-nega) https://github.com/bitcoin/bitcoin/pull/25175
sudoforge has quit [Ping timeout: 244 seconds]
AaronvanW has quit [Remote host closed the connection]
<bitcoin-git>
bitcoin/master fa4ee53 MacroFake: Do not pass time getter to Chainstate helpers
<bitcoin-git>
bitcoin/master faf012b MacroFake: Do not pass Consensus::Params& to Chainstate helpers
<bitcoin-git>
bitcoin/master fafe5c0 MacroFake: Do not pass CChainParams& to BlockAssembler constructor
<bitcoin-git>
[bitcoin] MarcoFalke merged pull request #25168: refactor: Avoid passing params where not needed (master...2205-remove-bloat-🏮) https://github.com/bitcoin/bitcoin/pull/25168
Guyver2 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] jonatack opened pull request #25176: Fix frequent -netinfo JSON errors from missing getpeerinfo#relaytxes (master...fix-netinfo-json-errors-from-null-getpeerinfo-relaytxes-field) https://github.com/bitcoin/bitcoin/pull/25176
bitdex has quit [Quit: = ""]
brunoerg has joined #bitcoin-core-dev
yanmaani2 has quit [Ping timeout: 240 seconds]
yanmaani2 has joined #bitcoin-core-dev
<bitcoin-git>
[bitcoin] theStack opened pull request #25178: doc: remove passing `--disable-external-signer` in OpenBSD build guide (master...202205-doc-update_openbsd_build_docs_71) https://github.com/bitcoin/bitcoin/pull/25178
furszy has joined #bitcoin-core-dev
noonien has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 240 seconds]
Guyver2_ has joined #bitcoin-core-dev
Guyver2 has quit [Ping timeout: 260 seconds]
z9z0b3t1_ has joined #bitcoin-core-dev
david-bakin has joined #bitcoin-core-dev
z9z0b3t1c has quit [Ping timeout: 256 seconds]
szkl has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
mikehu44 has quit [Ping timeout: 240 seconds]
common has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Remote host closed the connection]
Kaizen_Kintsugi_ has joined #bitcoin-core-dev
Kaizen_K_ has joined #bitcoin-core-dev
Kaizen_Kintsugi_ has quit [Ping timeout: 276 seconds]
furszy has quit [Remote host closed the connection]
<david-bakin>
hmm, clear ccache - i'll try that next time - but I don't rule out an incompatibility in the toolchain because it _did_ go away when I changed the code
<gribble>
https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
<Murch>
Oh, I should look at #25122
<gribble>
https://github.com/bitcoin/bitcoin/issues/25122 | rpc: getreceivedbylabel, return early if no addresses were found in the address book by furszy · Pull Request #25122 · bitcoin/bitcoin · GitHub
<Murch>
I have reviewed the other already
<achow101>
It looks like there have been a lot of proposed changes to AvailableCoins that conflict with each other, but all look nice to get in
<Murch>
Yeah, that's right
<achow101>
e.g. #25005 #25118 #25083 #24699 #24584
<gribble>
https://github.com/bitcoin/bitcoin/issues/25005 | wallet: remove extra wtx lookup in AvailableCoins + several code cleanups. by furszy · Pull Request #25005 · bitcoin/bitcoin · GitHub
<Murch>
I think maintaining the test when we start changing the coin selection algos will be annoying, but it's also kinda nice to see the exact boundaries
<Murch>
yeah thanks!
<Murch>
I think that S3RK might be a bit stuck there, no way forward not really shot down either
<achow101>
perhaps more people should look at it
<Murch>
Could we perhaps give more input how it should be developed to address maintainability concerns?
<achow101>
maybe more programmatic math rather than hardcoded math
<Murch>
Yeah
<Murch>
Do you know what the status with Bruno's "Prefer changeless" PR is?
<achow101>
Murch: it seems like it needs conceptual review as to whether that's a good idea?
<Murch>
achow101: I think I'd be "concept ack, approach nack", wasn't sure whether that came out clearly
<Murch>
Is brunoerg here?
<jonatack>
having good boundary testing of expected behavior in place before making big changes can be good if the testing is of the right kind... maybe hoist the magic numbers up to constants or derive them programmatically as mentioned
<Murch>
instagibbs, jonatack: I think one issue is also that it sorta depends on the current selection of algorithms we use, and sort of tests whether the outcome was Knapsack, or BnB at times
<instagibbs>
Murch, yeah I'm not wading in on the overall thrust, deferring on that
<Murch>
Yeah, #23475 needs some sanity limit, similar to the avoid_partial_spend approach
<gribble>
https://github.com/bitcoin/bitcoin/issues/23475 | wallet: add config to prioritize a solution that doesnt create change in coin selection by brunoerg · Pull Request #23475 · bitcoin/bitcoin · GitHub
<Murch>
Okay, I guess the overall result is, we could all take another glance at these and perhaps be a bit more direct with feedback? ;)
<achow101>
yes
lukedashjr has joined #bitcoin-core-dev
<jonatack>
instagibbs: Murch: agree, may need more abstraction
<achow101>
anything else to discuss?
luke-jr has quit [Ping timeout: 240 seconds]
lukedashjr is now known as luke-jr
<Murch>
No, just … by the way, I'm of the opinion that Knapsack needs to die